openvisio-agent 0.18.11 → 0.18.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.18.11",
+  "version": "0.18.13",
   "description": "Connect Claude Code, Codex, or OpenCode to an OpenVisio team — MCP tools + optional autonomy — in one command.",
   "type": "module",
   "bin": {

package/scripts/certify.mjs

@@ -26,6 +26,7 @@ const memory = readFileSync(join(root, 'src', 'memory.mjs'), 'utf8')
 const mcpHttp = readFileSync(join(root, 'src', 'mcp-http.mjs'), 'utf8')
 const opencodeConfig = readFileSync(join(root, 'src', 'opencode-config.mjs'), 'utf8')
 const codexConfig = readFileSync(join(root, 'src', 'codex-config.mjs'), 'utf8')
+const codexProxy = readFileSync(join(root, 'src', 'codex-mcp-proxy.mjs'), 'utf8')
 const prPush = readFileSync(join(root, 'src', 'pr-push.mjs'), 'utf8')
 const cli = readFileSync(join(root, 'bin', 'cli.mjs'), 'utf8')
 const websocket = readFileSync(join(root, 'src', 'ws.mjs'), 'utf8')
@@ -63,9 +64,11 @@ const assertions = [
   ['Codex cannot race the watcher with post_message', watcher.includes("disabledMcpTools: ['post_message']") && codexConfig.includes('disabled_tools = [')],
   ['Codex cannot continue without OpenVisio MCP tools', watcher.includes('buildCodexMcpOverride') && codexConfig.includes('required = true') && codexConfig.includes('startup_timeout_sec = 30')],
   ['Codex discovers deferred OpenVisio actions before claiming they are missing', watcher.includes('Codex may defer MCP actions') && watcher.includes('use tool_search to find that exact action') && watcher.includes('initial-list miss is NOT evidence that the server is disconnected')],
+  ['Codex authentication is injected outside the model', codexConfig.includes('OPENVISIO_CODEX_API_KEY') && codexProxy.includes('toolWithoutCredentialInputs') && codexProxy.includes('client.callTool') && watcher.includes('local OpenVisio MCP bridge injects authentication outside the model')],
   ['reply delivery keys survive reconnects', watcher.includes('deliveredReplies: [...deliveredReplies]') && watcher.includes('deliveredReplies.has(deliveryKey)')],
   ['tickets and guarded replies use the behavior-tested serial queue', watcher.includes('createCycleQueue({') && watcher.includes('queues[laneName].enqueue') && cycleQueue.includes('const pending = new Map()')],
   ['queued assignments are checked again before model execution', watcher.includes('queued ticket no longer actionable; skipped before model start')],
+  ['feature titles cannot be mistaken for coordination commands', watcher.includes('taskIsCoordinationOnly(taskText)') && events.includes('Uploading files as messages') && events.includes('explicitCoordination')],
   ['reply runner has no coding workspace or coding charter', watcher.includes("workdir: '', systemPrompt: CHAT_CHARTER") && opencodeConfig.includes("'*': 'deny'")],
   ['MCP requests have a deadline including response bodies', mcpHttp.includes('controller.abort()') && mcpHttp.includes('const body = await res.text()')],
   ['BYO memory uses real ticket and thread identities', watcher.includes('createByoMemoryGraph') && watcher.includes('memory.context(memoryRefs)') && memory.includes('sameRef(r.projectId, refs.projectId)') && memory.includes('sameRef(r.threadId, refs.threadId)')],

package/src/codex-config.mjs

@@ -5,13 +5,11 @@ const tomlString = (value) => JSON.stringify(String(value))
 // its tools, which makes an otherwise connected agent incorrectly claim that it
 // cannot inspect OpenVisio. Fail the subprocess instead so the watcher can retry
 // the event and report a real runtime failure without delivering model guesswork.
-export function buildCodexMcpOverride({ mcpUrl, mcpHeaders, disabledMcpTools = [] } = {}) {
+export function buildCodexMcpOverride({ mcpUrl, proxyCommand, proxyPath, disabledMcpTools = [] } = {}) {
   if (!mcpUrl) return ''
-  const headerEntries = Object.entries(mcpHeaders || {})
-    .map(([key, value]) => `${tomlString(key)} = ${tomlString(value)}`)
-    .join(', ')
+  if (!proxyCommand || !proxyPath) throw new Error('Codex MCP proxy command and path are required')
   const disabled = Array.isArray(disabledMcpTools) ? disabledMcpTools.filter(Boolean) : []
-  const headerConfig = headerEntries ? `, http_headers = { ${headerEntries} }` : ''
   const disabledToolConfig = disabled.length ? `, disabled_tools = [${disabled.map(tomlString).join(', ')}]` : ''
-  return `mcp_servers={ openvisio-team = { url = ${tomlString(mcpUrl)}, required = true, startup_timeout_sec = 30${headerConfig}${disabledToolConfig} } }`
+  const envVars = ['OPENVISIO_CODEX_MCP_URL', 'OPENVISIO_CODEX_API_KEY', 'OPENVISIO_CODEX_IDENTIFIER'].map(tomlString).join(', ')
+  return `mcp_servers={ openvisio-team = { command = ${tomlString(proxyCommand)}, args = [${tomlString(proxyPath)}], env_vars = [${envVars}], required = true, startup_timeout_sec = 30${disabledToolConfig} } }`
 }

package/src/codex-mcp-proxy.mjs

@@ -0,0 +1,73 @@
+import { createInterface } from 'node:readline'
+import { resolve } from 'node:path'
+import { fileURLToPath } from 'node:url'
+import { createMcpHttpClient } from './mcp-http.mjs'
+
+export function toolWithoutCredentialInputs(tool) {
+  const copy = structuredClone(tool)
+  const schema = copy.inputSchema ?? copy.input_schema
+  if (!schema || typeof schema !== 'object') return copy
+  if (schema.properties && typeof schema.properties === 'object') {
+    delete schema.properties.agent_api_key
+    delete schema.properties.agent_identifier
+  }
+  if (Array.isArray(schema.required)) {
+    schema.required = schema.required.filter((name) => name !== 'agent_api_key' && name !== 'agent_identifier')
+  }
+  return copy
+}
+
+export function runCodexMcpProxy() {
+  const url = process.env.OPENVISIO_CODEX_MCP_URL
+  const apiKey = process.env.OPENVISIO_CODEX_API_KEY
+  const identifier = process.env.OPENVISIO_CODEX_IDENTIFIER
+  if (!url || !apiKey || !identifier) throw new Error('OpenVisio Codex MCP bridge is missing its watcher environment.')
+  const client = createMcpHttpClient({ url, apiKey, identifier, clientVersion: 'openvisio-agent-codex-proxy' })
+  const reply = (id, result) => process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id, result }) + '\n')
+  const fail = (id, error, request) => {
+    const message = String(error?.message || error || 'MCP bridge error').split(apiKey).join('[redacted]')
+    if (request?.method === 'tools/call') {
+      const safeArgs = { ...(request.params?.arguments || {}) }
+      delete safeArgs.agent_api_key
+      delete safeArgs.agent_identifier
+      process.stderr.write(`OpenVisio MCP bridge call failed: ${String(request.params?.name || 'unknown')} ${JSON.stringify(safeArgs).slice(0, 1000)} — ${message.slice(0, 1000)}\n`)
+    }
+    process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id, error: { code: -32000, message: message.slice(0, 1000) } }) + '\n')
+  }
+  const lines = createInterface({ input: process.stdin, crlfDelay: Infinity })
+  lines.on('line', async (line) => {
+    let request
+    try { request = JSON.parse(line) } catch { return }
+    const id = request.id
+    try {
+      if (request.method === 'initialize') {
+        reply(id, {
+          protocolVersion: request.params?.protocolVersion || '2025-03-26',
+          capabilities: { tools: { listChanged: false } },
+          serverInfo: { name: 'openvisio-agent', version: '1' },
+        })
+      } else if (request.method === 'notifications/initialized') {
+        // Notification: no response.
+      } else if (request.method === 'ping') {
+        reply(id, {})
+      } else if (request.method === 'tools/list') {
+        const tools = await client.listTools()
+        reply(id, { tools: tools.map(toolWithoutCredentialInputs) })
+      } else if (request.method === 'tools/call') {
+        reply(id, await client.callTool(request.params?.name, request.params?.arguments || {}))
+      } else if (id != null) {
+        process.stdout.write(JSON.stringify({ jsonrpc: '2.0', id, error: { code: -32601, message: 'Method not found' } }) + '\n')
+      }
+    } catch (error) {
+      if (id != null) fail(id, error, request)
+    }
+  })
+}
+
+if (process.argv[1] && resolve(process.argv[1]) === fileURLToPath(import.meta.url)) {
+  try { runCodexMcpProxy() }
+  catch (error) {
+    process.stderr.write(String(error?.message || error) + '\n')
+    process.exitCode = 1
+  }
+}

package/src/events.mjs

@@ -471,6 +471,17 @@ export function conversationNeedsCode(value) {
   return action && target
 }
 
+// Coordination tickets are imperative board/chat actions, not implementation
+// work that merely mentions words such as "message", "status", or "label" in
+// its feature title. Requiring the coordination verb at the start prevents
+// tickets like "Uploading files as messages" from being routed away from the
+// coding lane.
+export function taskIsCoordinationOnly(value) {
+  const text = String(value || '').trim()
+  const explicitCoordination = /^(?:please\s+)?(?:move|moving|assign|reassign|unassign|comment(?:\s+on)?|reply(?:\s+to)?|send\s+(?:a\s+)?message|triage|prioriti[sz]e|rename|close|reopen|(?:add|remove|change|update)\s+(?:the\s+)?(?:status|column|label))\b/i.test(text)
+  return explicitCoordination && !conversationNeedsCode(text)
+}
+
 // A mention event means this agent's name appeared somewhere, not necessarily
 // that the request was addressed to it. Reject a later-agent hand-off before a
 // model starts, while keeping explicitly shared requests addressed to both.

package/src/watch.mjs

@@ -8,9 +8,10 @@ import { spawn, spawnSync } from 'node:child_process'
 import { closeSync, writeFileSync, mkdirSync, existsSync, openSync, readFileSync, unlinkSync } from 'node:fs'
 import { homedir } from 'node:os'
 import { join, dirname } from 'node:path'
+import { fileURLToPath } from 'node:url'
 import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
 import { connectAgentWs, assertWebSocket } from './ws.mjs'
-import { agentAddedByName, agentStateRequest, buildTaskCompletionReport, claudeEventEvidence, classifyConversationTarget, codexEventEvidence, codexPolicyBlock, combineRuntimeWorkEvidence, conversationNeedsCode, mentionDedupeKeys, missingRuntimeWorkEvidence, normalizeRenderedMessageText, opencodeEventEvidence, renderedAgentMessages, shouldSuppressCodexDiagnostic, taskAgentId, taskFromEvent, taskIsAwaitingReview, taskIsCompleted, ticketDisplaySlug } from './events.mjs'
+import { agentAddedByName, agentStateRequest, buildTaskCompletionReport, claudeEventEvidence, classifyConversationTarget, codexEventEvidence, codexPolicyBlock, combineRuntimeWorkEvidence, conversationNeedsCode, mentionDedupeKeys, missingRuntimeWorkEvidence, normalizeRenderedMessageText, opencodeEventEvidence, renderedAgentMessages, shouldSuppressCodexDiagnostic, taskAgentId, taskFromEvent, taskIsAwaitingReview, taskIsCompleted, taskIsCoordinationOnly, ticketDisplaySlug } from './events.mjs'
 import { createByoMemoryGraph } from './memory.mjs'
 import { repositoryHasPrPushAuthorization } from './pr-push.mjs'
 import { createMcpHttpClient } from './mcp-http.mjs'
@@ -439,6 +440,7 @@ function createOpencodeRunner({ mcpUrl, mcpHeaders, cfgKey, workdir, canCode, ma
 function createCodexRunner({ mcpUrl, mcpHeaders, workdir, canCode, maxCycleMs, log, debug, model, onTool, systemPrompt }) {
   const bin = onPath('codex') || 'codex'
   const cwd = workdir || OV_DIR
+  const proxyPath = fileURLToPath(new URL('./codex-mcp-proxy.mjs', import.meta.url))
   let cancelActive = null
 
   function runCycle(prompt, cycleModel, cycleOptions = {}) {
@@ -446,7 +448,7 @@ function createCodexRunner({ mcpUrl, mcpHeaders, workdir, canCode, maxCycleMs, l
       const m = cycleModel || model
       const full = systemPrompt ? systemPrompt + '\n\n' + prompt : prompt
       const disabledMcpTools = Array.isArray(cycleOptions.disabledMcpTools) ? cycleOptions.disabledMcpTools.filter(Boolean) : []
-      const mcpOverride = buildCodexMcpOverride({ mcpUrl, mcpHeaders, disabledMcpTools })
+      const mcpOverride = buildCodexMcpOverride({ mcpUrl, proxyCommand: process.execPath, proxyPath, disabledMcpTools })
       const args = ['exec', '--ignore-user-config', '--skip-git-repo-check', '--ephemeral', '--json', '--color', 'never',
         ...(canCode ? ['--approve-for-me'] : ['--sandbox', 'read-only']),
         ...(m ? ['--model', m] : []),
@@ -524,7 +526,19 @@ function createCodexRunner({ mcpUrl, mcpHeaders, workdir, canCode, maxCycleMs, l
       try {
         // Always inspect Codex JSONL so a successful process exit cannot be
         // mistaken for completed work. Keep it out of normal logs unless debug.
-        child = spawn(bin, args, { ...modelProcessOptions, cwd, stdio: ['ignore', 'pipe', 'pipe'] })
+        child = spawn(bin, args, {
+          ...modelProcessOptions,
+          cwd,
+          env: {
+            ...process.env,
+            ...(mcpUrl ? {
+              OPENVISIO_CODEX_MCP_URL: mcpUrl,
+              OPENVISIO_CODEX_API_KEY: mcpHeaders?.['x-agent-api-key'] || '',
+              OPENVISIO_CODEX_IDENTIFIER: mcpHeaders?.['x-agent-identifier'] || '',
+            } : {}),
+          },
+          stdio: ['ignore', 'pipe', 'pipe'],
+        })
         if (child.stdout) child.stdout.on('data', (d) => {
           jsonlBuffer += String(d)
           const lines = jsonlBuffer.split('\n')
@@ -765,7 +779,10 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
   const canCode = !!workdir
   // The Mastra bridge authenticates per-CALL: every openvisio-team tool needs
   // agent_identifier + agent_api_key as arguments. Hand them over up front.
-  const credNote = `AUTH: the openvisio-team tools REQUIRE two arguments on EVERY call — agent_identifier: "${identifier}" and agent_api_key: "${apiKey}". Include BOTH on every openvisio-team tool call. Codex may defer MCP actions instead of placing them in the initial tool list. If a native tool_search is available and an expected openvisio-team action is not initially visible, use tool_search to find that exact action, then call it; an initial-list miss is NOT evidence that the server is disconnected. Do not ask a teammate to reconnect or provide a slug until tool_search and the applicable live lookup have actually failed. On backend MCP, discover and update work with list_agents, list_projects, list_tasks, list_task_types, get_ticket, update_ticket, list_channels, list_message_thread, and list_activity as applicable. Ticket comments are optional: never invent or call comment_ticket unless that exact tool appears or tool_search finds it. get_marching_orders, poll_inbox, get_resource, list_mcp_resources, and list_mcp_resource_templates are NOT team-action tools here; never call them. Tools may be namespaced — call whichever names actually appear. The credentials are given here; do NOT hunt for them. Bash/git/gh ARE for code work; this rule only forbids searching for keys.`
+  const authRule = agent === 'codex'
+    ? 'AUTH: the local OpenVisio MCP bridge injects authentication outside the model. Never add, request, print, or search for agent credentials in tool arguments.'
+    : `AUTH: the openvisio-team tools REQUIRE two arguments on EVERY call — agent_identifier: "${identifier}" and agent_api_key: "${apiKey}". Include BOTH on every openvisio-team tool call. The credentials are given here; do NOT hunt for them.`
+  const credNote = `${authRule} Codex may defer MCP actions instead of placing them in the initial tool list. If a native tool_search is available and an expected openvisio-team action is not initially visible, use tool_search to find that exact action, then call it; an initial-list miss is NOT evidence that the server is disconnected. Do not ask a teammate to reconnect or provide a slug until tool_search and the applicable live lookup have actually failed. On backend MCP, discover and update work with list_agents, list_projects, list_tasks, list_task_types, get_ticket, update_ticket, list_channels, list_message_thread, and list_activity as applicable. Ticket comments are optional: never invent or call comment_ticket unless that exact tool appears or tool_search finds it. get_marching_orders, poll_inbox, get_resource, list_mcp_resources, and list_mcp_resource_templates are NOT team-action tools here; never call them. Tools may be namespaced — call whichever names actually appear. Bash/git/gh ARE for code work; this rule only forbids searching for keys.`
   // The STATIC charter + creds are the session system prompt (cached, billed once),
   // NOT re-sent in every cycle's user message — the big token saving.
   const systemPrompt = (canCode ? CODE_CHARTER : CHAT_CHARTER) + '\n\n' + credNote
@@ -1462,7 +1479,6 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
 
   // Route only concrete repository requests to the coding lane. Conversation
   // ownership is classified separately before this is consulted.
-  const coordinationOnly = (value) => /\b(?:move|moving|status|column|assign|reassign|unassign|comment|reply|message|triage|prioriti[sz]e|label|rename|close|reopen)\b/i.test(String(value || '')) && !conversationNeedsCode(value)
 
   // Engineers change the model under the hood from chat: "/model", "/model sonnet",
   // "use model haiku", "switch model to opus". Returns {report} | {set} | {invalid}.
@@ -1550,13 +1566,13 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
       const ticketSlug = ticketDisplaySlug(ticket)
       memory.remember({ key: `ticket:${projectId}:${ticketId}`, kind: 'ticket', state: 'queued', summary: title, refs: { projectId, ticketId }, meta: { sourceEvent: kind } })
       const taskText = [title, ticket.description, ticket.type, ticket.kind].filter(Boolean).join(' ')
-      const cycleKind = canCode && !coordinationOnly(taskText) ? 'full' : 'coord'
+      const cycleKind = canCode && !taskIsCoordinationOnly(taskText) ? 'full' : 'coord'
       log(kind + ' verified ticket #' + ticketId + ' “' + title + '” -> ' + cycleKind + ' lane')
       const activityChannel = await projectStatusChannel(projectId)
       if (activityChannel != null) sendStatus(activityChannel, 'thinking')
       if (cycleKind === 'full') { pendingCompletionReports.add(key); trimSeen(pendingCompletionReports); persistReplay() }
       const humanTicketRef = ticketSlug ? `ticket ${ticketSlug}` : `the ticket “${title}”`
-      void drain(cycleKind, `Authoritative get_ticket verification confirms ${humanTicketRef} is open and assigned to YOU. Internal tool identity: project_id ${projectId}, ticket_id ${ticketId}. Numeric ids are MCP arguments only and must never appear in human-facing text; use ${ticketSlug || 'the ticket title'} instead. Ticket details: ${JSON.stringify({ slug: ticketSlug, title, description: ticket.description, priority: ticket.priority, typeId: ticket.type_id ?? ticket.typeId })}. This assignment has no source thread: do not call post_message yourself. Use list_task_types and update_ticket to move it active, complete and verify the work, open the PR when applicable, then update/move the ticket with evidence. For coding work, the watcher will publish exactly one verified completion result in the project channel.`, activityChannel == null ? [] : [activityChannel], { projectId, ticketId, channelId: activityChannel })
+      void drain(cycleKind, `Authoritative get_ticket verification confirms ${humanTicketRef} is open and assigned to YOU. Internal tool identity: project_id ${projectId}, ticket_id ${ticketId}. For every get_ticket call pass exactly { project_id: ${projectId}, ticket_id: ${ticketId} }; for list_task_types pass exactly { project_id: ${projectId} }. Numeric ids are MCP arguments only and must never appear in human-facing text; use ${ticketSlug || 'the ticket title'} instead. Ticket details: ${JSON.stringify({ slug: ticketSlug, title, description: ticket.description, priority: ticket.priority, typeId: ticket.type_id ?? ticket.typeId })}. This assignment has no source thread: do not call post_message yourself. Use list_task_types and update_ticket to move it active, complete and verify the work, open the PR when applicable, then update/move the ticket with evidence. For coding work, the watcher will publish exactly one verified completion result in the project channel.`, activityChannel == null ? [] : [activityChannel], { projectId, ticketId, channelId: activityChannel })
     } catch (e) {
       log(kind + ' ticket verification failed for #' + ticketId + ': ' + (e?.message || e))
     }