openvisio-agent 0.17.2 → 0.17.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.17.2",
+  "version": "0.17.4",
   "description": "Connect Claude Code, Codex, or OpenCode to an OpenVisio team — MCP tools + optional autonomy — in one command.",
   "type": "module",
   "bin": {

package/scripts/certify.mjs

@@ -28,6 +28,8 @@ const spec = readFileSync(join(repo, 'docs', 'CODEX_BYO_AGENT_SPEC.md'), 'utf8')
 const assertions = [
   ['task:assigned is handled', watcher.includes("k === 'task:assigned'")],
   ['task signals are verified with get_ticket', watcher.includes("callMcpTool('get_ticket'")],
+  ['review and testing handoffs do not restart work', watcher.includes('taskIsAwaitingReview(task, reviewIds)') && watcher.includes('taskIsAwaitingReview(ticket)')],
+  ['review handoff releases the task key for future rework', watcher.includes('seenTasks.delete(taskKey)') && watcher.includes('seenTasks.delete(key)')],
   ['two internal lanes exist', watcher.includes('work: createCycleRunner') && watcher.includes('reply: createCycleRunner')],
   ['work and reply activity targets are isolated', watcher.includes("laneStatusTargets = { work: new Set(), reply: new Set() }") && watcher.includes("emitLaneStatus('work', 'typing')") && watcher.includes("emitLaneStatus('reply', 'typing')")],
   ['assigned task activity resolves a project channel', watcher.includes("callMcpTool('list_channels'") && watcher.includes('projectStatusChannel(projectId)')],
@@ -45,6 +47,7 @@ const assertions = [
   ['policy blocker is surfaced to the user', watcher.includes('reportPolicyBlock(prompt, activeTaskRef, result.policyBlock)') && watcher.includes('Action required: Alex is blocked')],
   ['blocker routing carries explicit task identity', watcher.includes('taskRefs: []') && watcher.includes('activeTaskRef') && watcher.includes('taskRef: activeTaskRef')],
   ['all runtime blockers have a delivery path', watcher.includes('publishBlocker') && watcher.includes('WORK_CYCLE_BLOCKED') && watcher.includes('COORDINATION_CYCLE_BLOCKED')],
+  ['ticket blocker cannot self-authorize', watcher.includes('ticketNotice = `Alex is paused') && watcher.includes('publishBlocker({ prompt, taskRef, notice, ticketNotice, pause: true })')],
   ['normative certification gates are documented', spec.includes('## Mandatory certification gates')],
 ]
 for (const [label, ok] of assertions) {

package/src/events.mjs

@@ -34,6 +34,18 @@ export function taskIsCompleted(task, completedTypeIds = new Set()) {
   return /\b(?:done|complete|completed|closed|cancelled|canceled|archived|resolved)\b/i.test(state)
 }
 
+// A coding agent has handed work off once the board reaches review, testing, QA,
+// or approval. These are not "completed" states: a reviewer may still send the
+// ticket back to an actionable column. Treating them as settled for the watcher,
+// however, prevents reconnect reconciliation from reopening the same PR every
+// 30 minutes while it waits for a human.
+export function taskIsAwaitingReview(task, reviewTypeIds = new Set()) {
+  if (!task || typeof task !== 'object') return false
+  if (reviewTypeIds.has(Number(task.type_id ?? task.typeId ?? task.status_id ?? task.statusId))) return true
+  const state = [task.status, task.state, task.type?.name, task.task_type?.name].filter(Boolean).join(' ')
+  return /\b(?:review|test|testing|qa|quality\s+assurance|verification|approval)\b/i.test(state)
+}
+
 export function agentStateRequest(backend, channelId, state, apiKey, identifier) {
   if (!['thinking', 'working', 'typing'].includes(state)) throw new Error('invalid agent state')
   const id = Number(channelId)

package/src/watch.mjs

@@ -10,7 +10,7 @@ import { homedir } from 'node:os'
 import { join, dirname } from 'node:path'
 import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
 import { connectAgentWs, assertWebSocket } from './ws.mjs'
-import { agentStateRequest, codexPolicyBlock, requestTargetsLaterAgent, taskAgentId, taskFromEvent, taskIsCompleted } from './events.mjs'
+import { agentStateRequest, codexPolicyBlock, requestTargetsLaterAgent, taskAgentId, taskFromEvent, taskIsAwaitingReview, taskIsCompleted } from './events.mjs'
 
 // Behaviour prompts. The openvisio-team MCP bridge requires the agent's
 // credentials as ARGUMENTS on every tool call — those are injected at runtime by
@@ -650,7 +650,7 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
   }
   const ensureMcpSession = async () => {
     if (mcpSessionId) return
-    const res = await mcpPost({ jsonrpc: '2.0', id: ++mcpRpcId, method: 'initialize', params: { protocolVersion: '2025-03-26', capabilities: {}, clientInfo: { name: 'openvisio-agent', version: '0.17.2' } } }, false)
+    const res = await mcpPost({ jsonrpc: '2.0', id: ++mcpRpcId, method: 'initialize', params: { protocolVersion: '2025-03-26', capabilities: {}, clientInfo: { name: 'openvisio-agent', version: '0.17.4' } } }, false)
     if (!res.ok) throw new Error('MCP initialize HTTP ' + res.status)
     await mcpPayload(res)
     mcpSessionId = res.headers.get('mcp-session-id') || ''
@@ -701,7 +701,7 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
     }
   }
 
-  const publishBlocker = async ({ prompt, taskRef, notice, pause = false }) => {
+  const publishBlocker = async ({ prompt, taskRef, notice, ticketNotice = notice, pause = false }) => {
     const sentenceTask = /ticket\s+#?(\d+).*?project\s+(\d+)/i.exec(prompt)
     const jsonTask = /"id"\s*:\s*(\d+)[\s\S]{0,300}?"projectId"\s*:\s*(\d+)/i.exec(prompt)
     const ticketId = Number(taskRef?.ticketId ?? sentenceTask?.[1] ?? jsonTask?.[1])
@@ -731,7 +731,7 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
     const key = `${projectId}:${ticketId}`
     if (pause) { blockedTasks.add(key); persistReplay() }
     try {
-      await callMcpTool('comment_ticket', { project_id: projectId, ticket_id: ticketId, text: notice })
+      await callMcpTool('comment_ticket', { project_id: projectId, ticket_id: ticketId, text: ticketNotice })
       delivered = true
       return
     } catch (e) {
@@ -740,11 +740,11 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
     const current = toolData(await callMcpTool('get_ticket', { project_id: projectId, ticket_id: ticketId }))
     const ticket = current.ticket ?? current.task ?? current
     const description = String(ticket.description || '')
-    if (!description.includes(notice)) {
+    if (!description.includes(ticketNotice)) {
       await callMcpTool('update_ticket', {
         project_id: projectId,
         ticket_id: ticketId,
-        description: `${description}${description ? '\n\n' : ''}[Agent blocker]\n${notice}`,
+        description: `${description}${description ? '\n\n' : ''}[Agent blocker]\n${ticketNotice}`,
       })
       delivered = true
     }
@@ -758,7 +758,8 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
       ? `Reply with: “I explicitly authorize Alex to push commit ${block.commit} to the exact repository URL for ${block.remote || 'the configured remote'}, on branch ${block.branch}.”`
       : 'Explicitly authorize the exact repository URL, commit, and branch in your reply.'
     const notice = `Action required: Alex is blocked at \`${command}\`${payload ? ` (${payload})` : ''}. Codex requires confirmation before exporting private repository code. ${approval} The ticket is paused until that approval is recorded.`
-    return publishBlocker({ prompt, taskRef, notice, pause: true })
+    const ticketNotice = `Alex is paused at \`${command}\`${payload ? ` (${payload})` : ''}. Repository push confirmation is required in the project channel; no automatic retry will occur.`
+    return publishBlocker({ prompt, taskRef, notice, ticketNotice, pause: true })
   }
 
   // Reconcile everything that may have arrived while disconnected. This spends no
@@ -782,21 +783,30 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
           callMcpTool('list_task_types', { project_id: project.id }).then(toolData),
           callMcpTool('list_activity', { project_id: project.id }).then(toolData),
         ])
-        const doneIds = new Set((Array.isArray(typesData.types) ? typesData.types : Array.isArray(typesData.task_types) ? typesData.task_types : Array.isArray(typesData.taskTypes) ? typesData.taskTypes : []).filter((t) => /\b(?:done|complete|completed|closed|cancelled|canceled|archived|resolved)\b/i.test(String(t.name || ''))).map((t) => Number(t.id)))
+        const taskTypes = Array.isArray(typesData.types) ? typesData.types : Array.isArray(typesData.task_types) ? typesData.task_types : Array.isArray(typesData.taskTypes) ? typesData.taskTypes : []
+        const doneIds = new Set(taskTypes.filter((t) => /\b(?:done|complete|completed|closed|cancelled|canceled|archived|resolved)\b/i.test(String(t.name || ''))).map((t) => Number(t.id)))
+        const reviewIds = new Set(taskTypes.filter((t) => /\b(?:review|test|testing|qa|quality\s+assurance|verification|approval)\b/i.test(String(t.name || ''))).map((t) => Number(t.id)))
         for (const task of Array.isArray(tasksData.tasks) ? tasksData.tasks : []) {
           const taskAgentId = Number(task.agent_id ?? task.agentId ?? task.agent?.id)
           const taskIdent = String(task.agent?.identifier ?? task.agent?.slug ?? '')
-          if (!taskIsCompleted(task, doneIds) && (taskAgentId === Number(self.id) || taskIdent === identifier)) {
-            const taskKey = `${project.id}:${task.id}`
-            if (blockedTasks.has(taskKey)) {
-              const approvalText = [task.title, task.description].filter(Boolean).join(' ')
-              if (/\b(?:i\s+)?(?:explicitly\s+)?(?:approve|authorize)\b[\s\S]{0,240}\b(?:git\s+push|push(?:ing)?\s+(?:the\s+)?(?:branch|code)|github|remote)\b/i.test(approvalText)) {
-                blockedTasks.delete(taskKey); seenTasks.delete(taskKey); persistReplay()
-                log('backlog ticket #' + task.id + ' now contains explicit push authorization — resuming')
-              } else continue
-            }
-            assigned.push({ id: task.id, projectId: project.id, project: project.name, title: task.title, priority: task.priority, typeId: task.type_id ?? task.typeId, updatedAt: task.updated_at ?? task.updatedAt })
+          if (taskAgentId !== Number(self.id) && taskIdent !== identifier) continue
+          const taskKey = `${project.id}:${task.id}`
+          if (taskIsCompleted(task, doneIds) || taskIsAwaitingReview(task, reviewIds)) {
+            if (blockedTasks.delete(taskKey)) persistReplay()
+            // Release the in-flight de-dupe key at handoff. If a reviewer moves
+            // the ticket back to an actionable column, that update must start a
+            // fresh work cycle.
+            seenTasks.delete(taskKey)
+            continue
+          }
+          if (blockedTasks.has(taskKey)) {
+            const approvalText = [task.title, task.description].filter(Boolean).join(' ')
+            if (/\b(?:i\s+)?(?:explicitly\s+)?(?:approve|authorize)\b[\s\S]{0,240}\b(?:git\s+push|push(?:ing)?\s+(?:the\s+)?(?:branch|code)|github|remote)\b/i.test(approvalText)) {
+              blockedTasks.delete(taskKey); seenTasks.delete(taskKey); persistReplay()
+              log('backlog ticket #' + task.id + ' now contains explicit push authorization — resuming')
+            } else continue
           }
+          assigned.push({ id: task.id, projectId: project.id, project: project.name, title: task.title, priority: task.priority, typeId: task.type_id ?? task.typeId, updatedAt: task.updated_at ?? task.updatedAt })
         }
         const activities = Array.isArray(activityData.activities) ? activityData.activities : Array.isArray(activityData.activity) ? activityData.activity : []
         const mentionNeedles = [self.name, self.identifier, self.slug, identifier].filter(Boolean).map((s) => '@' + String(s).toLowerCase())
@@ -986,7 +996,11 @@ function loopBackendWs({ backend, wsUrl, apiKey, identifier, slug, claude, agent
       const belongsToSelf = (selfAgentId != null && assignedId === selfAgentId) || assignedIdentifier === identifier
       const key = `${projectId}:${ticketId}`
       if (!belongsToSelf) { blockedTasks.delete(key); persistReplay(); seenTasks.delete(key); log(kind + ' ticket #' + ticketId + ' is not assigned to this agent — ignored'); return }
-      if (taskIsCompleted(ticket)) { blockedTasks.delete(key); persistReplay(); seenTasks.add(key); log(kind + ' ticket #' + ticketId + ' is already complete — ignored'); return }
+      if (taskIsCompleted(ticket) || taskIsAwaitingReview(ticket)) {
+        blockedTasks.delete(key); persistReplay(); seenTasks.delete(key)
+        log(kind + ' ticket #' + ticketId + ' is already complete or awaiting review — ignored')
+        return
+      }
       if (blockedTasks.has(key)) {
         const approvalText = [ticket.title, ticket.description].filter(Boolean).join(' ')
         if (/\b(?:i\s+)?(?:explicitly\s+)?(?:approve|authorize)\b[\s\S]{0,240}\b(?:git\s+push|push(?:ing)?\s+(?:the\s+)?(?:branch|code)|github|remote)\b/i.test(approvalText)) {