openvisio-agent 0.15.2 → 0.16.1

package/package.json

@@ -1,11 +1,14 @@
 {
   "name": "openvisio-agent",
-  "version": "0.15.2",
+  "version": "0.16.1",
   "description": "Connect Claude Code, Codex, or OpenCode to an OpenVisio team — MCP tools + optional autonomy — in one command.",
   "type": "module",
   "bin": {
     "openvisio-agent": "bin/cli.mjs"
   },
+  "scripts": {
+    "test": "node --test"
+  },
   "files": [
     "bin",
     "src",

package/src/events.mjs

@@ -0,0 +1,48 @@
+// Backend deployments have emitted task bodies in a few compatible envelope
+// shapes over time. Keep that transport detail out of the watcher so an
+// assignment cannot be silently dropped during a rolling backend/client update.
+export function taskFromEvent(payload) {
+  if (!payload || typeof payload !== 'object') return null
+
+  const candidates = [
+    payload.task,
+    payload.data && payload.data.task,
+    payload.payload && payload.payload.task,
+    payload.data,
+    payload.payload,
+    payload,
+  ]
+
+  for (const candidate of candidates) {
+    if (!candidate || typeof candidate !== 'object') continue
+    const hasTaskIdentity = candidate.id != null || candidate.task_id != null || candidate.taskId != null
+    if (hasTaskIdentity) return candidate
+  }
+  return null
+}
+
+export function taskAgentId(task) {
+  if (!task || typeof task !== 'object') return null
+  return task.agent_id != null ? task.agent_id : (task.agentId != null ? task.agentId : null)
+}
+
+// A mention event means this agent's name appeared somewhere, not necessarily
+// that the request was addressed to it. Reject a later-agent hand-off before a
+// model starts, while keeping explicitly shared requests addressed to both.
+export function requestTargetsLaterAgent(text, selfAliases) {
+  const value = String(text || '')
+  const aliases = new Set((selfAliases || []).map((v) => String(v || '').toLowerCase().replace(/^@/, '')).filter(Boolean))
+  if (!value || !aliases.size) return false
+
+  const mentions = [...value.matchAll(/@([a-z0-9](?:[a-z0-9_.-]*[a-z0-9_-])?)/gi)].map((match) => ({ name: match[1].toLowerCase(), index: match.index ?? 0, end: (match.index ?? 0) + match[0].length }))
+  const self = mentions.find((mention) => aliases.has(mention.name))
+  if (!self) return false
+  const later = mentions.find((mention) => mention.index > self.index && !aliases.has(mention.name))
+  if (!later) return false
+
+  const bridge = value.slice(self.end, later.index).toLowerCase()
+  const suffix = value.slice(later.end).trim().toLowerCase()
+  const shared = /\b(?:and|with|alongside)\s*$/.test(bridge.trim()) && /\b(?:both|together|you (?:two|all)|everyone)\b/.test(suffix)
+  if (shared) return false
+  return /\?|^(?:[,.:;-]\s*)?(?:please\s+)?(?:can|could|would|will|do|write|create|make|send|fix|check|review|prepare|give|tell|help|handle|take|move|update|implement)\b/i.test(suffix)
+}

package/src/watch.mjs

@@ -10,6 +10,7 @@ import { homedir } from 'node:os'
 import { join, dirname } from 'node:path'
 import { OV_DIR, DEFAULT_WORKSPACE, readConfig, writeJson, configPath, onPath, fail, ok, info, slugify, stripSlash, chmodSafe } from './lib.mjs'
 import { connectAgentWs, assertWebSocket } from './ws.mjs'
+import { requestTargetsLaterAgent, taskAgentId, taskFromEvent } from './events.mjs'
 
 // Behaviour prompts. The openvisio-team MCP bridge requires the agent's
 // credentials as ARGUMENTS on every tool call — those are injected at runtime by
@@ -545,12 +546,18 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   // The STATIC charter + creds are the session system prompt (cached, billed once),
   // NOT re-sent in every cycle's user message — the big token saving.
   const systemPrompt = (canCode ? CODE_CHARTER : CHAT_CHARTER) + '\n\n' + credNote
-  const { runCycle } = createCycleRunner({
+  const runnerOptions = {
     claude, agent, mcpUrl, mcpHeaders: { 'x-agent-api-key': apiKey, 'x-agent-identifier': identifier },
     cfgKey: identifier, mcpConfig, workdir, log, debug, model, systemPrompt,
     // The moment the agent calls post_message it is about to speak → "typing".
     onTool: (name) => { if (/post_message/.test(name)) emitStatus('typing') },
-  })
+  }
+  // One watcher and one WS subscription, but two independent model lanes. This
+  // avoids duplicate event delivery while mentions can be answered during code.
+  const runners = {
+    work: createCycleRunner(runnerOptions),
+    reply: createCycleRunner({ ...runnerOptions, cfgKey: identifier + '-reply' }),
+  }
   const fullPrompt = canCode ? CODE_FULL : CYCLE
   const fastPrompt = canCode ? CODE_FAST : CYCLE_FAST
   // Live model state — changeable at runtime by the in-chat `/model` command.
@@ -559,8 +566,10 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   let codeModel = model
   let liteModel = chatModel || model
 
-  let busy = false
-  let queued = null // 'full' | 'coord' | 'fast' | 'sweep' | 'intro' — a cycle requested while one was running
+  const lanes = {
+    work: { busy: false, queued: null, pending: [] },
+    reply: { busy: false, queued: null, pending: [] },
+  }
   // Tasks we've already reacted to (keyed task-id:agent — so a REASSIGNMENT to a
   // different agent re-triggers), so a noisy stream of task:updated events doesn't
   // re-acknowledge the same assignment.
@@ -573,7 +582,6 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   // channel + message / task), so the agent acts on THEM directly instead of
   // hoping poll_inbox re-surfaces the same item. Accumulated across coalesced
   // events and drained into the next cycle's prompt.
-  const pending = []
   let backlogProbeBusy = false
   let lastTaskSignature = ''
   let lastTaskTriggeredAt = 0
@@ -602,7 +610,7 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   }
   const ensureMcpSession = async () => {
     if (mcpSessionId) return
-    const res = await mcpPost({ jsonrpc: '2.0', id: ++mcpRpcId, method: 'initialize', params: { protocolVersion: '2025-03-26', capabilities: {}, clientInfo: { name: 'openvisio-agent', version: '0.15.2' } } }, false)
+    const res = await mcpPost({ jsonrpc: '2.0', id: ++mcpRpcId, method: 'initialize', params: { protocolVersion: '2025-03-26', capabilities: {}, clientInfo: { name: 'openvisio-agent', version: '0.16.1' } } }, false)
     if (!res.ok) throw new Error('MCP initialize HTTP ' + res.status)
     await mcpPayload(res)
     mcpSessionId = res.headers.get('mcp-session-id') || ''
@@ -635,7 +643,7 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   // Reconcile everything that may have arrived while disconnected. This spends no
   // model tokens unless the tools actually report pending work.
   const reconcileBacklog = async () => {
-    if (!mcpUrl || backlogProbeBusy || busy) return
+    if (!mcpUrl || backlogProbeBusy) return
     backlogProbeBusy = true
     try {
       const agentsData = toolData(await callMcpTool('list_agents'))
@@ -696,10 +704,12 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
   const baseFor = (kind) => kind === 'intro' ? INTRO : kind === 'full' ? fullPrompt : (kind === 'coord' || kind === 'sweep') ? COORDINATE : fastPrompt
 
   async function drain(kind, context) {
-    if (context) pending.push(context)
-    if (busy) { queued = (RANK[kind] ?? 0) >= (RANK[queued] ?? 0) ? kind : queued; log('busy — queued a ' + kind + ' follow-up cycle'); return }
-    busy = true
-    const ctx = pending.splice(0) // take everything accumulated so far
+    const laneName = kind === 'full' ? 'work' : 'reply'
+    const lane = lanes[laneName]
+    if (context) lane.pending.push(context)
+    if (lane.busy) { lane.queued = (RANK[kind] ?? 0) >= (RANK[lane.queued] ?? 0) ? kind : lane.queued; log(laneName + ' lane busy — queued a ' + kind + ' follow-up cycle'); return }
+    lane.busy = true
+    const ctx = lane.pending.splice(0)
     // credNote + charter live in the cached system prompt now — the per-cycle
     // message is just the event context + the small base instruction.
     const prompt = (ctx.length ? ctx.join('\n') + '\n\n' : '') + baseFor(kind)
@@ -713,7 +723,7 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
     emitStatus('working')
     const heartbeat = targets.length ? setInterval(() => emitStatus('working'), 9000) : null
     try {
-      const result = await runCycle(prompt, useModel)
+      const result = await runners[laneName].runCycle(prompt, useModel)
       // A zero exit is not proof of work. Assigned-ticket cycles must both use
       // the task MCP and leave repository evidence. A simple `ls` no longer
       // counts as completion. Do not retry a verified real blocker.
@@ -722,13 +732,13 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
       if (agent === 'codex' && kind === 'full' && result?.subtype === 'ok' && incomplete && !legitimateNoWork) {
         const missing = [!result.didMcpTaskRead && 'read the ticket through get_ticket/list_tasks', !result.didRepoMutation && 'perform and verify the repository change', !result.didMcpTaskUpdate && 'update the ticket through update_ticket'].filter(Boolean)
         log('coding cycle incomplete; recovery requires: ' + missing.join(', '))
-        await runCycle(`The assigned task is NOT complete. Missing evidence: ${missing.join('; ')}. Do not post another acknowledgement or plan. Resume now. First use get_ticket/list_tasks and list_task_types, then do the repository work, verify it, commit and push an agent/* branch, open the PR, call update_ticket with the correct board column, and post exactly one result update with evidence. If a real blocker appears, report it once.`, codeModel)
+        await runners.work.runCycle(`The assigned task is NOT complete. Missing evidence: ${missing.join('; ')}. Do not post another acknowledgement or plan. Resume now. First use get_ticket/list_tasks and list_task_types, then do the repository work, verify it, commit and push an agent/* branch, open the PR, call update_ticket with the correct board column, and post exactly one result update with evidence. If a real blocker appears, report it once.`, codeModel)
       }
     } finally {
       if (heartbeat) clearInterval(heartbeat)
       for (const c of targets) { sendStatus(c, 'done'); statusTargets.delete(c) }
-      busy = false
-      if (queued || pending.length) { const next = queued || 'fast'; queued = null; void drain(next) }
+      lane.busy = false
+      if (lane.queued || lane.pending.length) { const next = lane.queued || (laneName === 'work' ? 'full' : 'fast'); lane.queued = null; void drain(next) }
     }
   }
 
@@ -818,6 +828,10 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
       const dedupeKey = mid != null ? 'id:' + mid : 'sig:' + (cid != null ? cid : '?') + '|' + text.slice(0, 100)
       if (seenMentions.has(dedupeKey)) { log('agent:mention (dup) — skipped'); return }
       seenMentions.add(dedupeKey); if (seenMentions.size > 500) seenMentions.clear()
+      if (requestTargetsLaterAgent(text, [slug, identifier])) {
+        log('agent:mention addressed to a later-mentioned agent — skipped')
+        return
+      }
       // Under-the-hood model control from chat (view / switch the model the agent runs).
       const mcmd = cid != null ? parseModelCmd(text) : null
       if (mcmd) {
@@ -848,7 +862,13 @@ function loopBackendWs({ wsUrl, apiKey, identifier, slug, claude, agent, mcpConf
       const ctx = cid != null
         ? `You were @mentioned in OpenVisio channel ${cid}${who ? ` by "${who}"` : ''}: "${text}". This mention is FOR YOU. ${codingMention ? 'This is repository work: complete the coding flow first, then send' : 'Send'} EXACTLY ONE reply with post_message: arguments: channel_id ${cid}${threadRoot != null ? `, parent_id ${threadRoot} (reply IN THAT THREAD, do not start a new top-level message)` : ''}, plus agent_identifier + agent_api_key from the AUTH line above, and a 1-3 sentence reply. Compose the whole answer, then post it ONCE. Do not post a first reply and then a revised version. FIRST read the recent messages in this thread: if you already answered this, or another agent was the one addressed, do NOT post at all. Be sure of your answer before sending.${who ? ` To @mention them back, write their EXACT full name "@${who}". A mention only links when the name matches exactly.` : ''} You ALREADY have the message here. Do not poll_inbox, and after your single reply, STOP.`
         : undefined
-      void drain(codingMention ? 'full' : 'fast', ctx)
+      if (codingMention) {
+        const ack = cid != null
+          ? `You were asked for repository work in channel ${cid}${threadRoot != null ? `, thread ${threadRoot}` : ''}. The dedicated work lane has accepted it. Post exactly one short reply with post_message in that same thread saying you have picked it up and will return there with the verified result. Include agent_identifier + agent_api_key. Do not inspect or edit code in this reply lane.`
+          : undefined
+        void drain('coord', ack)
+        void drain('full', ctx)
+      } else void drain('fast', ctx)
     } else if (k === 'error') {
       const detail = raw && (raw.message || raw.error || raw.reason || raw.code || raw.d?.message || raw.d?.error)
       // Older backend stages reject agent_status. Stop its heartbeat after the