openvisio-agent 0.11.1 → 0.12.0

package/README.md

@@ -62,12 +62,15 @@ Routine messages, triage, introductions, catch-up checks, and ticket movement us
 openvisio-agent watch --name ada                 # run in this terminal
 openvisio-agent watch --name ada --install       # run in the background, start at login
 openvisio-agent watch --name ada --workdir ~/repo  # allow REAL work on a git branch
+openvisio-agent stop --name ada                  # stop service + every ada watcher
 ```
 
 With `--workdir`, the agent gets file + Bash tools scoped to that repo and works on a branch. Guardrails are built in: it never pushes or merges, and destructive shell (`git push`, `rm`, `sudo`, `curl`, publish, PR-merge, …) is denied.
 
 `--install` sets up a background service (launchd on macOS, systemd `--user` on Linux) that runs `watch` and restarts on login. Logs go to `~/.openvisio/<agent>.log` (macOS) or `journalctl --user -u openvisio-<agent>` (Linux).
 
+Do not chase auto-changing watcher PIDs. `openvisio-agent stop --name <agent>` unloads the named background service first, stops every remaining watcher for that exact agent, and clears its stale lock. Running `watch --install` also performs this cleanup before replacing the service.
+
 ## Security
 
 - **No opaque script.** You run a named, versioned npm package you can read here and on [npmjs.com](https://www.npmjs.com/package/openvisio-agent).

package/bin/cli.mjs

@@ -14,7 +14,7 @@ import { mkdirSync, readFileSync, writeFileSync } from 'node:fs'
 import { fileURLToPath } from 'node:url'
 import { dirname, join } from 'node:path'
 import { parseFlags, slugify, stripSlash, exchangeToken, ensureClaude, ensureCodex, writeJson, mcpConfigPath, configPath, chmodSafe, onPath, OV_DIR, fail, ok, info } from '../src/lib.mjs'
-import { runWatch, installService } from '../src/watch.mjs'
+import { runWatch, installService, stopWatchers } from '../src/watch.mjs'
 
 const HERE = dirname(fileURLToPath(import.meta.url))
 const VERSION = (() => { try { return JSON.parse(readFileSync(join(HERE, '..', 'package.json'), 'utf8')).version } catch { return '0.0.0' } })()
@@ -27,6 +27,7 @@ Usage:
   openvisio-agent connect <ovs_code> --host <url> [--name "<agent>"] [--mcp-url <url>] [--agent claude|codex|opencode]
   openvisio-agent connect --backend <url> --key <api-key> --id <identifier> [--name "<agent>"] [--ws <wss-url>] [--mcp-url <url>] [--agent claude|codex|opencode]
   openvisio-agent watch   --name <agent> [--install] [--workspace <dir>] [--chat-only] [--model <m>] [--chat-model <m>] [--debug]
+  openvisio-agent stop    --name <agent>
   openvisio-agent --help | --version
 
 connect
@@ -72,6 +73,11 @@ watch
   setup needed. Use --workspace <dir> to relocate it (e.g. an existing clones folder),
   --chat-only to disable code work, and --install to run in the background on login.
 
+stop
+  Stops the named agent's launchd/systemd service first, then terminates every
+  remaining watcher with that exact --name and clears its stale lock. Use this
+  instead of killing changing PIDs: openvisio-agent stop --name Alex
+
 Docs: https://www.npmjs.com/package/openvisio-agent`
 
 // Register the `openvisio-team` MCP at USER (global) scope so it's available in
@@ -280,6 +286,11 @@ async function main() {
   const rest = parseFlags(argv.slice(1))
   if (cmd === 'connect') return runConnect(rest)
   if (cmd === 'watch') return runWatch(rest)
+  if (cmd === 'stop') {
+    const name = String(rest.flags.name || rest.positional[0] || '')
+    if (!name) fail('Missing agent name.\n  Usage: openvisio-agent stop --name <agent>')
+    return stopWatchers({ slug: slugify(name) })
+  }
   fail(`Unknown command "${cmd}".\n\n${HELP}`)
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openvisio-agent",
-  "version": "0.11.1",
+  "version": "0.12.0",
   "description": "Connect Claude Code, Codex, or OpenCode to an OpenVisio team — MCP tools + optional autonomy — in one command.",
   "type": "module",
   "bin": {

package/src/watch.mjs

@@ -229,18 +229,13 @@ export async function runWatch({ flags }) {
     const lock = acquireSingleInstance(slug || 'openvisio')
     if (lock.conflict) {
       const watcherName = slug || 'openvisio'
-      const stop = process.platform === 'darwin'
-        ? `launchctl unload ~/Library/LaunchAgents/io.openvisio.${watcherName}.plist`
-        : process.platform === 'win32'
-          ? 'Stop the existing openvisio-agent process in Task Manager.'
-          : `systemctl --user stop openvisio-${watcherName}.service`
       const logs = process.platform === 'darwin'
         ? `tail -f ~/.openvisio/${watcherName}.log`
         : `journalctl --user -u openvisio-${watcherName} -f`
       fail(`Another openvisio-agent watcher for "${watcherName}" is already running (pid ${lock.conflict}).\n` +
         `  Two watchers for the same agent BOTH reply to every mention — that is what causes duplicate/contradicting messages.\n` +
         `  This is usually the auto-restarting background service; killing its PID only makes it restart.\n` +
-        `  To run in this terminal instead, stop the service first:\n    ${stop}\n` +
+        `  Stop the service and every watcher for this agent with:\n    openvisio-agent stop --name ${watcherName}\n` +
         `  Or keep the service and inspect its log:\n    ${logs}\n` +
         `  Refusing to start a second watcher.`)
     }
@@ -871,7 +866,57 @@ function loop({ host, key, slug, claude, agent, mcpConfig, mcpUrl, workdir, mode
 }
 
 // ── background service install (launchd / systemd) ───────────────────────────
+/** Stop the auto-restarting service first, then every orphaned watcher whose
+ *  --name resolves to this exact slug. Never use a broad pkill pattern. */
+export function stopWatchers({ slug, quiet = false }) {
+  const key = slugify(slug || 'openvisio')
+  let serviceStopped = false
+
+  if (process.platform === 'darwin') {
+    const plist = join(homedir(), 'Library', 'LaunchAgents', `io.openvisio.${key}.plist`)
+    if (existsSync(plist)) {
+      const r = spawnSync('launchctl', ['unload', plist], { stdio: 'ignore' })
+      serviceStopped = r.status === 0
+    }
+  } else if (process.platform !== 'win32') {
+    const r = spawnSync('systemctl', ['--user', 'stop', `openvisio-${key}.service`], { stdio: 'ignore' })
+    serviceStopped = r.status === 0
+  }
+
+  const watcherPids = () => {
+    if (process.platform === 'win32') return []
+    const r = spawnSync('ps', ['-axo', 'pid=,command='], { encoding: 'utf8' })
+    if (r.status !== 0) return []
+    const out = []
+    for (const line of String(r.stdout || '').split(/\r?\n/)) {
+      const m = /^\s*(\d+)\s+(.+)$/.exec(line)
+      if (!m) continue
+      const pid = Number(m[1]); const command = m[2]
+      if (pid === process.pid || !/\bopenvisio-agent\b/.test(command) || !/\bwatch\b/.test(command)) continue
+      const name = /(?:^|\s)--name(?:=|\s+)["']?([^"'\s]+)/.exec(command)?.[1]
+      if (name && slugify(name) === key) out.push(pid)
+    }
+    return out
+  }
+
+  const found = watcherPids()
+  for (const pid of found) { try { process.kill(pid, 'SIGTERM') } catch { /* already stopped */ } }
+  if (found.length) Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 600)
+  const stubborn = watcherPids()
+  for (const pid of stubborn) { try { process.kill(pid, 'SIGKILL') } catch { /* already stopped */ } }
+  if (stubborn.length) Atomics.wait(new Int32Array(new SharedArrayBuffer(4)), 0, 0, 150)
+
+  const remaining = watcherPids()
+  if (remaining.length) fail(`Could not stop watcher${remaining.length === 1 ? '' : 's'} for "${key}": ${remaining.join(', ')}`)
+  try { unlinkSync(join(OV_DIR, `watch-${key}.lock`)) } catch { /* absent */ }
+  if (!quiet) ok(`Stopped ${found.length} watcher process${found.length === 1 ? '' : 'es'} for "${key}"${serviceStopped ? ' and disabled its background service' : ''}.`)
+  return { stopped: found.length, serviceStopped }
+}
+
 export function installService({ slug, workdir }) {
+  // Replacing a service must also remove manually-started watchers. Otherwise the
+  // new KeepAlive process repeatedly spawns, sees their lock, exits, and respawns.
+  stopWatchers({ slug, quiet: true })
   const binPath = onPath('openvisio-agent')
   if (!binPath || binPath.includes('/_npx/')) {
     info('Installing openvisio-agent globally so the background service has a stable path…')