opensquid 0.5.395

package/dist/anti-drift/rules.js

@@ -0,0 +1,368 @@
+/**
+ * Anti-drift declarative rule list (0.7.33 — unified-evaluator track).
+ *
+ * Per loop/docs/opensquid-anti-drift-unified-evaluator-design.md: one
+ * declarative `Rule[]` list replaces the per-file hook handlers in
+ * src/hooks/*. Each rule:
+ *
+ *   - `id`         stable identifier
+ *   - `catches`    which D-entry (or "preexisting") this rule covers
+ *   - `hook`       which lifecycle event this rule binds to
+ *   - `when`       (cheap, synchronous) gate — short-circuits before
+ *                  expensive `check` work
+ *   - `check`      (async) returns a Verdict
+ *   - `bypass`     optional env var that emergency-disables the rule
+ *   - `rationale`  one-line agent-facing reason (used in error messages)
+ *
+ * Today the check functions DELEGATE to existing src/hooks/* helpers
+ * (engine-vocab-gate, versioning-gate, workflow-gate, drift-patterns,
+ * inline-report-check, etc.) so this patch ships the declarative
+ * SURFACE without re-implementing every gate. The 0.7.35 cutover
+ * moves the helper bodies into src/anti-drift/* and deletes the old
+ * per-hook files.
+ *
+ * The evaluator (0.7.34) walks this list at each hook event, runs
+ * applicable rules, aggregates verdicts (most-restrictive wins for
+ * PreToolUse permissions; all surfaces accumulate at Stop/UPS).
+ */
+import { findDrifts, decide as decideDriftPatterns } from "../hooks/drift-patterns.js";
+import { evaluateEngineVocabGate } from "../hooks/engine-vocab-gate.js";
+import { isRecallRequired, clearRecallRequired } from "../hooks/heartbeat.js";
+import { checkInlineReportFormat } from "../hooks/inline-report-check.js";
+import { checkChatSendReportFormat } from "../hooks/pre-tool-use.js";
+import { evaluateVersioningGate } from "../hooks/versioning-gate.js";
+import { evaluateWorkflowGate } from "../hooks/workflow-gate.js";
+// =====================================================================
+// Helpers shared across rules
+// =====================================================================
+function getCommand(ctx) {
+    const v = ctx.toolInput?.command;
+    return typeof v === "string" ? v : null;
+}
+function isBypassed(rule) {
+    if (!rule.bypass)
+        return false;
+    return process.env[rule.bypass] === "1";
+}
+/** Pass-through verdict factory keeps the rule list legible. */
+const PASS = { kind: "pass" };
+// =====================================================================
+// The rule list (18 entries — matches the design doc)
+// =====================================================================
+export const RULES = [
+    // ---------- Hard blocks (PreToolUse) ----------
+    {
+        id: "active-task-required",
+        catches: "D1",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_ACTIVE_TASK_GATE",
+        rationale: "log_phase / chat_send without an in_progress task means the workflow-gate has nothing to validate against — exactly the D1 headline drift.",
+        when: (ctx) => ctx.toolName === "mcp__opensquid__log_phase" || ctx.toolName === "mcp__opensquid__chat_send",
+        check: async (ctx) => {
+            // Delegated to the existing readActiveTaskId for now (transcript
+            // parsing). 0.7.35 cutover swaps this to state.readActiveTask.
+            if (!ctx.transcriptPath)
+                return PASS;
+            const { readActiveTaskId } = await import("../hooks/transcript.js");
+            try {
+                const id = await readActiveTaskId(ctx.transcriptPath);
+                if (id)
+                    return PASS;
+            }
+            catch {
+                return PASS;
+            }
+            return {
+                kind: "block",
+                message: `🦑 [opensquid] ${ctx.toolName} called without an in_progress task. Call TaskCreate first.`,
+            };
+        },
+    },
+    {
+        id: "never-amend",
+        catches: "preexisting",
+        hook: "PreToolUse",
+        rationale: "git commit --amend hides iteration history per feedback_auto_commit; use a follow-up commit instead.",
+        when: (ctx) => ctx.toolName === "Bash",
+        check: async (ctx) => deriveDriftPatternVerdict(ctx, "never-amend"),
+    },
+    {
+        id: "no-implicit-push",
+        catches: "preexisting",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_DRIFT",
+        rationale: "git push requires explicit user authorization; commits stay local by default.",
+        when: (ctx) => ctx.toolName === "Bash",
+        check: async (ctx) => deriveDriftPatternVerdict(ctx, "no-implicit-push"),
+    },
+    {
+        id: "no-force-push-main",
+        catches: "preexisting",
+        hook: "PreToolUse",
+        rationale: "force-push to main/master is destructive and bypasses normal authorization.",
+        when: (ctx) => ctx.toolName === "Bash",
+        check: async (ctx) => deriveDriftPatternVerdict(ctx, "no-force-push-main"),
+    },
+    {
+        id: "engine-vocab-leak",
+        catches: "D6",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_ENGINE_VOCAB_GATE",
+        rationale: "engine artifacts must not name consumer products per feedback_engine_vocabulary_discipline.",
+        when: (ctx) => ctx.toolName === "Bash" && /\bgit\s+commit\b/.test(getCommand(ctx) ?? ""),
+        check: async (ctx) => {
+            const r = await evaluateEngineVocabGate({
+                cwd: ctx.cwd,
+                bashCommand: getCommand(ctx) ?? undefined,
+            });
+            if (r.block)
+                return { kind: "block", message: r.stderr };
+            if (r.stderr)
+                return { kind: "warn", message: r.stderr };
+            return PASS;
+        },
+    },
+    {
+        id: "versioning-bump-required",
+        catches: "D5+preexisting",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_VERSION_GATE",
+        rationale: "every src commit ships a matching patch bump per feedback_pre1_versioning v4 PATCH-ONLY rule.",
+        when: (ctx) => ctx.toolName === "Bash" && /\bgit\s+commit\b/.test(getCommand(ctx) ?? ""),
+        check: async (ctx) => {
+            const r = await evaluateVersioningGate({ cwd: ctx.cwd });
+            if (r.block)
+                return { kind: "block", message: r.stderr };
+            if (r.stderr)
+                return { kind: "warn", message: r.stderr };
+            return PASS;
+        },
+    },
+    {
+        id: "workflow-phases-required",
+        catches: "preexisting",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_WORKFLOW_GATE",
+        rationale: "git commit requires required phases logged for the active task per feedback_workflow_cycle.",
+        when: (ctx) => ctx.toolName === "Bash" && /\bgit\s+commit\b/.test(getCommand(ctx) ?? ""),
+        check: async (ctx) => {
+            const r = await evaluateWorkflowGate({ transcriptPath: ctx.transcriptPath });
+            if (r.block)
+                return { kind: "block", message: r.stderr };
+            if (r.stderr)
+                return { kind: "warn", message: r.stderr };
+            return PASS;
+        },
+    },
+    {
+        id: "seven-phase-report-format",
+        catches: "D3",
+        hook: "PreToolUse",
+        rationale: "chat_send body matching the task-report marker must include the PHASES heading per feedback_telegram_reports.",
+        when: (ctx) => ctx.toolName === "mcp__opensquid__chat_send",
+        check: async (ctx) => {
+            const msg = checkChatSendReportFormat({
+                tool: ctx.toolName ?? "",
+                input: ctx.toolInput ?? {},
+            });
+            return msg ? { kind: "warn", message: msg } : PASS;
+        },
+    },
+    {
+        id: "heartbeat-recall-required",
+        catches: "D7",
+        hook: "PreToolUse",
+        bypass: "OPENSQUID_SKIP_RECALL_GATE",
+        rationale: "after a heartbeat surfaces, the next mcp__opensquid__* call must be recall to re-anchor.",
+        when: (ctx) => typeof ctx.toolName === "string" && ctx.toolName.startsWith("mcp__opensquid__"),
+        check: async (ctx) => {
+            if (!ctx.sessionId)
+                return PASS;
+            const required = await isRecallRequired(ctx.sessionId);
+            if (!required)
+                return PASS;
+            if (ctx.toolName === "mcp__opensquid__recall") {
+                await clearRecallRequired(ctx.sessionId);
+                return PASS;
+            }
+            return {
+                kind: "block",
+                message: `🦑 [opensquid recall-gate] ${ctx.toolName} blocked — heartbeat surfaced this turn; call mcp__opensquid__recall first.`,
+            };
+        },
+    },
+    // ---------- Soft warns (PreToolUse) ----------
+    {
+        id: "telegram-redirect-report",
+        catches: "D2",
+        hook: "PreToolUse",
+        rationale: "task-completion reports go via mcp__opensquid__chat_send to the project report_channel, not plugin:telegram reply (DM).",
+        when: (ctx) => ctx.toolName === "mcp__plugin_telegram_telegram__reply",
+        check: async (ctx) => deriveDriftPatternVerdict(ctx, "telegram-redirect-report"),
+    },
+    {
+        id: "bundled-commit",
+        catches: "D4",
+        hook: "PreToolUse",
+        rationale: "prefer multiple small logical commits over one large catchall per feedback_auto_commit.",
+        when: (ctx) => ctx.toolName === "Bash",
+        check: async (ctx) => deriveDriftPatternVerdict(ctx, "bundled-commit"),
+    },
+    // ---------- Stop hook ----------
+    {
+        id: "inline-report-missing-phases",
+        catches: "D3-inline",
+        hook: "Stop",
+        rationale: "in-session status reports must include the PHASES heading too, not just chat_send — feedback_telegram_reports applies to both surfaces.",
+        when: (ctx) => Boolean(ctx.assistantText),
+        check: async (ctx) => {
+            const v = checkInlineReportFormat(ctx.assistantText ?? "");
+            if (!v)
+                return PASS;
+            return {
+                kind: "surface",
+                message: `inline-report-missing-phases: message shape suggests a completion report (version_refs=${v.signals.version_refs}, commit_hashes=${v.signals.hash_refs}) but PHASES heading missing.`,
+            };
+        },
+    },
+    {
+        id: "false-stop-haiku",
+        catches: "D9",
+        hook: "Stop",
+        rationale: "trailing pause-prompts violate feedback_full_automation_mode; Claude Code's native prompt-type Stop hook (installed via hooks-cli) handles the Haiku classification + re-prompt loop.",
+        when: () => false, // implemented as a `type: "prompt"` settings.json entry, not via this Rule.check path
+        check: async () => PASS,
+    },
+    // ---------- UserPromptSubmit ----------
+    {
+        id: "multi-task-plan-injection",
+        catches: "D8",
+        hook: "UserPromptSubmit",
+        rationale: "when the user lists multiple task identifiers, mirror back the parsed plan before executing to catch a misread per feedback_user_words_have_top_weight.",
+        when: (ctx) => typeof ctx.userPrompt === "string",
+        check: async (ctx) => {
+            const { detectMultiTaskDirective } = await import("../hooks/user-prompt-submit.js");
+            const msg = detectMultiTaskDirective(ctx.userPrompt ?? "");
+            return msg ? { kind: "surface", message: msg } : PASS;
+        },
+    },
+    // ---------- SessionEnd ----------
+    {
+        id: "drift-catalog-auto",
+        catches: "D10",
+        hook: "SessionEnd",
+        rationale: "auto-catalog drift markers (user corrections, rule citations, mea culpas) so the dogfood proof writes itself.",
+        when: () => true,
+        check: async (ctx) => {
+            if (!ctx.sessionId)
+                return PASS;
+            const { runDriftCatalogScan } = await import("../hooks/drift-catalog.js");
+            try {
+                const count = await runDriftCatalogScan({
+                    sessionId: ctx.sessionId,
+                    transcriptPath: ctx.transcriptPath,
+                    cwd: ctx.cwd,
+                });
+                if (count > 0) {
+                    return {
+                        kind: "warn",
+                        message: `🦑 [opensquid drift-catalog] recorded ${count} drift marker(s)`,
+                    };
+                }
+            }
+            catch {
+                /* fail-open per Stop/SessionEnd precedent */
+            }
+            return PASS;
+        },
+    },
+    {
+        id: "session-state-cleanup",
+        catches: "preexisting",
+        hook: "SessionEnd",
+        rationale: "remove per-session ledger + state files to bound disk usage.",
+        when: () => true,
+        check: async (ctx) => {
+            if (!ctx.sessionId)
+                return PASS;
+            const { clearSession } = await import("../hooks/honesty-ledger.js");
+            try {
+                await clearSession(ctx.sessionId);
+            }
+            catch {
+                /* non-fatal */
+            }
+            return PASS;
+        },
+    },
+    // ---------- Honesty + heartbeat (Stop hook auto-actions) ----------
+    {
+        id: "honesty-reconcile",
+        catches: "preexisting",
+        hook: "Stop",
+        rationale: "reconcile claims-vs-actions for the just-completed turn; broken promises surface next UPS.",
+        when: (ctx) => Boolean(ctx.sessionId && ctx.transcriptPath),
+        check: async () => PASS, // orchestrated by the evaluator (multi-step IO); kept here for catalog completeness
+    },
+    {
+        id: "heartbeat-arm",
+        catches: "preexisting",
+        hook: "Stop",
+        rationale: "arm the heartbeat nudge when the transcript crosses the configured token threshold.",
+        when: (ctx) => Boolean(ctx.sessionId && ctx.transcriptPath),
+        check: async () => PASS, // orchestrated by the evaluator; same kept-for-catalog reason
+    },
+];
+// =====================================================================
+// Evaluation helpers — used by the evaluator (0.7.34) to walk RULES
+// =====================================================================
+/**
+ * Pick the rules that apply to a given hook event AND that aren't
+ * bypassed. Exported so the evaluator and tests share the same filter.
+ */
+export function rulesForEvent(event) {
+    return RULES.filter((r) => r.hook === event && !isBypassed(r));
+}
+/**
+ * Walk applicable rules and collect verdicts. Stops at the first
+ * `block` for PreToolUse events; aggregates all surfaces/warns for
+ * Stop/UPS/SessionEnd events.
+ */
+export async function evaluateRules(ctx) {
+    const verdicts = [];
+    for (const rule of rulesForEvent(ctx.hookEvent)) {
+        if (!rule.when(ctx))
+            continue;
+        const v = await rule.check(ctx);
+        verdicts.push(v);
+        // Short-circuit on PreToolUse block — match the existing
+        // most-restrictive-wins semantic.
+        if (ctx.hookEvent === "PreToolUse" && v.kind === "block")
+            break;
+    }
+    return verdicts;
+}
+// =====================================================================
+// Internal: drift-patterns delegation (shared by 4 rules)
+// =====================================================================
+/**
+ * Run the existing drift-patterns catalog against the tool call and
+ * extract the verdict for a specific pattern id. Returns PASS when
+ * the pattern doesn't fire OR when the verdict is bypass-only.
+ *
+ * Lets RULES delegate to the legacy catalog while presenting the
+ * declarative shape externally. The 0.7.35 cutover inlines these.
+ */
+async function deriveDriftPatternVerdict(ctx, patternId) {
+    if (!ctx.toolName)
+        return PASS;
+    const call = { tool: ctx.toolName, input: ctx.toolInput ?? {} };
+    const hits = findDrifts(call).filter((h) => h.pattern.id === patternId);
+    if (hits.length === 0)
+        return PASS;
+    const { exit, stderr } = decideDriftPatterns(hits, call);
+    if (exit === 2)
+        return { kind: "block", message: stderr };
+    return { kind: "warn", message: stderr };
+}
+//# sourceMappingURL=rules.js.map

package/dist/anti-drift/rules.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"rules.js","sourceRoot":"","sources":["../../src.legacy/anti-drift/rules.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,EAAE,UAAU,EAAE,MAAM,IAAI,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AACvF,OAAO,EAAE,uBAAuB,EAAE,MAAM,+BAA+B,CAAC;AACxE,OAAO,EAAE,gBAAgB,EAAE,mBAAmB,EAAE,MAAM,uBAAuB,CAAC;AAC9E,OAAO,EAAE,uBAAuB,EAAE,MAAM,iCAAiC,CAAC;AAC1E,OAAO,EAAE,yBAAyB,EAAE,MAAM,0BAA0B,CAAC;AACrE,OAAO,EAAE,sBAAsB,EAAE,MAAM,6BAA6B,CAAC;AACrE,OAAO,EAAE,oBAAoB,EAAE,MAAM,2BAA2B,CAAC;AA2CjE,wEAAwE;AACxE,8BAA8B;AAC9B,wEAAwE;AAExE,SAAS,UAAU,CAAC,GAAgB;IAClC,MAAM,CAAC,GAAG,GAAG,CAAC,SAAS,EAAE,OAAO,CAAC;IACjC,OAAO,OAAO,CAAC,KAAK,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;AAC1C,CAAC;AAED,SAAS,UAAU,CAAC,IAAU;IAC5B,IAAI,CAAC,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAC;IAC/B,OAAO,OAAO,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,KAAK,GAAG,CAAC;AAC1C,CAAC;AAED,gEAAgE;AAChE,MAAM,IAAI,GAAY,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC;AAEvC,wEAAwE;AACxE,sDAAsD;AACtD,wEAAwE;AAExE,MAAM,CAAC,MAAM,KAAK,GAAW;IAC3B,iDAAiD;IACjD;QACE,EAAE,EAAE,sBAAsB;QAC1B,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,iCAAiC;QACzC,SAAS,EACP,4IAA4I;QAC9I,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CACZ,GAAG,CAAC,QAAQ,KAAK,2BAA2B,IAAI,GAAG,CAAC,QAAQ,KAAK,2BAA2B;QAC9F,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,iEAAiE;YACjE,+DAA+D;YAC/D,IAAI,CAAC,GAAG,CAAC,cAAc;gBAAE,OAAO,IAAI,CAAC;YACrC,MAAM,EAAE,gBAAgB,EAAE,GAAG,MAAM,MAAM,CAAC,wBAAwB,CAAC,CAAC;YACpE,IAAI,CAAC;gBACH,MAAM,EAAE,GAAG,MAAM,gBAAgB,CAAC,GAAG,CAAC,cAAc,CAAC,CAAC;gBACtD,IAAI,EAAE;oBAAE,OAAO,IAAI,CAAC;YACtB,CAAC;YAAC,MAAM,CAAC;gBACP,OAAO,IAAI,CAAC;YACd,CAAC;YACD,OAAO;gBACL,IAAI,EAAE,OAAO;gBACb,OAAO,EAAE,kBAAkB,GAAG,CAAC,QAAQ,6DAA6D;aACrG,CAAC;QACJ,CAAC;KACF;IAED;QACE,EAAE,EAAE,aAAa;QACjB,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,YAAY;QAClB,SAAS,EACP,sGAAsG;QACxG,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM;QACtC,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,EAAE,aAAa,CAAC;KACpE;IAED;QACE,EAAE,EAAE,kBAAkB;QACtB,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,sBAAsB;QAC9B,SAAS,EAAE,+EAA+E;QAC1F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM;QACtC,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,EAAE,kBAAkB,CAAC;KACzE;IAED;QACE,EAAE,EAAE,oBAAoB;QACxB,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,YAAY;QAClB,SAAS,EAAE,6EAA6E;QACxF,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM;QACtC,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,EAAE,oBAAoB,CAAC;KAC3E;IAED;QACE,EAAE,EAAE,mBAAmB;QACvB,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,kCAAkC;QAC1C,SAAS,EACP,6FAA6F;QAC/F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM,IAAI,kBAAkB,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QACxF,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,CAAC,GAAG,MAAM,uBAAuB,CAAC;gBACtC,GAAG,EAAE,GAAG,CAAC,GAAG;gBACZ,WAAW,EAAE,UAAU,CAAC,GAAG,CAAC,IAAI,SAAS;aAC1C,CAAC,CAAC;YACH,IAAI,CAAC,CAAC,KAAK;gBAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,IAAI,CAAC,CAAC,MAAM;gBAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,OAAO,IAAI,CAAC;QACd,CAAC;KACF;IAED;QACE,EAAE,EAAE,0BAA0B;QAC9B,OAAO,EAAE,gBAAgB;QACzB,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,6BAA6B;QACrC,SAAS,EACP,+FAA+F;QACjG,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM,IAAI,kBAAkB,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QACxF,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,CAAC,GAAG,MAAM,sBAAsB,CAAC,EAAE,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,CAAC,CAAC;YACzD,IAAI,CAAC,CAAC,KAAK;gBAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,IAAI,CAAC,CAAC,MAAM;gBAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,OAAO,IAAI,CAAC;QACd,CAAC;KACF;IAED;QACE,EAAE,EAAE,0BAA0B;QAC9B,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,8BAA8B;QACtC,SAAS,EACP,6FAA6F;QAC/F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM,IAAI,kBAAkB,CAAC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC;QACxF,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,CAAC,GAAG,MAAM,oBAAoB,CAAC,EAAE,cAAc,EAAE,GAAG,CAAC,cAAc,EAAE,CAAC,CAAC;YAC7E,IAAI,CAAC,CAAC,KAAK;gBAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,IAAI,CAAC,CAAC,MAAM;gBAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC;YACzD,OAAO,IAAI,CAAC;QACd,CAAC;KACF;IAED;QACE,EAAE,EAAE,2BAA2B;QAC/B,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,SAAS,EACP,+GAA+G;QACjH,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,2BAA2B;QAC3D,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,GAAG,GAAG,yBAAyB,CAAC;gBACpC,IAAI,EAAE,GAAG,CAAC,QAAQ,IAAI,EAAE;gBACxB,KAAK,EAAE,GAAG,CAAC,SAAS,IAAI,EAAE;aAC3B,CAAC,CAAC;YACH,OAAO,GAAG,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;QACrD,CAAC;KACF;IAED;QACE,EAAE,EAAE,2BAA2B;QAC/B,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,MAAM,EAAE,4BAA4B;QACpC,SAAS,EACP,0FAA0F;QAC5F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,GAAG,CAAC,QAAQ,KAAK,QAAQ,IAAI,GAAG,CAAC,QAAQ,CAAC,UAAU,CAAC,kBAAkB,CAAC;QAC9F,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,IAAI,CAAC,GAAG,CAAC,SAAS;gBAAE,OAAO,IAAI,CAAC;YAChC,MAAM,QAAQ,GAAG,MAAM,gBAAgB,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;YACvD,IAAI,CAAC,QAAQ;gBAAE,OAAO,IAAI,CAAC;YAC3B,IAAI,GAAG,CAAC,QAAQ,KAAK,wBAAwB,EAAE,CAAC;gBAC9C,MAAM,mBAAmB,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;gBACzC,OAAO,IAAI,CAAC;YACd,CAAC;YACD,OAAO;gBACL,IAAI,EAAE,OAAO;gBACb,OAAO,EAAE,8BAA8B,GAAG,CAAC,QAAQ,6EAA6E;aACjI,CAAC;QACJ,CAAC;KACF;IAED,gDAAgD;IAChD;QACE,EAAE,EAAE,0BAA0B;QAC9B,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,SAAS,EACP,yHAAyH;QAC3H,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,sCAAsC;QACtE,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,EAAE,0BAA0B,CAAC;KACjF;IAED;QACE,EAAE,EAAE,gBAAgB;QACpB,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,YAAY;QAClB,SAAS,EACP,yFAAyF;QAC3F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,KAAK,MAAM;QACtC,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,yBAAyB,CAAC,GAAG,EAAE,gBAAgB,CAAC;KACvE;IAED,kCAAkC;IAClC;QACE,EAAE,EAAE,8BAA8B;QAClC,OAAO,EAAE,WAAW;QACpB,IAAI,EAAE,MAAM;QACZ,SAAS,EACP,yIAAyI;QAC3I,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,aAAa,CAAC;QACzC,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,CAAC,GAAG,uBAAuB,CAAC,GAAG,CAAC,aAAa,IAAI,EAAE,CAAC,CAAC;YAC3D,IAAI,CAAC,CAAC;gBAAE,OAAO,IAAI,CAAC;YACpB,OAAO;gBACL,IAAI,EAAE,SAAS;gBACf,OAAO,EAAE,0FAA0F,CAAC,CAAC,OAAO,CAAC,YAAY,mBAAmB,CAAC,CAAC,OAAO,CAAC,SAAS,+BAA+B;aAC/L,CAAC;QACJ,CAAC;KACF;IAED;QACE,EAAE,EAAE,kBAAkB;QACtB,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,MAAM;QACZ,SAAS,EACP,uLAAuL;QACzL,IAAI,EAAE,GAAG,EAAE,CAAC,KAAK,EAAE,sFAAsF;QACzG,KAAK,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI;KACxB;IAED,yCAAyC;IACzC;QACE,EAAE,EAAE,2BAA2B;QAC/B,OAAO,EAAE,IAAI;QACb,IAAI,EAAE,kBAAkB;QACxB,SAAS,EACP,yJAAyJ;QAC3J,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,GAAG,CAAC,UAAU,KAAK,QAAQ;QACjD,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,MAAM,EAAE,wBAAwB,EAAE,GAAG,MAAM,MAAM,CAAC,gCAAgC,CAAC,CAAC;YACpF,MAAM,GAAG,GAAG,wBAAwB,CAAC,GAAG,CAAC,UAAU,IAAI,EAAE,CAAC,CAAC;YAC3D,OAAO,GAAG,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,SAAS,EAAE,OAAO,EAAE,GAAG,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC;QACxD,CAAC;KACF;IAED,mCAAmC;IACnC;QACE,EAAE,EAAE,oBAAoB;QACxB,OAAO,EAAE,KAAK;QACd,IAAI,EAAE,YAAY;QAClB,SAAS,EACP,+GAA+G;QACjH,IAAI,EAAE,GAAG,EAAE,CAAC,IAAI;QAChB,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,IAAI,CAAC,GAAG,CAAC,SAAS;gBAAE,OAAO,IAAI,CAAC;YAChC,MAAM,EAAE,mBAAmB,EAAE,GAAG,MAAM,MAAM,CAAC,2BAA2B,CAAC,CAAC;YAC1E,IAAI,CAAC;gBACH,MAAM,KAAK,GAAG,MAAM,mBAAmB,CAAC;oBACtC,SAAS,EAAE,GAAG,CAAC,SAAS;oBACxB,cAAc,EAAE,GAAG,CAAC,cAAc;oBAClC,GAAG,EAAE,GAAG,CAAC,GAAG;iBACb,CAAC,CAAC;gBACH,IAAI,KAAK,GAAG,CAAC,EAAE,CAAC;oBACd,OAAO;wBACL,IAAI,EAAE,MAAM;wBACZ,OAAO,EAAE,yCAAyC,KAAK,kBAAkB;qBAC1E,CAAC;gBACJ,CAAC;YACH,CAAC;YAAC,MAAM,CAAC;gBACP,6CAA6C;YAC/C,CAAC;YACD,OAAO,IAAI,CAAC;QACd,CAAC;KACF;IAED;QACE,EAAE,EAAE,uBAAuB;QAC3B,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,YAAY;QAClB,SAAS,EAAE,8DAA8D;QACzE,IAAI,EAAE,GAAG,EAAE,CAAC,IAAI;QAChB,KAAK,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE;YACnB,IAAI,CAAC,GAAG,CAAC,SAAS;gBAAE,OAAO,IAAI,CAAC;YAChC,MAAM,EAAE,YAAY,EAAE,GAAG,MAAM,MAAM,CAAC,4BAA4B,CAAC,CAAC;YACpE,IAAI,CAAC;gBACH,MAAM,YAAY,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC;YACpC,CAAC;YAAC,MAAM,CAAC;gBACP,eAAe;YACjB,CAAC;YACD,OAAO,IAAI,CAAC;QACd,CAAC;KACF;IAED,qEAAqE;IACrE;QACE,EAAE,EAAE,mBAAmB;QACvB,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,MAAM;QACZ,SAAS,EACP,4FAA4F;QAC9F,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,SAAS,IAAI,GAAG,CAAC,cAAc,CAAC;QAC3D,KAAK,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,EAAE,oFAAoF;KAC9G;IAED;QACE,EAAE,EAAE,eAAe;QACnB,OAAO,EAAE,aAAa;QACtB,IAAI,EAAE,MAAM;QACZ,SAAS,EACP,qFAAqF;QACvF,IAAI,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC,SAAS,IAAI,GAAG,CAAC,cAAc,CAAC;QAC3D,KAAK,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,EAAE,8DAA8D;KACxF;CACF,CAAC;AAEF,wEAAwE;AACxE,oEAAoE;AACpE,wEAAwE;AAExE;;;GAGG;AACH,MAAM,UAAU,aAAa,CAAC,KAAgB;IAC5C,OAAO,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,KAAK,IAAI,CAAC,UAAU,CAAC,CAAC,CAAC,CAAC,CAAC;AACjE,CAAC;AAED;;;;GAIG;AACH,MAAM,CAAC,KAAK,UAAU,aAAa,CAAC,GAAgB;IAClD,MAAM,QAAQ,GAAc,EAAE,CAAC;IAC/B,KAAK,MAAM,IAAI,IAAI,aAAa,CAAC,GAAG,CAAC,SAAS,CAAC,EAAE,CAAC;QAChD,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC;YAAE,SAAS;QAC9B,MAAM,CAAC,GAAG,MAAM,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC;QAChC,QAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACjB,yDAAyD;QACzD,kCAAkC;QAClC,IAAI,GAAG,CAAC,SAAS,KAAK,YAAY,IAAI,CAAC,CAAC,IAAI,KAAK,OAAO;YAAE,MAAM;IAClE,CAAC;IACD,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,wEAAwE;AACxE,0DAA0D;AAC1D,wEAAwE;AAExE;;;;;;;GAOG;AACH,KAAK,UAAU,yBAAyB,CAAC,GAAgB,EAAE,SAAiB;IAC1E,IAAI,CAAC,GAAG,CAAC,QAAQ;QAAE,OAAO,IAAI,CAAC;IAC/B,MAAM,IAAI,GAAG,EAAE,IAAI,EAAE,GAAG,CAAC,QAAQ,EAAE,KAAK,EAAE,GAAG,CAAC,SAAS,IAAI,EAAE,EAAE,CAAC;IAChE,MAAM,IAAI,GAAG,UAAU,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,KAAK,SAAS,CAAC,CAAC;IACxE,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,IAAI,CAAC;IACnC,MAAM,EAAE,IAAI,EAAE,MAAM,EAAE,GAAG,mBAAmB,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC;IACzD,IAAI,IAAI,KAAK,CAAC;QAAE,OAAO,EAAE,IAAI,EAAE,OAAO,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;IAC1D,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,CAAC;AAC3C,CAAC"}

package/dist/anti-drift/rules.test.js

@@ -0,0 +1,213 @@
+/**
+ * Tests for anti-drift/rules.ts (0.7.33 unified-evaluator track).
+ *
+ * Validates:
+ *   1. Catalog shape — every rule has the required fields
+ *   2. rulesForEvent filtering — by event + bypass env var
+ *   3. evaluateRules behavior — PreToolUse short-circuits on block
+ *   4. Specific rule when() predicates fire correctly
+ *
+ * Deep behavioral coverage of each rule's check() lives in the
+ * existing src/hooks/*.test.ts suites (since the rules delegate
+ * there). The 0.7.35 cutover migrates those tests alongside.
+ */
+import { afterEach, beforeEach, describe, expect, it } from "vitest";
+import { RULES, evaluateRules, rulesForEvent, } from "./rules.js";
+describe("RULES catalog shape", () => {
+    it("has at least 16 rules (matches the design doc's 18, allowing 1-2 implementation merges)", () => {
+        expect(RULES.length).toBeGreaterThanOrEqual(16);
+    });
+    it("every rule has all required fields populated", () => {
+        for (const r of RULES) {
+            expect(r.id).toBeTruthy();
+            expect(r.catches).toBeTruthy();
+            expect(["PreToolUse", "Stop", "UserPromptSubmit", "SessionEnd"]).toContain(r.hook);
+            expect(typeof r.when).toBe("function");
+            expect(typeof r.check).toBe("function");
+            expect(r.rationale).toBeTruthy();
+        }
+    });
+    it("rule ids are unique", () => {
+        const ids = RULES.map((r) => r.id);
+        expect(new Set(ids).size).toBe(ids.length);
+    });
+    it("covers all 10 drift D-entries (by `catches` field)", () => {
+        const covered = new Set(RULES.map((r) => r.catches).flatMap((c) => c.split("+").map((s) => s.trim())));
+        for (const drift of ["D1", "D2", "D3", "D4", "D5", "D6", "D7", "D8", "D9", "D10"]) {
+            expect([...covered].some((c) => c === drift || c.startsWith(drift)), `expected catches to include ${drift}`).toBe(true);
+        }
+    });
+});
+describe("rulesForEvent", () => {
+    it("filters by hook event", () => {
+        const preRules = rulesForEvent("PreToolUse");
+        expect(preRules.every((r) => r.hook === "PreToolUse")).toBe(true);
+        expect(preRules.length).toBeGreaterThan(0);
+    });
+    it("excludes bypassed rules", () => {
+        const target = RULES.find((r) => r.id === "active-task-required");
+        expect(target).toBeDefined();
+        expect(target.bypass).toBe("OPENSQUID_SKIP_ACTIVE_TASK_GATE");
+        process.env.OPENSQUID_SKIP_ACTIVE_TASK_GATE = "1";
+        try {
+            const ids = rulesForEvent("PreToolUse").map((r) => r.id);
+            expect(ids).not.toContain("active-task-required");
+        }
+        finally {
+            delete process.env.OPENSQUID_SKIP_ACTIVE_TASK_GATE;
+        }
+    });
+    it("bypass env var must be exactly '1' (other values do NOT bypass)", () => {
+        process.env.OPENSQUID_SKIP_ACTIVE_TASK_GATE = "true";
+        try {
+            const ids = rulesForEvent("PreToolUse").map((r) => r.id);
+            expect(ids).toContain("active-task-required");
+        }
+        finally {
+            delete process.env.OPENSQUID_SKIP_ACTIVE_TASK_GATE;
+        }
+    });
+});
+describe("rule when() predicates", () => {
+    const preCtx = (toolName, command) => ({
+        hookEvent: "PreToolUse",
+        toolName,
+        toolInput: command !== undefined ? { command } : {},
+    });
+    it("active-task-required fires only on log_phase / chat_send", () => {
+        const rule = RULES.find((r) => r.id === "active-task-required");
+        expect(rule.when(preCtx("mcp__opensquid__log_phase"))).toBe(true);
+        expect(rule.when(preCtx("mcp__opensquid__chat_send"))).toBe(true);
+        expect(rule.when(preCtx("Bash", "ls"))).toBe(false);
+        expect(rule.when(preCtx("Read"))).toBe(false);
+    });
+    it("never-amend.when fires on Bash tool", () => {
+        const rule = RULES.find((r) => r.id === "never-amend");
+        expect(rule.when(preCtx("Bash", "git commit --amend"))).toBe(true);
+        // Filter happens inside check via drift-patterns; when() just gates by tool name.
+        expect(rule.when(preCtx("Edit"))).toBe(false);
+    });
+    it("engine-vocab-leak fires only on git commit Bash commands", () => {
+        const rule = RULES.find((r) => r.id === "engine-vocab-leak");
+        expect(rule.when(preCtx("Bash", "git commit -m 'foo'"))).toBe(true);
+        expect(rule.when(preCtx("Bash", "git status"))).toBe(false);
+        expect(rule.when(preCtx("Bash"))).toBe(false);
+    });
+    it("heartbeat-recall-required fires on any mcp__opensquid__* tool", () => {
+        const rule = RULES.find((r) => r.id === "heartbeat-recall-required");
+        expect(rule.when(preCtx("mcp__opensquid__recall"))).toBe(true);
+        expect(rule.when(preCtx("mcp__opensquid__log_phase"))).toBe(true);
+        expect(rule.when(preCtx("mcp__opensquid__chat_send"))).toBe(true);
+        expect(rule.when(preCtx("mcp__plugin_telegram_telegram__reply"))).toBe(false);
+        expect(rule.when(preCtx("Bash"))).toBe(false);
+    });
+    it("telegram-redirect-report fires only on plugin:telegram reply", () => {
+        const rule = RULES.find((r) => r.id === "telegram-redirect-report");
+        expect(rule.when(preCtx("mcp__plugin_telegram_telegram__reply"))).toBe(true);
+        expect(rule.when(preCtx("mcp__opensquid__chat_send"))).toBe(false);
+    });
+    it("inline-report-missing-phases fires on Stop with assistantText", () => {
+        const rule = RULES.find((r) => r.id === "inline-report-missing-phases");
+        expect(rule.when({ hookEvent: "Stop", assistantText: "hi" })).toBe(true);
+        expect(rule.when({ hookEvent: "Stop" })).toBe(false);
+    });
+    it("multi-task-plan-injection fires on UPS with userPrompt", () => {
+        const rule = RULES.find((r) => r.id === "multi-task-plan-injection");
+        expect(rule.when({ hookEvent: "UserPromptSubmit", userPrompt: "166 then 168" })).toBe(true);
+        expect(rule.when({ hookEvent: "UserPromptSubmit" })).toBe(false);
+    });
+});
+describe("evaluateRules — short-circuit on PreToolUse block", () => {
+    let originalRules;
+    beforeEach(() => {
+        originalRules = [...RULES];
+    });
+    afterEach(() => {
+        RULES.length = 0;
+        RULES.push(...originalRules);
+    });
+    it("PreToolUse: stops at the first block verdict (most-restrictive-wins)", async () => {
+        // Replace catalog with two fakes that both apply; the first blocks.
+        RULES.length = 0;
+        let secondRan = false;
+        RULES.push({
+            id: "fake-block",
+            catches: "test",
+            hook: "PreToolUse",
+            when: () => true,
+            check: async () => ({ kind: "block", message: "first" }),
+            rationale: "test",
+        }, {
+            id: "fake-second",
+            catches: "test",
+            hook: "PreToolUse",
+            when: () => true,
+            check: async () => {
+                secondRan = true;
+                return { kind: "pass" };
+            },
+            rationale: "test",
+        });
+        const verdicts = await evaluateRules({ hookEvent: "PreToolUse", toolName: "Bash" });
+        expect(verdicts.length).toBe(1);
+        expect(verdicts[0]).toEqual({ kind: "block", message: "first" });
+        expect(secondRan).toBe(false);
+    });
+    it("Stop: accumulates all verdicts (no short-circuit on first surface)", async () => {
+        RULES.length = 0;
+        RULES.push({
+            id: "fake-surface-a",
+            catches: "test",
+            hook: "Stop",
+            when: () => true,
+            check: async () => ({ kind: "surface", message: "a" }),
+            rationale: "test",
+        }, {
+            id: "fake-surface-b",
+            catches: "test",
+            hook: "Stop",
+            when: () => true,
+            check: async () => ({ kind: "surface", message: "b" }),
+            rationale: "test",
+        });
+        const verdicts = await evaluateRules({ hookEvent: "Stop", assistantText: "test" });
+        expect(verdicts.length).toBe(2);
+        expect(verdicts.map((v) => v.kind === "surface" && v.message)).toEqual(["a", "b"]);
+    });
+    it("skips rules whose when() returns false", async () => {
+        RULES.length = 0;
+        RULES.push({
+            id: "fake-not-applicable",
+            catches: "test",
+            hook: "PreToolUse",
+            when: () => false,
+            check: async () => ({ kind: "block", message: "should not fire" }),
+            rationale: "test",
+        });
+        const verdicts = await evaluateRules({ hookEvent: "PreToolUse", toolName: "Bash" });
+        expect(verdicts).toEqual([]);
+    });
+});
+describe("Verdict shape — pass / block / warn / surface", () => {
+    it("PASS verdicts have no message field", () => {
+        const v = { kind: "pass" };
+        expect(v.kind).toBe("pass");
+        expect("message" in v).toBe(false);
+    });
+    it("non-pass verdicts carry a message", () => {
+        const block = { kind: "block", message: "x" };
+        const warn = { kind: "warn", message: "y" };
+        const surface = { kind: "surface", message: "z" };
+        expect(block.message).toBe("x");
+        expect(warn.message).toBe("y");
+        expect(surface.message).toBe("z");
+    });
+});
+describe("hook-event coverage", () => {
+    it("each of the 4 hook events has at least one rule", () => {
+        for (const event of ["PreToolUse", "Stop", "UserPromptSubmit", "SessionEnd"]) {
+            const rules = RULES.filter((r) => r.hook === event);
+            expect(rules.length, `expected at least one rule for ${event}`).toBeGreaterThan(0);
+        }
+    });
+});