openspec-playwright 0.3.41 → 0.3.42

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openspec-playwright",
-  "version": "0.3.41",
+  "version": "0.3.42",
   "description": "OpenSpec + Playwright E2E verification setup tool for Claude Code",
   "type": "module",
   "bin": {

package/templates/auth.setup.ts

@@ -2,32 +2,35 @@
 // This file authenticates once and saves the session state to .auth/user.json
 // All subsequent tests reuse this state — no repeated logins needed.
 //
-// Setup:
+// Setup (only if your app requires login):
 //   1. Set credentials: export E2E_USERNAME=xxx E2E_PASSWORD=yyy
-//   2. Run: npx playwright test --project=setup
-//      (if UI login: browser opens — log in manually once)
-//   3. Credentials are saved — tests auto-use the saved session
+//   2. Enable auth: export E2E_AUTH_REQUIRED=true
+//   3. Choose method: export E2E_AUTH_METHOD=api   # or ui
+//   4. Run: npx playwright test --project=setup
 //
-// To switch users, update credentials and re-run step 2.
-//
-// For multi-user testing, add more setup blocks with different storageState paths.
+// If E2E_AUTH_REQUIRED is not true, auth setup is skipped so public apps
+// can run seed/smoke tests without credentials.
 
 import { test as setup, expect } from '@playwright/test';
 import { existsSync } from 'fs';
 
+const authRequired = process.env.E2E_AUTH_REQUIRED === 'true';
+const authMethod = process.env.E2E_AUTH_METHOD || 'api';
+
 // ─── API Login (preferred) ───────────────────────────────────────────────────
 // If your app has a login API, configure it in tests/playwright/credentials.yaml:
 //   api: /api/auth/login
-// Then this block runs automatically.
 
 setup('authenticate via API', async ({ page }) => {
+  setup.skip(!authRequired || authMethod !== 'api', 'API auth not required/enabled');
+
   const baseUrl = process.env.BASE_URL || 'http://localhost:3000';
   const username = process.env.E2E_USERNAME;
   const password = process.env.E2E_PASSWORD;
 
   if (!username || !password) {
     throw new Error(
-      'E2E_USERNAME and E2E_PASSWORD environment variables are required.\n' +
+      'E2E_USERNAME and E2E_PASSWORD environment variables are required when E2E_AUTH_REQUIRED=true.\n' +
       'Set them with: export E2E_USERNAME=xxx E2E_PASSWORD=yyy'
     );
   }
@@ -51,13 +54,15 @@ setup('authenticate via API', async ({ page }) => {
 // If no login API, use UI login. Update selectors to match your login page.
 
 setup('authenticate via UI', async ({ page }) => {
+  setup.skip(!authRequired || authMethod !== 'ui', 'UI auth not required/enabled');
+
   const baseUrl = process.env.BASE_URL || 'http://localhost:3000';
   const username = process.env.E2E_USERNAME;
   const password = process.env.E2E_PASSWORD;
 
   if (!username || !password) {
     throw new Error(
-      'E2E_USERNAME and E2E_PASSWORD environment variables are required.\n' +
+      'E2E_USERNAME and E2E_PASSWORD environment variables are required when E2E_AUTH_REQUIRED=true.\n' +
       'Set them with: export E2E_USERNAME=xxx E2E_PASSWORD=yyy'
     );
   }

package/templates/playwright.config.ts

@@ -41,13 +41,13 @@ function findNpmRoot(projectRoot: string, maxDepth = 5): string {
   return search(projectRoot, 0) ?? projectRoot;
 }
 
-const projectRoot = findProjectRoot(__dirname);
+const projectRoot = findProjectRoot(process.cwd());
 const npmRoot = findNpmRoot(projectRoot);
 
 // ─── BASE_URL: prefer env, then seed.spec.ts, then default ───
 const seedSpec = join(projectRoot, 'tests', 'playwright', 'seed.spec.ts');
 let baseUrl = process.env.BASE_URL || 'http://localhost:3000';
-if (existsSync(seedSpec)) {
+if (!process.env.BASE_URL && existsSync(seedSpec)) {
   const content = readFileSync(seedSpec, 'utf-8');
   const m = content.match(/BASE_URL\s*=\s*process\.env\.BASE_URL\s*\|\|\s*['"]([^'"]+)['"]/);
   if (m) baseUrl = m[1];
@@ -59,13 +59,27 @@ const npmPkg = join(npmRoot, 'package.json');
 if (existsSync(npmPkg)) {
   const pkg = JSON.parse(readFileSync(npmPkg, 'utf-8'));
   const scripts = pkg.scripts ?? {};
-  devCmd = scripts.dev ?? scripts.start ?? scripts.serve ?? scripts.preview ?? devCmd;
+  const scriptName = scripts['dev:all']
+    ? 'dev:all'
+    : scripts.dev
+      ? 'dev'
+      : scripts.start
+        ? 'start'
+        : scripts.serve
+          ? 'serve'
+          : scripts.preview
+            ? 'preview'
+            : 'dev';
+  devCmd = `npm run ${scriptName}`;
   // Prefix with cd if npmRoot differs from projectRoot
   if (npmRoot !== projectRoot) {
     devCmd = `cd ${npmRoot} && ${devCmd}`;
   }
 }
 
+const authStatePath = join(projectRoot, 'playwright', '.auth', 'user.json');
+const storageState = existsSync(authStatePath) ? authStatePath : undefined;
+
 export default defineConfig({
   testDir: join(projectRoot, 'tests', 'playwright'),
   outputDir: join(projectRoot, 'tests', 'playwright', 'test-results'),
@@ -99,7 +113,7 @@ export default defineConfig({
       name: 'chromium',
       use: {
         ...devices['Desktop Chrome'],
-        storageState: './playwright/.auth/user.json',
+        storageState,
       },
       dependencies: ['setup'],
       // teardown: 'teardown', // Uncomment when teardown project is enabled

package/templates/seed.spec.ts

@@ -49,9 +49,12 @@ test.describe('Application smoke tests', () => {
       }
     };
     page.on('console', handler);
-    test.afterEach(() => page.off('console', handler));
-    await page.reload();
-    await page.waitForLoadState('networkidle');
+    try {
+      await page.reload();
+      await page.waitForLoadState('networkidle');
+    } finally {
+      page.off('console', handler);
+    }
     // Filter out known non-critical errors
     const criticalErrors = errors.filter(
       (e) => !e.includes('favicon') && !e.includes('404')