openk8s 1.0.1 → 1.0.2

package/src/app/__tests__/utils.test.ts

@@ -0,0 +1,358 @@
+import { describe, expect, test, spyOn } from "bun:test";
+import {
+  loadError,
+  statusLine,
+  deleteStatusMessage,
+  resourceDetailText,
+  activePortForwardRoute,
+  activePortForwardLabel,
+  portForwardId,
+  parseLocalPort,
+  statusTone,
+  kindDescription,
+  currentKindLabel,
+  resourcePreview,
+  normalizeFilter,
+  filterResources,
+  nextVisibleResourceName,
+  defaultNamespace,
+  selectedRef,
+  selectedForwardsForRef,
+} from "../utils";
+import type { ResourceListItem, ActivePortForward, ResourceDetail, NamespaceItem, ResourceKind } from "../../lib/k8s/types";
+
+// ── loadError ────────────────────────────────────────────────────────────────
+
+describe("loadError", () => {
+  test("formats Error instance", () => {
+    const result = loadError(new Error("Something failed"));
+    expect(result.message).toBe("Something failed");
+  });
+
+  test("includes error cause", () => {
+    const error = new Error("Failed to connect", { cause: "Connection refused" });
+    const result = loadError(error);
+    expect(result.message).toBe("Failed to connect");
+    expect(result.detail).toBe("Connection refused");
+  });
+
+  test("returns generic message for non-Error", () => {
+    expect(loadError("string error").message).toBe("Unexpected error");
+    expect(loadError(42).message).toBe("Unexpected error");
+    expect(loadError(null).message).toBe("Unexpected error");
+    expect(loadError(undefined).message).toBe("Unexpected error");
+  });
+});
+
+// ── statusLine ───────────────────────────────────────────────────────────────
+
+describe("statusLine", () => {
+  test("formats with namespace", () => {
+    expect(statusLine({ ref: { kind: "Pod", name: "nginx", namespace: "default" } })).toBe("Pod default/nginx");
+  });
+
+  test("formats without namespace", () => {
+    expect(statusLine({ ref: { kind: "Node", name: "node-1" } })).toBe("Node node-1");
+  });
+
+  test("returns fallback for undefined ref", () => {
+    expect(statusLine({})).toBe("No selection");
+  });
+});
+
+// ── deleteStatusMessage ──────────────────────────────────────────────────────
+
+describe("deleteStatusMessage", () => {
+  test("single target", () => {
+    expect(deleteStatusMessage([{ kind: "Pod", name: "web" }], "Deleting")).toBe("Deleting Pod web");
+  });
+
+  test("multiple targets", () => {
+    expect(deleteStatusMessage([{ kind: "Pod", name: "a" }, { kind: "Pod", name: "b" }], "Deleted")).toBe("Deleted 2 resources");
+  });
+
+  test("empty targets", () => {
+    expect(deleteStatusMessage([], "Deleting")).toBe("Deleting no selection");
+  });
+});
+
+// ── resourceDetailText ───────────────────────────────────────────────────────
+
+describe("resourceDetailText", () => {
+  test("plain string line", () => {
+    const result = resourceDetailText("kind: Pod", []);
+    expect(result).toEqual({ id: "kind: Pod", text: "kind: Pod", revealable: false });
+  });
+
+  test("non-revealable structured line", () => {
+    const line = { id: "l1", text: "KEY=value" };
+    const result = resourceDetailText(line, ["l1"]);
+    expect(result).toEqual({ id: "l1", text: "KEY=value", revealable: false });
+  });
+
+  test("revealable line when not revealed", () => {
+    const line = { id: "l1", text: "KEY=*****", revealedText: "KEY=secret", revealable: true };
+    const result = resourceDetailText(line, []);
+    expect(result.text).toContain("[click to reveal]");
+    expect(result.revealable).toBe(true);
+  });
+
+  test("revealable line when revealed", () => {
+    const line = { id: "l1", text: "KEY=*****", revealedText: "KEY=secret", revealable: true };
+    const result = resourceDetailText(line, ["l1"]);
+    expect(result.text).toBe("KEY=secret");
+    expect(result.revealable).toBe(true);
+  });
+});
+
+// ── Port forward helpers ────────────────────────────────────────────────────
+
+describe("activePortForwardRoute", () => {
+  test("formats route", () => {
+    const pf: ActivePortForward = {
+      id: "pf1", context: "prod", namespace: "default", namespaced: true,
+      ref: { kind: "Pod", name: "web" }, localPort: 8080, remotePort: 80, status: "ready",
+    };
+    expect(activePortForwardRoute(pf)).toBe("localhost:8080 -> 80");
+  });
+});
+
+describe("activePortForwardLabel", () => {
+  test("formats full label", () => {
+    const pf: ActivePortForward = {
+      id: "pf1", context: "prod", namespace: "default", namespaced: true,
+      ref: { kind: "Pod", name: "web", namespace: "default" }, localPort: 8080, remotePort: 80, status: "ready",
+    };
+    expect(activePortForwardLabel(pf)).toBe("Pod default/web  localhost:8080 -> 80");
+  });
+});
+
+describe("portForwardId", () => {
+  test("generates unique ID", () => {
+    expect(portForwardId({ context: "prod", namespace: "default", ref: { kind: "Pod", name: "web" }, localPort: 8080, remotePort: 80 }))
+      .toBe("prod:default:Pod:web:8080:80");
+  });
+});
+
+// ── parseLocalPort ──────────────────────────────────────────────────────────
+
+describe("parseLocalPort", () => {
+  test("parses valid port", () => expect(parseLocalPort("8080")).toBe(8080));
+  test("rejects non-numeric", () => expect(parseLocalPort("abc")).toBeUndefined());
+  test("rejects out of range", () => expect(parseLocalPort("99999")).toBeUndefined());
+  test("rejects zero", () => expect(parseLocalPort("0")).toBeUndefined());
+  test("rejects negative", () => expect(parseLocalPort("-1")).toBeUndefined());
+});
+
+// ── statusTone ──────────────────────────────────────────────────────────────
+
+describe("statusTone", () => {
+  test("danger keywords", () => {
+    expect(statusTone("Error")).toBe("danger");
+    expect(statusTone("CrashLoopBackOff")).toBe("danger");
+    expect(statusTone("NotReady")).toBe("danger");
+    expect(statusTone("Evicted")).toBe("danger");
+  });
+
+  test("warning keywords", () => {
+    expect(statusTone("Pending")).toBe("warning");
+    expect(statusTone("Warning")).toBe("warning");
+    expect(statusTone("MemoryPressure")).toBe("warning");
+    expect(statusTone("Terminating")).toBe("warning");
+  });
+
+  test("success keywords", () => {
+    expect(statusTone("Running")).toBe("success");
+    expect(statusTone("Ready")).toBe("success");
+    expect(statusTone("Succeeded")).toBe("success");
+  });
+
+  test("neutral fallback", () => {
+    expect(statusTone("Unknown")).toBe("info");
+    expect(statusTone("Scaling")).toBe("info");
+  });
+});
+
+// ── kindDescription ─────────────────────────────────────────────────────────
+
+describe("kindDescription", () => {
+  test("namespaced without short names", () => {
+    expect(kindDescription({ name: "pods", namespaced: true, shortNames: [] })).toBe("Namespaced");
+  });
+
+  test("cluster-scoped with short names", () => {
+    expect(kindDescription({ name: "nodes", namespaced: false, shortNames: ["no"] })).toBe("Cluster  no");
+  });
+});
+
+// ── currentKindLabel ─────────────────────────────────────────────────────────
+
+describe("currentKindLabel", () => {
+  test("finds kind by name", () => {
+    const kinds: ResourceKind[] = [{ name: "pods", namespaced: true, shortNames: ["po"] }];
+    expect(currentKindLabel({ resourceKinds: kinds, selectedKind: "pods" })).toBe("pods");
+  });
+
+  test("falls back to selected kind string", () => {
+    expect(currentKindLabel({ resourceKinds: [], selectedKind: "pods" })).toBe("pods");
+  });
+});
+
+// ── resourcePreview ──────────────────────────────────────────────────────────
+
+describe("resourcePreview", () => {
+  test("fallback when no resource", () => {
+    expect(resourcePreview({}))?.toEqual(["Select a resource to inspect it."]);
+  });
+
+  test("preview with resource", () => {
+    const resource: ResourceListItem = {
+      ref: { kind: "Pod", name: "web", namespace: "default" },
+      status: "Running", age: "5m", summary: "nginx",
+    };
+    const lines = resourcePreview({ resource });
+    expect(lines).toContain("kind: Pod");
+    expect(lines).toContain("name: web");
+    expect(lines).toContain("summary: nginx");
+  });
+});
+
+// ── normalizeFilter ─────────────────────────────────────────────────────────
+
+describe("normalizeFilter", () => {
+  test("trims and lowercases", () => {
+    expect(normalizeFilter("  Nginx  ")).toBe("nginx");
+  });
+});
+
+// ── filterResources ─────────────────────────────────────────────────────────
+
+describe("filterResources", () => {
+  const resources: ResourceListItem[] = [
+    { ref: { kind: "Pod", name: "nginx-abc" }, status: "Running", age: "5m", summary: "nginx web server" },
+    { ref: { kind: "Pod", name: "redis-cache" }, status: "Running", age: "2m", summary: "redis cache" },
+    { ref: { kind: "Pod", name: "mysql-db" }, status: "Pending", age: "1m", summary: "mysql database" },
+  ];
+
+  test("returns all resources when filter is empty", () => {
+    expect(filterResources({ resources, filter: "" })).toHaveLength(3);
+  });
+
+  test("filters by name", () => {
+    expect(filterResources({ resources, filter: "nginx" })).toHaveLength(1);
+  });
+
+  test("filters by status", () => {
+    expect(filterResources({ resources, filter: "Pending" })).toHaveLength(1);
+  });
+
+  test("filters by summary", () => {
+    expect(filterResources({ resources, filter: "cache" })).toHaveLength(1);
+  });
+
+  test("is case-insensitive", () => {
+    expect(filterResources({ resources, filter: "NGINX" })).toHaveLength(1);
+  });
+
+  test("returns empty for no match", () => {
+    expect(filterResources({ resources, filter: "zzzzz" })).toHaveLength(0);
+  });
+});
+
+// ── nextVisibleResourceName ─────────────────────────────────────────────────
+
+describe("nextVisibleResourceName", () => {
+  const resources: ResourceListItem[] = [
+    { ref: { kind: "Pod", name: "a" }, status: "Running", age: "1m", summary: "" },
+    { ref: { kind: "Pod", name: "b" }, status: "Running", age: "2m", summary: "" },
+  ];
+
+  test("returns undefined for empty list", () => {
+    expect(nextVisibleResourceName({ resources: [], selectedName: "a" })).toBeUndefined();
+  });
+
+  test("returns selected name when it exists", () => {
+    expect(nextVisibleResourceName({ resources, selectedName: "a" })).toBe("a");
+  });
+
+  test("returns first when selected name not present", () => {
+    expect(nextVisibleResourceName({ resources, selectedName: "c" })).toBe("a");
+  });
+
+  test("returns first when no selection", () => {
+    expect(nextVisibleResourceName({ resources, selectedName: undefined })).toBe("a");
+  });
+});
+
+// ── defaultNamespace ─────────────────────────────────────────────────────────
+
+describe("defaultNamespace", () => {
+  const namespaces: NamespaceItem[] = [
+    { name: "default" },
+    { name: "kube-system" },
+  ];
+
+  test("keeps current namespace if it exists", () => {
+    expect(defaultNamespace({ namespaces, currentNamespace: "kube-system" })).toBe("kube-system");
+  });
+
+  test("returns first namespace when current not found", () => {
+    expect(defaultNamespace({ namespaces, currentNamespace: "missing" })).toBe("default");
+  });
+
+  test("returns 'default' when no namespaces", () => {
+    expect(defaultNamespace({ namespaces: [], currentNamespace: "kube-system" })).toBe("default");
+  });
+});
+
+// ── selectedRef ─────────────────────────────────────────────────────────────
+
+describe("selectedRef", () => {
+  const detail: ResourceDetail = {
+    ref: { kind: "Pod", name: "web", namespace: "default" },
+    summaryLines: [], summarySections: [], yaml: "",
+  };
+
+  test("returns detail ref when it matches resource", () => {
+    const resource: ResourceListItem = { ref: { kind: "Pod", name: "web", namespace: "default" }, status: "Running", age: "1m", summary: "" };
+    expect(selectedRef({ detail, resource })).toBe(detail.ref);
+  });
+
+  test("returns resource ref when detail doesn't match", () => {
+    const resource: ResourceListItem = { ref: { kind: "Pod", name: "other" }, status: "Running", age: "1m", summary: "" };
+    expect(selectedRef({ detail, resource })).toBe(resource.ref);
+  });
+
+  test("returns resource ref when no detail", () => {
+    const resource: ResourceListItem = { ref: { kind: "Pod", name: "web" }, status: "Running", age: "1m", summary: "" };
+    expect(selectedRef({ detail: undefined, resource })).toBe(resource.ref);
+  });
+
+  test("returns undefined when neither", () => {
+    expect(selectedRef({})).toBeUndefined();
+  });
+});
+
+// ── selectedForwardsForRef ──────────────────────────────────────────────────
+
+describe("selectedForwardsForRef", () => {
+  const ref = { kind: "Pod", name: "web", namespace: "default" };
+  const forwards: ActivePortForward[] = [
+    { id: "1", context: "p", namespace: "default", namespaced: true, ref, localPort: 8080, remotePort: 80, status: "ready" },
+    { id: "2", context: "p", namespace: "default", namespaced: true, ref: { kind: "Pod", name: "db" }, localPort: 3306, remotePort: 3306, status: "ready" },
+  ];
+
+  test("filters forwards matching the ref", () => {
+    const result = selectedForwardsForRef({ forwards, ref });
+    expect(result).toHaveLength(1);
+    expect(result[0]?.id).toBe("1");
+  });
+
+  test("returns empty for undefined ref", () => {
+    expect(selectedForwardsForRef({ forwards, ref: undefined })).toEqual([]);
+  });
+
+  test("returns empty when no forwards match", () => {
+    expect(selectedForwardsForRef({ forwards, ref: { kind: "Node", name: "n1" } })).toEqual([]);
+  });
+});

package/src/app/app-actions.ts

@@ -0,0 +1,262 @@
+import type {
+  ActivePortForward,
+  AppError,
+  AppState,
+  EventItem,
+  LoadStatus,
+  LogOptions,
+  Notification,
+  OverlayId,
+  PaneId,
+  ResourceDetail,
+  ResourceKind,
+  ResourceListItem,
+} from "../lib/k8s/types";
+
+export interface SetActivePaneAction {
+  type: "setActivePane";
+  pane: PaneId;
+}
+
+export interface CyclePaneAction {
+  type: "cyclePane";
+  direction: 1 | -1;
+}
+
+export interface SetOverlayAction {
+  type: "setOverlay";
+  overlay?: OverlayId | undefined;
+}
+
+export interface SetInspectorTabAction {
+  type: "setInspectorTab";
+  tab: AppState["inspectorTab"];
+}
+
+export interface SetKubectlAvailableAction {
+  type: "setKubectlAvailable";
+  available: boolean;
+}
+
+export interface SetStatusMessageAction {
+  type: "setStatusMessage";
+  message: string;
+}
+
+export interface SetErrorAction {
+  type: "setError";
+  error?: AppError | undefined;
+}
+
+export interface SetContextsStatusAction {
+  type: "setContextsStatus";
+  status: LoadStatus;
+}
+
+export interface SetContextsAction {
+  type: "setContexts";
+  contexts: AppState["contexts"];
+  activeContext?: string | undefined;
+}
+
+export interface SetActiveContextAction {
+  type: "setActiveContext";
+  activeContext?: string | undefined;
+}
+
+export interface SetNamespacesStatusAction {
+  type: "setNamespacesStatus";
+  status: LoadStatus;
+}
+
+export interface SetNamespacesAction {
+  type: "setNamespaces";
+  namespaces: AppState["namespaces"];
+  activeNamespace: string;
+}
+
+export interface SetActiveNamespaceAction {
+  type: "setActiveNamespace";
+  namespace: string;
+}
+
+export interface SetResourceKindsStatusAction {
+  type: "setResourceKindsStatus";
+  status: LoadStatus;
+}
+
+export interface SetResourceKindsAction {
+  type: "setResourceKinds";
+  resourceKinds: ResourceKind[];
+  selectedKind: string;
+}
+
+export interface SetSelectedKindAction {
+  type: "setSelectedKind";
+  kind: string;
+}
+
+export interface SetResourcesStatusAction {
+  type: "setResourcesStatus";
+  status: LoadStatus;
+}
+
+export interface SetResourcesAction {
+  type: "setResources";
+  resources: ResourceListItem[];
+  selectedResourceName?: string | undefined;
+}
+
+export interface ToggleSelectedResourceAction {
+  type: "toggleSelectedResource";
+  name: string;
+}
+
+export interface ClearSelectedResourcesAction {
+  type: "clearSelectedResources";
+}
+
+export interface SetResourceFilterAction {
+  type: "setResourceFilter";
+  value: string;
+}
+
+export interface SetSelectedResourceNameAction {
+  type: "setSelectedResourceName";
+  name?: string | undefined;
+}
+
+export interface SetSelectedResourceDetailStatusAction {
+  type: "setSelectedResourceDetailStatus";
+  status: LoadStatus;
+}
+
+export interface SetSelectedResourceDetailAction {
+  type: "setSelectedResourceDetail";
+  detail?: ResourceDetail | undefined;
+}
+
+export interface SetEventsStatusAction {
+  type: "setEventsStatus";
+  status: LoadStatus;
+}
+
+export interface SetEventsAction {
+  type: "setEvents";
+  events: EventItem[];
+}
+
+export interface ToggleRevealDetailLineAction {
+  type: "toggleRevealDetailLine";
+  id: string;
+}
+
+export interface AddActivePortForwardAction {
+  type: "addActivePortForward";
+  forward: ActivePortForward;
+}
+
+export interface UpdateActivePortForwardAction {
+  type: "updateActivePortForward";
+  id: string;
+  patch: Partial<ActivePortForward>;
+}
+
+export interface RemoveActivePortForwardAction {
+  type: "removeActivePortForward";
+  id: string;
+}
+
+export interface ClearTransientViewsAction {
+  type: "clearTransientViews";
+}
+
+export interface SetLogsDataAction {
+  type: "setLogsData";
+  logsTarget?: string | undefined;
+  logsText: string;
+  logsStatus: LoadStatus;
+}
+
+export interface SetLogsContainerAction {
+  type: "setLogsContainer";
+  container?: string | undefined;
+}
+
+export interface SetLogsOptionsAction {
+  type: "setLogsOptions";
+  options: LogOptions;
+}
+
+export interface PushNotificationAction {
+  type: "pushNotification";
+  notification: Notification;
+}
+
+export interface DismissNotificationAction {
+  type: "dismissNotification";
+  id: string;
+}
+
+export interface SetRevealedSecretValueAction {
+  type: "setRevealedSecretValue";
+  id: string;
+  value: string;
+}
+
+export interface SetPodMetricsAction {
+  type: "setPodMetrics";
+  metrics: AppState["podMetrics"];
+}
+
+export interface SetNodeMetricsAction {
+  type: "setNodeMetrics";
+  metrics: AppState["nodeMetrics"];
+}
+
+export interface SetHelmRollbackRevisionAction {
+  type: "setHelmRollbackRevision";
+  value: string;
+}
+
+export type AppAction =
+  | SetActivePaneAction
+  | CyclePaneAction
+  | SetOverlayAction
+  | SetInspectorTabAction
+  | SetKubectlAvailableAction
+  | SetStatusMessageAction
+  | SetErrorAction
+  | SetContextsStatusAction
+  | SetContextsAction
+  | SetActiveContextAction
+  | SetNamespacesStatusAction
+  | SetNamespacesAction
+  | SetActiveNamespaceAction
+  | SetResourceKindsStatusAction
+  | SetResourceKindsAction
+  | SetSelectedKindAction
+  | SetResourcesStatusAction
+  | SetResourcesAction
+  | ToggleSelectedResourceAction
+  | ClearSelectedResourcesAction
+  | SetResourceFilterAction
+  | SetSelectedResourceNameAction
+  | SetSelectedResourceDetailStatusAction
+  | SetSelectedResourceDetailAction
+  | SetEventsStatusAction
+  | SetEventsAction
+  | ToggleRevealDetailLineAction
+  | AddActivePortForwardAction
+  | UpdateActivePortForwardAction
+  | RemoveActivePortForwardAction
+  | ClearTransientViewsAction
+  | SetLogsDataAction
+  | SetLogsContainerAction
+  | SetLogsOptionsAction
+  | PushNotificationAction
+  | DismissNotificationAction
+  | SetRevealedSecretValueAction
+  | SetPodMetricsAction
+  | SetNodeMetricsAction
+  | SetHelmRollbackRevisionAction;