openid-client 2.4.1 → 2.4.5

package/CHANGELOG.md

@@ -2,6 +2,46 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+<a name="2.4.5"></a>
+## [2.4.5](https://github.com/panva/node-openid-client/compare/v2.4.4...v2.4.5) (2018-11-05)
+
+
+### Bug Fixes
+
+* upgrade min node-jose version to fix its performance in node ([e682dfc](https://github.com/panva/node-openid-client/commit/e682dfc))
+
+
+
+<a name="2.4.4"></a>
+## [2.4.4](https://github.com/panva/node-openid-client/compare/v2.4.3...v2.4.4) (2018-10-18)
+
+
+### Bug Fixes
+
+* strategy code_verifier length, removed uuid dependency ([60d0cb8...ea4a8fd](https://github.com/panva/node-openid-client/compare/60d0cb8...ea4a8fd)), closes [#131](https://github.com/panva/node-openid-client/issues/131)
+
+
+
+<a name="2.4.3"></a>
+## [2.4.3](https://github.com/panva/node-openid-client/compare/v2.4.2...v2.4.3) (2018-10-10)
+
+
+### Bug Fixes
+
+* assign Discovery 1.0 defaults when discovering with .well-known ([74b593e](https://github.com/panva/node-openid-client/commit/74b593e))
+
+
+
+<a name="2.4.2"></a>
+## [2.4.2](https://github.com/panva/node-openid-client/compare/v2.4.1...v2.4.2) (2018-09-27)
+
+
+### Bug Fixes
+
+* non-string error responses are not treated as OpenIdConnectError ([782d464](https://github.com/panva/node-openid-client/commit/782d464)), closes [#125](https://github.com/panva/node-openid-client/issues/125)
+
+
+
 <a name="2.4.1"></a>
 ## [2.4.1](https://github.com/panva/node-openid-client/compare/v2.4.0...v2.4.1) (2018-09-16)
 

package/README.md

@@ -57,7 +57,7 @@ versions, if you utilize these consider using the tilde ~ operator in your packa
 breaking changes may be introduced as part of these specification updates.
 
 ## Certification
-[<img width="184" height="96" align="right" src="https://cdn.rawgit.com/panva/node-openid-client/38cf016b/OpenID_Certified.png" alt="OpenID Certification">][openid-certified-link]  
+[<img width="184" height="96" align="right" src="https://cdn.jsdelivr.net/gh/panva/node-openid-client@38cf016b0837e6d4116de3780b28d222d5780bc9/OpenID_Certified.png" alt="OpenID Certification">][openid-certified-link]  
 Filip Skokan has [certified][openid-certified-link] that [openid-client][npm-url]
 conforms to the RP Basic, RP Implicit, RP Hybrid, RP Config, RP Dynamic and RP Form Post profiles
 of the OpenID Connect™ protocol.
@@ -69,6 +69,12 @@ of the OpenID Connect™ protocol.
 
 [<img width="65" height="65" align="left" src="https://avatars.githubusercontent.com/u/2824157?s=75&v=4" alt="auth0-logo">][sponsor-auth0] If you want to quickly add OpenID Connect authentication to Node.js apps, feel free to check out Auth0's Node.js SDK and free plan at [auth0.com/overview][sponsor-auth0].<br><br>
 
+<h2>Support</h2>
+
+[<img src="https://c5.patreon.com/external/logo/become_a_patron_button@2x.png" width="160" align="right">][support-patreon]
+If you or your business use openid-client, please consider becoming a [Patron][support-patreon] so I can continue maintaining it and adding new features carefree. You may also donate one-time via [PayPal][support-paypal].
+[<img src="https://cdn.jsdelivr.net/gh/gregoiresgt/payment-icons@183140a5ff8f39b5a19d59ebeb2c77f03c3a24d3/Assets/Payment/PayPal/Paypal@2x.png" width="100" align="right">][support-paypal]
+
 
 ## Get started
 On the off-chance you want to manage multiple clients for multiple issuers you need to first get
@@ -558,7 +564,8 @@ Issuer.useRequest();
 [request-library]: https://github.com/request/request
 [signed-userinfo]: https://openid.net/specs/openid-connect-core-1_0.html#UserInfoResponse
 [openid-certified-link]: https://openid.net/certification/
-[openid-certified-logo]: https://cdn.rawgit.com/panva/node-openid-client/master/OpenID_Certified.png
 [passport-url]: http://passportjs.org
 [npm-url]: https://www.npmjs.com/package/openid-client
 [sponsor-auth0]: https://auth0.com/overview?utm_source=GHsponsor&utm_medium=GHsponsor&utm_campaign=openid-client&utm_content=auth
+[support-patreon]: https://www.patreon.com/panva
+[support-paypal]: https://www.paypal.me/panva

package/lib/client.js

@@ -6,7 +6,6 @@ const querystring = require('querystring');
 const url = require('url');
 
 const jose = require('node-jose');
-const uuid = require('uuid/v4');
 const base64url = require('base64url');
 const _ = require('lodash');
 const tokenHash = require('oidc-token-hash');
@@ -19,6 +18,7 @@ const now = require('./util/unix_timestamp');
 const { CALLBACK_PROPERTIES, CLIENT_DEFAULTS, JWT_CONTENT } = require('./helpers/consts');
 const issuerRegistry = require('./issuer_registry');
 const forEach = require('./util/for_each');
+const random = require('./util/random');
 
 const errorHandler = errorHandlerFactory();
 const bearerErrorHandler = errorHandlerFactory({ bearerEndpoint: true });
@@ -951,7 +951,7 @@ class Client {
         return this.createSign(endpoint).then(sign => sign.update(JSON.stringify({
           iat: timestamp,
           exp: timestamp + 60,
-          jti: uuid(),
+          jti: random(),
           iss: this.client_id,
           sub: this.client_id,
           aud: this.issuer[`${endpoint}_endpoint`],

package/lib/helpers/is_standard_body_error.js

@@ -2,7 +2,7 @@ module.exports = function isStandardBodyError(error) {
   if (error instanceof this.httpClient.HTTPError) {
     try {
       error.response.body = JSON.parse(error.response.body);
-      return !!error.response.body.error;
+      return typeof error.response.body.error === 'string' && error.response.body.error.length;
     } catch (err) {}
   }
 

package/lib/issuer.js

@@ -196,7 +196,7 @@ class Issuer {
     if (parsed.pathname.includes('/.well-known/')) {
       return this.httpClient.get(uri, this.httpOptions())
         .then(expectResponseWithBody(200))
-        .then(response => new this(JSON.parse(response.body)))
+        .then(response => new this(Object.assign({}, ISSUER_DEFAULTS, JSON.parse(response.body))))
         .catch(errorHandler.bind(this));
     }
 

package/lib/passport_strategy.js

@@ -6,11 +6,11 @@ const url = require('url');
 const assert = require('assert');
 
 const base64url = require('base64url');
-const uuid = require('uuid/v4');
 const _ = require('lodash');
 
 const OpenIdConnectError = require('./open_id_connect_error');
 const Client = require('./client');
+const random = require('./util/random');
 
 function verified(err, user, info = {}) {
   if (err) {
@@ -81,17 +81,17 @@ OpenIDConnectStrategy.prototype.authenticate = function authenticate(req, option
     if (_.isEmpty(reqParams)) {
       // provide options object with extra authentication parameters
       const params = _.defaults({}, options, this._params, {
-        state: uuid(),
+        state: random(),
       });
 
       if (!params.nonce && params.response_type.includes('id_token')) {
-        params.nonce = uuid();
+        params.nonce = random();
       }
 
       req.session[sessionKey] = _.pick(params, 'nonce', 'state', 'max_age', 'response_type');
 
       if (this._usePKCE) {
-        const verifier = uuid();
+        const verifier = random();
         req.session[sessionKey].code_verifier = verifier;
 
         switch (this._usePKCE) { // eslint-disable-line default-case

package/lib/util/random.js

@@ -0,0 +1,5 @@
+const { randomBytes } = require('crypto');
+
+const base64url = require('base64url');
+
+module.exports = (bytes = 32) => base64url(randomBytes(bytes));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openid-client",
-  "version": "2.4.1",
+  "version": "2.4.5",
   "description": "OpenID Connect Relying Party (RP, Client) implementation for Node.js servers, supports passportjs",
   "keywords": [
     "auth",
@@ -25,15 +25,14 @@
     "strategy"
   ],
   "homepage": "https://github.com/panva/node-openid-client",
+  "repository": "panva/node-openid-client",
   "license": "MIT",
   "author": "Filip Skokan <panva.ip@gmail.com>",
   "files": [
     "lib"
   ],
   "main": "lib/index.js",
-  "repository": "panva/node-openid-client",
   "scripts": {
-    "commitmsg": "commitlint -E GIT_PARAMS",
     "coverage": "nyc mocha",
     "lint": "eslint lib test",
     "lint-fix": "eslint lib test --fix",
@@ -41,33 +40,32 @@
   },
   "dependencies": {
     "base64url": "^3.0.0",
-    "got": "^8.3.1",
-    "lodash": "^4.17.10",
+    "got": "^8.3.2",
+    "lodash": "^4.17.11",
     "lru-cache": "^4.1.3",
-    "node-jose": "^1.0.0",
+    "node-jose": "^1.1.0",
     "oidc-token-hash": "^3.0.1",
-    "p-any": "^1.1.0",
-    "uuid": "^3.2.1"
+    "p-any": "^1.1.0"
   },
   "devDependencies": {
-    "@commitlint/cli": "^7.0.0",
-    "@commitlint/config-conventional": "^7.0.1",
-    "chai": "^4.1.2",
-    "eslint": "^5.3.0",
+    "@commitlint/cli": "^7.1.2",
+    "@commitlint/config-conventional": "^7.1.2",
+    "chai": "^4.2.0",
+    "eslint": "^5.6.0",
     "eslint-config-airbnb-base": "^13.1.0",
     "eslint-plugin-import": "^2.14.0",
-    "husky": "^0.14.3",
-    "koa": "^2.5.1",
-    "koa-body": "^4.0.0",
-    "koa-ejs": "^4.1.1",
+    "husky": "^1.0.0",
+    "koa": "^2.5.3",
+    "koa-body": "^4.0.4",
+    "koa-ejs": "^4.1.2",
     "koa-router": "^7.4.0",
-    "koa-session": "^5.8.1",
+    "koa-session": "^5.9.0",
     "mocha": "^5.2.0",
     "nock": "^10.0.0",
     "nyc": "^13.0.1",
     "readable-mock-req": "^0.2.2",
-    "request": "^2.87.0",
-    "sinon": "^6.0.0",
+    "request": "^2.88.0",
+    "sinon": "^7.0.0",
     "timekeeper": "^2.1.2"
   },
   "engines": {
@@ -78,6 +76,11 @@
       "@commitlint/config-conventional"
     ]
   },
+  "husky": {
+    "hooks": {
+      "commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
+    }
+  },
   "nyc": {
     "reporter": [
       "lcov",