opendevbrowser 0.0.19 → 0.0.21

package/skills/opendevbrowser-design-agent/artifacts/design-workflows.md

@@ -77,20 +77,29 @@ Use when the work should flow through the OpenDevBrowser design canvas.
 
 1. Open a canvas session.
 2. Read the handshake and document context.
-3. Fill the full design contract.
-4. Extract the `generationPlan`.
-5. Send `canvas.plan.set`.
-6. Mutate with `canvas.document.patch`.
-7. Poll feedback and refresh preview until the contract and runtime match.
+3. Inspect `planStatus`, `preflightState`, `generationPlanRequirements.allowedValues`, `generationPlanIssues`, and `guidance.recommendedNextCommands` before moving on.
+4. Treat `preflightState="handshake_read"` as the normal first-step checkpoint; if the handshake is already reporting `plan_invalid`, repair the plan instead of mutating.
+5. Fill the full design contract.
+6. Extract the `generationPlan`.
+7. Send `canvas.plan.set`.
+8. If the response is accepted, read `guidance.recommendedNextCommands` again and mutate with `canvas.document.patch`.
+9. If the response fails with `generation_plan_invalid`, inspect `details.missingFields`, `details.issues`, and `generationPlanIssues`, then optionally re-read with `canvas.plan.get` or `canvas.capabilities.get`.
+10. Render preview, poll feedback, and save or export until the contract and runtime match.
 
 Canonical command order:
 
 ```bash
 npx opendevbrowser canvas --command canvas.session.open --params '{"requestId":"req_open_01","browserSessionId":"<browser-session-id>","documentId":null,"repoPath":null,"mode":"dual-track"}'
+# Inspect planStatus, preflightState, generationPlanRequirements.allowedValues, generationPlanIssues, and guidance.recommendedNextCommands before continuing.
 npx opendevbrowser canvas --command canvas.plan.set --params-file ./tmp/canvas-plan.json
+# If canvas.plan.set succeeds with planStatus=accepted or preflightState=plan_accepted, follow the returned guidance into canvas.document.patch.
+# Optional diagnostics after generation_plan_invalid:
+# npx opendevbrowser canvas --command canvas.plan.get --params '{"requestId":"req_plan_get_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","documentId":"<document-id>"}'
+# or re-read with canvas.capabilities.get to inspect generationPlanIssues before resubmitting canvas.plan.set.
 npx opendevbrowser canvas --command canvas.document.patch --params-file ./tmp/canvas-patch.json
-npx opendevbrowser canvas --command canvas.feedback.poll --params '{"requestId":"req_feedback_01","canvasSessionId":"<canvas-session-id>","documentId":"<document-id>","targetId":"<target-id>","afterCursor":null}'
 npx opendevbrowser canvas --command canvas.preview.render --params '{"requestId":"req_preview_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","targetId":"<target-id>","projection":"canvas_html"}'
+npx opendevbrowser canvas --command canvas.feedback.poll --params '{"requestId":"req_feedback_01","canvasSessionId":"<canvas-session-id>","documentId":"<document-id>","targetId":"<target-id>","afterCursor":null}'
+npx opendevbrowser canvas --command canvas.document.save --params '{"requestId":"req_save_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","documentId":"<document-id>","repoPath":null}'
 ```
 
 ## Workflow D — Real-Surface Validation

package/skills/opendevbrowser-design-agent/assets/templates/canvas-generation-plan.design.v1.json

@@ -9,29 +9,28 @@
       "summary": "Clarify hierarchy, trust, and action flow"
     },
     "visualDirection": {
-      "profile": "product-led-clarity",
-      "styleAxes": {
-        "contrast": "high",
-        "density": "airy"
-      }
+      "profile": "product-story",
+      "themeStrategy": "single-theme"
     },
     "layoutStrategy": {
-      "approach": "hero-led-grid"
+      "approach": "hero-led-grid",
+      "navigationModel": "global-header"
     },
     "contentStrategy": {
       "source": "real-content-first"
     },
     "componentStrategy": {
       "mode": "reuse-first",
-      "approvedLibraries": [
-        "shadcn"
+      "interactionStates": [
+        "default",
+        "hover",
+        "focus",
+        "disabled"
       ]
     },
     "motionPosture": {
       "level": "subtle",
-      "allow3D": false,
-      "allowParallax": false,
-      "allowCustomSmoothScroll": false
+      "reducedMotion": "respect-user-preference"
     },
     "responsivePosture": {
       "primaryViewport": "desktop",
@@ -43,16 +42,18 @@
     },
     "accessibilityPosture": {
       "target": "WCAG_2_2_AA",
-      "reducedMotion": "required",
-      "keyboardParity": true
+      "keyboardNavigation": "full"
     },
     "validationTargets": {
       "blockOn": [
-        "contrast-failure"
-      ],
-      "warnOn": [
+        "contrast-failure",
         "responsive-mismatch"
-      ]
+      ],
+      "requiredThemes": [
+        "light"
+      ],
+      "browserValidation": "required",
+      "maxInteractionLatencyMs": 160
     }
   }
 }

package/skills/opendevbrowser-design-agent/scripts/design-workflow.sh

@@ -97,10 +97,21 @@ EOF
 cat skills/opendevbrowser-design-agent/assets/templates/design-contract.v1.json
 cat skills/opendevbrowser-design-agent/assets/templates/canvas-generation-plan.design.v1.json
 cat skills/opendevbrowser-design-agent/artifacts/design-contract-playbook.md
+cat skills/opendevbrowser-best-practices/artifacts/canvas-governance-playbook.md
+cat skills/opendevbrowser-best-practices/assets/templates/canvas-handshake-example.json
 ./skills/opendevbrowser-design-agent/scripts/extract-canvas-plan.sh ./tmp/design-contract.json > ./tmp/canvas-plan.json
 $CLI_PREFIX canvas --command canvas.session.open --params '{"requestId":"req_open_01","browserSessionId":"<browser-session-id>","documentId":null,"repoPath":null,"mode":"dual-track"}'
+# Inspect planStatus, preflightState, generationPlanRequirements.allowedValues, generationPlanIssues, and guidance.recommendedNextCommands before continuing.
+# Treat preflightState=handshake_read as the normal first-step checkpoint before canvas.plan.set.
 $CLI_PREFIX canvas --command canvas.plan.set --params-file ./tmp/canvas-plan.json
+# If canvas.plan.set succeeds with planStatus=accepted or preflightState=plan_accepted, follow the returned guidance into canvas.document.patch.
+# Optional diagnostics after generation_plan_invalid:
+# $CLI_PREFIX canvas --command canvas.plan.get --params '{"requestId":"req_plan_get_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","documentId":"<document-id>"}'
+# or re-read with canvas.capabilities.get to inspect generationPlanIssues before resubmitting canvas.plan.set.
+$CLI_PREFIX canvas --command canvas.document.patch --params-file ./tmp/canvas-patch.json
+$CLI_PREFIX canvas --command canvas.preview.render --params '{"requestId":"req_preview_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","targetId":"<target-id>","prototypeId":"<prototype-id>"}'
 $CLI_PREFIX canvas --command canvas.feedback.poll --params '{"requestId":"req_feedback_01","canvasSessionId":"<canvas-session-id>","documentId":"<document-id>","targetId":"<target-id>","afterCursor":null}'
+$CLI_PREFIX canvas --command canvas.document.save --params '{"requestId":"req_save_01","canvasSessionId":"<canvas-session-id>","leaseId":"<lease-id>","documentId":"<document-id>","repoPath":null}'
 EOF
     ;;
   real-surface-validation)

package/skills/opendevbrowser-design-agent/scripts/validate-skill-assets.sh

@@ -88,6 +88,16 @@ const skillDocMarkers = [
   "assets/templates/reference-pattern-board.v1.json",
   "assets/templates/design-release-gate.v1.json",
   "scripts/extract-canvas-plan.sh",
+  "canvas.session.open",
+  "canvas.plan.get",
+  "generationPlanIssues",
+  "canvas.document.patch",
+  "canvas.preview.render",
+  "canvas.document.save",
+  "handshake_read",
+  "plan_invalid",
+  "plan_accepted",
+  "recommendedNextCommands",
   "canvas.plan.set",
   "canvas.history.undo",
   "canvas.history.redo",
@@ -105,6 +115,38 @@ const skillDocMarkers = [
   "docs.lovable.dev/prompting/prompting-best-practices"
 ];
 
+const designWorkflowMarkers = [
+  "canvas.session.open",
+  "canvas.plan.set",
+  "canvas.plan.get",
+  "generationPlanIssues",
+  "canvas.document.patch",
+  "canvas.preview.render",
+  "canvas.feedback.poll",
+  "canvas.document.save",
+  "handshake_read",
+  "plan_invalid",
+  "plan_accepted",
+  "recommendedNextCommands"
+];
+
+const workflowOutputMarkers = {
+  "canvas-contract": [
+    "canvas.session.open",
+    "canvas.plan.set",
+    "canvas.plan.get",
+    "generationPlanIssues",
+    "canvas.document.patch",
+    "canvas.preview.render",
+    "canvas.feedback.poll",
+    "canvas.document.save",
+    "handshake_read",
+    "plan_invalid",
+    "plan_accepted",
+    "recommendedNextCommands"
+  ]
+};
+
 const patternMarkers = [
   "Anthropic",
   "Vercel v0",
@@ -154,6 +196,13 @@ for (const marker of patternMarkers) {
   }
 }
 
+const designWorkflowDoc = fs.readFileSync(fullPath("artifacts/design-workflows.md"), "utf8");
+for (const marker of designWorkflowMarkers) {
+  if (!designWorkflowDoc.includes(marker)) {
+    failures.push(`design-workflows missing marker: ${marker}`);
+  }
+}
+
 const extractScript = fullPath("scripts/extract-canvas-plan.sh");
 const contractTemplate = fullPath("assets/templates/design-contract.v1.json");
 const extractResult = spawnSync(extractScript, [contractTemplate], { encoding: "utf8" });
@@ -210,6 +259,14 @@ for (const workflow of [
   if ((result.stdout ?? "").trim().length === 0) {
     failures.push(`design-workflow.sh produced empty output for mode ${workflow}`);
   }
+  const requiredOutputMarkers = workflowOutputMarkers[workflow];
+  if (requiredOutputMarkers) {
+    for (const marker of requiredOutputMarkers) {
+      if (!(result.stdout ?? "").includes(marker)) {
+        failures.push(`design-workflow.sh output for ${workflow} missing marker: ${marker}`);
+      }
+    }
+  }
 }
 
 if (failures.length > 0) {

package/skills/opendevbrowser-product-presentation-asset/SKILL.md

@@ -67,8 +67,8 @@ The `render-video-brief.sh` helper adds:
 1. Pick product URL or product name.
 2. Run collection workflow and confirm output pack path.
 3. Review generated manifest/copy/features for accuracy and check whether the pack is visual-ready or metadata-first.
-4. Run `render-video-brief.sh` to generate production instructions and visual sourcing notes.
-	Canonical helper path: `scripts/render-video-brief.sh`.
+4. Run `./skills/opendevbrowser-product-presentation-asset/scripts/render-video-brief.sh` to generate production instructions and visual sourcing notes.
+	Canonical helper path: `./skills/opendevbrowser-product-presentation-asset/scripts/render-video-brief.sh`.
 5. If no visuals were captured, source or capture visuals before handing the brief to the editor/creator pipeline.
 
 ## Parallel Multitab Alignment