opendevbrowser 0.0.16 → 0.0.17

package/skills/opendevbrowser-best-practices/scripts/run-robustness-audit.sh

@@ -14,6 +14,7 @@ Usage:
 
 Examples:
   ./skills/opendevbrowser-best-practices/scripts/run-robustness-audit.sh
+  ./skills/opendevbrowser-best-practices/scripts/run-robustness-audit.sh canvas-pack
   ./skills/opendevbrowser-best-practices/scripts/run-robustness-audit.sh opendevbrowser-shopping
 HELP
 }
@@ -27,19 +28,99 @@ skills=(
   "opendevbrowser-research:ISSUE-06 ISSUE-09 ISSUE-10 ISSUE-12"
 )
 
+canvas_issue_ids=(
+  "CANVAS-01"
+  "CANVAS-02"
+  "CANVAS-03"
+  "CANVAS-04"
+  "CANVAS-05"
+  "CANVAS-06"
+  "CANVAS-07"
+)
+
 status=0
 target="${1:-all}"
 
+check_canvas_pack() {
+  local root="$1"
+  local status_ref="$2"
+  local playbook="$root/artifacts/canvas-governance-playbook.md"
+  local command_ref="$root/artifacts/command-channel-reference.md"
+  local skill_file="$root/SKILL.md"
+  local feedback_eval="$root/assets/templates/canvas-feedback-eval.json"
+  local blocker_checklist="$root/assets/templates/canvas-blocker-checklist.json"
+  local robustness_checklist="$root/assets/templates/robustness-checklist.json"
+
+  for file_path in "$playbook" "$command_ref" "$skill_file" "$feedback_eval" "$blocker_checklist" "$robustness_checklist"; do
+    if [[ ! -f "$file_path" ]]; then
+      echo "[canvas-pack] missing file: $file_path" >&2
+      printf -v "$status_ref" '%s' 1
+      return
+    fi
+  done
+
+  for marker in \
+    "Canvas Governance Handshake" \
+    "artifacts/canvas-governance-playbook.md" \
+    "assets/templates/canvas-feedback-eval.json"; do
+    if ! grep -Fq "$marker" "$skill_file"; then
+      echo "[canvas-pack] SKILL.md missing marker: $marker" >&2
+      printf -v "$status_ref" '%s' 1
+    fi
+  done
+
+  for marker in \
+    "canvas.session.open" \
+    "canvas.plan.set" \
+    "canvas.feedback.poll" \
+    "plan_required"; do
+    if ! grep -Fq "$marker" "$command_ref"; then
+      echo "[canvas-pack] command/channel reference missing marker: $marker" >&2
+      printf -v "$status_ref" '%s' 1
+    fi
+  done
+
+  for issue_id in "${canvas_issue_ids[@]}"; do
+    if ! grep -Fq "$issue_id" "$playbook"; then
+      echo "[canvas-pack] playbook missing issue id: $issue_id" >&2
+      printf -v "$status_ref" '%s' 1
+    fi
+  done
+
+  if ! node -e '
+    const fs = require("fs");
+    const [feedbackPath, blockerPath, robustnessPath, ...expected] = process.argv.slice(1);
+    const feedback = JSON.parse(fs.readFileSync(feedbackPath, "utf8"));
+    const blockers = JSON.parse(fs.readFileSync(blockerPath, "utf8"));
+    const robustness = JSON.parse(fs.readFileSync(robustnessPath, "utf8"));
+    const feedbackIds = new Set(feedback.requiredIssueClasses || []);
+    const blockerIds = new Set((blockers.blockers || []).map((entry) => entry.auditId));
+    const robustnessIds = new Set((((robustness.canvas || {}).issueClasses) || []).map((entry) => entry.auditId));
+    const missing = expected.filter((id) => !feedbackIds.has(id) || !blockerIds.has(id) || !robustnessIds.has(id));
+    if (missing.length > 0) {
+      console.error(`[canvas-pack] missing canvas audit ids in JSON templates: ${missing.join(", ")}`);
+      process.exit(1);
+    }
+  ' "$feedback_eval" "$blocker_checklist" "$robustness_checklist" "${canvas_issue_ids[@]}"; then
+    printf -v "$status_ref" '%s' 1
+  fi
+}
+
 if [[ "$target" == "-h" || "$target" == "--help" ]]; then
   usage
   exit 0
 fi
 
 found_target=0
+if [[ "$target" == "all" || "$target" == "canvas-pack" ]]; then
+  found_target=1
+  check_canvas_pack "$root" status
+fi
+
 for entry in "${skills[@]}"; do
   skill="${entry%%:*}"
   expected="${entry#*:}"
-  if [[ "$target" != "all" && "$skill" != "$target" ]]; then
+  if [[ "$target" != "all" && "$target" != "canvas-pack" && "$skill" != "$target" ]]; then
     continue
   fi
   found_target=1

package/skills/opendevbrowser-best-practices/scripts/validate-skill-assets.sh

@@ -4,90 +4,231 @@ set -euo pipefail
 skill_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 skill_file="$skill_root/SKILL.md"
 
-required_paths=(
-  "artifacts/provider-workflows.md"
-  "artifacts/parity-gates.md"
-  "artifacts/debug-trace-playbook.md"
-  "artifacts/fingerprint-tiers.md"
-  "artifacts/macro-workflows.md"
-  "artifacts/browser-agent-known-issues-matrix.md"
-  "artifacts/command-channel-reference.md"
-  "assets/templates/mode-flag-matrix.json"
-  "assets/templates/ops-request-envelope.json"
-  "assets/templates/cdp-forward-envelope.json"
-  "assets/templates/robustness-checklist.json"
-  "assets/templates/surface-audit-checklist.json"
-  "scripts/odb-workflow.sh"
-  "scripts/run-robustness-audit.sh"
+node - "$skill_root" "$skill_file" <<'NODE'
+const fs = require("node:fs");
+const path = require("node:path");
+
+const [skillRoot, skillFile] = process.argv.slice(2);
+
+const requiredPaths = [
+  "artifacts/provider-workflows.md",
+  "artifacts/parity-gates.md",
+  "artifacts/debug-trace-playbook.md",
+  "artifacts/fingerprint-tiers.md",
+  "artifacts/macro-workflows.md",
+  "artifacts/browser-agent-known-issues-matrix.md",
+  "artifacts/command-channel-reference.md",
+  "artifacts/canvas-governance-playbook.md",
+  "assets/templates/mode-flag-matrix.json",
+  "assets/templates/ops-request-envelope.json",
+  "assets/templates/cdp-forward-envelope.json",
+  "assets/templates/robustness-checklist.json",
+  "assets/templates/surface-audit-checklist.json",
+  "assets/templates/canvas-handshake-example.json",
+  "assets/templates/canvas-generation-plan.v1.json",
+  "assets/templates/canvas-feedback-eval.json",
+  "assets/templates/canvas-blocker-checklist.json",
+  "scripts/odb-workflow.sh",
+  "scripts/run-robustness-audit.sh",
   "scripts/validate-skill-assets.sh"
-)
+];
+
+const jsonTemplates = [
+  "assets/templates/mode-flag-matrix.json",
+  "assets/templates/ops-request-envelope.json",
+  "assets/templates/cdp-forward-envelope.json",
+  "assets/templates/robustness-checklist.json",
+  "assets/templates/surface-audit-checklist.json",
+  "assets/templates/canvas-handshake-example.json",
+  "assets/templates/canvas-generation-plan.v1.json",
+  "assets/templates/canvas-feedback-eval.json",
+  "assets/templates/canvas-blocker-checklist.json"
+];
+
+const executableScripts = [
+  "scripts/odb-workflow.sh",
+  "scripts/run-robustness-audit.sh",
+  "scripts/validate-skill-assets.sh"
+];
+
+const skillDocMarkers = [
+  "npx opendevbrowser --help",
+  "npx opendevbrowser help",
+  "56 CLI commands, 49 tools, 38 `/ops` commands, 26 `/canvas` commands",
+  "mutationPolicy.allowedBeforePlan",
+  "canvas.code.bind",
+  "canvas.code.resolve",
+  "bound_app_runtime",
+  "annotate --stored"
+];
 
-json_templates=(
-  "assets/templates/mode-flag-matrix.json"
-  "assets/templates/ops-request-envelope.json"
-  "assets/templates/cdp-forward-envelope.json"
+const commandRefMarkers = [
+  "CLI commands: `56`",
+  "Plugin tools: `49`",
+  "`/ops` command names: `38`",
+  "`/canvas` command names: `26`",
+  "docs/SURFACE_REFERENCE.md",
+  "npx opendevbrowser help",
+  "canvas.session.open",
+  "canvas.session.attach",
+  "canvas.feedback.poll",
+  "canvas.code.bind",
+  "canvas.code.resolve",
+  "canvas.tab.sync",
+  "canvas.overlay.sync",
+  "feedback.heartbeat",
+  "governanceRequirements",
+  "generationPlanRequirements",
+  "mutationPolicy",
+  "code-sync",
+  "parity",
+  "plan_required",
+  "annotate --stored",
+  "storage",
+  "opencode",
+  "codex",
+  "claudecode",
+  "ampcli"
+];
+
+const workflowMarkers = [
+  "canvas-preflight",
+  "canvas-feedback-eval"
+];
+
+const canvasPlaybookMarkers = [
+  "canvas.session.open",
+  "canvas.plan.set",
+  "canvas.feedback.poll",
+  "CANVAS-01",
+  "CANVAS-07"
+];
+
+const canvasTemplateMarkers = [
+  "CANVAS-01",
+  "CANVAS-02",
+  "CANVAS-03",
+  "CANVAS-04",
+  "CANVAS-05",
+  "CANVAS-06",
+  "CANVAS-07"
+];
+
+const templateMarkerPaths = [
+  "assets/templates/canvas-feedback-eval.json",
+  "assets/templates/canvas-blocker-checklist.json",
   "assets/templates/robustness-checklist.json"
-  "assets/templates/surface-audit-checklist.json"
-)
-
-command_ref_markers=(
-  'CLI commands: `55`'
-  'Plugin tools: `48`'
-  '`/ops` command names: `38`'
-  'docs/SURFACE_REFERENCE.md'
-  'opencode'
-  'codex'
-  'claudecode'
-  'ampcli'
-)
-
-status=0
-
-for rel_path in "${required_paths[@]}"; do
-  full_path="$skill_root/$rel_path"
-  if [[ ! -f "$full_path" ]]; then
-    echo "Missing required asset: $rel_path" >&2
-    status=1
-  fi
-done
-
-for rel_path in "scripts/odb-workflow.sh" "scripts/run-robustness-audit.sh" "scripts/validate-skill-assets.sh"; do
-  full_path="$skill_root/$rel_path"
-  if [[ -f "$full_path" && ! -x "$full_path" ]]; then
-    echo "Script is not executable: $rel_path" >&2
-    status=1
-  fi
-done
-
-for rel_path in "${json_templates[@]}"; do
-  full_path="$skill_root/$rel_path"
-  if [[ -f "$full_path" ]]; then
-    if ! node -e 'const fs=require("fs"); JSON.parse(fs.readFileSync(process.argv[1], "utf8"));' "$full_path" >/dev/null 2>&1; then
-      echo "Invalid JSON template: $rel_path" >&2
-      status=1
-    fi
-  fi
-done
-
-for rel_path in "${required_paths[@]}"; do
-  if ! grep -Fq "$rel_path" "$skill_file"; then
-    echo "SKILL.md missing reference: $rel_path" >&2
-    status=1
-  fi
-done
-
-command_ref_path="$skill_root/artifacts/command-channel-reference.md"
-if [[ -f "$command_ref_path" ]]; then
-  for marker in "${command_ref_markers[@]}"; do
-    if ! grep -Fq "$marker" "$command_ref_path"; then
-      echo "Command/channel reference missing marker: $marker" >&2
-      status=1
-    fi
-  done
-fi
-
-if [[ $status -ne 0 ]]; then
-  exit $status
-fi
-
-echo "Skill assets validated: ${#required_paths[@]} files referenced/present, ${#json_templates[@]} JSON templates parsed."
+];
+
+const surfaceAuditPath = "assets/templates/surface-audit-checklist.json";
+const surfaceAuditMarkers = [
+  "\"cliCommands\": 56",
+  "\"tools\": 49",
+  "\"opsCommands\": 38",
+  "\"canvasCommands\": 26",
+  "Canvas command names documented",
+  "Canvas code-sync surface documented",
+  "Annotation send/copy semantics documented"
+];
+
+const failures = [];
+
+const readUtf8 = (relPath) => fs.readFileSync(path.join(skillRoot, relPath), "utf8");
+const hasMarker = (content, marker) => content.includes(marker);
+
+for (const relPath of requiredPaths) {
+  if (!fs.existsSync(path.join(skillRoot, relPath))) {
+    failures.push(`Missing required asset: ${relPath}`);
+  }
+}
+
+for (const relPath of executableScripts) {
+  const fullPath = path.join(skillRoot, relPath);
+  if (!fs.existsSync(fullPath)) continue;
+  const mode = fs.statSync(fullPath).mode & 0o111;
+  if (mode === 0) {
+    failures.push(`Script is not executable: ${relPath}`);
+  }
+}
+
+for (const relPath of jsonTemplates) {
+  const fullPath = path.join(skillRoot, relPath);
+  if (!fs.existsSync(fullPath)) continue;
+  try {
+    JSON.parse(fs.readFileSync(fullPath, "utf8"));
+  } catch {
+    failures.push(`Invalid JSON template: ${relPath}`);
+  }
+}
+
+const skillDoc = fs.readFileSync(skillFile, "utf8");
+for (const relPath of requiredPaths) {
+  if (!hasMarker(skillDoc, relPath)) {
+    failures.push(`SKILL.md missing reference: ${relPath}`);
+  }
+}
+for (const marker of skillDocMarkers) {
+  if (!hasMarker(skillDoc, marker)) {
+    failures.push(`SKILL.md missing marker: ${marker}`);
+  }
+}
+
+const commandRefPath = "artifacts/command-channel-reference.md";
+if (fs.existsSync(path.join(skillRoot, commandRefPath))) {
+  const commandRef = readUtf8(commandRefPath);
+  for (const marker of commandRefMarkers) {
+    if (!hasMarker(commandRef, marker)) {
+      failures.push(`Command/channel reference missing marker: ${marker}`);
+    }
+  }
+}
+
+const workflowPath = "scripts/odb-workflow.sh";
+if (fs.existsSync(path.join(skillRoot, workflowPath))) {
+  const workflow = readUtf8(workflowPath);
+  for (const marker of workflowMarkers) {
+    if (!hasMarker(workflow, marker)) {
+      failures.push(`Workflow router missing marker: ${marker}`);
+    }
+  }
+}
+
+const canvasPlaybookPath = "artifacts/canvas-governance-playbook.md";
+if (fs.existsSync(path.join(skillRoot, canvasPlaybookPath))) {
+  const canvasPlaybook = readUtf8(canvasPlaybookPath);
+  for (const marker of canvasPlaybookMarkers) {
+    if (!hasMarker(canvasPlaybook, marker)) {
+      failures.push(`Canvas playbook missing marker: ${marker}`);
+    }
+  }
+}
+
+if (fs.existsSync(path.join(skillRoot, surfaceAuditPath))) {
+  const surfaceAudit = readUtf8(surfaceAuditPath);
+  for (const marker of surfaceAuditMarkers) {
+    if (!hasMarker(surfaceAudit, marker)) {
+      failures.push(`Surface audit checklist missing marker: ${marker}`);
+    }
+  }
+}
+
+for (const relPath of templateMarkerPaths) {
+  const fullPath = path.join(skillRoot, relPath);
+  if (!fs.existsSync(fullPath)) continue;
+  const content = fs.readFileSync(fullPath, "utf8");
+  for (const marker of canvasTemplateMarkers) {
+    if (!hasMarker(content, marker)) {
+      failures.push(`Canvas template missing marker (${marker}): ${relPath}`);
+    }
+  }
+}
+
+if (failures.length > 0) {
+  for (const failure of failures) {
+    console.error(failure);
+  }
+  process.exit(1);
+}
+
+console.log(`Skill assets validated: ${requiredPaths.length} files referenced/present, ${jsonTemplates.length} JSON templates parsed.`);
+NODE