opencrater 0.2.2 → 0.2.4

package/cli.js

@@ -133,17 +133,17 @@ function enableIn(file, host) {
       matcher: "",
       hooks: [{ type: "command", command: cmdFor(event, host) }],
     };
-    const idx = list.findIndex(isOurs);
-    if (idx >= 0) {
-      if (JSON.stringify(list[idx]) !== JSON.stringify(desired)) {
-        list[idx] = desired;
-        changed = true;
-      }
-    } else {
-      list.push(desired);
+    // Remove EVERY entry of ours, then add exactly one. findIndex+replace only
+    // fixed the first match, so repeated installs / older command shapes left
+    // duplicate opencrater-hook entries piling up. Filtering collapses them.
+    const others = list.filter((r) => !isOurs(r));
+    const mine = list.filter(isOurs);
+    const alreadyCorrect =
+      mine.length === 1 && JSON.stringify(mine[0]) === JSON.stringify(desired);
+    if (!alreadyCorrect) {
+      settings.hooks[event] = [...others, desired];
       changed = true;
     }
-    settings.hooks[event] = list;
   }
   if (changed) writeJson(file, settings);
   return changed;
@@ -283,16 +283,28 @@ function showAgain() {
     return;
   }
   const { spawnSync, spawn } = require("node:child_process");
-  // our own terminal's device (we are running interactively)
-  const tty = spawnSync("tty", { stdio: ["inherit", "pipe", "ignore"], encoding: "utf8" })
-    .stdout?.trim();
+  const isWin = process.platform === "win32";
   // Replay: live ✕ (local), but never re-poll or re-record the original
   // impression — it was already dismissed once.
   const payload = { ...saved.payload, replay: true };
   delete payload.impressionId;
   const env = { ...process.env, OPENCRATER_PAINT: JSON.stringify(payload) };
-  if (tty && tty.startsWith("/dev/")) env.OPENCRATER_TTY = tty;
-  const child = spawn(process.execPath, [painter], { detached: true, stdio: "ignore", env });
+  // Unix: resolve our terminal device so the detached painter can open it.
+  // Windows: no `tty` command and no device path — the painter opens CONOUT$
+  // of the console it inherits, so we must NOT detach (detach = new/hidden
+  // console = nothing visible). Mirror the SDK's painterSpawnOptions.
+  if (!isWin) {
+    const tty = spawnSync("tty", { stdio: ["inherit", "pipe", "ignore"], encoding: "utf8" })
+      .stdout?.trim();
+    if (tty && tty.startsWith("/dev/")) env.OPENCRATER_TTY = tty;
+  }
+  const child = spawn(process.execPath, [painter], {
+    detached: !isWin,
+    stdio: "ignore",
+    env,
+    ...(isWin ? { windowsHide: true } : {}),
+  });
+  child.on("error", () => {});
   child.unref();
   console.log("opencrater: showing the last ad again.");
 }
@@ -347,13 +359,21 @@ if (cmd === "on" || cmd === "enable") {
     console.log("  overlay surface); message-level sponsorship is on the roadmap.");
   }
   // Pre-install the local hook runtime (background): hooks then run via
-  // plain node — no npx resolution latency, no cold-cache races.
+  // plain node — no npx resolution latency, no cold-cache races. Best-effort
+  // and non-fatal — hooks fall back to `npx -y` when the runtime is absent.
   try {
     const { spawn } = require("node:child_process");
-    spawn("npm", ["install", "--prefix",
+    // Windows: `npm` is `npm.cmd`, spawnable only through a shell — without
+    // shell:true this throws ENOENT as an async 'error' event that escapes
+    // try/catch and crashes the process. shell:true + an error handler keep
+    // it silent on every platform.
+    const isWin = process.platform === "win32";
+    const child = spawn("npm", ["install", "--prefix",
       path.join(os.homedir(), ".config", "opencrater", "runtime"),
       "@opencrater/sdk@latest", "--silent", "--no-audit", "--no-fund"],
-      { detached: true, stdio: "ignore" }).unref();
+      { detached: true, stdio: "ignore", shell: isWin, windowsHide: true });
+    child.on("error", () => {});
+    child.unref();
   } catch {}
   console.log("OpenCrater ads enabled for Claude Code + Codex.");
   console.log("All hooks registered as triggers; cards render only at session edges");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencrater",
-  "version": "0.2.2",
+  "version": "0.2.4",
   "description": "OpenCrater — sponsor cards in Claude Code and Codex. Free, one command, opt out anytime.",
   "keywords": [
     "opencrater",