opencode-worktree 0.4.0 → 0.4.1

package/README.md

@@ -155,7 +155,11 @@ Previous versions stored config in `.opencode-worktree.json` files in each repos
 
 ## Update notifications
 
-When a new version is published to npm, the TUI will show a non-intrusive update message in the title bar. The version check runs in the background and doesn't slow down startup.
+On launch, the app performs a single in-process npm version check and stores the result in a local cache.
+
+If a newer version is found, the warning appears on the next launch in the title bar as:
+
+`Update: <current> -> <latest> (npm i -g)`
 
 ## Development
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-worktree",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "private": false,
   "type": "module",
   "description": "TUI for managing git worktrees with opencode integration.",

package/src/ui.ts

@@ -10,7 +10,7 @@ import {
   type KeyEvent,
   type SelectOption,
 } from "@opentui/core";
-import { checkForUpdate } from "./update-check.js";
+import { checkForUpdatesOnLaunch, getCachedUpdateNotice } from "./update-check.js";
 import { basename } from "node:path";
 import {
   checkoutBranch,
@@ -145,21 +145,17 @@ class WorktreeSelector {
     });
     this.renderer.root.add(this.title);
 
-    // Display version or update notification in title line
+    // Display version/update notice from previous launch, then refresh cache now.
     if (this.pkg) {
-      const updateInfo = checkForUpdate(this.pkg);
+      const updateInfo = getCachedUpdateNotice(this.pkg);
+      checkForUpdatesOnLaunch(this.pkg);
 
-      let noticeContent: string;
-      let noticeColor: string;
+      let noticeContent = `v${this.pkg.version}`;
+      let noticeColor = "#64748B";
 
       if (updateInfo?.hasUpdate) {
-        // Update available
-        noticeContent = `Update: ${updateInfo.current} → ${updateInfo.latest} (npm i -g)`;
-        noticeColor = "#F59E0B"; // Amber
-      } else {
-        // On latest version (or no cache yet)
-        noticeContent = `v${this.pkg.version}`;
-        noticeColor = "#64748B"; // Subtle gray
+        noticeContent = `Update: ${updateInfo.current} -> ${updateInfo.latest} (npm i -g)`;
+        noticeColor = "#F59E0B";
       }
 
       this.versionNotice = new TextRenderable(renderer, {

package/src/update-check.ts

@@ -1,7 +1,7 @@
-import { spawn } from "node:child_process";
 import fs from "node:fs";
-import path from "node:path";
 import os from "node:os";
+import path from "node:path";
+import https from "node:https";
 
 export type UpdateInfo = {
   hasUpdate: boolean;
@@ -10,147 +10,123 @@ export type UpdateInfo = {
 };
 
 type UpdateCache = {
-  name: string; // Package name to verify cache matches
+  name: string;
   latest: string;
   lastCheck: number;
 };
 
 const CACHE_DIR = path.join(os.homedir(), ".config", "configstore");
 const CACHE_FILE = path.join(CACHE_DIR, "opencode-worktree-update.json");
+const REQUEST_TIMEOUT_MS = 4000;
 
-// Check interval: 1 hour in milliseconds
-const CHECK_INTERVAL_MS = 60 * 60 * 1000;
-
-/**
- * Read the cached update info from disk
- * Returns null if cache doesn't exist or package name doesn't match
- */
 function readCache(packageName: string): UpdateCache | null {
   try {
     if (!fs.existsSync(CACHE_FILE)) {
       return null;
     }
+
     const content = fs.readFileSync(CACHE_FILE, "utf-8");
     const cache = JSON.parse(content) as UpdateCache;
-    
-    // Verify the cache is for the correct package
     if (cache.name !== packageName) {
       return null;
     }
-    
+
     return cache;
   } catch {
     return null;
   }
 }
 
-/**
- * Compare two semver version strings
- * Returns true if latest > current
- */
+function writeCache(packageName: string, latestVersion: string): void {
+  try {
+    if (!fs.existsSync(CACHE_DIR)) {
+      fs.mkdirSync(CACHE_DIR, { recursive: true });
+    }
+
+    fs.writeFileSync(
+      CACHE_FILE,
+      JSON.stringify(
+        {
+          name: packageName,
+          latest: latestVersion,
+          lastCheck: Date.now(),
+        },
+        null,
+        2,
+      ),
+    );
+  } catch {
+    // Best-effort cache write.
+  }
+}
+
 function isNewerVersion(current: string, latest: string): boolean {
-  // Handle dev versions
   if (current === "dev" || current === "0.0.0") {
     return false;
   }
 
-  const parseVersion = (v: string): number[] => {
-    return v
+  const parseVersion = (version: string): number[] =>
+    version
       .replace(/^v/, "")
       .split(".")
-      .map((n) => parseInt(n, 10) || 0);
-  };
+      .map((part) => parseInt(part, 10) || 0);
 
   const currentParts = parseVersion(current);
   const latestParts = parseVersion(latest);
 
   for (let i = 0; i < 3; i++) {
-    const c = currentParts[i] || 0;
-    const l = latestParts[i] || 0;
-    if (l > c) return true;
-    if (l < c) return false;
+    const currentPart = currentParts[i] || 0;
+    const latestPart = latestParts[i] || 0;
+
+    if (latestPart > currentPart) return true;
+    if (latestPart < currentPart) return false;
   }
 
   return false;
 }
 
-/**
- * Spawn a detached background process to fetch the latest version from npm
- * and write it to the cache file. This doesn't block the main process.
- */
-function fetchLatestInBackground(packageName: string): void {
-  // Create an inline script that fetches from npm and writes to cache
-  const script = `
-    const https = require('https');
-    const fs = require('fs');
-    const path = require('path');
-    const os = require('os');
-
-    const cacheDir = path.join(os.homedir(), '.config', 'configstore');
-    const cacheFile = path.join(cacheDir, 'opencode-worktree-update.json');
-
-    const url = 'https://registry.npmjs.org/${packageName}/latest';
-
-    https.get(url, { headers: { 'Accept': 'application/json' } }, (res) => {
-      let data = '';
-      res.on('data', (chunk) => { data += chunk; });
-      res.on('end', () => {
+function fetchLatestVersion(packageName: string): void {
+  const url = `https://registry.npmjs.org/${packageName}/latest`;
+
+  const request = https.get(
+    url,
+    { headers: { Accept: "application/json" } },
+    (response) => {
+      if (response.statusCode !== 200) {
+        response.resume();
+        return;
+      }
+
+      let data = "";
+      response.on("data", (chunk: Buffer) => {
+        data += chunk.toString("utf-8");
+      });
+      response.on("end", () => {
         try {
-          const pkg = JSON.parse(data);
-          if (pkg.version) {
-            if (!fs.existsSync(cacheDir)) {
-              fs.mkdirSync(cacheDir, { recursive: true });
-            }
-            fs.writeFileSync(cacheFile, JSON.stringify({
-              name: '${packageName}',
-              latest: pkg.version,
-              lastCheck: Date.now()
-            }, null, 2));
+          const payload = JSON.parse(data) as { version?: string };
+          if (payload.version) {
+            writeCache(packageName, payload.version);
           }
-        } catch {}
+        } catch {
+          // Ignore invalid response payloads.
+        }
       });
-    }).on('error', () => {});
-  `;
-
-  try {
-    // Spawn node to run the script
-    const child = spawn(process.execPath, ["-e", script], {
-      detached: true,
-      stdio: "ignore",
-      env: { ...process.env },
-    });
-
-    // Unref so the parent process can exit independently
-    child.unref();
-  } catch {
-    // Silently fail - background fetch is best-effort
-  }
+    },
+  );
+
+  request.setTimeout(REQUEST_TIMEOUT_MS, () => {
+    request.destroy();
+  });
+  request.on("error", () => {
+    // Best-effort network check.
+  });
 }
 
-/**
- * Check for updates. This is non-blocking:
- * 1. Reads the cached latest version (if available)
- * 2. Compares against current version
- * 3. Spawns a background process to refresh the cache for next time
- *
- * Returns null if no cache exists yet (first run)
- */
-export function checkForUpdate(pkg: {
+export function getCachedUpdateNotice(pkg: {
   name: string;
   version: string;
 }): UpdateInfo | null {
   const cache = readCache(pkg.name);
-  const now = Date.now();
-
-  // Spawn background fetch if cache is stale or doesn't exist
-  const shouldFetch =
-    !cache || now - cache.lastCheck > CHECK_INTERVAL_MS;
-
-  if (shouldFetch) {
-    fetchLatestInBackground(pkg.name);
-  }
-
-  // If no cache, we can't determine if there's an update yet
   if (!cache) {
     return null;
   }
@@ -161,3 +137,7 @@ export function checkForUpdate(pkg: {
     latest: cache.latest,
   };
 }
+
+export function checkForUpdatesOnLaunch(pkg: { name: string }): void {
+  fetchLatestVersion(pkg.name);
+}