opencode-swarm 7.146.3 → 7.146.4

package/dist/hooks/pr-workflow-gate.d.ts

@@ -1,6 +1,6 @@
 import * as fsp from 'node:fs/promises';
 import { z } from 'zod';
-import { type CandidateSeverity, type RowFormatFamily } from '../background/candidate-contract.js';
+import { type CandidateSeverity, type FindingsSeverity, type RowFormatFamily } from '../background/candidate-contract.js';
 import { type LaneOutputArtifact } from '../background/lane-output-store.js';
 import { type BackgroundDelegationRecord, type BackgroundDelegationResult, type BackgroundDelegationWorkflowLaneRecovery, findByBatchId, sweepStaleDelegations } from '../background/pending-delegations.js';
 import { type PrReviewInlineTriggerRow } from '../background/pr-review-trigger-contract.js';
@@ -11,7 +11,7 @@ export declare const PR_REVIEW_BASE_DIMENSION_IDS: readonly ["intent-architectur
 export declare const PR_REVIEW_REQUIRED_MICRO_LANE_IDS: ("auth-identity-secrets" | "untrusted-input-boundaries" | "subprocess-platform" | "concurrency-state" | "dependencies-build-release" | "api-schema-migrations" | "test-infrastructure" | "ui-accessibility-i18n" | "privacy-observability" | "generated-provenance" | "unclassified-risk")[];
 export type PrReviewBaseDimensionId = (typeof PR_REVIEW_BASE_DIMENSION_IDS)[number];
 export type PrWorkflowMode = 'PR_REVIEW' | 'PR_FEEDBACK';
-export type PrReviewLaneValidationPredicate = 'batch.validated_at' | 'batch.expected_lane_unique' | 'record.missing' | 'record.duplicate_lane' | 'record.subagent_session_id' | 'record.duplicate_subagent_session_id' | 'record.forbidden_subagent_session_id' | 'record.created_at' | 'record.workflow_lane' | 'record.owned_workflow_lanes' | 'record.mode' | 'record.pr_head_sha' | 'record.git_head' | 'record.status' | 'result.output_degraded' | 'result.transcript_incomplete' | 'result.chars' | 'result.digest' | 'result.output_ref' | 'artifact.readable' | 'artifact.ref' | 'artifact.batch_id' | 'artifact.lane_id' | 'artifact.mode' | 'artifact.session_id' | 'artifact.parent_session_id' | 'artifact.agent' | 'artifact.role' | 'artifact.source' | 'artifact.workflow_lane_record' | 'artifact.workflow_lane_expected' | 'artifact.pr_head_sha' | 'artifact.git_head' | 'artifact.revision_digest' | 'record.scope' | 'artifact.scope' | 'artifact.digest' | 'artifact.chars' | 'discovery.header' | 'discovery.row' | 'discovery.coverage' | 'discovery.duplicate_evidence';
+export type PrReviewLaneValidationPredicate = 'batch.validated_at' | 'batch.expected_lane_unique' | 'record.missing' | 'record.duplicate_lane' | 'record.subagent_session_id' | 'record.duplicate_subagent_session_id' | 'record.forbidden_subagent_session_id' | 'record.created_at' | 'record.workflow_lane' | 'record.owned_workflow_lanes' | 'record.mode' | 'record.pr_head_sha' | 'record.git_head' | 'record.status' | 'result.output_degraded' | 'result.transcript_incomplete' | 'result.chars' | 'result.digest' | 'result.output_ref' | 'artifact.readable' | 'artifact.ref' | 'artifact.batch_id' | 'artifact.lane_id' | 'artifact.mode' | 'artifact.session_id' | 'artifact.parent_session_id' | 'artifact.agent' | 'artifact.role' | 'artifact.source' | 'artifact.workflow_lane_record' | 'artifact.workflow_lane_expected' | 'artifact.pr_head_sha' | 'artifact.git_head' | 'artifact.revision_digest' | 'record.scope' | 'artifact.scope' | 'artifact.digest' | 'artifact.chars' | 'discovery.header' | 'discovery.row' | 'discovery.coverage' | 'discovery.duplicate_evidence' | 'reviewer.verdict_rows' | 'critic.verdict_rows';
 export interface PrReviewLaneValidationFailure {
     predicate: PrReviewLaneValidationPredicate;
     expected: string;
@@ -54,12 +54,20 @@ export interface PrWorkflowTransportRecoveryValidationInput {
     artifact: LaneOutputArtifact | null;
     revisionDigest: string;
 }
+export interface PrReviewVerdictCollectionReceipt {
+    assignedReviewItemIds: string[];
+    acceptedReviewItemIds: string[];
+    rejectedReviewItemIds: string[];
+}
 export type PrWorkflowTransportRecoveryValidationResult = {
     ok: true;
     recoveries?: readonly BackgroundDelegationWorkflowLaneRecovery[];
+    receipt?: PrReviewVerdictCollectionReceipt;
 } | {
     ok: false;
     reason: string;
+    failure?: PrReviewLaneValidationFailure;
+    receipt?: PrReviewVerdictCollectionReceipt;
 };
 export interface PrWorkflowCheckoutRecoveryRecord {
     code: 'UNMERGED_INDEX' | 'GIT_OPERATION_IN_PROGRESS' | 'DIRTY_SUBMODULE' | 'SWARM_STATE_TRACKING_ERROR' | 'GIT_STATE_INDETERMINATE';
@@ -258,7 +266,14 @@ type PrReviewArtifactRecord = {
     finding_id: string;
     status: 'PENDING' | 'CONFIRMED' | 'DISPROVED' | 'PRE_EXISTING';
     next_action: 'route_to_reviewer' | 'route_to_critic' | 'report' | 'suppress_with_reason' | 'handoff_to_feedback';
-    severity?: CandidateSeverity;
+    /**
+     * Optional in the TYPE only so a legacy findings row persisted before
+     * required-severity landed still loads (`readFindings` JSON-parses without
+     * re-validating). Presence is REQUIRED by
+     * `assertPrReviewArtifactRecordsMatchAuthoritativeVerdicts`, which treats an
+     * omitted severity as a mismatch rather than skipping the check (issue #2279).
+     */
+    severity?: FindingsSeverity;
 };
 interface PrFeedbackScopeDeclarationRecord {
     taskId: string;
@@ -292,8 +307,9 @@ interface PrReviewValidationBatchRecord {
 interface PrReviewBatchCoherenceRecord {
     /**
      * The exact candidate/critic inventory this batch's ownership was validated
-     * against at record time (the same set `assertExactStringSet` compared the
-     * declared lane items to).
+     * against at record time. A batch may own a subset of this inventory; retaining
+     * the full set here prevents stale partial batches from contributing after the
+     * mechanically derived inventory changes.
      */
     validatedInventory: string[];
     /**
@@ -305,6 +321,8 @@ interface PrReviewBatchCoherenceRecord {
      * claims it invalidated and leaves its siblings intact.
      */
     reviewerItemBindings?: Record<string, string>;
+    /** Key encoding for reviewerItemBindings; absent means legacy raw item IDs. */
+    reviewerItemBindingKeyEncoding?: 'prefixed-v1';
 }
 export interface PrWorkflowGateState {
     schemaVersion: 1;
@@ -888,6 +906,12 @@ export declare const _test_exports: {
     resolveRemoteRefsContainingHead: typeof resolveRemoteRefsContainingHead;
     resolveRemoteRefsContainingHeadAsync: typeof resolveRemoteRefsContainingHeadAsync;
     parseCriticVerdict: typeof parseCriticVerdict;
+    /**
+     * Exact production verdict-row analysis and item composition parsers. Exposed
+     * so the assignment-boundary regression can prove both paths remain linear.
+     */
+    analyzePrReviewVerdictRowContract: typeof analyzePrReviewVerdictRowContract;
+    parseLaneItemVerdicts: typeof parseLaneItemVerdicts;
     /**
      * Read-only view of the item-keyed composition for one session, including
      * the diagnostics that settlement only logs (abandoned declared lanes,
@@ -994,6 +1018,12 @@ interface PrReviewGateContext {
     reviewer?: PrReviewPhaseComposition;
     critic?: PrReviewPhaseComposition;
     candidateInventory?: string[];
+    /**
+     * candidate_id -> the severity its `[CANDIDATE]` row declared. Populated
+     * as a by-product of deriving the inventory, so it is exactly as
+     * authoritative and as scoped as the inventory itself (issue #2320).
+     */
+    candidateSeverities?: Map<string, CandidateSeverity>;
 }
 /**
  * Extract candidate ids from a discovery artifact's [CANDIDATE] rows. When
@@ -1006,6 +1036,13 @@ interface PrReviewGateContext {
 interface CanonicalCandidateArtifactRow {
     candidateId: string;
     workflowLane: string;
+    /**
+     * The row's declared severity, already validated against
+     * `CANDIDATE_SEVERITIES` by `analyzeCandidateFields` (so never `NONE`).
+     * Carried so the `post_explorer` findings boundary can compare a record's
+     * severity against the candidate row that produced it (issue #2320).
+     */
+    severity: CandidateSeverity | null;
     evidence: string;
     lineNumber: number;
 }
@@ -1133,6 +1170,22 @@ export declare function prReviewDiscoveryArtifactCoversLane(text: string, expect
  * `pipeFields` can never produce, so no field boundary is forgeable.
  */
 declare function reviewerVerdictRowDigest(fields: readonly string[]): string;
+/**
+ * Per-item verdicts an artifact actually carries, as a map rather than a
+ * boolean. This is the granularity the composition needs: one unparseable item
+ * must not discard its healthy siblings in the same lane.
+ */
+declare function parseLaneItemVerdicts(text: string, itemIds: readonly string[], phase: PrReviewComposablePhase, reviewerClaims?: ReadonlyMap<string, PrReviewItemClaim>): Map<string, {
+    classification: string;
+    severity: string;
+    rowDigest?: string;
+}>;
+/** Exact assigned-row contract used by both normal and recovered collection. */
+declare function analyzePrReviewVerdictRowContract(text: string, itemIds: readonly string[], phase: PrReviewComposablePhase, reviewerClaims?: ReadonlyMap<string, PrReviewItemClaim>): {
+    ok: boolean;
+    expected: string;
+    actual: string;
+};
 declare function parseCriticVerdict(text: string, itemId: string, reviewerSeverity?: string): {
     status: string;
     severity: string;