opencode-swarm-plugin 0.29.0 → 0.30.2

package/src/swarm.integration.test.ts

@@ -15,6 +15,7 @@ import {
   swarm_progress,
   swarm_complete,
   swarm_subtask_prompt,
+  swarm_spawn_subtask,
   swarm_evaluation_prompt,
   swarm_select_strategy,
   swarm_plan_prompt,
@@ -23,6 +24,7 @@ import {
   swarm_checkpoint,
   swarm_recover,
 } from "./swarm";
+import { swarm_review, swarm_review_feedback } from "./swarm-review";
 import { mcpCall, setState, clearState, AGENT_MAIL_URL } from "./agent-mail";
 
 // ============================================================================
@@ -1162,7 +1164,65 @@ describe("swarm_init", () => {
   });
 });
 
-describe("Graceful Degradation", () => {
+  describe("Worker Handoff Generation", () => {
+    it("generateWorkerHandoff creates valid WorkerHandoff object", () => {
+      // This will test the new function once we implement it
+      const { generateWorkerHandoff } = require("./swarm-orchestrate");
+      
+      const handoff = generateWorkerHandoff({
+        task_id: "opencode-swarm-monorepo-lf2p4u-abc123.1",
+        files_owned: ["src/auth.ts", "src/middleware.ts"],
+        epic_summary: "Add OAuth authentication",
+        your_role: "Implement OAuth provider",
+        dependencies_completed: ["Database schema ready"],
+        what_comes_next: "Integration tests",
+      });
+
+      // Verify contract section
+      expect(handoff.contract.task_id).toBe("opencode-swarm-monorepo-lf2p4u-abc123.1");
+      expect(handoff.contract.files_owned).toEqual(["src/auth.ts", "src/middleware.ts"]);
+      expect(handoff.contract.files_readonly).toEqual([]);
+      expect(handoff.contract.dependencies_completed).toEqual(["Database schema ready"]);
+      expect(handoff.contract.success_criteria.length).toBeGreaterThan(0);
+
+      // Verify context section
+      expect(handoff.context.epic_summary).toBe("Add OAuth authentication");
+      expect(handoff.context.your_role).toBe("Implement OAuth provider");
+      expect(handoff.context.what_comes_next).toBe("Integration tests");
+
+      // Verify escalation section
+      expect(handoff.escalation.blocked_contact).toBe("coordinator");
+      expect(handoff.escalation.scope_change_protocol).toContain("swarmmail_send");
+    });
+
+    it("swarm_spawn_subtask includes handoff JSON in prompt", async () => {
+      const result = await swarm_spawn_subtask.execute(
+        {
+          bead_id: "opencode-swarm-monorepo-lf2p4u-abc123.1",
+          epic_id: "opencode-swarm-monorepo-lf2p4u-abc123",
+          subtask_title: "Add OAuth provider",
+          subtask_description: "Configure Google OAuth",
+          files: ["src/auth/google.ts"],
+          shared_context: "Using NextAuth.js v5",
+        },
+        mockContext,
+      );
+
+      // Parse the JSON response
+      const parsed = JSON.parse(result);
+      const prompt = parsed.prompt;
+
+      // Should contain WorkerHandoff JSON section
+      expect(prompt).toContain("## WorkerHandoff Contract");
+      expect(prompt).toContain('"contract"');
+      expect(prompt).toContain('"task_id"');
+      expect(prompt).toContain('"files_owned"');
+      expect(prompt).toContain('"success_criteria"');
+      expect(prompt).toContain("opencode-swarm-monorepo-lf2p4u-abc123.1");
+    });
+  });
+
+  describe("Graceful Degradation", () => {
   it("swarm_decompose works without CASS", async () => {
     // This should work regardless of CASS availability
     const result = await swarm_decompose.execute(
@@ -1245,8 +1305,8 @@ describe("Swarm Prompt V2 (with Swarm Mail/Beads)", () => {
   describe("formatSubtaskPromptV2", () => {
     it("generates correct prompt with all fields", () => {
       const result = formatSubtaskPromptV2({
-        bead_id: "bd-123.1",
-        epic_id: "bd-123",
+        bead_id: "test-swarm-plugin-lf2p4u-oauth123.1",
+        epic_id: "test-swarm-plugin-lf2p4u-oauth123",
         subtask_title: "Add OAuth provider",
         subtask_description: "Configure Google OAuth in the auth config",
         files: ["src/auth/google.ts", "src/auth/config.ts"],
@@ -1267,14 +1327,14 @@ describe("Swarm Prompt V2 (with Swarm Mail/Beads)", () => {
       expect(result).toContain("We are using NextAuth.js v5");
 
       // Check bead/epic IDs are substituted
-      expect(result).toContain("bd-123.1");
-      expect(result).toContain("bd-123");
+      expect(result).toContain("test-swarm-plugin-lf2p4u-oauth123.1");
+      expect(result).toContain("test-swarm-plugin-lf2p4u-oauth123");
     });
 
     it("handles missing optional fields", () => {
       const result = formatSubtaskPromptV2({
-        bead_id: "bd-456.1",
-        epic_id: "bd-456",
+        bead_id: "test-swarm-plugin-lf2p4u-simple456.1",
+        epic_id: "test-swarm-plugin-lf2p4u-simple456",
         subtask_title: "Simple task",
         subtask_description: "",
         files: [],
@@ -1295,8 +1355,8 @@ describe("Swarm Prompt V2 (with Swarm Mail/Beads)", () => {
 
     it("handles files with special characters", () => {
       const result = formatSubtaskPromptV2({
-        bead_id: "bd-789.1",
-        epic_id: "bd-789",
+        bead_id: "test-swarm-plugin-lf2p4u-paths789.1",
+        epic_id: "test-swarm-plugin-lf2p4u-paths789",
         subtask_title: "Handle paths",
         subtask_description: "Test file paths",
         files: [
@@ -1965,3 +2025,320 @@ describe("Checkpoint/Recovery Flow (integration)", () => {
   // and swarm_recover tests above. Auto-checkpoint at milestones (25%, 50%, 75%) is
   // a convenience feature that doesn't need dedicated integration tests.
 });
+
+// ============================================================================
+// Contract Validation Tests
+// ============================================================================
+
+describe("Contract Validation", () => {
+  describe("validateContract", () => {
+    it("passes when files_touched is subset of files_owned", () => {
+      // This test will fail until we implement validateContract
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        ["src/auth.ts", "src/utils.ts"],
+        ["src/auth.ts", "src/utils.ts", "src/types.ts"]
+      );
+      
+      expect(result.valid).toBe(true);
+      expect(result.violations).toHaveLength(0);
+    });
+    
+    it("fails when files_touched has extra files", () => {
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        ["src/auth.ts", "src/forbidden.ts"],
+        ["src/auth.ts"]
+      );
+      
+      expect(result.valid).toBe(false);
+      expect(result.violations).toContain("src/forbidden.ts");
+    });
+    
+    it("matches glob patterns correctly", () => {
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        ["src/auth/service.ts", "src/auth/types.ts"],
+        ["src/auth/**/*.ts"]
+      );
+      
+      expect(result.valid).toBe(true);
+      expect(result.violations).toHaveLength(0);
+    });
+    
+    it("detects violations outside glob pattern", () => {
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        ["src/auth/service.ts", "src/utils/helper.ts"],
+        ["src/auth/**"]
+      );
+      
+      expect(result.valid).toBe(false);
+      expect(result.violations).toContain("src/utils/helper.ts");
+    });
+    
+    it("passes with empty files_touched (read-only work)", () => {
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        [],
+        ["src/auth/**"]
+      );
+      
+      expect(result.valid).toBe(true);
+      expect(result.violations).toHaveLength(0);
+    });
+    
+    it("handles multiple glob patterns", () => {
+      const { validateContract } = require("./swarm-orchestrate");
+      
+      const result = validateContract(
+        ["src/auth/service.ts", "tests/auth.test.ts"],
+        ["src/auth/**", "tests/**"]
+      );
+      
+      expect(result.valid).toBe(true);
+      expect(result.violations).toHaveLength(0);
+    });
+  });
+  
+  describe("swarm_complete with contract validation", () => {
+    it("includes contract validation result when files_touched provided", async () => {
+      // This test needs a real decomposition event, so it's more of an integration check
+      // The actual validation logic is tested in unit tests above
+      // Here we just verify the response includes contract_validation field
+      
+      const mockResult = {
+        success: true,
+        contract_validation: {
+          validated: false,
+          reason: "No files_owned contract found (non-epic subtask or decomposition event missing)",
+        },
+      };
+      
+      // Verify the structure exists
+      expect(mockResult.contract_validation).toBeDefined();
+      expect(mockResult.contract_validation.validated).toBe(false);
+    });
+  });
+
+  describe("swarm_complete project_key handling (bug fix)", () => {
+    it("finds cells created with full path project_key", async () => {
+      // BUG: swarm_complete was mangling project_key with .replace(/\//g, "-")
+      // before querying, but cells are stored with the original path.
+      // This caused "Bead not found" errors for cells created via hive_create_epic.
+      
+      const testProjectPath = "/tmp/swarm-complete-projectkey-test-" + Date.now();
+      const { getHiveAdapter } = await import("./hive");
+      const adapter = await getHiveAdapter(testProjectPath);
+      
+      // Create a cell using the full path as project_key (like hive_create_epic does)
+      const cell = await adapter.createCell(testProjectPath, {
+        title: "Test cell for project_key bug",
+        type: "task",
+        priority: 2,
+      });
+      
+      expect(cell.id).toBeDefined();
+      
+      // Now try to complete it via swarm_complete with the same project_key
+      const result = await swarm_complete.execute(
+        {
+          project_key: testProjectPath, // Full path, not mangled
+          agent_name: "test-agent",
+          bead_id: cell.id,
+          summary: "Testing project_key handling",
+          skip_verification: true,
+          skip_review: true,
+        },
+        mockContext,
+      );
+      
+      const parsed = JSON.parse(result);
+      
+      // This should succeed - the cell exists with this project_key
+      // BUG: Before fix, this fails with "Bead not found" because swarm_complete
+      // was looking for project_key "-tmp-swarm-complete-projectkey-test-xxx"
+      expect(parsed.success).toBe(true);
+      expect(parsed.error).toBeUndefined();
+      expect(parsed.bead_id).toBe(cell.id);
+    });
+
+    it("handles project_key with slashes correctly", async () => {
+      // Verify that project_key like "/Users/joel/Code/project" works
+      const testProjectPath = "/a/b/c/test-" + Date.now();
+      const { getHiveAdapter } = await import("./hive");
+      const adapter = await getHiveAdapter(testProjectPath);
+      
+      const cell = await adapter.createCell(testProjectPath, {
+        title: "Nested path test",
+        type: "task",
+        priority: 2,
+      });
+      
+      // Verify cell was created with correct project_key
+      const retrieved = await adapter.getCell(testProjectPath, cell.id);
+      expect(retrieved).not.toBeNull();
+      expect(retrieved?.id).toBe(cell.id);
+      
+      // swarm_complete should find it using the same project_key
+      const result = await swarm_complete.execute(
+        {
+          project_key: testProjectPath,
+          agent_name: "test-agent",
+          bead_id: cell.id,
+          summary: "Nested path test",
+          skip_verification: true,
+          skip_review: true,
+        },
+        mockContext,
+      );
+      
+      const parsed = JSON.parse(result);
+      expect(parsed.success).toBe(true);
+    });
+  });
+
+  describe("swarm_complete review gate UX", () => {
+    it("returns success: true with status: pending_review when review not attempted", async () => {
+      const testProjectPath = "/tmp/swarm-review-gate-test-" + Date.now();
+      const { getHiveAdapter } = await import("./hive");
+      const adapter = await getHiveAdapter(testProjectPath);
+
+      // Create a task cell directly
+      const cell = await adapter.createCell(testProjectPath, {
+        title: "Test task for review gate",
+        type: "task",
+        priority: 2,
+      });
+
+      // Start the task
+      await adapter.updateCell(testProjectPath, cell.id, {
+        status: "in_progress",
+      });
+
+      // Try to complete without review (skip_review intentionally omitted - defaults to false)
+      const result = await swarm_complete.execute(
+        {
+          project_key: testProjectPath,
+          agent_name: "TestAgent",
+          bead_id: cell.id,
+          summary: "Done",
+          files_touched: ["test.ts"],
+          skip_verification: true,
+          // skip_review intentionally omitted - defaults to false
+        },
+        mockContext,
+      );
+
+      const parsed = JSON.parse(result);
+
+      // Should be success: true with workflow status
+      expect(parsed.success).toBe(true);
+      expect(parsed.status).toBe("pending_review");
+      expect(parsed.message).toContain("awaiting coordinator review");
+      expect(parsed.next_steps).toBeInstanceOf(Array);
+      expect(parsed.next_steps.length).toBeGreaterThan(0);
+      expect(parsed.review_status).toBeDefined();
+      expect(parsed.review_status.reviewed).toBe(false);
+      expect(parsed.review_status.approved).toBe(false);
+
+      // Should NOT have error field
+      expect(parsed.error).toBeUndefined();
+    });
+
+    it("returns success: true, not error, when review not approved", async () => {
+      const testProjectPath = "/tmp/swarm-review-not-approved-test-" + Date.now();
+      const { getHiveAdapter } = await import("./hive");
+      const { markReviewRejected } = await import("./swarm-review");
+      const adapter = await getHiveAdapter(testProjectPath);
+
+      // Create a task cell directly
+      const cell = await adapter.createCell(testProjectPath, {
+        title: "Test task for review not approved",
+        type: "task",
+        priority: 2,
+      });
+
+      // Start the task
+      await adapter.updateCell(testProjectPath, cell.id, {
+        status: "in_progress",
+      });
+
+      // Manually set review status to rejected (approved: false, but reviewed: true)
+      // This simulates the review gate detecting a review was done but not approved
+      markReviewRejected(cell.id);
+
+      // Try to complete with review not approved
+      const result = await swarm_complete.execute(
+        {
+          project_key: testProjectPath,
+          agent_name: "TestAgent",
+          bead_id: cell.id,
+          summary: "Done",
+          files_touched: ["test.ts"],
+          skip_verification: true,
+        },
+        mockContext,
+      );
+
+      const parsed = JSON.parse(result);
+
+      // Should be success: true with workflow status (not error)
+      expect(parsed.success).toBe(true);
+      expect(parsed.status).toBe("needs_changes");
+      expect(parsed.message).toContain("changes requested");
+      expect(parsed.next_steps).toBeInstanceOf(Array);
+      expect(parsed.next_steps.length).toBeGreaterThan(0);
+      expect(parsed.review_status).toBeDefined();
+      expect(parsed.review_status.reviewed).toBe(true);
+      expect(parsed.review_status.approved).toBe(false);
+
+      // Should NOT have error field
+      expect(parsed.error).toBeUndefined();
+    });
+
+    it("completes successfully when skip_review=true", async () => {
+      const testProjectPath = "/tmp/swarm-skip-review-test-" + Date.now();
+      const { getHiveAdapter } = await import("./hive");
+      const adapter = await getHiveAdapter(testProjectPath);
+
+      // Create a task cell directly
+      const cell = await adapter.createCell(testProjectPath, {
+        title: "Test task for skip review",
+        type: "task",
+        priority: 2,
+      });
+
+      // Start the task
+      await adapter.updateCell(testProjectPath, cell.id, {
+        status: "in_progress",
+      });
+
+      // Complete with skip_review
+      const result = await swarm_complete.execute(
+        {
+          project_key: testProjectPath,
+          agent_name: "TestAgent",
+          bead_id: cell.id,
+          summary: "Done",
+          files_touched: ["test.ts"],
+          skip_verification: true,
+          skip_review: true,
+        },
+        mockContext,
+      );
+
+      const parsed = JSON.parse(result);
+
+      // Should complete without review gate
+      expect(parsed.success).toBe(true);
+      expect(parsed.status).toBeUndefined(); // No workflow status when skipping
+      expect(parsed.error).toBeUndefined();
+    });
+  });
+});