opencode-swarm-plugin 0.21.0 → 0.23.0

package/src/storage.ts

@@ -141,15 +141,102 @@ export interface StorageConfig {
   useSemanticSearch: boolean;
 }
 
-export const DEFAULT_STORAGE_CONFIG: StorageConfig = {
-  backend: "semantic-memory",
-  collections: {
+/**
+ * Generate unique test collection name
+ *
+ * Creates a timestamp-based suffix for test collections to ensure complete isolation.
+ * Each test run gets its own collections that don't pollute production semantic-memory.
+ *
+ * @returns Unique suffix like "test-1734567890123"
+ *
+ * @example
+ * ```typescript
+ * // In test setup:
+ * process.env.TEST_SEMANTIC_MEMORY_COLLECTION = getTestCollectionName();
+ * // Results in collections like: swarm-feedback-test-1734567890123
+ * ```
+ */
+export function getTestCollectionName(): string {
+  return `test-${Date.now()}`;
+}
+
+/**
+ * Get collection names with optional test suffix
+ *
+ * Supports two test isolation modes:
+ * 1. TEST_MEMORY_COLLECTIONS=true - appends "-test" (shared across test run)
+ * 2. TEST_SEMANTIC_MEMORY_COLLECTION=<suffix> - appends custom suffix (unique per test run)
+ *
+ * Mode 2 is preferred for full isolation - prevents test pollution of production
+ * semantic-memory collections.
+ *
+ * @example
+ * ```typescript
+ * // Production
+ * getCollectionNames()
+ * // => { feedback: "swarm-feedback", patterns: "swarm-patterns", maturity: "swarm-maturity" }
+ *
+ * // Test mode 1 (legacy)
+ * process.env.TEST_MEMORY_COLLECTIONS = "true"
+ * getCollectionNames()
+ * // => { feedback: "swarm-feedback-test", patterns: "swarm-patterns-test", ... }
+ *
+ * // Test mode 2 (preferred - full isolation)
+ * process.env.TEST_SEMANTIC_MEMORY_COLLECTION = "test-1734567890123"
+ * getCollectionNames()
+ * // => { feedback: "swarm-feedback-test-1734567890123", patterns: "swarm-patterns-test-1734567890123", ... }
+ * ```
+ */
+function getCollectionNames(): StorageCollections {
+  const base = {
     feedback: "swarm-feedback",
     patterns: "swarm-patterns",
     maturity: "swarm-maturity",
-  },
-  useSemanticSearch: true,
-};
+  };
+
+  // Test isolation mode 2 (preferred): unique suffix per test run
+  const testSuffix = process.env.TEST_SEMANTIC_MEMORY_COLLECTION;
+  if (testSuffix) {
+    return {
+      feedback: `${base.feedback}-${testSuffix}`,
+      patterns: `${base.patterns}-${testSuffix}`,
+      maturity: `${base.maturity}-${testSuffix}`,
+    };
+  }
+
+  // Test isolation mode 1 (legacy): shared "-test" suffix
+  if (process.env.TEST_MEMORY_COLLECTIONS === "true") {
+    return {
+      feedback: `${base.feedback}-test`,
+      patterns: `${base.patterns}-test`,
+      maturity: `${base.maturity}-test`,
+    };
+  }
+
+  return base;
+}
+
+/**
+ * Get default storage configuration
+ *
+ * Returns a fresh config object on each call to ensure env vars (like
+ * TEST_SEMANTIC_MEMORY_COLLECTION) are read at runtime, not module load time.
+ *
+ * @returns Default storage configuration
+ */
+export function getDefaultStorageConfig(): StorageConfig {
+  return {
+    backend: "semantic-memory",
+    collections: getCollectionNames(),
+    useSemanticSearch: true,
+  };
+}
+
+/**
+ * @deprecated Use getDefaultStorageConfig() instead. This static export
+ * captures collections at module load time, breaking test isolation.
+ */
+export const DEFAULT_STORAGE_CONFIG: StorageConfig = getDefaultStorageConfig();
 
 // ============================================================================
 // Unified Storage Interface
@@ -189,6 +276,43 @@ export interface LearningStorage {
   close(): Promise<void>;
 }
 
+// ============================================================================
+// Session Stats Tracking
+// ============================================================================
+
+interface SessionStats {
+  storesCount: number;
+  queriesCount: number;
+  sessionStart: number;
+  lastAlertCheck: number;
+}
+
+let sessionStats: SessionStats = {
+  storesCount: 0,
+  queriesCount: 0,
+  sessionStart: Date.now(),
+  lastAlertCheck: Date.now(),
+};
+
+/**
+ * Reset session stats (for testing)
+ */
+export function resetSessionStats(): void {
+  sessionStats = {
+    storesCount: 0,
+    queriesCount: 0,
+    sessionStart: Date.now(),
+    lastAlertCheck: Date.now(),
+  };
+}
+
+/**
+ * Get current session stats
+ */
+export function getSessionStats(): Readonly<SessionStats> {
+  return { ...sessionStats };
+}
+
 // ============================================================================
 // Semantic Memory Storage Implementation
 // ============================================================================
@@ -203,13 +327,48 @@ export class SemanticMemoryStorage implements LearningStorage {
   private config: StorageConfig;
 
   constructor(config: Partial<StorageConfig> = {}) {
-    this.config = { ...DEFAULT_STORAGE_CONFIG, ...config };
+    // Use getDefaultStorageConfig() to ensure env vars are read at runtime
+    this.config = { ...getDefaultStorageConfig(), ...config };
+    console.log(
+      `[storage] SemanticMemoryStorage initialized with collections:`,
+      this.config.collections,
+    );
   }
 
   // -------------------------------------------------------------------------
   // Helpers
   // -------------------------------------------------------------------------
 
+  /**
+   * Check if low usage alert should be sent
+   *
+   * Sends alert via agentmail if:
+   * - More than 10 minutes have elapsed since session start
+   * - Less than 1 store operation has occurred
+   * - Alert hasn't been sent in the last 10 minutes
+   */
+  private async checkLowUsageAlert(): Promise<void> {
+    const TEN_MINUTES = 10 * 60 * 1000;
+    const now = Date.now();
+    const sessionDuration = now - sessionStats.sessionStart;
+    const timeSinceLastAlert = now - sessionStats.lastAlertCheck;
+
+    if (
+      sessionDuration >= TEN_MINUTES &&
+      sessionStats.storesCount < 1 &&
+      timeSinceLastAlert >= TEN_MINUTES
+    ) {
+      console.warn(
+        `[storage] LOW USAGE ALERT: ${sessionStats.storesCount} stores after ${Math.floor(sessionDuration / 60000)} minutes`,
+      );
+      sessionStats.lastAlertCheck = now;
+
+      // Send alert via Agent Mail if available
+      // Note: This requires agentmail to be initialized, which may not always be the case
+      // We'll log the alert and let the coordinator detect it in logs
+    }
+  }
+
   private async store(
     collection: string,
     data: unknown,
@@ -222,7 +381,19 @@ export class SemanticMemoryStorage implements LearningStorage {
       args.push("--metadata", JSON.stringify(metadata));
     }
 
-    await execSemanticMemory(args);
+    console.log(`[storage] store() -> collection="${collection}"`);
+    sessionStats.storesCount++;
+
+    const result = await execSemanticMemory(args);
+
+    if (result.exitCode !== 0) {
+      console.warn(
+        `[storage] semantic-memory store() failed with exit code ${result.exitCode}: ${result.stderr.toString().trim()}`,
+      );
+    }
+
+    // Alert check: if 10+ minutes elapsed with < 1 store, send alert
+    await this.checkLowUsageAlert();
   }
 
   private async find<T>(
@@ -245,6 +416,11 @@ export class SemanticMemoryStorage implements LearningStorage {
       args.push("--fts");
     }
 
+    console.log(
+      `[storage] find() -> collection="${collection}", query="${query.slice(0, 50)}${query.length > 50 ? "..." : ""}", limit=${limit}, fts=${useFts}`,
+    );
+    sessionStats.queriesCount++;
+
     const result = await execSemanticMemory(args);
 
     if (result.exitCode !== 0) {
@@ -280,6 +456,9 @@ export class SemanticMemoryStorage implements LearningStorage {
   }
 
   private async list<T>(collection: string): Promise<T[]> {
+    console.log(`[storage] list() -> collection="${collection}"`);
+    sessionStats.queriesCount++;
+
     const result = await execSemanticMemory([
       "list",
       "--collection",
@@ -611,7 +790,8 @@ export class InMemoryStorage implements LearningStorage {
 export function createStorage(
   config: Partial<StorageConfig> = {},
 ): LearningStorage {
-  const fullConfig = { ...DEFAULT_STORAGE_CONFIG, ...config };
+  // Use getDefaultStorageConfig() to ensure env vars are read at runtime
+  const fullConfig = { ...getDefaultStorageConfig(), ...config };
 
   switch (fullConfig.backend) {
     case "semantic-memory":

package/src/swarm-mail.ts

@@ -26,9 +26,9 @@ import {
   releaseSwarmFiles,
   acknowledgeSwarmMessage,
   checkSwarmHealth,
-} from "./streams/swarm-mail";
-import { getActiveReservations } from "./streams/projections";
-import type { MailSessionState } from "./streams/events";
+  getActiveReservations,
+  type MailSessionState,
+} from "swarm-mail";
 import {
   existsSync,
   mkdirSync,