opencode-snippets 1.4.2 → 1.4.3

package/src/expander.ts

@@ -1,225 +0,0 @@
-import { PATTERNS } from "./constants.js";
-import { logger } from "./logger.js";
-import type { ExpansionResult, ParsedSnippetContent, SnippetRegistry } from "./types.js";
-
-/**
- * Maximum number of times a snippet can be expanded to prevent infinite loops
- */
-const MAX_EXPANSION_COUNT = 15;
-
-/**
- * Tag types for parsing
- */
-type BlockType = "prepend" | "append";
-
-/**
- * Parses snippet content to extract inline text and prepend/append blocks
- *
- * Uses a lenient stack-based parser:
- * - Unclosed tags → treat rest of content as block
- * - Nesting → log error, return null (skip expansion)
- * - Multiple blocks → collected in document order
- *
- * @param content - The raw snippet content to parse
- * @returns Parsed content with inline, prepend, and append parts, or null on error
- */
-export function parseSnippetBlocks(content: string): ParsedSnippetContent | null {
-  const prepend: string[] = [];
-  const append: string[] = [];
-  let inline = "";
-
-  // Regex to find opening and closing tags
-  const tagPattern = /<(\/?)(?<tagName>prepend|append)>/gi;
-  let lastIndex = 0;
-  let currentBlock: { type: BlockType; startIndex: number; contentStart: number } | null = null;
-
-  let match = tagPattern.exec(content);
-  while (match !== null) {
-    const isClosing = match[1] === "/";
-    const tagName = match.groups?.tagName?.toLowerCase() as BlockType;
-    const tagStart = match.index;
-    const tagEnd = tagStart + match[0].length;
-
-    if (isClosing) {
-      // Closing tag
-      if (currentBlock === null) {
-        // Closing tag without opening - ignore it, treat as inline content
-        continue;
-      }
-      if (currentBlock.type !== tagName) {
-        // Mismatched closing tag - this is a nesting error
-        logger.warn(
-          `Mismatched closing tag: expected </${currentBlock.type}>, found </${tagName}>`,
-        );
-        return null;
-      }
-      // Extract block content
-      const blockContent = content.slice(currentBlock.contentStart, tagStart).trim();
-      if (blockContent) {
-        if (currentBlock.type === "prepend") {
-          prepend.push(blockContent);
-        } else {
-          append.push(blockContent);
-        }
-      }
-      lastIndex = tagEnd;
-      currentBlock = null;
-    } else {
-      // Opening tag
-      if (currentBlock !== null) {
-        // Nested opening tag - error
-        logger.warn(`Nested tags not allowed: found <${tagName}> inside <${currentBlock.type}>`);
-        return null;
-      }
-      // Add any inline content before this tag
-      const inlinePart = content.slice(lastIndex, tagStart);
-      inline += inlinePart;
-      currentBlock = { type: tagName, startIndex: tagStart, contentStart: tagEnd };
-    }
-    match = tagPattern.exec(content);
-  }
-
-  // Handle unclosed tag (lenient: treat rest as block content)
-  if (currentBlock !== null) {
-    const blockContent = content.slice(currentBlock.contentStart).trim();
-    if (blockContent) {
-      if (currentBlock.type === "prepend") {
-        prepend.push(blockContent);
-      } else {
-        append.push(blockContent);
-      }
-    }
-  } else {
-    // Add any remaining inline content
-    inline += content.slice(lastIndex);
-  }
-
-  return {
-    inline: inline.trim(),
-    prepend,
-    append,
-  };
-}
-
-/**
- * Expands hashtags in text recursively with loop detection
- *
- * Returns an ExpansionResult containing the inline-expanded text plus
- * collected prepend/append blocks from all expanded snippets.
- *
- * @param text - The text containing hashtags to expand
- * @param registry - The snippet registry to look up hashtags
- * @param expansionCounts - Map tracking how many times each snippet has been expanded
- * @returns ExpansionResult with text and collected blocks
- */
-export function expandHashtags(
-  text: string,
-  registry: SnippetRegistry,
-  expansionCounts = new Map<string, number>(),
-): ExpansionResult {
-  const collectedPrepend: string[] = [];
-  const collectedAppend: string[] = [];
-
-  let expanded = text;
-  let hasChanges = true;
-
-  // Keep expanding until no more hashtags are found
-  while (hasChanges) {
-    const previous = expanded;
-    let loopDetected = false;
-
-    // Reset regex state (global flag requires this)
-    PATTERNS.HASHTAG.lastIndex = 0;
-
-    // We need to collect blocks during replacement, so we track them here
-    const roundPrepend: string[] = [];
-    const roundAppend: string[] = [];
-
-    expanded = expanded.replace(PATTERNS.HASHTAG, (match, name) => {
-      const key = name.toLowerCase();
-
-      const snippet = registry.get(key);
-      if (snippet === undefined) {
-        // Unknown snippet - leave as-is
-        return match;
-      }
-
-      // Track expansion count to prevent infinite loops
-      const count = (expansionCounts.get(key) || 0) + 1;
-      if (count > MAX_EXPANSION_COUNT) {
-        // Loop detected! Leave the hashtag as-is and stop expanding
-        logger.warn(
-          `Loop detected: snippet '#${key}' expanded ${count} times (max: ${MAX_EXPANSION_COUNT})`,
-        );
-        loopDetected = true;
-        return match; // Leave as-is instead of error message
-      }
-
-      expansionCounts.set(key, count);
-
-      // Parse the snippet content for blocks
-      const parsed = parseSnippetBlocks(snippet.content);
-      if (parsed === null) {
-        // Parse error - leave hashtag unchanged
-        logger.warn(`Failed to parse snippet '${key}', leaving hashtag unchanged`);
-        return match;
-      }
-
-      // Collect prepend/append blocks
-      roundPrepend.push(...parsed.prepend);
-      roundAppend.push(...parsed.append);
-
-      // Recursively expand any hashtags in the inline content
-      const nestedResult = expandHashtags(parsed.inline, registry, expansionCounts);
-
-      // Collect blocks from nested expansion
-      roundPrepend.push(...nestedResult.prepend);
-      roundAppend.push(...nestedResult.append);
-
-      return nestedResult.text;
-    });
-
-    // Add this round's blocks to collected blocks
-    collectedPrepend.push(...roundPrepend);
-    collectedAppend.push(...roundAppend);
-
-    // Only continue if the text actually changed AND no loop was detected
-    hasChanges = expanded !== previous && !loopDetected;
-  }
-
-  return {
-    text: expanded,
-    prepend: collectedPrepend,
-    append: collectedAppend,
-  };
-}
-
-/**
- * Assembles the final message from an expansion result
- *
- * Joins: prepend blocks + inline text + append blocks
- * with double newlines between non-empty sections.
- *
- * @param result - The expansion result to assemble
- * @returns The final assembled message
- */
-export function assembleMessage(result: ExpansionResult): string {
-  const parts: string[] = [];
-
-  // Add prepend blocks
-  if (result.prepend.length > 0) {
-    parts.push(result.prepend.join("\n\n"));
-  }
-
-  // Add main text
-  if (result.text.trim()) {
-    parts.push(result.text);
-  }
-
-  // Add append blocks
-  if (result.append.length > 0) {
-    parts.push(result.append.join("\n\n"));
-  }
-
-  return parts.join("\n\n");
-}

package/src/loader.test.ts

@@ -1,352 +0,0 @@
-import { mkdir, rm, writeFile } from "node:fs/promises";
-import { join } from "node:path";
-import { loadSnippets } from "../src/loader.js";
-
-describe("loadSnippets - Dual Path Support", () => {
-  let tempDir: string;
-  let globalSnippetDir: string;
-  let projectSnippetDir: string;
-
-  beforeEach(async () => {
-    // Create temporary directories for testing
-    tempDir = join(process.cwd(), ".test-temp");
-    globalSnippetDir = join(tempDir, "global-snippet");
-    projectSnippetDir = join(tempDir, "project", ".opencode", "snippet");
-
-    await mkdir(globalSnippetDir, { recursive: true });
-    await mkdir(projectSnippetDir, { recursive: true });
-  });
-
-  afterEach(async () => {
-    // Clean up temporary directories
-    await rm(tempDir, { recursive: true, force: true });
-  });
-
-  describe("Global snippets only", () => {
-    it("should load snippets with aliases", async () => {
-      await writeFile(
-        join(globalSnippetDir, "careful.md"),
-        `---
-aliases: safe
----
-Think step by step. Double-check your work.`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("careful")?.content).toBe("Think step by step. Double-check your work.");
-      expect(snippets.get("safe")?.content).toBe("Think step by step. Double-check your work.");
-    });
-
-    it("should load multiple snippets from global directory", async () => {
-      await writeFile(join(globalSnippetDir, "snippet1.md"), "Content of snippet 1");
-      await writeFile(join(globalSnippetDir, "snippet2.md"), "Content of snippet 2");
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("snippet1")?.content).toBe("Content of snippet 1");
-      expect(snippets.get("snippet2")?.content).toBe("Content of snippet 2");
-    });
-  });
-
-  describe("Project snippets only", () => {
-    it("should load snippets from project directory", async () => {
-      await writeFile(
-        join(projectSnippetDir, "project-specific.md"),
-        "This is a project-specific snippet",
-      );
-
-      // Load with project directory
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      expect(snippets.size).toBe(1);
-      expect(snippets.get("project-specific")?.content).toBe("This is a project-specific snippet");
-    });
-
-    it("should handle missing global directory when project exists", async () => {
-      await writeFile(join(projectSnippetDir, "team-rule.md"), "Team rule 1");
-      await writeFile(join(projectSnippetDir, "domain-knowledge.md"), "Domain knowledge");
-
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("team-rule")?.content).toBe("Team rule 1");
-      expect(snippets.get("domain-knowledge")?.content).toBe("Domain knowledge");
-    });
-  });
-
-  describe("Both global and project snippets", () => {
-    it("should merge global and project snippets", async () => {
-      // Create global snippet
-      await writeFile(join(globalSnippetDir, "global.md"), "Global snippet content");
-
-      // Create project snippet
-      await writeFile(join(projectSnippetDir, "project.md"), "Project snippet content");
-
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("global")?.content).toBe("Global snippet content");
-      expect(snippets.get("project")?.content).toBe("Project snippet content");
-    });
-
-    it("should allow project snippets to override global snippets", async () => {
-      // Create global snippet
-      await writeFile(join(globalSnippetDir, "careful.md"), "Global careful content");
-
-      // Create project snippet with same name
-      await writeFile(join(projectSnippetDir, "careful.md"), "Project-specific careful content");
-
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      // Project snippet should override global
-      expect(snippets.get("careful")?.content).toBe("Project-specific careful content");
-      expect(snippets.size).toBe(1);
-    });
-  });
-
-  describe("Alias handling", () => {
-    it("should handle multiple aliases from different sources", async () => {
-      // Global snippet with aliases
-      await writeFile(
-        join(globalSnippetDir, "review.md"),
-        `---
-aliases:
-  - pr
-  - check
----
-Global review guidelines`,
-      );
-
-      // Project snippet with aliases
-      await writeFile(
-        join(projectSnippetDir, "test.md"),
-        `---
-aliases:
-  - tdd
-  - testing
----
-Project test guidelines`,
-      );
-
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      expect(snippets.size).toBe(6); // review, pr, check, test, tdd, testing
-      expect(snippets.get("review")?.content).toBe("Global review guidelines");
-      expect(snippets.get("pr")?.content).toBe("Global review guidelines");
-      expect(snippets.get("check")?.content).toBe("Global review guidelines");
-      expect(snippets.get("test")?.content).toBe("Project test guidelines");
-      expect(snippets.get("tdd")?.content).toBe("Project test guidelines");
-      expect(snippets.get("testing")?.content).toBe("Project test guidelines");
-    });
-
-    it("should allow project to override global aliases", async () => {
-      // Global snippet with aliases
-      await writeFile(
-        join(globalSnippetDir, "careful.md"),
-        `---
-aliases:
-  - safe
-  - cautious
----
-Global careful`,
-      );
-
-      // Project snippet with same name but different aliases
-      await writeFile(
-        join(projectSnippetDir, "careful.md"),
-        `---
-aliases: safe
----
-Project careful`,
-      );
-
-      const projectDir = join(tempDir, "project");
-      const snippets = await loadSnippets(projectDir, globalSnippetDir);
-
-      // Project should override with its aliases
-      expect(snippets.get("careful")?.content).toBe("Project careful");
-      expect(snippets.get("safe")?.content).toBe("Project careful");
-      expect(snippets.get("cautious")?.content).toBeUndefined();
-      expect(snippets.size).toBe(2);
-    });
-  });
-
-  describe("Edge cases", () => {
-    it("should handle empty snippet content", async () => {
-      await writeFile(join(globalSnippetDir, "empty.md"), "");
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-      expect(snippets.size).toBe(1);
-      expect(snippets.get("empty")?.content).toBe("");
-    });
-
-    it("should handle snippet with only metadata", async () => {
-      await writeFile(
-        join(globalSnippetDir, "metadata-only.md"),
-        `---
-description: "A snippet with only metadata"
-aliases: meta
----`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("metadata-only")?.content).toBe("");
-      expect(snippets.get("meta")?.content).toBe("");
-    });
-
-    it("should handle multiline content", async () => {
-      await writeFile(
-        join(globalSnippetDir, "multiline.md"),
-        `Line 1
-Line 2
-Line 3`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-      expect(snippets.get("multiline")?.content).toBe("Line 1\nLine 2\nLine 3");
-    });
-
-    it("should ignore non-.md files", async () => {
-      await writeFile(join(globalSnippetDir, "not-a-snippet.txt"), "This should be ignored");
-      await writeFile(join(globalSnippetDir, "valid.md"), "This should be loaded");
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-      expect(snippets.size).toBe(1);
-      expect(snippets.get("valid")?.content).toBe("This should be loaded");
-      expect(snippets.has("not-a-snippet")).toBe(false);
-    });
-
-    it("should handle invalid frontmatter", async () => {
-      await writeFile(
-        join(globalSnippetDir, "bad-frontmatter.md"),
-        `---
-invalid yaml
----
-Content`,
-      );
-
-      await writeFile(join(globalSnippetDir, "special-chars.md"), "Special content");
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-      // Should load valid snippet, skip invalid one
-      expect(snippets.get("special-chars")?.content).toBe("Special content");
-    });
-
-    it("should handle non-existent directories gracefully", async () => {
-      const snippets = await loadSnippets(undefined, "/nonexistent/path");
-      expect(snippets.size).toBe(0);
-    });
-  });
-
-  describe("Smoke test - real global snippets", () => {
-    it("should load real global snippets without crashing", async () => {
-      // This is a smoke test - just verify it doesn't crash
-      const snippets = await loadSnippets();
-
-      // We don't assert specific content since we don't control user's global snippets
-      // Just verify it returns a Map
-      expect(snippets).toBeInstanceOf(Map);
-      expect(Array.isArray(Array.from(snippets.keys()))).toBe(true);
-    });
-  });
-
-  // PR #13 requirement: accept both 'alias' and 'aliases' in frontmatter
-  describe("Frontmatter alias/aliases normalization", () => {
-    it("accepts 'alias' as string (singular form)", async () => {
-      await writeFile(
-        join(globalSnippetDir, "greeting.md"),
-        `---
-alias: hi
----
-Hello there!`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("greeting")?.content).toBe("Hello there!");
-      expect(snippets.get("hi")?.content).toBe("Hello there!");
-    });
-
-    it("accepts 'alias' as array (singular form)", async () => {
-      await writeFile(
-        join(globalSnippetDir, "greeting.md"),
-        `---
-alias:
-  - hi
-  - hello
----
-Hello there!`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(3);
-      expect(snippets.get("greeting")?.content).toBe("Hello there!");
-      expect(snippets.get("hi")?.content).toBe("Hello there!");
-      expect(snippets.get("hello")?.content).toBe("Hello there!");
-    });
-
-    it("accepts 'aliases' as string (existing behavior)", async () => {
-      await writeFile(
-        join(globalSnippetDir, "greeting.md"),
-        `---
-aliases: hi
----
-Hello there!`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("greeting")?.content).toBe("Hello there!");
-      expect(snippets.get("hi")?.content).toBe("Hello there!");
-    });
-
-    it("accepts 'aliases' as array (existing behavior)", async () => {
-      await writeFile(
-        join(globalSnippetDir, "greeting.md"),
-        `---
-aliases:
-  - hi
-  - hello
----
-Hello there!`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(3);
-      expect(snippets.get("greeting")?.content).toBe("Hello there!");
-      expect(snippets.get("hi")?.content).toBe("Hello there!");
-      expect(snippets.get("hello")?.content).toBe("Hello there!");
-    });
-
-    it("prefers 'aliases' over 'alias' if both present", async () => {
-      await writeFile(
-        join(globalSnippetDir, "greeting.md"),
-        `---
-alias: ignored
-aliases: used
----
-Hello there!`,
-      );
-
-      const snippets = await loadSnippets(undefined, globalSnippetDir);
-
-      expect(snippets.size).toBe(2);
-      expect(snippets.get("greeting")?.content).toBe("Hello there!");
-      expect(snippets.get("used")?.content).toBe("Hello there!");
-      expect(snippets.has("ignored")).toBe(false);
-    });
-  });
-});