opencode-ship 0.8.0 → 0.10.0-rc.17
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +108 -0
- package/README.md +5 -3
- package/THIRD_PARTY_NOTICES.md +77 -18
- package/assets/agents/ship-controller.md +122 -0
- package/assets/agents/ship-final-spec-reviewer.md +87 -0
- package/assets/agents/ship-final-standards-reviewer.md +83 -0
- package/assets/agents/ship-planner.md +78 -0
- package/assets/agents/ship-task-builder.md +91 -0
- package/assets/agents/ship-task-reviewer.md +78 -0
- package/assets/commands/ship-deliver.md +30 -0
- package/assets/commands/ship-resume.md +28 -0
- package/assets/commands/ship-status.md +25 -0
- package/assets/skills/brainstorming/SKILL.md +160 -0
- package/assets/skills/brainstorming/spec-document-reviewer-prompt.md +49 -0
- package/assets/skills/brainstorming/visual-companion.md +298 -0
- package/assets/skills/code-review/SKILL.md +98 -0
- package/assets/skills/codebase-design/DEEPENING.md +37 -0
- package/assets/skills/codebase-design/DESIGN-IT-TWICE.md +44 -0
- package/assets/skills/codebase-design/SKILL.md +123 -0
- package/assets/skills/dispatching-parallel-agents/SKILL.md +176 -0
- package/assets/skills/domain-modeling/ADR-FORMAT.md +47 -0
- package/assets/skills/domain-modeling/CONTEXT-FORMAT.md +60 -0
- package/assets/skills/domain-modeling/SKILL.md +83 -0
- package/assets/skills/engineering-workflow/SKILL.md +125 -0
- package/assets/skills/engineering-workflow/domain.md +51 -0
- package/assets/skills/engineering-workflow/issue-tracker-github.md +45 -0
- package/assets/skills/engineering-workflow/issue-tracker-gitlab.md +46 -0
- package/assets/skills/engineering-workflow/issue-tracker-local.md +30 -0
- package/assets/skills/engineering-workflow/triage-labels.md +15 -0
- package/assets/skills/executing-plans/SKILL.md +73 -0
- package/assets/skills/grill-with-docs/SKILL.md +10 -14
- package/assets/skills/grilling/SKILL.md +21 -0
- package/assets/skills/handoff/SKILL.md +25 -0
- package/assets/skills/prototype/LOGIC.md +79 -0
- package/assets/skills/prototype/SKILL.md +35 -0
- package/assets/skills/prototype/UI.md +112 -0
- package/assets/skills/receiving-code-review/SKILL.md +214 -0
- package/assets/skills/requesting-code-review/SKILL.md +104 -0
- package/assets/skills/requesting-code-review/code-reviewer.md +172 -0
- package/assets/skills/research/SKILL.md +21 -0
- package/assets/skills/setup-engineering-workflow/SKILL.md +125 -0
- package/assets/skills/setup-engineering-workflow/domain.md +51 -0
- package/assets/skills/setup-engineering-workflow/issue-tracker-github.md +45 -0
- package/assets/skills/setup-engineering-workflow/issue-tracker-gitlab.md +46 -0
- package/assets/skills/setup-engineering-workflow/issue-tracker-local.md +30 -0
- package/assets/skills/setup-engineering-workflow/triage-labels.md +15 -0
- package/assets/skills/subagent-driven-development/SKILL.md +512 -0
- package/assets/skills/subagent-driven-development/implementer-prompt.md +142 -0
- package/assets/skills/subagent-driven-development/re-review-prompt.md +106 -0
- package/assets/skills/subagent-driven-development/task-reviewer-prompt.md +185 -0
- package/assets/skills/systematic-debugging/CREATION-LOG.md +119 -0
- package/assets/skills/systematic-debugging/SKILL.md +292 -0
- package/assets/skills/systematic-debugging/condition-based-waiting-example.ts +158 -0
- package/assets/skills/systematic-debugging/condition-based-waiting.md +115 -0
- package/assets/skills/systematic-debugging/defense-in-depth.md +122 -0
- package/assets/skills/systematic-debugging/find-polluter.sh +72 -0
- package/assets/skills/systematic-debugging/root-cause-tracing.md +169 -0
- package/assets/skills/systematic-debugging/test-academic.md +14 -0
- package/assets/skills/systematic-debugging/test-pressure-1.md +58 -0
- package/assets/skills/systematic-debugging/test-pressure-2.md +68 -0
- package/assets/skills/systematic-debugging/test-pressure-3.md +69 -0
- package/assets/skills/test-driven-development/SKILL.md +329 -0
- package/assets/skills/test-driven-development/writing-good-tests.md +198 -0
- package/assets/skills/to-spec/SKILL.md +84 -0
- package/assets/skills/to-tickets/SKILL.md +114 -0
- package/assets/skills/triage/AGENT-BRIEF.md +207 -0
- package/assets/skills/triage/OUT-OF-SCOPE.md +105 -0
- package/assets/skills/triage/SKILL.md +114 -15
- package/assets/skills/verification-before-completion/SKILL.md +129 -0
- package/assets/skills/wayfinder/SKILL.md +137 -0
- package/assets/skills/writing-plans/SKILL.md +177 -0
- package/assets/skills/writing-plans/plan-document-reviewer-prompt.md +49 -0
- package/dist/cli.js +1146 -435
- package/dist/core.js +210 -61
- package/dist/plugin.js +2368 -230
- package/package.json +3 -1
- package/schema/ship-config.schema.json +63 -2
- package/schema/ship-lock.schema.json +5 -3
- package/tests/plugin/plugin-load.test.mjs +85 -0
- package/vendor/mattpocock/LICENSE +30 -0
- package/vendor/obra/LICENSE +30 -0
- package/vendor/sources.json +976 -0
- package/vendor/superpowers/LICENSE +30 -0
- package/vendor/upstreams/mattpocock/skills/engineering/code-review/SKILL.md +89 -0
- package/vendor/upstreams/mattpocock/skills/engineering/codebase-design/DEEPENING.md +37 -0
- package/vendor/upstreams/mattpocock/skills/engineering/codebase-design/DESIGN-IT-TWICE.md +44 -0
- package/vendor/upstreams/mattpocock/skills/engineering/codebase-design/SKILL.md +114 -0
- package/vendor/upstreams/mattpocock/skills/engineering/domain-modeling/ADR-FORMAT.md +47 -0
- package/vendor/upstreams/mattpocock/skills/engineering/domain-modeling/CONTEXT-FORMAT.md +60 -0
- package/vendor/upstreams/mattpocock/skills/engineering/domain-modeling/SKILL.md +74 -0
- package/vendor/upstreams/mattpocock/skills/engineering/grill-with-docs/SKILL.md +7 -0
- package/vendor/upstreams/mattpocock/skills/engineering/prototype/LOGIC.md +79 -0
- package/vendor/upstreams/mattpocock/skills/engineering/prototype/SKILL.md +26 -0
- package/vendor/upstreams/mattpocock/skills/engineering/prototype/UI.md +112 -0
- package/vendor/upstreams/mattpocock/skills/engineering/research/SKILL.md +12 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/SKILL.md +116 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/domain.md +51 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/issue-tracker-github.md +45 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/issue-tracker-gitlab.md +46 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/issue-tracker-local.md +30 -0
- package/vendor/upstreams/mattpocock/skills/engineering/setup-matt-pocock-skills/triage-labels.md +15 -0
- package/vendor/upstreams/mattpocock/skills/engineering/to-spec/SKILL.md +75 -0
- package/vendor/upstreams/mattpocock/skills/engineering/to-tickets/SKILL.md +105 -0
- package/vendor/upstreams/mattpocock/skills/engineering/triage/AGENT-BRIEF.md +207 -0
- package/vendor/upstreams/mattpocock/skills/engineering/triage/OUT-OF-SCOPE.md +105 -0
- package/vendor/upstreams/mattpocock/skills/engineering/triage/SKILL.md +112 -0
- package/vendor/upstreams/mattpocock/skills/engineering/wayfinder/SKILL.md +128 -0
- package/vendor/upstreams/mattpocock/skills/productivity/grilling/SKILL.md +12 -0
- package/vendor/upstreams/mattpocock/skills/productivity/handoff/SKILL.md +16 -0
- package/vendor/upstreams/obra/skills/brainstorming/SKILL.md +151 -0
- package/vendor/upstreams/obra/skills/brainstorming/spec-document-reviewer-prompt.md +49 -0
- package/vendor/upstreams/obra/skills/brainstorming/visual-companion.md +298 -0
- package/vendor/upstreams/obra/skills/dispatching-parallel-agents/SKILL.md +167 -0
- package/vendor/upstreams/obra/skills/executing-plans/SKILL.md +64 -0
- package/vendor/upstreams/obra/skills/receiving-code-review/SKILL.md +205 -0
- package/vendor/upstreams/obra/skills/requesting-code-review/SKILL.md +95 -0
- package/vendor/upstreams/obra/skills/requesting-code-review/code-reviewer.md +172 -0
- package/vendor/upstreams/obra/skills/subagent-driven-development/SKILL.md +503 -0
- package/vendor/upstreams/obra/skills/subagent-driven-development/implementer-prompt.md +142 -0
- package/vendor/upstreams/obra/skills/subagent-driven-development/re-review-prompt.md +106 -0
- package/vendor/upstreams/obra/skills/subagent-driven-development/task-reviewer-prompt.md +185 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/CREATION-LOG.md +119 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/SKILL.md +283 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/condition-based-waiting-example.ts +158 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/condition-based-waiting.md +115 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/defense-in-depth.md +122 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/find-polluter.sh +72 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/root-cause-tracing.md +169 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/test-academic.md +14 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/test-pressure-1.md +58 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/test-pressure-2.md +68 -0
- package/vendor/upstreams/obra/skills/systematic-debugging/test-pressure-3.md +69 -0
- package/vendor/upstreams/obra/skills/test-driven-development/SKILL.md +320 -0
- package/vendor/upstreams/obra/skills/test-driven-development/writing-good-tests.md +198 -0
- package/vendor/upstreams/obra/skills/verification-before-completion/SKILL.md +120 -0
- package/vendor/upstreams/obra/skills/writing-plans/SKILL.md +168 -0
- package/vendor/upstreams/obra/skills/writing-plans/plan-document-reviewer-prompt.md +49 -0
|
@@ -0,0 +1,105 @@
|
|
|
1
|
+
# Out-of-Scope Knowledge Base
|
|
2
|
+
|
|
3
|
+
The `.out-of-scope/` directory in a repo stores persistent records of rejected feature requests. It serves two purposes:
|
|
4
|
+
|
|
5
|
+
1. **Institutional memory** — why a feature was rejected, so the reasoning isn't lost when the issue is closed
|
|
6
|
+
2. **Deduplication** — when a new issue comes in that matches a prior rejection, the skill can surface the previous decision instead of re-litigating it
|
|
7
|
+
|
|
8
|
+
## Directory structure
|
|
9
|
+
|
|
10
|
+
```
|
|
11
|
+
.out-of-scope/
|
|
12
|
+
├── dark-mode.md
|
|
13
|
+
├── plugin-system.md
|
|
14
|
+
└── graphql-api.md
|
|
15
|
+
```
|
|
16
|
+
|
|
17
|
+
One file per **concept**, not per issue. Multiple issues requesting the same thing are grouped under one file.
|
|
18
|
+
|
|
19
|
+
## File format
|
|
20
|
+
|
|
21
|
+
The file should be written in a relaxed, readable style — more like a short design document than a database entry. Use paragraphs, code samples, and examples to make the reasoning clear and useful to someone encountering it for the first time.
|
|
22
|
+
|
|
23
|
+
```markdown
|
|
24
|
+
# Dark Mode
|
|
25
|
+
|
|
26
|
+
This project does not support dark mode or user-facing theming.
|
|
27
|
+
|
|
28
|
+
## Why this is out of scope
|
|
29
|
+
|
|
30
|
+
The rendering pipeline assumes a single color palette defined in
|
|
31
|
+
`ThemeConfig`. Supporting multiple themes would require:
|
|
32
|
+
|
|
33
|
+
- A theme context provider wrapping the entire component tree
|
|
34
|
+
- Per-component theme-aware style resolution
|
|
35
|
+
- A persistence layer for user theme preferences
|
|
36
|
+
|
|
37
|
+
This is a significant architectural change that doesn't align with the
|
|
38
|
+
project's focus on content authoring. Theming is a concern for downstream
|
|
39
|
+
consumers who embed or redistribute the output.
|
|
40
|
+
|
|
41
|
+
```ts
|
|
42
|
+
// The current ThemeConfig interface is not designed for runtime switching:
|
|
43
|
+
interface ThemeConfig {
|
|
44
|
+
colors: ColorPalette; // single palette, resolved at build time
|
|
45
|
+
fonts: FontStack;
|
|
46
|
+
}
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
## Prior requests
|
|
50
|
+
|
|
51
|
+
- #42 — "Add dark mode support"
|
|
52
|
+
- #87 — "Night theme for accessibility"
|
|
53
|
+
- #134 — "Dark theme option"
|
|
54
|
+
```
|
|
55
|
+
|
|
56
|
+
### Naming the file
|
|
57
|
+
|
|
58
|
+
Use a short, descriptive kebab-case name for the concept: `dark-mode.md`, `plugin-system.md`, `graphql-api.md`. The name should be recognizable enough that someone browsing the directory understands what was rejected without opening the file.
|
|
59
|
+
|
|
60
|
+
### Writing the reason
|
|
61
|
+
|
|
62
|
+
The reason should be substantive — not "we don't want this" but why. Good reasons reference:
|
|
63
|
+
|
|
64
|
+
- Project scope or philosophy ("This project focuses on X; theming is a downstream concern")
|
|
65
|
+
- Technical constraints ("Supporting this would require Y, which conflicts with our Z architecture")
|
|
66
|
+
- Strategic decisions ("We chose to use A instead of B because...")
|
|
67
|
+
|
|
68
|
+
The reason should be durable. Avoid referencing temporary circumstances ("we're too busy right now") — those aren't real rejections, they're deferrals.
|
|
69
|
+
|
|
70
|
+
## When to check `.out-of-scope/`
|
|
71
|
+
|
|
72
|
+
During triage (Step 1: Gather context), read all files in `.out-of-scope/`. When evaluating a new issue:
|
|
73
|
+
|
|
74
|
+
- Check if the request matches an existing out-of-scope concept
|
|
75
|
+
- Matching is by concept similarity, not keyword — "night theme" matches `dark-mode.md`
|
|
76
|
+
- If there's a match, surface it to the maintainer: "This is similar to `.out-of-scope/dark-mode.md` — we rejected this before because [reason]. Do you still feel the same way?"
|
|
77
|
+
|
|
78
|
+
The maintainer may:
|
|
79
|
+
|
|
80
|
+
- **Confirm** — the new issue gets added to the existing file's "Prior requests" list, then closed
|
|
81
|
+
- **Reconsider** — the out-of-scope file gets deleted or updated, and the issue proceeds through normal triage
|
|
82
|
+
- **Disagree** — the issues are related but distinct, proceed with normal triage
|
|
83
|
+
|
|
84
|
+
## When to write to `.out-of-scope/`
|
|
85
|
+
|
|
86
|
+
Only when an **enhancement** (not a bug) is *rejected* as `wontfix`. This applies to enhancement PRs exactly as it does to issues — a rejected PR is recorded here so the same request doesn't return as fresh code.
|
|
87
|
+
|
|
88
|
+
Do **not** write here when something is closed as `wontfix` because it's **already implemented**. That's a built feature, not a rejected one; recording it would poison the dedup checks with false rejections. Instead, the closing comment points to where the feature already lives.
|
|
89
|
+
|
|
90
|
+
The flow:
|
|
91
|
+
|
|
92
|
+
1. Maintainer decides a feature request is out of scope
|
|
93
|
+
2. Check if a matching `.out-of-scope/` file already exists
|
|
94
|
+
3. If yes: append the new issue to the "Prior requests" list
|
|
95
|
+
4. If no: create a new file with the concept name, decision, reason, and first prior request
|
|
96
|
+
5. Post a comment on the issue explaining the decision and mentioning the `.out-of-scope/` file
|
|
97
|
+
6. Close the issue with the `wontfix` label
|
|
98
|
+
|
|
99
|
+
## Updating or removing out-of-scope files
|
|
100
|
+
|
|
101
|
+
If the maintainer changes their mind about a previously rejected concept:
|
|
102
|
+
|
|
103
|
+
- Delete the `.out-of-scope/` file
|
|
104
|
+
- The skill does not need to reopen old issues — they're historical records
|
|
105
|
+
- The new issue that triggered the reconsideration proceeds through normal triage
|
|
@@ -1,22 +1,121 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: triage
|
|
3
|
-
description:
|
|
4
|
-
|
|
5
|
-
Use this skill first on every new issue or unplanned
|
|
6
|
-
work item. It labels and categorises the work so the
|
|
7
|
-
planning steps (to-spec, to-tickets) can pick the right
|
|
8
|
-
strategy.
|
|
3
|
+
description: Move issues and external PRs through a state machine of triage roles — categorise, verify, grill if needed, and write agent-ready briefs.
|
|
4
|
+
disable-model-invocation: true
|
|
9
5
|
---
|
|
10
6
|
|
|
11
7
|
# Triage
|
|
12
8
|
|
|
13
|
-
|
|
14
|
-
profile expects every new issue to be triaged before the spec
|
|
15
|
-
step. Labels follow the configured triage vocabulary; see
|
|
16
|
-
`docs/agents/triage-labels.md` for the consumer's vocabulary
|
|
17
|
-
override.
|
|
9
|
+
Move issues on the project issue tracker through a small state machine of triage roles.
|
|
18
10
|
|
|
19
|
-
|
|
20
|
-
|
|
21
|
-
|
|
22
|
-
|
|
11
|
+
If this repo treats external pull requests as a request surface (see the issue-tracker config), triage covers them too: **a PR is an issue with attached code** — same roles, same states, same machine, with a few deltas marked "for a PR" below. Resolve a bare `#42` to an issue or PR per the tracker config.
|
|
12
|
+
|
|
13
|
+
Every comment or issue posted to the issue tracker during triage **must** start with this disclaimer:
|
|
14
|
+
|
|
15
|
+
```
|
|
16
|
+
> *This was generated by AI during triage.*
|
|
17
|
+
```
|
|
18
|
+
|
|
19
|
+
## Reference docs
|
|
20
|
+
|
|
21
|
+
- [AGENT-BRIEF.md](AGENT-BRIEF.md) — how to write durable agent briefs
|
|
22
|
+
- [OUT-OF-SCOPE.md](OUT-OF-SCOPE.md) — how the `.out-of-scope/` knowledge base works
|
|
23
|
+
|
|
24
|
+
## Roles
|
|
25
|
+
|
|
26
|
+
Two **category** roles:
|
|
27
|
+
|
|
28
|
+
- `bug` — something is broken
|
|
29
|
+
- `enhancement` — new feature or improvement
|
|
30
|
+
|
|
31
|
+
Five **state** roles:
|
|
32
|
+
|
|
33
|
+
- `needs-triage` — maintainer needs to evaluate
|
|
34
|
+
- `needs-info` — waiting on reporter for more information
|
|
35
|
+
- `ready-for-agent` — fully specified, ready for an AFK agent
|
|
36
|
+
- `ready-for-human` — needs human implementation
|
|
37
|
+
- `wontfix` — will not be actioned
|
|
38
|
+
|
|
39
|
+
For a PR, the same states read against the attached code: `ready-for-agent` means a brief is attached and an agent should take the next step on the diff; `ready-for-human` means it's ready for a human to merge.
|
|
40
|
+
|
|
41
|
+
Every triaged issue should carry exactly one category role and one state role. If state roles conflict, flag it and ask the maintainer before doing anything else.
|
|
42
|
+
|
|
43
|
+
These are canonical role names — the actual label strings used in the issue tracker may differ. The mapping should have been provided to you - run `/setup-matt-pocock-skills` if not.
|
|
44
|
+
|
|
45
|
+
State transitions: an unlabeled issue normally goes to `needs-triage` first; from there it moves to `needs-info`, `ready-for-agent`, `ready-for-human`, or `wontfix`. `needs-info` returns to `needs-triage` once the reporter replies. The maintainer can override at any time — flag transitions that look unusual and ask before proceeding.
|
|
46
|
+
|
|
47
|
+
## Invocation
|
|
48
|
+
|
|
49
|
+
The maintainer invokes `/triage` and describes what they want in natural language. Interpret the request and act. Examples:
|
|
50
|
+
|
|
51
|
+
- "Show me anything that needs my attention"
|
|
52
|
+
- "Let's look at #42" (issue or PR)
|
|
53
|
+
- "Move #42 to ready-for-agent"
|
|
54
|
+
- "What's ready for agents to pick up?"
|
|
55
|
+
|
|
56
|
+
## Show what needs attention
|
|
57
|
+
|
|
58
|
+
Query the issue tracker and present three buckets, oldest first:
|
|
59
|
+
|
|
60
|
+
1. **Unlabeled** — never triaged.
|
|
61
|
+
2. **`needs-triage`** — evaluation in progress.
|
|
62
|
+
3. **`needs-info` with reporter activity since the last triage notes** — needs re-evaluation.
|
|
63
|
+
|
|
64
|
+
When PRs are in scope, include external PRs in these buckets and tag each line `[PR]` or `[issue]`. Discovery surfaces only *external* PRs (the tracker config defines who counts as external) — a collaborator's in-flight PR is not triage work. This filter is discovery-only; an explicitly named PR is always triaged regardless of author.
|
|
65
|
+
|
|
66
|
+
Show counts and a one-line summary per item. Let the maintainer pick.
|
|
67
|
+
|
|
68
|
+
## Triage a specific issue or PR
|
|
69
|
+
|
|
70
|
+
1. **Gather context.** Read the full issue or PR (body, comments, labels, author, dates; for a PR, the diff too). Parse any prior triage notes so you don't re-ask resolved questions. Explore the codebase using the project's domain glossary, respecting ADRs in the area. Run two checks against the codebase: (a) **redundancy** — search for an existing implementation of the requested behavior by domain concept (not just the request's wording), and report where you looked. If found, it's an already-implemented `wontfix` (step 5). (b) **prior rejection** — read `.out-of-scope/*.md` and surface any that resembles this request.
|
|
71
|
+
|
|
72
|
+
2. **Recommend.** Tell the maintainer your category and state recommendation with reasoning, plus a brief codebase summary relevant to the request — including whether it's already implemented. Wait for direction.
|
|
73
|
+
|
|
74
|
+
3. **Verify the claim.** Before any grilling, check that the claim holds up. For a bug, reproduce it from the reporter's steps. For a PR, confirm the diff does what it claims — check it out, run the relevant tests or commands. Report what happened: confirmed (with code path), failed, or insufficient detail (a strong `needs-info` signal). A confirmed verification makes a much stronger agent brief.
|
|
75
|
+
|
|
76
|
+
4. **Grill (if needed).** If the request needs fleshing out, run the `/grilling` and `/domain-modeling` skills together — grill it into shape one question at a time, sharpening domain terms and updating `CONTEXT.md`/ADRs inline as decisions land.
|
|
77
|
+
|
|
78
|
+
5. **Apply the outcome:**
|
|
79
|
+
- `ready-for-agent` — post an agent brief comment ([AGENT-BRIEF.md](AGENT-BRIEF.md)).
|
|
80
|
+
- `ready-for-human` — same structure as an agent brief, but note why it can't be delegated (judgment calls, external access, design decisions, manual testing).
|
|
81
|
+
- `needs-info` — post triage notes (template below).
|
|
82
|
+
- `wontfix` — close, with the comment depending on *why*:
|
|
83
|
+
- **Already implemented** — the change already exists in the codebase. Point to where it lives; do **not** write to `.out-of-scope/` (that KB is for *rejected* requests, not built ones).
|
|
84
|
+
- **Rejected (bug)** — polite explanation, then close.
|
|
85
|
+
- **Rejected (enhancement)** — write to `.out-of-scope/`, link to it from a comment, then close ([OUT-OF-SCOPE.md](OUT-OF-SCOPE.md)).
|
|
86
|
+
- `needs-triage` — apply the role. Optional comment if there's partial progress.
|
|
87
|
+
|
|
88
|
+
## Quick state override
|
|
89
|
+
|
|
90
|
+
If the maintainer says "move #42 to ready-for-agent", trust them and apply the role directly. Confirm what you're about to do (role changes, comment, close), then act. Skip grilling. If moving to `ready-for-agent` without a grilling session, ask whether they want to write an agent brief.
|
|
91
|
+
|
|
92
|
+
## Needs-info template
|
|
93
|
+
|
|
94
|
+
```markdown
|
|
95
|
+
## Triage Notes
|
|
96
|
+
|
|
97
|
+
**What we've established so far:**
|
|
98
|
+
|
|
99
|
+
- point 1
|
|
100
|
+
- point 2
|
|
101
|
+
|
|
102
|
+
**What we still need from you (@reporter):**
|
|
103
|
+
|
|
104
|
+
- question 1
|
|
105
|
+
- question 2
|
|
106
|
+
```
|
|
107
|
+
|
|
108
|
+
Capture everything resolved during grilling under "established so far" so the work isn't lost. Questions must be specific and actionable, not "please provide more info".
|
|
109
|
+
|
|
110
|
+
## Resuming a previous session
|
|
111
|
+
|
|
112
|
+
If prior triage notes exist on the issue or PR, read them, check whether the reporter has answered any outstanding questions, and present an updated picture before continuing. Don't re-ask resolved questions.
|
|
113
|
+
|
|
114
|
+
## Ship integration
|
|
115
|
+
|
|
116
|
+
This skill is part of the engineering profile shipped by
|
|
117
|
+
`opencode-ship@1.0`. The strong planner child session is
|
|
118
|
+
configured with `openai/gpt-5.6-sol` and the durable workflow
|
|
119
|
+
state lives under `<git-common-dir>/opencode-ship/`. All
|
|
120
|
+
GitHub mutations go through Ship's typed tools; never use
|
|
121
|
+
`gh api` or raw shell.
|
|
@@ -0,0 +1,129 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: verification-before-completion
|
|
3
|
+
description: Use when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always
|
|
4
|
+
---
|
|
5
|
+
|
|
6
|
+
# Verification Before Completion
|
|
7
|
+
|
|
8
|
+
## Overview
|
|
9
|
+
|
|
10
|
+
**Core principle:** Evidence before claims, always.
|
|
11
|
+
|
|
12
|
+
**Violating the letter of this rule is violating the spirit of this rule.**
|
|
13
|
+
|
|
14
|
+
## The Iron Law
|
|
15
|
+
|
|
16
|
+
```
|
|
17
|
+
NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE
|
|
18
|
+
```
|
|
19
|
+
|
|
20
|
+
If you haven't run the verification command in this message, you cannot claim it passes.
|
|
21
|
+
|
|
22
|
+
## The Gate Function
|
|
23
|
+
|
|
24
|
+
```
|
|
25
|
+
BEFORE claiming any status or expressing satisfaction:
|
|
26
|
+
|
|
27
|
+
1. IDENTIFY: What command proves this claim?
|
|
28
|
+
2. RUN: Execute the FULL command (fresh, complete)
|
|
29
|
+
3. READ: Full output, check exit code, count failures
|
|
30
|
+
4. VERIFY: Does output confirm the claim?
|
|
31
|
+
- If NO: State actual status with evidence
|
|
32
|
+
- If YES: State claim WITH evidence
|
|
33
|
+
5. ONLY THEN: Make the claim
|
|
34
|
+
|
|
35
|
+
Skip any step = lying, not verifying
|
|
36
|
+
```
|
|
37
|
+
|
|
38
|
+
## Common Failures
|
|
39
|
+
|
|
40
|
+
| Claim | Requires | Not Sufficient |
|
|
41
|
+
|-------|----------|----------------|
|
|
42
|
+
| Tests pass | Test command output: 0 failures | Previous run, "should pass" |
|
|
43
|
+
| Linter clean | Linter output: 0 errors | Partial check, extrapolation |
|
|
44
|
+
| Build succeeds | Build command: exit 0 | Linter passing, logs look good |
|
|
45
|
+
| Bug fixed | Test original symptom: passes | Code changed, assumed fixed |
|
|
46
|
+
| Regression test works | Red-green cycle verified | Test passes once |
|
|
47
|
+
| Agent completed | VCS diff shows changes | Agent reports "success" |
|
|
48
|
+
| Requirements met | Line-by-line checklist | Tests passing |
|
|
49
|
+
|
|
50
|
+
## Red Flags - STOP
|
|
51
|
+
|
|
52
|
+
- Using "should", "probably", "seems to"
|
|
53
|
+
- Expressing satisfaction before verification ("Great!", "Perfect!", "Done!", etc.)
|
|
54
|
+
- About to commit/push/PR without verification
|
|
55
|
+
- Trusting agent success reports
|
|
56
|
+
- Relying on partial verification
|
|
57
|
+
- Thinking "just this once"
|
|
58
|
+
- Tired and wanting work over
|
|
59
|
+
- **ANY wording implying success without having run verification**
|
|
60
|
+
|
|
61
|
+
## Rationalization Prevention
|
|
62
|
+
|
|
63
|
+
| Excuse | Reality |
|
|
64
|
+
|--------|---------|
|
|
65
|
+
| "Should work now" | RUN the verification |
|
|
66
|
+
| "I'm confident" | Confidence ≠ evidence |
|
|
67
|
+
| "Just this once" | No exceptions |
|
|
68
|
+
| "Linter passed" | Linter ≠ compiler |
|
|
69
|
+
| "Agent said success" | Verify independently |
|
|
70
|
+
| "I'm tired" | Exhaustion ≠ excuse |
|
|
71
|
+
| "Partial check is enough" | Partial proves nothing |
|
|
72
|
+
| "Different words so rule doesn't apply" | Spirit over letter |
|
|
73
|
+
|
|
74
|
+
## Key Patterns
|
|
75
|
+
|
|
76
|
+
**Tests:**
|
|
77
|
+
```
|
|
78
|
+
✅ [Run test command] [See: 34/34 pass] "All tests pass"
|
|
79
|
+
❌ "Should pass now" / "Looks correct"
|
|
80
|
+
```
|
|
81
|
+
|
|
82
|
+
**Regression tests (TDD Red-Green):**
|
|
83
|
+
```
|
|
84
|
+
✅ Write → Run (pass) → Revert fix → Run (MUST FAIL) → Restore → Run (pass)
|
|
85
|
+
❌ "I've written a regression test" (without red-green verification)
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
**Build:**
|
|
89
|
+
```
|
|
90
|
+
✅ [Run build] [See: exit 0] "Build passes"
|
|
91
|
+
❌ "Linter passed" (linter doesn't check compilation)
|
|
92
|
+
```
|
|
93
|
+
|
|
94
|
+
**Requirements:**
|
|
95
|
+
```
|
|
96
|
+
✅ Re-read plan → Create checklist → Verify each → Report gaps or completion
|
|
97
|
+
❌ "Tests pass, phase complete"
|
|
98
|
+
```
|
|
99
|
+
|
|
100
|
+
**Agent delegation:**
|
|
101
|
+
```
|
|
102
|
+
✅ Agent reports success → Check VCS diff → Verify changes → Report actual state
|
|
103
|
+
❌ Trust agent report
|
|
104
|
+
```
|
|
105
|
+
|
|
106
|
+
## When To Apply
|
|
107
|
+
|
|
108
|
+
**ALWAYS before:**
|
|
109
|
+
- ANY variation of success/completion claims
|
|
110
|
+
- ANY expression of satisfaction
|
|
111
|
+
- ANY positive statement about work state
|
|
112
|
+
- Committing, PR creation, task completion
|
|
113
|
+
- Moving to next task
|
|
114
|
+
- Delegating to agents
|
|
115
|
+
|
|
116
|
+
**Rule applies to:**
|
|
117
|
+
- Exact phrases
|
|
118
|
+
- Paraphrases and synonyms
|
|
119
|
+
- Implications of success
|
|
120
|
+
- ANY communication suggesting completion/correctness
|
|
121
|
+
|
|
122
|
+
## Ship integration
|
|
123
|
+
|
|
124
|
+
This skill is part of the engineering profile shipped by
|
|
125
|
+
`opencode-ship@1.0`. Execution is driven by the deterministic
|
|
126
|
+
Ship controller; the cheap builder (`minimax/MiniMax-M3`) cannot
|
|
127
|
+
commit, push, mutate GitHub, mark Ready, or merge. The
|
|
128
|
+
verification-before-completion rule is enforced by
|
|
129
|
+
`delivery_verify`, not by the model self-asserting completion.
|
|
@@ -0,0 +1,137 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: wayfinder
|
|
3
|
+
description: Plan a huge chunk of work — more than one agent session can hold — as a shared map of decision tickets on your issue tracker, and resolve them one at a time until the way to the destination is clear.
|
|
4
|
+
disable-model-invocation: true
|
|
5
|
+
---
|
|
6
|
+
|
|
7
|
+
A loose idea has arrived — too big for one agent session, and wrapped in fog: the way from here to the **destination** isn't visible yet. Wayfinding is about finding that way, not charging at the destination. This skill charts the way as a **shared map** on the repo's issue tracker, then works its **decision tickets** — questions whose resolution is a decision, not slices of a build to execute — one at a time until the route is clear.
|
|
8
|
+
|
|
9
|
+
The destination varies per effort, and naming it is the first act of charting — it shapes every ticket. It might be a spec to hand off and iterate on, a decision to lock before planning starts, or a change made in place like a data-structure migration. The map is domain-agnostic — engineering work, course content, whatever fits the shape.
|
|
10
|
+
|
|
11
|
+
## Plan, don't do
|
|
12
|
+
|
|
13
|
+
Wayfinder is **planning** by default: each ticket resolves a decision, and the map is done when the way is clear — nothing left to decide before someone goes and does the thing. The pull to just do the work is usually the signal you've reached the edge of the map and it's time to hand off. An effort can override this in its **Notes** — carrying execution into the map itself — but absent that, produce decisions, not deliverables.
|
|
14
|
+
|
|
15
|
+
## Refer by name
|
|
16
|
+
|
|
17
|
+
Every map and ticket is an issue, so it has a **name** — its title. In everything the human reads — narration, the map's Decisions-so-far — refer to it by that name, never by a bare id, number, or slug. A wall of `#42, #43, #44` is illegible; names read at a glance. The id and URL don't vanish — a name wraps its link — but they ride *inside* the name, never stand in for it.
|
|
18
|
+
|
|
19
|
+
## The Map
|
|
20
|
+
|
|
21
|
+
The map is a single issue on this repo's issue tracker, labelled `wayfinder:map` — the canonical artifact. Its tickets are child issues of the map.
|
|
22
|
+
|
|
23
|
+
The map is an **index**, not a store. It lists the decisions made and points at the tickets that hold their detail; a decision lives in exactly one place — its ticket — so the map never restates it, only gists it and links.
|
|
24
|
+
|
|
25
|
+
**Where the map, its child tickets, blocking, and frontier queries physically live is tracker-specific.** The issue tracker should have been provided to you — run `/setup-matt-pocock-skills` if not. Consult the tracker doc's "Wayfinding operations" section for how _this_ repo expresses them. If no tracker has been provided, default to the local-markdown tracker.
|
|
26
|
+
|
|
27
|
+
### The map body
|
|
28
|
+
|
|
29
|
+
The whole map at low resolution, loaded once per session. Open tickets are **not** listed — they are open child issues, found by query.
|
|
30
|
+
|
|
31
|
+
```markdown
|
|
32
|
+
## Destination
|
|
33
|
+
|
|
34
|
+
<what reaching the end of this map looks like — the spec, decision, or change this effort is finding its way to. One or two lines; every session orients to it before choosing a ticket.>
|
|
35
|
+
|
|
36
|
+
## Notes
|
|
37
|
+
|
|
38
|
+
<domain; skills every session should consult; standing preferences for this effort>
|
|
39
|
+
|
|
40
|
+
## Decisions so far
|
|
41
|
+
|
|
42
|
+
<!-- the index — one line per closed ticket: enough to judge relevance, then zoom the link for the detail the ticket holds -->
|
|
43
|
+
|
|
44
|
+
- [<closed ticket title>](link) — <one-line gist of the answer>
|
|
45
|
+
|
|
46
|
+
## Not yet specified
|
|
47
|
+
|
|
48
|
+
<!-- see "Fog of war": in-scope fog you can't ticket yet; graduates as the frontier advances -->
|
|
49
|
+
|
|
50
|
+
## Out of scope
|
|
51
|
+
|
|
52
|
+
<!-- see "Out of scope": work ruled beyond the destination; closed, never graduates -->
|
|
53
|
+
```
|
|
54
|
+
|
|
55
|
+
### Tickets
|
|
56
|
+
|
|
57
|
+
Each ticket is a **child issue** of the map; the tracker's issue id is its identity. Its body is the question, sized to one 100K token agent session:
|
|
58
|
+
|
|
59
|
+
```markdown
|
|
60
|
+
## Question
|
|
61
|
+
|
|
62
|
+
<the decision or investigation this ticket resolves>
|
|
63
|
+
```
|
|
64
|
+
|
|
65
|
+
Each ticket carries a `wayfinder:<type>` label — one of `research`, `prototype`, `grilling`, `task` (see [Ticket Types](#ticket-types)).
|
|
66
|
+
|
|
67
|
+
A session **claims** a ticket by assigning it to the dev driving the map, **first**, before any work, so concurrent sessions skip it. That assignee _is_ the claim: an open, unassigned ticket is unclaimed.
|
|
68
|
+
|
|
69
|
+
Blocking uses the tracker's **native** dependency relationship — essential because it renders the frontier _visually_ in the tracker's own UI, so the human sees what's takeable without opening the map. Only a tracker that lacks native blocking falls back to a body convention. A ticket is **unblocked** when every ticket blocking it is closed; the **frontier** is the open, unblocked, unclaimed children — the edge of the known.
|
|
70
|
+
|
|
71
|
+
The answer isn't part of the body — it's recorded on resolution (see [Work through the map](#work-through-the-map)). Assets created while resolving a ticket are linked from the issue, not pasted in.
|
|
72
|
+
|
|
73
|
+
## Ticket Types
|
|
74
|
+
|
|
75
|
+
Every ticket is either **HITL** — human in the loop, worked *with* a human who speaks for themselves — or **AFK**, driven by the agent alone. A HITL ticket only resolves through that live exchange; the agent never stands in for the human's side of it (a grilling agent that answers its own questions has broken this).
|
|
76
|
+
|
|
77
|
+
- **Research** (AFK): Reading documentation, third-party APIs, or local resources like knowledge bases to surface a fact a decision waits on. Resolved by a `/research` **subagent**. Use when knowledge outside the current working directory is required.
|
|
78
|
+
- **Prototype** (HITL): Raise the fidelity of the discussion by making a cheap, rough, concrete artifact to react to — an outline, a rough take, a stub, or UI/logic code via the /prototype skill. Links the prototype as an asset. Use when "how should it look" or "how should it behave" is the key question.
|
|
79
|
+
- **Grilling** (HITL): Conversation via the /grilling and /domain-modeling skills, one question at a time. The default case.
|
|
80
|
+
- **Task** (HITL or AFK): Manual work that must happen before a *decision* can be made — nothing to decide, prototype, or research, but the discussion is blocked until it's done. Signing up for a service so its API can be judged, provisioning access, moving data so its shape can be seen. This is the one type that *does* rather than decides — and it earns its place by unblocking a decision, not by delivering the destination. The agent drives it alone where it can (AFK); otherwise it hands the human a precise checklist (HITL). Resolved when the work is done; the answer records what was done and any resulting facts (credentials location, new URLs, row counts) later tickets depend on.
|
|
81
|
+
|
|
82
|
+
## Fog of war
|
|
83
|
+
|
|
84
|
+
The map is _deliberately_ incomplete: don't chart what you can't yet see. Beyond the live tickets lies the **fog of war** — the dim view of decisions and investigations you can tell are coming but can't yet pin down, because they hang on questions still open. Resolving a ticket clears the fog ahead of it, graduating whatever's now specifiable into fresh tickets — one at a time, until the way to the destination is clear and no tickets remain.
|
|
85
|
+
|
|
86
|
+
The map's **Not yet specified** section is where that dim view is written down: the suspected question, the area to revisit later. It's the undiscovered frontier _toward_ the destination — everything here is in scope, just not sharp enough to ticket. Write as loosely or as fully as the view allows; it doubles as a signpost for collaborators reading where the effort is headed.
|
|
87
|
+
|
|
88
|
+
**Fog or ticket?** The test is whether you can state the question precisely now — _not_ whether you can answer it now.
|
|
89
|
+
|
|
90
|
+
- **Ticket when** the question is already sharp — even if it's blocked and you can't act on it yet.
|
|
91
|
+
- **Not yet specified when** you can't yet phrase it that sharply. Don't pre-slice the fog into ticket-sized pieces: it's coarser than a ticket, and one patch may graduate into several tickets, or none, once the frontier reaches it.
|
|
92
|
+
|
|
93
|
+
**Not yet specified** excludes what's already decided (Decisions so far), what's already a live ticket, and what's out of scope (the next section).
|
|
94
|
+
|
|
95
|
+
## Out of scope
|
|
96
|
+
|
|
97
|
+
Fog only ever gathers _toward_ the destination. The destination fixes the scope, so work beyond it is **out of scope** — it isn't fog, and it doesn't belong in **Not yet specified**. It gets its own **Out of scope** section on the map: work you've consciously ruled out of _this_ effort. Scope, not sharpness, lands it here.
|
|
98
|
+
|
|
99
|
+
Out-of-scope work never graduates — the frontier stops at the destination — so it returns only if the destination is redrawn, and then as a fresh effort, not a resumption.
|
|
100
|
+
|
|
101
|
+
Ruling something out of scope is a scoping act, not a step on the route. When a ticket that already exists turns out to sit past the destination — mis-scoped in while charting, or exposed by a resolution — **close it** (a closed ticket is unambiguously off the frontier) and leave one line in the **Out of scope** section: the gist plus why it's out of scope, linking the closed ticket. It stays out of **Decisions so far**, which records the route actually walked — a scope boundary isn't a step on it.
|
|
102
|
+
|
|
103
|
+
## Invocation
|
|
104
|
+
|
|
105
|
+
Two modes. Either way, **never resolve more than one ticket per session** — with the exception of research tickets.
|
|
106
|
+
|
|
107
|
+
### Chart the map
|
|
108
|
+
|
|
109
|
+
User invokes with a loose idea.
|
|
110
|
+
|
|
111
|
+
1. **Name the destination.** Run a `/grilling` and `/domain-modeling` session to pin down what this map is finding its way to — the spec, decision, or change. The destination fixes the scope, so it's settled first.
|
|
112
|
+
2. **Map the frontier.** Grill again, **breadth-first** this time: fan out across the whole space rather than deep on any one thread, surfacing the open decisions and the first steps takeable now. **If this surfaces no fog** — the way to the destination is already clear, the whole journey small enough for one session — you don't need a map. Stop and ask the user how they'd like to proceed.
|
|
113
|
+
3. **Create the map** (label `wayfinder:map`): Destination and Notes filled in, Decisions-so-far empty, the fog sketched into **Not yet specified**.
|
|
114
|
+
4. **Create the tickets you can specify now** as child issues of the map — then wire blocking edges in a **second pass** (issues need ids before they can reference each other). Wiring sorts them into the frontier and the blocked; everything you can't yet specify stays in the fog — the **Not yet specified** section.
|
|
115
|
+
5. **Fire the research subagents.** For each `research` ticket you just created, spin up a `/research` subagent to resolve it in parallel, capturing its findings on a throwaway `research/<name>` branch with a context pointer from the ticket.
|
|
116
|
+
6. Stop — charting is one session's work; it hand-resolves nothing.
|
|
117
|
+
|
|
118
|
+
### Work through the map
|
|
119
|
+
|
|
120
|
+
User invokes with a map (URL or number). A ticket is **optional** — without one, you pick the next decision, not the user.
|
|
121
|
+
|
|
122
|
+
1. Load the **map** — the low-res view, not every ticket body.
|
|
123
|
+
2. Choose the ticket. If the user named one, use it. Otherwise take the first frontier ticket in order. **Claim it**: assign it to yourself before any work.
|
|
124
|
+
3. Resolve it — **zoom as needed**: fetch the full body of any related or closed ticket on demand; invoke the skills the `## Notes` block names. If in doubt, use `/grilling` and `/domain-modeling`.
|
|
125
|
+
4. Record the resolution: post the answer as a **resolution comment**, **close** the issue, and **append a context pointer** to the map's Decisions-so-far.
|
|
126
|
+
5. Add newly-surfaced tickets (create-then-wire); graduate any fog the answer has made specifiable, clearing each graduated patch from **Not yet specified** so it lives only as its new ticket. If the answer reveals a ticket — this one or another — sits beyond the destination, **rule it out of scope** rather than resolving it on the route. If the decision invalidates other parts of the map, update or delete those tickets.
|
|
127
|
+
|
|
128
|
+
The user may run unblocked tickets in parallel, so expect other sessions to be editing the tracker concurrently.
|
|
129
|
+
|
|
130
|
+
## Ship integration
|
|
131
|
+
|
|
132
|
+
This skill is part of the engineering profile shipped by
|
|
133
|
+
`opencode-ship@1.0`. The strong planner child session is
|
|
134
|
+
configured with `openai/gpt-5.6-sol` and the durable workflow
|
|
135
|
+
state lives under `<git-common-dir>/opencode-ship/`. All
|
|
136
|
+
GitHub mutations go through Ship's typed tools; never use
|
|
137
|
+
`gh api` or raw shell.
|