opencode-reviewer 0.6.0 → 0.7.0

package/README.md

@@ -116,11 +116,19 @@ costs use reported charges; other endpoints use available catalog estimates.
 Received usage counts even if a review fails or is interrupted. Unreported charges
 are missing from the totals.
 
-Lifetime statistics also show **Safe** and **Unsafe** review counts. Each completed,
-validated review counts once, even without usage data. Previews, retries and failed
-or interrupted analyses do not count. Re-enabling a conversation can produce a new
-review, which counts again. The totals persist across restarts; earlier ratings
-were not recorded and cannot be reconstructed.
+The lifetime dialog shows completed reviews, retries, tokens, cost, Safe/Unsafe
+percentages, confirmed auto-approvals, and average time to a rating and full report.
+Percentages use recorded completed reviews as their denominator. Each validated
+review counts once, even without usage data; a fresh review after re-enabling counts
+again. Retries count extra API attempts actually dispatched, including format
+corrections and transport recovery. Manual approvals are not auto-approvals.
+Timings run from evaluation start, including evidence and retries, to the accepted
+attempt's first rating and final validated response, excluding rendering/countdown
+time. Non-streaming reviews use the final response time for both measurements.
+Only running averages and sample counts are stored, not individual timings.
+Totals persist across restarts. New metrics show partial history when older records
+lack them; averages include measured reviews only. Earlier unrecorded values cannot
+be reconstructed.
 
 Reviews send the pending request, latest user prompt, project context, and relevant
 file snapshots, diffs, or tool arguments to your endpoint before approval. Shell

package/dist/tui.js

@@ -1181,7 +1181,17 @@ var uiText = {
     tokenCoverage: (available, total) => `Token counts available: ${available}/${total} requests`,
     pricingCoverage: (available, total) => `Pricing available: ${available}/${total} requests`,
     since: (date) => `Recorded since: ${date}`,
-    ratings: (safe, unsafe) => `Safe: ${safe} \xB7 Unsafe: ${unsafe}`,
+    ratings: (safe, unsafe) => `${safe} \u2713 ${unsafe} \u2717`,
+    dialogReviews: (count3) => `Reviews: ${count3}`,
+    dialogRetries: (count3, partial) => `Retries: ${count3}${partial ? " (partial history)" : ""}`,
+    dialogTokens: (input, output, partial) => `Tokens: ${input} in ${output} out${partial ? " (partial coverage)" : ""}`,
+    dialogTokensUnavailable: "Tokens: unavailable",
+    dialogCost: (amount2, partial) => amount2 === void 0 ? "Cost: unavailable" : `Cost: $${amount2}${partial ? " (partial pricing)" : ""}`,
+    dialogSafe: (count3, percentage) => `Safe: ${count3} (${percentage === void 0 ? "n/a" : `${percentage}%`})`,
+    dialogUnsafe: (count3, percentage) => `Unsafe: ${count3} (${percentage === void 0 ? "n/a" : `${percentage}%`})`,
+    dialogAutoApproved: (count3, percentage, partial) => `Auto-approved: ${count3} (${percentage === void 0 ? "n/a" : `${percentage}%`})${partial ? " (partial history)" : ""}`,
+    averageFullReport: (seconds) => `Average time to full report: ${seconds === void 0 ? "unavailable" : `${seconds}s`}`,
+    averageRating: (seconds) => `Average time to rating: ${seconds === void 0 ? "unavailable" : `${seconds}s`}`,
     ratingsSince: (date) => `Ratings recorded since: ${date}`,
     ratingsExplanation: "Ratings count completed, validated reviews, including those without usage data. Previews, retries and failed or interrupted analyses do not count. A fresh review after re-enabling counts again. Earlier ratings were not recorded and cannot be recovered.",
     explanation: "Received usage only, including interrupted or unsuccessful reviews. Unreported charges remain unknown. Costs combine endpoint-reported amounts and catalog estimates; legacy history retains its original estimates. Earlier unrecorded usage cannot be recovered."
@@ -1817,11 +1827,11 @@ async function streamedAssessment(response, signal, accounting, progress, firstC
   if (!done || !stopped) throw new Error("Reviewer stream ended without stop and DONE");
   return assessment;
 }
-async function review(evidence, config, signal, fetcher = fetch, environment = process.env, prompts = BUILTIN_PROMPTS, pricing, onUsage, onProgress, onDiagnostics) {
+async function review(evidence, config, signal, fetcher = fetch, environment = process.env, prompts = BUILTIN_PROMPTS, pricing, onUsage, onProgress, onDiagnostics, onRetry) {
   if (remainingTime(signal) === Infinity) {
     let worker;
     try {
-      return await withDeadline(signal, config.timeoutMs, (bounded) => worker = review(evidence, config, bounded, fetcher, environment, prompts, pricing, onUsage, onProgress, onDiagnostics));
+      return await withDeadline(signal, config.timeoutMs, (bounded) => worker = review(evidence, config, bounded, fetcher, environment, prompts, pricing, onUsage, onProgress, onDiagnostics, onRetry));
     } finally {
       await worker?.catch(() => {
       });
@@ -1861,18 +1871,32 @@ async function review(evidence, config, signal, fetcher = fetch, environment = p
         const body = JSON.stringify({
           model: config.model,
           messages,
+          max_tokens: 2e3,
           stream: config.stream,
           ...config.stream ? { stream_options: { include_usage: true } } : {}
         });
         reviewStage(signal, "Reviewer response");
         diagnose = onDiagnostics ? diagnosticAttempt(onDiagnostics, attempt) : void 0;
-        response = await abortable(fetcher(`${config.baseURL}/chat/completions`, {
-          method: "POST",
-          redirect: "error",
-          signal: AbortSignal.any([signal, requestAbort.signal]),
-          headers: { "Content-Type": "application/json", ...key ? { Authorization: `Bearer ${key}` } : {} },
-          body
-        }), signal, cancelBody);
+        signal.throwIfAborted();
+        let pending;
+        try {
+          pending = fetcher(`${config.baseURL}/chat/completions`, {
+            method: "POST",
+            redirect: "error",
+            signal: AbortSignal.any([signal, requestAbort.signal]),
+            headers: { "Content-Type": "application/json", ...key ? { Authorization: `Bearer ${key}` } : {} },
+            body
+          });
+        } finally {
+          if (attempt > 0) {
+            try {
+              void Promise.resolve(onRetry?.()).catch(() => {
+              });
+            } catch {
+            }
+          }
+        }
+        response = await abortable(pending, signal, cancelBody);
         diagnose?.("headers");
       } catch (error) {
         signal.throwIfAborted();
@@ -2184,6 +2208,7 @@ var Controller = class {
       if (value.attempt !== entry.attempt + 1 || value.phase !== (value.attempt ? "retrying" : "evaluating")) return;
       this.clearProgress(entry);
       entry.attempt = value.attempt;
+      entry.ratingAt = void 0;
       entry.view = { ...entry.view, progress: { attempt: value.attempt, phase: value.phase } };
       this.publish();
       return;
@@ -2199,6 +2224,7 @@ var Controller = class {
       ...typeof value.preview.safe === "boolean" ? { safe: value.preview.safe } : {},
       ...typeof value.preview.desc === "string" ? { desc: value.preview.desc } : {}
     };
+    if (typeof preview.safe === "boolean" && entry.ratingAt === void 0) entry.ratingAt = this.time.now();
     entry.pendingProgress = { attempt: value.attempt, phase: "streaming", preview };
     if (preview.safe !== entry.view.progress?.preview?.safe) {
       const desc = entry.view.progress?.preview?.desc;
@@ -2378,6 +2404,7 @@ var Controller = class {
           return null;
         }
       }
+      entry.startedAt = this.time.now();
       return this.evaluate(request, entry.abort.signal, () => {
         if (active() && (entry.view.status === "identifying" || entry.view.status === "analyzing")) {
           entry.view = { ...entry.view, status: "analyzing" };
@@ -2390,7 +2417,9 @@ var Controller = class {
         entry.view = assessment ? { ...entry.view, status: "complete", assessment, progress: void 0 } : { ...entry.view, status: "unrelated", progress: void 0 };
         if (assessment) {
           try {
-            void Promise.resolve(this.ratingObserver?.(assessment.safe)).catch(() => {
+            const fullReportMs = Math.max(0, this.time.now() - entry.startedAt);
+            const ratingMs = entry.ratingAt === void 0 ? fullReportMs : Math.max(0, entry.ratingAt - entry.startedAt);
+            void Promise.resolve(this.ratingObserver?.(assessment.safe, { fullReportMs, ratingMs })).catch(() => {
             });
           } catch {
           }
@@ -3645,6 +3674,16 @@ import { constants as constants3 } from "node:fs";
 import { mkdir, open as open3, readdir as readdir2, rename, unlink } from "node:fs/promises";
 import { randomUUID } from "node:crypto";
 import path8 from "node:path";
+var emptyActivity = () => ({
+  reviews: 0,
+  usageRequests: 0,
+  retries: 0,
+  autoApproved: 0,
+  timedReviews: 0,
+  meanFullReportMs: 0,
+  meanRatingMs: 0,
+  since: null
+});
 var empty = () => ({
   requests: 0,
   tokenRequests: 0,
@@ -3655,7 +3694,8 @@ var empty = () => ({
   since: null,
   safe: 0,
   unsafe: 0,
-  ratingsSince: null
+  ratingsSince: null,
+  activity: emptyActivity()
 });
 var count2 = (value) => typeof value === "number" && Number.isSafeInteger(value) && value >= 0;
 var amount = (value) => typeof value === "number" && Number.isFinite(value) && value >= 0;
@@ -3664,8 +3704,15 @@ function validate(value) {
   if (!value || ![value.requests, value.tokenRequests, value.input, value.output, value.priced, value.safe, value.unsafe, value.safe + value.unsafe].every(count2) || !amount(value.cost) || value.priced > value.requests || value.tokenRequests > value.requests || value.requests > value.tokenRequests + value.priced || !value.tokenRequests && (value.input !== 0 || value.output !== 0) || (value.requests > 0 ? !count2(value.since) || value.since > 864e13 : value.since !== null || value.input !== 0 || value.output !== 0) || !value.priced && value.cost !== 0 || (value.safe + value.unsafe > 0 ? !count2(value.ratingsSince) || value.ratingsSince > 864e13 : value.ratingsSince !== null)) {
     throw new Error("Invalid lifetime usage totals");
   }
+  const activity = value.activity;
+  if (!activity || ![activity.reviews, activity.usageRequests, activity.retries, activity.autoApproved, activity.timedReviews].every(count2) || activity.reviews > value.safe + value.unsafe || activity.usageRequests > value.requests || activity.timedReviews > activity.reviews || ![activity.meanFullReportMs, activity.meanRatingMs].every(amount) || activity.meanRatingMs > activity.meanFullReportMs || !activity.timedReviews && (activity.meanFullReportMs !== 0 || activity.meanRatingMs !== 0) || (activity.reviews || activity.usageRequests || activity.retries || activity.autoApproved ? !count2(activity.since) || activity.since > 864e13 : activity.since !== null)) throw new Error("Invalid lifetime activity totals");
   return value;
 }
+function mean(left, leftCount, right, rightCount) {
+  if (!leftCount) return right;
+  if (!rightCount) return left;
+  return left + (right - left) * (rightCount / (leftCount + rightCount));
+}
 function add(left, right) {
   return validate({
     requests: left.requests + right.requests,
@@ -3677,7 +3724,17 @@ function add(left, right) {
     since: left.since === null ? right.since : right.since === null ? left.since : Math.min(left.since, right.since),
     safe: left.safe + right.safe,
     unsafe: left.unsafe + right.unsafe,
-    ratingsSince: left.ratingsSince === null ? right.ratingsSince : right.ratingsSince === null ? left.ratingsSince : Math.min(left.ratingsSince, right.ratingsSince)
+    ratingsSince: left.ratingsSince === null ? right.ratingsSince : right.ratingsSince === null ? left.ratingsSince : Math.min(left.ratingsSince, right.ratingsSince),
+    activity: {
+      reviews: left.activity.reviews + right.activity.reviews,
+      usageRequests: left.activity.usageRequests + right.activity.usageRequests,
+      retries: left.activity.retries + right.activity.retries,
+      autoApproved: left.activity.autoApproved + right.activity.autoApproved,
+      timedReviews: left.activity.timedReviews + right.activity.timedReviews,
+      meanFullReportMs: mean(left.activity.meanFullReportMs, left.activity.timedReviews, right.activity.meanFullReportMs, right.activity.timedReviews),
+      meanRatingMs: mean(left.activity.meanRatingMs, left.activity.timedReviews, right.activity.meanRatingMs, right.activity.timedReviews),
+      since: left.activity.since === null ? right.activity.since : right.activity.since === null ? left.activity.since : Math.min(left.activity.since, right.activity.since)
+    }
   });
 }
 var LifetimeUsage = class {
@@ -3706,13 +3763,36 @@ var LifetimeUsage = class {
       output: usage.output ?? 0,
       priced: usage.cost === void 0 ? 0 : 1,
       cost: usage.cost ?? 0,
-      since: Date.now()
+      since: Date.now(),
+      activity: { ...emptyActivity(), usageRequests: 1, since: Date.now() }
     });
   }
   /** One accepted final review, independent of POST count or received usage. */
-  recordRating(safe) {
+  recordRating(safe, timing) {
     if (typeof safe !== "boolean") return Promise.reject(new Error("Invalid review rating"));
-    return this.increment({ ...empty(), safe: safe ? 1 : 0, unsafe: safe ? 0 : 1, ratingsSince: Date.now() });
+    if (timing && (![timing.fullReportMs, timing.ratingMs].every(amount) || timing.ratingMs > timing.fullReportMs)) {
+      return Promise.reject(new Error("Invalid review timing"));
+    }
+    return this.increment({
+      ...empty(),
+      safe: safe ? 1 : 0,
+      unsafe: safe ? 0 : 1,
+      ratingsSince: Date.now(),
+      activity: {
+        ...emptyActivity(),
+        reviews: 1,
+        since: Date.now(),
+        timedReviews: timing ? 1 : 0,
+        meanFullReportMs: timing?.fullReportMs ?? 0,
+        meanRatingMs: timing?.ratingMs ?? 0
+      }
+    });
+  }
+  recordRetry() {
+    return this.increment({ ...empty(), activity: { ...emptyActivity(), retries: 1, since: Date.now() } });
+  }
+  recordAutoApproval() {
+    return this.increment({ ...empty(), activity: { ...emptyActivity(), autoApproved: 1, since: Date.now() } });
   }
   increment(increment) {
     this.pending = this.pending.catch(() => {
@@ -3723,7 +3803,7 @@ var LifetimeUsage = class {
       try {
         const file = await open3(temporary, "wx", 384);
         try {
-          await file.writeFile(JSON.stringify({ version: 3, ...this.local }));
+          await file.writeFile(JSON.stringify({ version: 4, ...this.local }));
           await file.sync();
         } finally {
           await file.close();
@@ -3783,7 +3863,7 @@ var LifetimeUsage = class {
         }
         if (size > 1024) throw new Error("Invalid lifetime usage snapshot");
         const value = JSON.parse(bytes.subarray(0, size).toString("utf8"));
-        if (value?.version !== 1 && value?.version !== 2 && value?.version !== 3) throw new Error("Unsupported lifetime usage snapshot");
+        if (![1, 2, 3, 4].includes(value?.version)) throw new Error("Unsupported lifetime usage snapshot");
         total = add(total, validate({
           requests: value.requests,
           input: value.input,
@@ -3792,9 +3872,10 @@ var LifetimeUsage = class {
           priced: value.priced,
           cost: value.cost,
           since: value.since,
-          safe: value.version === 3 ? value.safe : 0,
-          unsafe: value.version === 3 ? value.unsafe : 0,
-          ratingsSince: value.version === 3 ? value.ratingsSince : null
+          safe: value.version >= 3 ? value.safe : 0,
+          unsafe: value.version >= 3 ? value.unsafe : 0,
+          ratingsSince: value.version >= 3 ? value.ratingsSince : null,
+          activity: value.version === 4 ? value.activity : emptyActivity()
         }));
       } finally {
         await file.close();
@@ -3811,19 +3892,21 @@ function lifetimeCost(totals) {
   return uiText.lifetime.cost(totals.cost.toFixed(4), totals.priced < totals.requests);
 }
 function lifetimeReport(totals) {
+  const reviews = totals.safe + totals.unsafe, activity = totals.activity;
+  const percentage = (count3) => reviews ? (count3 / reviews * 100).toFixed(1) : void 0;
+  const partial = activity.reviews < reviews || activity.usageRequests < totals.requests;
   return [
-    lifetimeCost(totals),
-    uiText.lifetime.ratings(totals.safe, totals.unsafe),
-    uiText.lifetime.requests(totals.requests),
-    totals.tokenRequests ? uiText.lifetime.tokens(totals.input, totals.output, totals.tokenRequests < totals.requests) : uiText.lifetime.tokensUnavailable,
-    uiText.lifetime.tokenCoverage(totals.tokenRequests, totals.requests),
-    uiText.lifetime.pricingCoverage(totals.priced, totals.requests),
-    ...totals.since === null ? [] : [uiText.lifetime.since(new Date(totals.since).toISOString().slice(0, 10))],
-    ...totals.ratingsSince === null ? [] : [uiText.lifetime.ratingsSince(new Date(totals.ratingsSince).toISOString().slice(0, 10))],
+    uiText.lifetime.dialogReviews(reviews),
+    uiText.lifetime.dialogRetries(activity.retries, partial),
+    totals.tokenRequests ? uiText.lifetime.dialogTokens(totals.input, totals.output, totals.tokenRequests < totals.requests) : uiText.lifetime.dialogTokensUnavailable,
+    uiText.lifetime.dialogCost(totals.priced ? totals.cost.toFixed(4) : void 0, totals.priced < totals.requests),
     "",
-    uiText.lifetime.explanation,
+    uiText.lifetime.dialogSafe(totals.safe, percentage(totals.safe)),
+    uiText.lifetime.dialogUnsafe(totals.unsafe, percentage(totals.unsafe)),
+    uiText.lifetime.dialogAutoApproved(activity.autoApproved, percentage(activity.autoApproved), partial),
     "",
-    uiText.lifetime.ratingsExplanation
+    uiText.lifetime.averageFullReport(activity.timedReviews ? (activity.meanFullReportMs / 1e3).toFixed(2) : void 0),
+    uiText.lifetime.averageRating(activity.timedReviews ? (activity.meanRatingMs / 1e3).toFixed(2) : void 0)
   ].join("\n");
 }
 
@@ -3909,7 +3992,7 @@ var LifetimeRefresh = class {
 // src/lifetime-view.tsx
 function lifetimeTracker(api) {
   const directory = path9.join(api.state.path.state, "opencode-reviewer");
-  const store = new LifetimeUsage(path9.join(directory, "usage-v3"), path9.join(directory, "usage-v2"), path9.join(directory, "usage-v1"));
+  const store = new LifetimeUsage(path9.join(directory, "usage-v4"), path9.join(directory, "usage-v3"), path9.join(directory, "usage-v2"), path9.join(directory, "usage-v1"));
   const [totals, setTotals] = createSignal();
   const [unavailable, setUnavailable] = createSignal(false);
   const refresh = new LifetimeRefresh((signal) => store.totals(signal), (value) => {
@@ -3950,8 +4033,14 @@ function lifetimeTracker(api) {
     record: (usage) => {
       void store.record(usage).then(() => refresh.refresh(), () => refresh.failed());
     },
-    recordRating: (safe) => {
-      void store.recordRating(safe).then(() => refresh.refresh(), () => refresh.failed());
+    recordRating: (safe, timing) => {
+      void store.recordRating(safe, timing).then(() => refresh.refresh(), () => refresh.failed());
+    },
+    recordRetry: () => {
+      void store.recordRetry().then(() => refresh.refresh(), () => refresh.failed());
+    },
+    recordAutoApproval: () => {
+      void store.recordAutoApproval().then(() => refresh.refresh(), () => refresh.failed());
     }
   };
 }
@@ -6347,7 +6436,7 @@ async function reviewTui(api, options, fileIO, observer, notificationBackend) {
         }, config, configError, signal, onIdentified, files);
         if (!evidence) return null;
         signal.throwIfAborted();
-        const result = review(evidence, config, signal, void 0, void 0, prompts, (model) => modelPricing(api.state.provider, config.baseURL, model), lifetime.record, onProgress, trace?.forward);
+        const result = review(evidence, config, signal, void 0, void 0, prompts, (model) => modelPricing(api.state.provider, config.baseURL, model), lifetime.record, onProgress, trace?.forward, lifetime.recordRetry);
         worker = result;
         return result;
       });
@@ -6368,7 +6457,10 @@ async function reviewTui(api, options, fileIO, observer, notificationBackend) {
       once: (request, signal) => measured(traces?.get(request), "approval-reply", () => approval.once(request, signal))
     } : approval,
     visibleID: () => visibleApproval()
-  }, void 0, modes, (fact) => notifications?.fact(fact), lifetime.recordRating);
+  }, void 0, modes, (fact) => {
+    if (fact.type === "confirmed" && fact.automatic) lifetime.recordAutoApproval();
+    notifications?.fact(fact);
+  }, lifetime.recordRating);
   api.event.on("permission.asked", (event) => controller.asked(event.properties));
   api.event.on("permission.replied", (event) => controller.replied(event.properties.requestID));
   api.event.on("session.deleted", (event) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-reviewer",
-  "version": "0.6.0",
+  "version": "0.7.0",
   "license": "MIT",
   "publishConfig": {
     "access": "public",