opencode-pilot 0.8.0 → 0.9.1

package/examples/config.yaml

@@ -42,6 +42,8 @@ sources:
   #     completed: false
   #   item:
   #     id: "reminder:{id}"
+  #   session:
+  #     name: "{title}"  # Optional: custom session name (presets have semantic defaults)
 
 # Tool config for custom MCP servers (GitHub/Linear have built-in config)
 # tools:

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-pilot",
-  "version": "0.8.0",
+  "version": "0.9.1",
   "type": "module",
   "main": "plugin/index.js",
   "description": "Automation daemon for OpenCode - polls for work and spawns sessions",

package/service/actions.js

@@ -18,7 +18,9 @@ import os from "os";
  */
 async function getOpencodePorts() {
   try {
-    const output = execSync('lsof -i -P 2>/dev/null | grep -E "opencode.*LISTEN" || true', {
+    // Use full path to lsof since /usr/sbin may not be in PATH in all contexts
+    // (e.g., when running as a service or from certain shell environments)
+    const output = execSync('/usr/sbin/lsof -i -P 2>/dev/null | grep -E "opencode.*LISTEN" || true', {
       encoding: 'utf-8',
       timeout: 30000
     });
@@ -75,6 +77,24 @@ function getPathMatchScore(targetPath, worktree, sandboxes = []) {
   return 0; // No match
 }
 
+/**
+ * Verify a server is healthy by checking it returns valid project data
+ * @param {string} url - Server URL
+ * @param {object} project - Project data already fetched from /project/current
+ * @returns {boolean} True if server appears healthy
+ */
+function isServerHealthy(project) {
+  // A healthy server should return a project with an id and time.created
+  // Stale/broken servers may return HTML or incomplete JSON
+  return !!(
+    project &&
+    typeof project === 'object' &&
+    project.id &&
+    project.time &&
+    typeof project.time.created === 'number'
+  );
+}
+
 /**
  * Discover a running opencode server that matches the target directory
  * 
@@ -82,7 +102,7 @@ function getPathMatchScore(targetPath, worktree, sandboxes = []) {
  * 1. Exact sandbox match (highest priority)
  * 2. Exact worktree match
  * 3. Target is subdirectory of worktree
- * 4. Global project (worktree="/") as fallback
+ * 4. Global project (worktree="/") as fallback (e.g., OpenCode Desktop)
  * 
  * @param {string} targetDir - The directory we want to work in
  * @param {object} [options] - Options for testing/mocking
@@ -115,6 +135,13 @@ export async function discoverOpencodeServer(targetDir, options = {}) {
       }
       
       const project = await response.json();
+      
+      // Health check: verify response has expected structure
+      if (!isServerHealthy(project)) {
+        debug(`discoverOpencodeServer: ${url} failed health check (invalid project data)`);
+        continue;
+      }
+      
       const worktree = project.worktree || '/';
       const sandboxes = project.sandboxes || [];
       
@@ -242,7 +269,7 @@ export function getCommandInfoNew(item, config, templatesDir, serverUrl) {
   // Build session name
   const sessionName = config.session?.name
     ? buildSessionName(config.session.name, item)
-    : `session-${item.number || item.id || Date.now()}`;
+    : (item.title || `session-${Date.now()}`);
 
   // Build command args
   const args = ["opencode", "run"];
@@ -297,13 +324,14 @@ function buildPrompt(item, config) {
 /**
  * Build command args for action
  * Uses "opencode run" for non-interactive execution
+ * @deprecated Legacy function - not currently used. See getCommandInfoNew instead.
  * @returns {object} { args: string[], cwd: string }
  */
 function buildCommandArgs(item, config) {
   const repoPath = expandPath(config.repo_path || ".");
   const sessionTitle = config.session?.name_template
     ? buildSessionName(config.session.name_template, item)
-    : `issue-${item.number || Date.now()}`;
+    : (item.title || `session-${Date.now()}`);
 
   // Build opencode run command args array (non-interactive)
   // Note: --title sets session title (--session is for continuing existing sessions)

package/service/presets/github.yaml

@@ -22,6 +22,8 @@ my-issues:
   item:
     id: "{html_url}"
   repo: "{repository_full_name}"
+  session:
+    name: "{title}"
 
 review-requests:
   name: review-requests
@@ -33,6 +35,8 @@ review-requests:
   item:
     id: "{html_url}"
   repo: "{repository_full_name}"
+  session:
+    name: "Review: {title}"
 
 my-prs-feedback:
   name: my-prs-feedback
@@ -46,6 +50,8 @@ my-prs-feedback:
   item:
     id: "{html_url}"
   repo: "{repository_full_name}"
+  session:
+    name: "Feedback: {title}"
   # Reprocess when PR is updated (new commits pushed, new comments, etc.)
   # This ensures we re-trigger after addressing review feedback
   reprocess_on:

package/service/presets/linear.yaml

@@ -21,3 +21,5 @@ my-issues:
     # teamId and assigneeId are required - user must provide
   item:
     id: "linear:{id}"
+  session:
+    name: "{title}"

package/test/unit/actions.test.js

@@ -260,6 +260,38 @@ describe('actions.js', () => {
       
       assert.ok(!cmdInfo.args.includes('--attach'), 'Should not include --attach flag');
     });
+
+    test('uses item title as session name when no session.name configured', async () => {
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { id: 'reminder-123', title: 'Review quarterly reports' };
+      const config = {
+        path: '~/code/backend',
+        prompt: 'default'
+      };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      const titleIndex = cmdInfo.args.indexOf('--title');
+      assert.ok(titleIndex !== -1, 'Should have --title flag');
+      assert.strictEqual(cmdInfo.args[titleIndex + 1], 'Review quarterly reports', 'Should use item title as session name');
+    });
+
+    test('falls back to timestamp when no session.name and no title', async () => {
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { id: 'item-123' };
+      const config = {
+        path: '~/code/backend',
+        prompt: 'default'
+      };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      const titleIndex = cmdInfo.args.indexOf('--title');
+      assert.ok(titleIndex !== -1, 'Should have --title flag');
+      assert.ok(cmdInfo.args[titleIndex + 1].startsWith('session-'), 'Should fall back to session-{timestamp}');
+    });
   });
 
   describe('discoverOpencodeServer', () => {
@@ -278,10 +310,10 @@ describe('actions.js', () => {
       const mockPorts = async () => [3000, 4000];
       const mockFetch = async (url) => {
         if (url === 'http://localhost:3000/project/current') {
-          return { ok: true, json: async () => ({ worktree: '/Users/test/project-a', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'proj-a', worktree: '/Users/test/project-a', sandboxes: [], time: { created: 1 } }) };
         }
         if (url === 'http://localhost:4000/project/current') {
-          return { ok: true, json: async () => ({ worktree: '/Users/test/project-b', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'proj-b', worktree: '/Users/test/project-b', sandboxes: [], time: { created: 1 } }) };
         }
         return { ok: false };
       };
@@ -300,7 +332,7 @@ describe('actions.js', () => {
       const mockPorts = async () => [3000];
       const mockFetch = async (url) => {
         if (url === 'http://localhost:3000/project/current') {
-          return { ok: true, json: async () => ({ worktree: '/Users/test/project', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'proj', worktree: '/Users/test/project', sandboxes: [], time: { created: 1 } }) };
         }
         return { ok: false };
       };
@@ -320,8 +352,10 @@ describe('actions.js', () => {
       const mockFetch = async (url) => {
         if (url === 'http://localhost:3000/project/current') {
           return { ok: true, json: async () => ({ 
+            id: 'proj',
             worktree: '/Users/test/project', 
-            sandboxes: ['/Users/test/.opencode/worktree/abc/sandbox-1'] 
+            sandboxes: ['/Users/test/.opencode/worktree/abc/sandbox-1'],
+            time: { created: 1 }
           }) };
         }
         return { ok: false };
@@ -342,11 +376,11 @@ describe('actions.js', () => {
       const mockFetch = async (url) => {
         if (url === 'http://localhost:3000/project/current') {
           // Global project
-          return { ok: true, json: async () => ({ worktree: '/', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'global', worktree: '/', sandboxes: [], time: { created: 1 } }) };
         }
         if (url === 'http://localhost:4000/project/current') {
           // Specific project
-          return { ok: true, json: async () => ({ worktree: '/Users/test/project', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'proj', worktree: '/Users/test/project', sandboxes: [], time: { created: 1 } }) };
         }
         return { ok: false };
       };
@@ -360,17 +394,19 @@ describe('actions.js', () => {
       assert.strictEqual(result, 'http://localhost:4000');
     });
 
-    test('falls back to global project when no specific match', async () => {
+    test('falls back to healthy global project when no specific match', async () => {
       const { discoverOpencodeServer } = await import('../../service/actions.js');
       
       const mockPorts = async () => [3000];
       const mockFetch = async (url) => {
         if (url === 'http://localhost:3000/project/current') {
-          return { ok: true, json: async () => ({ worktree: '/', sandboxes: [] }) };
+          // Healthy global project with proper structure
+          return { ok: true, json: async () => ({ id: 'global', worktree: '/', sandboxes: [], time: { created: 1 } }) };
         }
         return { ok: false };
       };
       
+      // Global servers (like OpenCode Desktop) should work as fallback
       const result = await discoverOpencodeServer('/Users/test/random/path', { 
         getPorts: mockPorts,
         fetch: mockFetch
@@ -404,7 +440,33 @@ describe('actions.js', () => {
           return { ok: false };
         }
         if (url === 'http://localhost:4000/project/current') {
-          return { ok: true, json: async () => ({ worktree: '/Users/test/project', sandboxes: [] }) };
+          return { ok: true, json: async () => ({ id: 'proj', worktree: '/Users/test/project', sandboxes: [], time: { created: 1 } }) };
+        }
+        return { ok: false };
+      };
+      
+      const result = await discoverOpencodeServer('/Users/test/project', { 
+        getPorts: mockPorts,
+        fetch: mockFetch
+      });
+      
+      assert.strictEqual(result, 'http://localhost:4000');
+    });
+
+    test('skips servers that return invalid JSON', async () => {
+      const { discoverOpencodeServer } = await import('../../service/actions.js');
+      
+      const mockPorts = async () => [3000, 4000];
+      const mockFetch = async (url) => {
+        if (url === 'http://localhost:3000/project/current') {
+          // Stale server returning HTML
+          return { 
+            ok: true, 
+            json: async () => { throw new SyntaxError('Unexpected token < in JSON'); }
+          };
+        }
+        if (url === 'http://localhost:4000/project/current') {
+          return { ok: true, json: async () => ({ id: 'proj', worktree: '/Users/test/project', sandboxes: [], time: { created: 1 } }) };
         }
         return { ok: false };
       };
@@ -416,6 +478,50 @@ describe('actions.js', () => {
       
       assert.strictEqual(result, 'http://localhost:4000');
     });
+
+    test('skips servers with incomplete project data (missing time)', async () => {
+      const { discoverOpencodeServer } = await import('../../service/actions.js');
+      
+      const mockPorts = async () => [3000, 4000];
+      const mockFetch = async (url) => {
+        if (url === 'http://localhost:3000/project/current') {
+          // Server returning incomplete response (missing time.created)
+          return { ok: true, json: async () => ({ id: 'broken', worktree: '/Users/test/project', sandboxes: [] }) };
+        }
+        if (url === 'http://localhost:4000/project/current') {
+          return { ok: true, json: async () => ({ id: 'proj', worktree: '/Users/test/project', sandboxes: [], time: { created: 1 } }) };
+        }
+        return { ok: false };
+      };
+      
+      const result = await discoverOpencodeServer('/Users/test/project', { 
+        getPorts: mockPorts,
+        fetch: mockFetch
+      });
+      
+      assert.strictEqual(result, 'http://localhost:4000');
+    });
+
+    test('returns null when server returns unhealthy project data', async () => {
+      const { discoverOpencodeServer } = await import('../../service/actions.js');
+      
+      const mockPorts = async () => [3000];
+      const mockFetch = async (url) => {
+        if (url === 'http://localhost:3000/project/current') {
+          // Server returns incomplete/unhealthy data (missing id and time)
+          return { ok: true, json: async () => ({ worktree: '/', sandboxes: [] }) };
+        }
+        return { ok: false };
+      };
+      
+      // Server that returns unhealthy project data should be skipped
+      const result = await discoverOpencodeServer('/Users/test/specific-project', { 
+        getPorts: mockPorts,
+        fetch: mockFetch
+      });
+      
+      assert.strictEqual(result, null, 'Should return null when server returns unhealthy project data');
+    });
   });
 
   describe('executeAction', () => {

package/test/unit/repo-config.test.js

@@ -664,6 +664,44 @@ sources:
       const filteredItem = { repository_full_name: 'other/repo' };
       assert.deepStrictEqual(resolveRepoForItem(source, filteredItem), []);
     });
+
+    test('github presets include semantic session names', async () => {
+      writeFileSync(configPath, `
+sources:
+  - preset: github/my-issues
+  - preset: github/review-requests
+  - preset: github/my-prs-feedback
+`);
+
+      const { loadRepoConfig, getSources } = await import('../../service/repo-config.js');
+      loadRepoConfig(configPath);
+      const sources = getSources();
+
+      // my-issues: just the title
+      assert.strictEqual(sources[0].session.name, '{title}', 'my-issues should use title');
+      
+      // review-requests: "Review: {title}"
+      assert.strictEqual(sources[1].session.name, 'Review: {title}', 'review-requests should prefix with Review:');
+      
+      // my-prs-feedback: "Feedback: {title}"
+      assert.strictEqual(sources[2].session.name, 'Feedback: {title}', 'my-prs-feedback should prefix with Feedback:');
+    });
+
+    test('linear preset includes session name', async () => {
+      writeFileSync(configPath, `
+sources:
+  - preset: linear/my-issues
+    args:
+      teamId: "team-uuid"
+      assigneeId: "user-uuid"
+`);
+
+      const { loadRepoConfig, getSources } = await import('../../service/repo-config.js');
+      loadRepoConfig(configPath);
+      const sources = getSources();
+
+      assert.strictEqual(sources[0].session.name, '{title}', 'linear/my-issues should use title');
+    });
   });
 
   describe('shorthand syntax', () => {