opencode-pilot 0.21.1 → 0.21.3

package/.github/workflows/ci.yml

@@ -48,7 +48,6 @@ jobs:
       - uses: actions/checkout@v4
         with:
           fetch-depth: 0
-          persist-credentials: false
 
       - name: Setup Node.js
         uses: actions/setup-node@v4

package/AGENTS.md

@@ -36,12 +36,10 @@ gh release list -R athal7/opencode-pilot -L 1
 npm view opencode-pilot version
 ```
 
-### 3. Clear OpenCode Plugin Cache
-
-OpenCode caches plugins at `~/.cache/opencode/node_modules/`. Clear the cache to pick up the new version:
+### 3. Upgrade via Homebrew
 
 ```bash
-rm -rf ~/.cache/opencode/node_modules/opencode-pilot
+brew upgrade opencode-pilot
 ```
 
 ### 4. Restart Service
@@ -50,13 +48,13 @@ If the service is running, restart it:
 
 ```bash
 # Stop current service (Ctrl+C) and restart
-npx opencode-pilot start
+opencode-pilot start
 ```
 
 ### 5. Verify Upgrade
 
 ```bash
-npx opencode-pilot status
+opencode-pilot status
 ```
 
 ## Configuration

package/Formula/opencode-pilot.rb

@@ -1,8 +1,8 @@
 class OpencodePilot < Formula
   desc "Automation daemon for OpenCode - polls GitHub/Linear issues and spawns sessions"
   homepage "https://github.com/athal7/opencode-pilot"
-  url "https://github.com/athal7/opencode-pilot/archive/refs/tags/v0.20.5.tar.gz"
-  sha256 "454bdead3efab2278c1b25e31d8e3d9dcb0c1895f4723a8e7757e01812605a84"
+  url "https://github.com/athal7/opencode-pilot/archive/refs/tags/v0.21.2.tar.gz"
+  sha256 "7295684359ee266599b634d903944a10d3597659266303f03c8376944e8e2a36"
   license "MIT"
 
   depends_on "node"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-pilot",
-  "version": "0.21.1",
+  "version": "0.21.3",
   "type": "module",
   "main": "plugin/index.js",
   "description": "Automation daemon for OpenCode - polls for work and spawns sessions",

package/service/poller.js

@@ -558,15 +558,12 @@ export async function enrichItemsWithComments(items, source, options = {}) {
   }
   
   // Fetch comments for each item (could be parallelized with Promise.all for speed)
+  // Note: Always fetch reviews - commentsCount from gh search only counts issue comments,
+  // not PR reviews or PR review comments. PRs with only review feedback would be missed.
   const enrichedItems = [];
   for (const item of items) {
-    // Only fetch if item has comments
-    if (item.comments > 0) {
-      const comments = await fetchGitHubComments(item, options);
-      enrichedItems.push({ ...item, _comments: comments });
-    } else {
-      enrichedItems.push(item);
-    }
+    const comments = await fetchGitHubComments(item, options);
+    enrichedItems.push({ ...item, _comments: comments });
   }
   
   return enrichedItems;

package/test/unit/poller.test.js

@@ -1113,7 +1113,10 @@ describe('poller.js', () => {
       assert.strictEqual(result[0]._comments, undefined);
     });
 
-    test('skips items with zero comments', async () => {
+    test('enriches items with zero commentsCount (PR reviews not counted in commentsCount)', async () => {
+      // This test verifies the fix for a bug where PRs with review feedback but
+      // zero issue comments were not enriched. GitHub's commentsCount only counts
+      // issue comments, not PR reviews or PR review comments.
       const { enrichItemsWithComments } = await import('../../service/poller.js');
       
       const items = [
@@ -1127,10 +1130,13 @@ describe('poller.js', () => {
       
       const result = await enrichItemsWithComments(items, source);
       
-      // Items returned unchanged (no API calls made)
+      // Items should be enriched with _comments (empty array if no feedback found)
+      // The actual API call may fail in test environment, but items should still
+      // have _comments set (either to fetched comments or empty array on error)
       assert.strictEqual(result.length, 2);
-      assert.strictEqual(result[0]._comments, undefined);
-      assert.strictEqual(result[1]._comments, undefined);
+      // _comments should be defined (array) - we always try to fetch now
+      assert.ok(Array.isArray(result[0]._comments), 'First item should have _comments array');
+      assert.ok(Array.isArray(result[1]._comments), 'Second item should have _comments array');
     });
 
     test('identifies GitHub MCP source correctly', async () => {
@@ -1142,9 +1148,10 @@ describe('poller.js', () => {
         tool: { mcp: 'github', name: 'search_issues' }
       };
       
-      // Should not throw, just skip due to 0 comments
+      // Should try to fetch comments (may return empty array on API error in tests)
       const result = await enrichItemsWithComments(items, source);
       assert.strictEqual(result.length, 1);
+      assert.ok(Array.isArray(result[0]._comments), 'Should have _comments array');
     });
 
     test('identifies GitHub CLI source correctly', async () => {
@@ -1156,9 +1163,10 @@ describe('poller.js', () => {
         tool: { command: ['gh', 'search', 'issues', '--json', 'number'] }
       };
       
-      // Should not throw, just skip due to 0 comments
+      // Should try to fetch comments (may return empty array on API error in tests)
       const result = await enrichItemsWithComments(items, source);
       assert.strictEqual(result.length, 1);
+      assert.ok(Array.isArray(result[0]._comments), 'Should have _comments array');
     });
   });