opencode-pilot 0.11.1 → 0.11.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-pilot",
-  "version": "0.11.1",
+  "version": "0.11.2",
   "type": "module",
   "main": "plugin/index.js",
   "description": "Automation daemon for OpenCode - polls for work and spawns sessions",

package/service/utils.js

@@ -20,6 +20,26 @@ export function getNestedValue(obj, path) {
   return value;
 }
 
+/**
+ * Check if a comment/review is an approval-only (no actionable feedback)
+ * 
+ * PR reviews have a state field (APPROVED, CHANGES_REQUESTED, COMMENTED).
+ * An approval without substantive body text doesn't require action from the author.
+ * 
+ * @param {object} comment - Comment or review object with optional state and body
+ * @returns {boolean} True if this is a pure approval with no actionable feedback
+ */
+export function isApprovalOnly(comment) {
+  // Only applies to PR reviews with APPROVED state
+  if (comment.state !== 'APPROVED') return false;
+  
+  // If there's substantive body text, it might contain feedback
+  const body = comment.body || '';
+  if (body.trim().length > 0) return false;
+  
+  return true;
+}
+
 /**
  * Check if a username represents a bot account
  * 
@@ -50,9 +70,12 @@ export function isBot(username, type) {
  * Used to filter out PRs where only bots have commented, since those don't
  * require the author's attention for human feedback.
  * 
+ * Also skips approval-only reviews (APPROVED state with no body text) since
+ * approvals don't require action from the author.
+ * 
  * @param {Array} comments - Array of comment objects with user.login and user.type
  * @param {string} authorUsername - Username of the PR/issue author
- * @returns {boolean} True if there's at least one non-bot, non-author comment
+ * @returns {boolean} True if there's at least one non-bot, non-author, actionable comment
  */
 export function hasNonBotFeedback(comments, authorUsername) {
   // Handle null/undefined/empty
@@ -75,7 +98,10 @@ export function hasNonBotFeedback(comments, authorUsername) {
     // Skip if it's the author themselves
     if (authorLower && username?.toLowerCase() === authorLower) continue;
     
-    // Found a non-bot, non-author comment
+    // Skip approval-only reviews (no actionable feedback)
+    if (isApprovalOnly(comment)) continue;
+    
+    // Found a non-bot, non-author, actionable comment
     return true;
   }
   

package/test/unit/utils.test.js

@@ -100,6 +100,77 @@ describe('utils.js', () => {
       
       assert.strictEqual(hasNonBotFeedback(comments, 'contributor'), true);
     });
+
+    test('returns false when only approval-only reviews (no feedback body)', async () => {
+      const { hasNonBotFeedback } = await import('../../service/utils.js');
+      
+      // PR reviews with APPROVED state but no body should not trigger feedback
+      const comments = [
+        { user: { login: 'github-actions[bot]', type: 'Bot' }, body: 'CI passed' },
+        { user: { login: 'reviewer', type: 'User' }, state: 'APPROVED', body: '' },
+      ];
+      
+      assert.strictEqual(hasNonBotFeedback(comments, 'author'), false);
+    });
+
+    test('returns true when approval includes feedback body', async () => {
+      const { hasNonBotFeedback } = await import('../../service/utils.js');
+      
+      // If someone approves but leaves feedback, we should consider it actionable
+      const comments = [
+        { user: { login: 'reviewer', type: 'User' }, state: 'APPROVED', body: 'LGTM but consider adding a test for edge cases' },
+      ];
+      
+      assert.strictEqual(hasNonBotFeedback(comments, 'author'), true);
+    });
+
+    test('returns true for CHANGES_REQUESTED reviews', async () => {
+      const { hasNonBotFeedback } = await import('../../service/utils.js');
+      
+      const comments = [
+        { user: { login: 'reviewer', type: 'User' }, state: 'CHANGES_REQUESTED', body: 'Please fix this' },
+      ];
+      
+      assert.strictEqual(hasNonBotFeedback(comments, 'author'), true);
+    });
+  });
+
+  describe('isApprovalOnly', () => {
+    test('returns true for APPROVED state with no body', async () => {
+      const { isApprovalOnly } = await import('../../service/utils.js');
+      
+      assert.strictEqual(isApprovalOnly({ state: 'APPROVED' }), true);
+      assert.strictEqual(isApprovalOnly({ state: 'APPROVED', body: '' }), true);
+      assert.strictEqual(isApprovalOnly({ state: 'APPROVED', body: null }), true);
+    });
+
+    test('returns false for APPROVED with substantive body', async () => {
+      const { isApprovalOnly } = await import('../../service/utils.js');
+      
+      // If someone approves but leaves feedback, we should still consider it feedback
+      assert.strictEqual(isApprovalOnly({ state: 'APPROVED', body: 'LGTM but consider renaming this function' }), false);
+    });
+
+    test('returns false for CHANGES_REQUESTED', async () => {
+      const { isApprovalOnly } = await import('../../service/utils.js');
+      
+      assert.strictEqual(isApprovalOnly({ state: 'CHANGES_REQUESTED', body: 'Please fix this' }), false);
+      assert.strictEqual(isApprovalOnly({ state: 'CHANGES_REQUESTED' }), false);
+    });
+
+    test('returns false for COMMENTED state', async () => {
+      const { isApprovalOnly } = await import('../../service/utils.js');
+      
+      assert.strictEqual(isApprovalOnly({ state: 'COMMENTED', body: 'This looks good' }), false);
+    });
+
+    test('returns false for regular comments without state', async () => {
+      const { isApprovalOnly } = await import('../../service/utils.js');
+      
+      // Issue comments don't have state field
+      assert.strictEqual(isApprovalOnly({ body: 'Please address this' }), false);
+      assert.strictEqual(isApprovalOnly({}), false);
+    });
   });
 
   describe('getNestedValue', () => {