opencode-pilot 0.1.0

package/test/unit/actions.test.js

@@ -0,0 +1,235 @@
+/**
+ * Tests for actions.js - session creation with new config format
+ */
+
+import { test, describe, beforeEach, afterEach } from 'node:test';
+import assert from 'node:assert';
+import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from 'fs';
+import { join } from 'path';
+import { tmpdir, homedir } from 'os';
+
+describe('actions.js', () => {
+  let tempDir;
+  let templatesDir;
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), 'opencode-pilot-actions-test-'));
+    templatesDir = join(tempDir, 'templates');
+    mkdirSync(templatesDir);
+  });
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  describe('expandTemplate', () => {
+    test('expands simple placeholders', async () => {
+      const { expandTemplate } = await import('../../service/actions.js');
+      
+      const result = expandTemplate('{title}\n\n{body}', {
+        title: 'Fix bug',
+        body: 'The bug is bad'
+      });
+      
+      assert.strictEqual(result, 'Fix bug\n\nThe bug is bad');
+    });
+
+    test('preserves unmatched placeholders', async () => {
+      const { expandTemplate } = await import('../../service/actions.js');
+      
+      const result = expandTemplate('{title}\n\n{missing}', {
+        title: 'Fix bug'
+      });
+      
+      assert.strictEqual(result, 'Fix bug\n\n{missing}');
+    });
+
+    test('expands nested field references', async () => {
+      const { expandTemplate } = await import('../../service/actions.js');
+      
+      const result = expandTemplate('Repo: {repository.full_name}', {
+        repository: { full_name: 'athal7/opencode-pilot' }
+      });
+      
+      assert.strictEqual(result, 'Repo: athal7/opencode-pilot');
+    });
+
+    test('preserves unmatched nested placeholders', async () => {
+      const { expandTemplate } = await import('../../service/actions.js');
+      
+      const result = expandTemplate('{team.name}', {
+        team: {}
+      });
+      
+      assert.strictEqual(result, '{team.name}');
+    });
+  });
+
+  describe('buildPromptFromTemplate', () => {
+    test('loads template from file and expands', async () => {
+      writeFileSync(join(templatesDir, 'default.md'), '{title}\n\n{body}');
+      
+      const { buildPromptFromTemplate } = await import('../../service/actions.js');
+      
+      const item = { title: 'Fix bug', body: 'Details here' };
+      const prompt = buildPromptFromTemplate('default', item, templatesDir);
+      
+      assert.strictEqual(prompt, 'Fix bug\n\nDetails here');
+    });
+
+    test('returns fallback when template not found', async () => {
+      const { buildPromptFromTemplate } = await import('../../service/actions.js');
+      
+      const item = { title: 'Fix bug', body: 'Details here' };
+      const prompt = buildPromptFromTemplate('nonexistent', item, templatesDir);
+      
+      // Should fall back to title + body
+      assert.strictEqual(prompt, 'Fix bug\n\nDetails here');
+    });
+
+    test('handles item with only title', async () => {
+      const { buildPromptFromTemplate } = await import('../../service/actions.js');
+      
+      const item = { title: 'Fix bug' };
+      const prompt = buildPromptFromTemplate('nonexistent', item, templatesDir);
+      
+      assert.strictEqual(prompt, 'Fix bug');
+    });
+  });
+
+  describe('getActionConfig', () => {
+    test('merges source, repo, and defaults', async () => {
+      const { getActionConfig } = await import('../../service/actions.js');
+      
+      const source = {
+        name: 'my-issues',
+        prompt: 'custom',
+        agent: 'reviewer'
+      };
+      const repoConfig = {
+        path: '~/code/backend',
+        session: { name: 'issue-{number}' }
+      };
+      const defaults = {
+        prompt: 'default',
+        working_dir: '~'
+      };
+      
+      const config = getActionConfig(source, repoConfig, defaults);
+      
+      // Source overrides
+      assert.strictEqual(config.prompt, 'custom');
+      assert.strictEqual(config.agent, 'reviewer');
+      // Repo config
+      assert.strictEqual(config.path, '~/code/backend');
+      assert.strictEqual(config.session.name, 'issue-{number}');
+    });
+
+    test('falls back to defaults when no source/repo overrides', async () => {
+      const { getActionConfig } = await import('../../service/actions.js');
+      
+      const source = { name: 'my-issues' };
+      const repoConfig = {};
+      const defaults = {
+        prompt: 'default',
+        working_dir: '~/scratch'
+      };
+      
+      const config = getActionConfig(source, repoConfig, defaults);
+      
+      assert.strictEqual(config.prompt, 'default');
+      assert.strictEqual(config.working_dir, '~/scratch');
+    });
+
+    test('source working_dir overrides repo path', async () => {
+      const { getActionConfig } = await import('../../service/actions.js');
+      
+      const source = {
+        name: 'cross-repo',
+        working_dir: '~/workspaces'
+      };
+      const repoConfig = {
+        path: '~/code/backend'
+      };
+      const defaults = {};
+      
+      const config = getActionConfig(source, repoConfig, defaults);
+      
+      assert.strictEqual(config.working_dir, '~/workspaces');
+    });
+
+  });
+
+  describe('getCommandInfoNew', () => {
+    test('builds command with all options', async () => {
+      writeFileSync(join(templatesDir, 'default.md'), '{title}\n\n{body}');
+      
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { number: 123, title: 'Fix bug', body: 'Details' };
+      const config = {
+        path: '~/code/backend',
+        prompt: 'default',
+        agent: 'coder',
+        session: { name: 'issue-{number}' }
+      };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      assert.strictEqual(cmdInfo.cwd, join(homedir(), 'code/backend'));
+      assert.ok(cmdInfo.args.includes('opencode'));
+      assert.ok(cmdInfo.args.includes('run'));
+      assert.ok(cmdInfo.args.includes('--title'));
+      assert.ok(cmdInfo.args.includes('issue-123'));
+      assert.ok(cmdInfo.args.includes('--agent'));
+      assert.ok(cmdInfo.args.includes('coder'));
+    });
+
+    test('uses working_dir when no path', async () => {
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { id: 'reminder-1', title: 'Do something' };
+      const config = {
+        working_dir: '~/scratch',
+        prompt: 'default'
+      };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      assert.strictEqual(cmdInfo.cwd, join(homedir(), 'scratch'));
+    });
+
+    test('defaults to home dir when no path or working_dir', async () => {
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { title: 'Do something' };
+      const config = { prompt: 'default' };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      assert.strictEqual(cmdInfo.cwd, homedir());
+    });
+
+    test('includes prompt from template as message', async () => {
+      writeFileSync(join(templatesDir, 'devcontainer.md'), '/devcontainer issue-{number}\n\n{title}\n\n{body}');
+      
+      const { getCommandInfoNew } = await import('../../service/actions.js');
+      
+      const item = { number: 66, title: 'Fix bug', body: 'Details' };
+      const config = {
+        path: '~/code/backend',
+        prompt: 'devcontainer'
+      };
+      
+      const cmdInfo = getCommandInfoNew(item, config, templatesDir);
+      
+      // Should NOT have --command flag (slash command is in template)
+      assert.ok(!cmdInfo.args.includes('--command'), 'Should not include --command flag');
+      
+      // Prompt should include the /devcontainer command
+      const lastArg = cmdInfo.args[cmdInfo.args.length - 1];
+      assert.ok(lastArg.includes('/devcontainer issue-66'), 'Prompt should include /devcontainer command');
+      assert.ok(lastArg.includes('Fix bug'), 'Prompt should include title');
+    });
+  });
+});

package/test/unit/config.test.js

@@ -0,0 +1,86 @@
+/**
+ * Tests for config.js - unified YAML configuration
+ */
+
+import { test, describe, beforeEach, afterEach } from 'node:test';
+import assert from 'node:assert';
+import { mkdtempSync, writeFileSync, mkdirSync, rmSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+
+// We'll test the module by creating temp config files
+
+describe('config.js', () => {
+  let tempDir;
+  let configPath;
+  let templatesDir;
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), 'opencode-pilot-test-'));
+    configPath = join(tempDir, 'config.yaml');
+    templatesDir = join(tempDir, 'templates');
+    mkdirSync(templatesDir);
+  });
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  describe('loadConfig', () => {
+    test('reads notifications from config.yaml', async () => {
+      writeFileSync(configPath, `
+notifications:
+  topic: test-topic
+  server: https://custom.ntfy.sh
+  idle_delay_ms: 600000
+`);
+
+      const { loadConfig } = await import('../../plugin/config.js');
+      const config = loadConfig(configPath);
+
+      assert.strictEqual(config.topic, 'test-topic');
+      assert.strictEqual(config.server, 'https://custom.ntfy.sh');
+      assert.strictEqual(config.idleDelayMs, 600000);
+    });
+
+    test('returns defaults when config file missing', async () => {
+      const { loadConfig } = await import('../../plugin/config.js');
+      const config = loadConfig('/nonexistent/path/config.yaml');
+
+      assert.strictEqual(config.server, 'https://ntfy.sh');
+      assert.strictEqual(config.idleDelayMs, 300000);
+    });
+
+    test('handles all config options', async () => {
+      writeFileSync(configPath, `
+notifications:
+  topic: my-topic
+  server: https://ntfy.example.com
+  token: tk_xxx
+  idle_delay_ms: 600000
+  idle_notify: false
+  error_notify: false
+  error_debounce_ms: 120000
+  retry_notify_first: false
+  retry_notify_after: 5
+  debug: true
+  debug_path: /custom/debug.log
+`);
+
+      const { loadConfig } = await import('../../plugin/config.js');
+      const config = loadConfig(configPath);
+
+      assert.strictEqual(config.topic, 'my-topic');
+      assert.strictEqual(config.server, 'https://ntfy.example.com');
+      assert.strictEqual(config.authToken, 'tk_xxx');
+      assert.strictEqual(config.idleDelayMs, 600000);
+      assert.strictEqual(config.idleNotify, false);
+      assert.strictEqual(config.errorNotify, false);
+      assert.strictEqual(config.errorDebounceMs, 120000);
+      assert.strictEqual(config.retryNotifyFirst, false);
+      assert.strictEqual(config.retryNotifyAfter, 5);
+      assert.strictEqual(config.debug, true);
+      assert.strictEqual(config.debugPath, '/custom/debug.log');
+    });
+  });
+});

package/test/unit/paths.test.js

@@ -0,0 +1,77 @@
+/**
+ * Tests for consistent path naming across the codebase.
+ * 
+ * These tests ensure all config/socket paths use "opencode-pilot" 
+ * and not the old "opencode-ntfy" name.
+ */
+
+import { test, describe } from 'node:test';
+import assert from 'node:assert';
+import { readFileSync } from 'fs';
+import { join, dirname } from 'path';
+import { fileURLToPath } from 'url';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+const ROOT_DIR = join(__dirname, '..', '..');
+const PLUGIN_DIR = join(ROOT_DIR, 'plugin');
+const SERVICE_DIR = join(ROOT_DIR, 'service');
+
+describe('Path naming consistency', () => {
+  
+  describe('config.js', () => {
+    const configPath = join(PLUGIN_DIR, 'config.js');
+    const content = readFileSync(configPath, 'utf8');
+    
+    test('uses opencode-pilot config path', () => {
+      assert.match(content, /opencode-pilot.*config\.yaml/, 
+        'config.js should reference opencode-pilot config path');
+    });
+    
+    test('does not reference old opencode-ntfy path', () => {
+      assert.doesNotMatch(content, /opencode-ntfy/,
+        'config.js should not reference old opencode-ntfy name');
+    });
+  });
+  
+  describe('logger.js', () => {
+    const loggerPath = join(PLUGIN_DIR, 'logger.js');
+    const content = readFileSync(loggerPath, 'utf8');
+    
+    test('uses opencode-pilot debug log path', () => {
+      assert.match(content, /opencode-pilot.*debug\.log/,
+        'logger.js should reference opencode-pilot debug log path');
+    });
+    
+    test('does not reference old opencode-ntfy path', () => {
+      assert.doesNotMatch(content, /opencode-ntfy/,
+        'logger.js should not reference old opencode-ntfy name');
+    });
+  });
+  
+  describe('server.js', () => {
+    const serverPath = join(SERVICE_DIR, 'server.js');
+    const content = readFileSync(serverPath, 'utf8');
+    
+    test('uses opencode-pilot socket path', () => {
+      assert.match(content, /opencode-pilot\.sock/,
+        'server.js should reference opencode-pilot socket path');
+    });
+    
+    test('uses opencode-pilot config path', () => {
+      assert.match(content, /opencode-pilot.*config\.json|opencode-pilot/,
+        'server.js should reference opencode-pilot paths');
+    });
+  });
+  
+  describe('index.js (plugin entry)', () => {
+    const indexPath = join(PLUGIN_DIR, 'index.js');
+    const content = readFileSync(indexPath, 'utf8');
+    
+    test('does not reference old opencode-ntfy name in comments', () => {
+      // Allow "ntfy" alone (the service name) but not "opencode-ntfy"
+      assert.doesNotMatch(content, /opencode-ntfy/,
+        'index.js should not reference old opencode-ntfy name');
+    });
+  });
+});

package/test/unit/poll-service.test.js

@@ -0,0 +1,142 @@
+/**
+ * Tests for poll-service.js
+ */
+
+import { test, describe, beforeEach, afterEach, mock } from 'node:test';
+import assert from 'node:assert';
+import { mkdtempSync, writeFileSync, mkdirSync, rmSync, existsSync } from 'fs';
+import { join } from 'path';
+import { tmpdir } from 'os';
+
+describe('poll-service.js', () => {
+  let tempDir;
+  let configPath;
+
+  beforeEach(() => {
+    tempDir = mkdtempSync(join(tmpdir(), 'opencode-pilot-poll-service-test-'));
+    configPath = join(tempDir, 'config.yaml');
+  });
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  describe('source configuration', () => {
+    test('parses sources with tool.mcp and tool.name', async () => {
+      const config = `
+sources:
+  - name: my-issues
+    tool:
+      mcp: github
+      name: search_issues
+    args:
+      q: "is:issue assignee:@me"
+    item:
+      id: "{html_url}"
+`;
+      writeFileSync(configPath, config);
+
+      const { loadRepoConfig, getAllSources } = await import('../../service/repo-config.js');
+      loadRepoConfig(configPath);
+      const sources = getAllSources();
+      
+      assert.strictEqual(sources.length, 1);
+      assert.strictEqual(sources[0].name, 'my-issues');
+      assert.ok(sources[0].tool, 'Source should have tool config');
+      assert.strictEqual(sources[0].tool.mcp, 'github');
+      assert.strictEqual(sources[0].tool.name, 'search_issues');
+    });
+
+    test('hasToolConfig validates source configuration', async () => {
+      const { hasToolConfig } = await import('../../service/poll-service.js');
+      
+      // Valid config
+      const valid = {
+        name: 'test',
+        tool: { mcp: 'github', name: 'search_issues' },
+        args: {}
+      };
+      assert.strictEqual(hasToolConfig(valid), true);
+      
+      // Missing tool
+      const missingTool = { name: 'test' };
+      assert.strictEqual(hasToolConfig(missingTool), false);
+      
+      // Missing mcp
+      const missingMcp = { name: 'test', tool: { name: 'search_issues' } };
+      assert.strictEqual(hasToolConfig(missingMcp), false);
+      
+      // Missing tool.name
+      const missingName = { name: 'test', tool: { mcp: 'github' } };
+      assert.strictEqual(hasToolConfig(missingName), false);
+    });
+  });
+
+  describe('buildActionConfigFromSource', () => {
+    test('includes source-level agent, model, prompt, and working_dir', async () => {
+      const { buildActionConfigFromSource } = await import('../../service/poll-service.js');
+      
+      const source = {
+        name: 'test-source',
+        agent: 'plan',
+        model: 'claude-opus',
+        prompt: 'devcontainer',
+        working_dir: '~/code/project',
+        session: { name: 'issue-{number}' }
+      };
+      const repoConfig = {
+        path: '~/code/default',
+        prompt: 'default'
+      };
+      
+      const config = buildActionConfigFromSource(source, repoConfig);
+      
+      assert.strictEqual(config.agent, 'plan');
+      assert.strictEqual(config.model, 'claude-opus');
+      assert.strictEqual(config.prompt, 'devcontainer');
+      assert.strictEqual(config.working_dir, '~/code/project');
+      assert.deepStrictEqual(config.session, { name: 'issue-{number}' });
+    });
+
+    test('falls back to repoConfig when source fields missing', async () => {
+      const { buildActionConfigFromSource } = await import('../../service/poll-service.js');
+      
+      const source = {
+        name: 'test-source'
+        // No agent, model, prompt, working_dir
+      };
+      const repoConfig = {
+        path: '~/code/default',
+        prompt: 'default',
+        session: { name: 'default-{number}' }
+      };
+      
+      const config = buildActionConfigFromSource(source, repoConfig);
+      
+      assert.strictEqual(config.prompt, 'default');
+      assert.strictEqual(config.repo_path, '~/code/default');
+      assert.deepStrictEqual(config.session, { name: 'default-{number}' });
+    });
+
+    test('source fields override repoConfig fields', async () => {
+      const { buildActionConfigFromSource } = await import('../../service/poll-service.js');
+      
+      const source = {
+        name: 'test-source',
+        prompt: 'review',
+        agent: 'code'
+      };
+      const repoConfig = {
+        path: '~/code/default',
+        prompt: 'default',
+        agent: 'plan'  // Should be overridden
+      };
+      
+      const config = buildActionConfigFromSource(source, repoConfig);
+      
+      assert.strictEqual(config.prompt, 'review');
+      assert.strictEqual(config.agent, 'code');
+    });
+
+  });
+});