opencode-mempalace-persistence 2.0.1 → 2.1.0

package/dist/index.js

@@ -1,10 +1,9 @@
-import { execSync, exec, spawnSync } from "child_process";
+import { execSync, execFileSync, execFile, spawnSync } from "child_process";
 import { existsSync, readFileSync, writeFileSync, mkdirSync, rmdirSync, unlinkSync, appendFileSync } from "fs";
 import { homedir } from "os";
 import { join } from "path";
 import { createHash } from "crypto";
 const HOME = homedir();
-const VENV_PYTHON = join(HOME, ".local/share/pipx/venvs/mempalace/bin/python3");
 const MEMPALACE_BIN = join(HOME, ".local/bin/mempalace");
 const OPENCODE_DB = join(HOME, ".local/share/opencode/opencode.db");
 const STATE_FILE = join(HOME, ".mempalace/sync_state.json");
@@ -38,6 +37,45 @@ function hookLog(msg) {
     }
     catch { }
 }
+// Errors are never silent: hook.log is always written (unlike the
+// DEBUG-gated log), so a broken pipeline is visible by default.
+function errLog(msg) {
+    log("ERROR: " + msg);
+    hookLog("ERROR: " + msg);
+}
+// Probe for a working Python interpreter at startup instead of hardcoding
+// one installer layout (pipx vs uv tool vs system). runPython only needs
+// stdlib (sqlite3/json), so any python3 works. Priority: explicit env
+// override, legacy pipx venv, uv tool venv, PATH fallback.
+let resolvedPython = undefined;
+function resolvePython() {
+    if (resolvedPython !== undefined)
+        return resolvedPython;
+    const candidates = [
+        process.env.MEMPALACE_PYTHON,
+        join(HOME, ".local/share/pipx/venvs/mempalace/bin/python3"),
+        join(HOME, ".local/share/uv/tools/mempalace/bin/python3"),
+    ].filter((p) => !!p && existsSync(p));
+    if (candidates.length > 0) {
+        resolvedPython = candidates[0];
+    }
+    else {
+        try {
+            execSync("python3 --version", { encoding: "utf-8", timeout: 10000 });
+            resolvedPython = "python3";
+        }
+        catch {
+            resolvedPython = null;
+        }
+    }
+    if (resolvedPython) {
+        log("using python: " + resolvedPython);
+    }
+    else {
+        errLog("no working Python interpreter found (tried MEMPALACE_PYTHON, pipx venv, uv tool venv, PATH python3) — DB export disabled");
+    }
+    return resolvedPython;
+}
 let miningLock = false;
 let lastSyncTs = 0;
 let wakeupDone = false;
@@ -46,12 +84,19 @@ let wakeupDone = false;
 // official Stop hook: the hook decides WHEN, the model decides WHAT).
 let pendingCheckpoint = null;
 function runPython(code) {
+    const python = resolvePython();
+    if (!python)
+        throw new Error("no working Python interpreter (see hook.log)");
     writeFileSync(TMP_SCRIPT, code);
     try {
-        return execSync(`${VENV_PYTHON} ${TMP_SCRIPT}`, { encoding: "utf-8", timeout: 30000 }).trim();
+        // argv array, no shell (see PR #2): paths here are fixed, never user input.
+        return execFileSync(python, [TMP_SCRIPT], { encoding: "utf-8", timeout: 30000 }).trim();
     }
     finally {
-        unlinkSync(TMP_SCRIPT);
+        try {
+            unlinkSync(TMP_SCRIPT);
+        }
+        catch { }
     }
 }
 function hasText(parts) {
@@ -99,7 +144,8 @@ function persistCounters(counters) {
 }
 function mempalaceWakeup() {
     try {
-        const out = execSync(`${MEMPALACE_BIN} wake-up`, { encoding: "utf-8", timeout: 15000 }).trim();
+        // argv array, no shell.
+        const out = execFileSync(MEMPALACE_BIN, ["wake-up"], { encoding: "utf-8", timeout: 15000 }).trim();
         if (!out)
             return "";
         return out.slice(0, MAX_WAKEUP_CHARS);
@@ -133,7 +179,9 @@ function readIdentity() {
 }
 function mempalaceSearch(query) {
     try {
-        const out = execSync(`${MEMPALACE_BIN} search "${query.replace(/"/g, '\\"')}" --results ${MAX_SEARCH_RESULTS}`, {
+        // argv array, no shell (see PR #2): the query is raw user message
+        // text, so it must never pass through /bin/sh. No manual escaping needed.
+        const out = execFileSync(MEMPALACE_BIN, ["search", query, "--results", String(MAX_SEARCH_RESULTS)], {
             encoding: "utf-8",
             timeout: 15000,
         }).trim();
@@ -162,7 +210,7 @@ function dbSync() {
         doDbSync();
     }
     catch (e) {
-        log("sync err: " + String(e));
+        errLog("sync err: " + String(e));
     }
 }
 function backfillRequested() {
@@ -270,8 +318,10 @@ function markSynced(now) {
 // Official classification: decisions, preferences, milestones, problems,
 // emotional context. Agent tag keeps opencode-mined drawers attributable.
 // One wing per project (official multi-project pattern).
-function mineCommand(wingDir, wing) {
-    return `${MEMPALACE_BIN} mine ${wingDir} --mode convos --extract general --agent opencode --wing ${wing}`;
+// Argv array, no shell (see PR #2): wing names are sanitized, but the
+// spawn path stays shell-free regardless.
+function mineArgs(wingDir, wing) {
+    return ["mine", wingDir, "--mode", "convos", "--extract", "general", "--agent", "opencode", "--wing", wing];
 }
 function cleanupExport(wings) {
     for (const files of wings.values()) {
@@ -323,13 +373,16 @@ function doDbSync() {
             return;
         }
         const [wing, files] = entries[i];
-        exec(mineCommand(join(OUT_DIR, wing), wing), {
+        // No timeout here by design (see PR #4): Node would kill only the
+        // wrapper shell and orphan the python mine process, which keeps
+        // holding the palace lock while the next mine piles up. miningLock
+        // already serializes concurrent mines; long mines run to completion.
+        execFile(MEMPALACE_BIN, mineArgs(join(OUT_DIR, wing), wing), {
             encoding: "utf-8",
-            timeout: 300000,
         }, (err) => {
             if (err) {
                 miningLock = false;
-                log(`mine err (${wing}): ${err.message}`);
+                errLog(`mine err (${wing}): ${err.message}`);
                 return;
             }
             log(`mined wing ${wing} (${files.length} sessions)`);
@@ -347,12 +400,12 @@ function exitSync() {
             return;
         for (const [wing] of wings) {
             log(`exit save: mining wing ${wing}`);
-            const res = spawnSync(MEMPALACE_BIN, ["mine", join(OUT_DIR, wing), "--mode", "convos", "--extract", "general", "--agent", "opencode", "--wing", wing], {
+            const res = spawnSync(MEMPALACE_BIN, mineArgs(join(OUT_DIR, wing), wing), {
                 encoding: "utf-8",
                 timeout: 60000,
             });
             if (res.error || res.status !== 0) {
-                log(`exit mine err (${wing}): ${String(res.error || res.status)}`);
+                errLog(`exit mine err (${wing}): ${String(res.error || res.status)}`);
                 return;
             }
         }
@@ -361,7 +414,7 @@ function exitSync() {
         log("exit save done");
     }
     catch (e) {
-        log("exit save err: " + String(e));
+        errLog("exit save err: " + String(e));
     }
 }
 export default (async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-mempalace-persistence",
-  "version": "2.0.1",
+  "version": "2.1.0",
   "description": "OpenCode plugin — auto-sync conversations to MemPalace memory in real-time. No forced wings, KG extraction via MCP tools.",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",