opencode-harness-kit 0.4.3 → 0.4.5

package/bin/baseline.mjs

@@ -19,18 +19,24 @@ const wantJson = args.includes("--json")
 const dbArg = args.indexOf("--db")
 const DB = dbArg >= 0 ? args[dbArg + 1] : join(homedir(), ".local/share/opencode/opencode.db")
 
+const { canQuerySqlite, sqliteMissingMessage, query: queryDb } = await import("../src/sqlite.js")
+
 if (!existsSync(DB)) {
   console.error(`opencode database not found: ${DB}`)
   console.error("pass --db <path> or run opencode at least once first")
   process.exit(1)
 }
 
+// The sqlite3 CLI, not the library. A missing tool is a thing a person can
+// fix, and the failure used to be a raw `spawnSync sqlite3 ENOENT` stack
+// trace.
+if (!canQuerySqlite()) {
+  console.error(sqliteMissingMessage())
+  process.exit(1)
+}
+
 function query(sql) {
-  const out = execFileSync("sqlite3", ["-json", `file:${DB}?mode=ro`, sql], {
-    encoding: "utf8",
-    maxBuffer: 256 * 1024 * 1024,
-  }).trim()
-  return out ? JSON.parse(out) : []
+  return queryDb(DB, sql)
 }
 
 const ASSISTANT = `json_extract(data,'$.role')='assistant'`
@@ -163,7 +169,9 @@ const topAskers = () => {
 // allowlist, which meant the number it reported was whatever the list looked
 // like when the copy was last edited. Every tuning decision in this project is
 // supposed to rest on this measurement, so it has to measure the real list.
-const { BASH_ALLOWLIST } = await import(new URL("../src/config.js", import.meta.url))
+const { BASH_ALLOWLIST } = await import(
+  new URL("../src/config.js", import.meta.url).href,
+)
 const kitAllowlist = BASH_ALLOWLIST
 const currentAllow = [
   "git status *", "git log *", "git diff *", "grep *",
@@ -184,7 +192,7 @@ const paidEquivalent =
 //
 // This exists because the kit once shipped max_lines 200 / max_bytes 8192 on
 // the reasoning that tight truncation "saves context", and a later install
-// measured 415 of 2,959 reads exceeding 8 KB against 418 reads issued with an
+// measured 415 of 2,966 reads exceeding 8 KB against 423 reads issued with an
 // `offset`. Truncation causes the re-read roughly one for one, and at the
 // measured ~17s median per request that round trip is more expensive than the
 // tokens it saves. Re-run this before changing these numbers again.

package/bin/git-hooks/pre-commit

@@ -1,12 +1,23 @@
 #!/bin/sh
 # Installed by `oc-harness install`. Remove with: rm .git/hooks/pre-commit
 #
-# Runs the offline gate on every commit. The live-install half is deliberately
-# left out: measure and attribute read ~/.local/share/opencode, which is slow,
-# machine-specific, and irrelevant to whether a commit broke the kit.
+# It runs the PROJECT's own checks, and only if the project has any.
 #
-# On a machine that has never run OpenCode, test:install cannot run at all, so
-# this hook uses the subset that needs nothing but the repository.
+# The previous version ran `npm run test:all`, which is a script of THIS KIT,
+# not of the project the hook was installed into. So in every project that
+# installed the kit, every commit failed with:
+#
+#     npm error Missing script: "test:all"
+#
+# until the author reached for --no-verify. A gate that blocks every commit
+# is not a gate.
+#
+# The kit's own repository is the exception, and it is handled by the script
+# list below: `test:all` is there, so the kit gates itself.
+#
+# The live-install half is deliberately left out: measure and attribute read
+# ~/.local/share/opencode, which is slow, machine-specific, and irrelevant to
+# whether a commit broke anything.
 
 set -e
 
@@ -18,13 +29,34 @@ if [ -n "$SKIP_SPACE_HARNESS_HOOK" ]; then
   exit 0
 fi
 
-echo "pre-commit: npm run test:all"
-if ! npm run test:all >/tmp/space-harness-hook.log 2>&1; then
+# No package.json, no JavaScript project, no gate.
+if [ ! -f package.json ]; then
+  exit 0
+fi
+
+# The gate is the project's own test script, if it has one. The kit's own
+# repository has `test:all`, which is the offline half of its gate.
+gate=""
+if node -e "process.exit(require('./package.json').scripts?.['test:all'] ? 0 : 1)" 2>/dev/null; then
+  gate="test:all"
+elif node -e "process.exit(require('./package.json').scripts?.test ? 0 : 1)" 2>/dev/null; then
+  gate="test"
+fi
+
+if [ -z "$gate" ]; then
+  # Nothing to run. A hook that blocks every commit because the project has
+  # no test script is worse than no hook.
+  exit 0
+fi
+
+log="${TMPDIR:-/tmp}/space-harness-hook.log"
+echo "pre-commit: npm run $gate"
+if ! npm run "$gate" >"$log" 2>&1; then
   echo "pre-commit: FAILED. Last lines:"
-  tail -30 /tmp/space-harness-hook.log
+  tail -30 "$log"
   echo ""
   echo "Fix it, or commit with --no-verify if you are certain it is not yours."
   exit 1
 fi
 
-exit 0
+exit 0