opencode-collaboration 0.5.1 → 0.6.0

package/README.md

@@ -96,7 +96,7 @@ Other Opencode sessions (2):
 Use send_message to tell "backend" that the login form now posts to /v2/login.
 ```
 
-The receiving session gets the text immediately as a synthetic user message, including the sender's exact endpoint ID and how to reply. `send_message` returns a tracking ID; use `peer_message_status` or `/peers-outbox` to distinguish transport receipt from final delivery.
+The receiving session gets the text immediately as a synthetic user message, including the sender's exact endpoint ID and how to reply. The receiver is told to reply via `send_message` only when a response is actually expected, and is explicitly told not to send acknowledgement-only messages — so two agents do not loop politely forever. `send_message` returns a tracking ID; use `peer_message_status` or `/peers-outbox` to distinguish transport receipt from final delivery.
 
 **Review held messages** (when `inboundPolicy` is `"hold"`):
 

package/README.zh-CN.md

@@ -96,7 +96,7 @@ Other Opencode sessions (2):
 Use send_message to tell "backend" that the login form now posts to /v2/login.
 ```
 
-接收方会话会立即收到这条文本，以一条合成的用户消息形式出现，其中包含发送方精确的端点 ID 以及回复方式。`send_message` 返回一个追踪 ID；用 `peer_message_status` 或 `/peers-outbox` 来区分"传输层已收到"和"最终已投递"。
+接收方会话会立即收到这条文本，以一条合成的用户消息形式出现，其中包含发送方精确的端点 ID 以及回复方式。接收方被要求**只在确实需要回应时**才通过 `send_message` 回复，并明确禁止仅确认/致谢类消息——避免两个 agent 无限礼貌往返。`send_message` 返回一个追踪 ID；用 `peer_message_status` 或 `/peers-outbox` 来区分"传输层已收到"和"最终已投递"。
 
 **审阅待审消息**（当 `inboundPolicy` 为 `"hold"` 时）：
 

package/dist/delivery.js

@@ -15,10 +15,16 @@ const FOOTER = "---\n" +
 // appends this to the agent's own system prompt (LLMRequestPrep.prepare), so it
 // never replaces it and does not leak into later turns or other sessions.
 const REPLY_DIRECTIVE = "This turn was triggered by a plain-text message from another opencode session (a peer), " +
-    "not by your user. Your user cannot see it, and your normal chat reply is NOT delivered to " +
-    "the peer. To respond — including to ask a clarifying question or request missing details — " +
-    "you MUST call the send_message tool with `to` set to the sender's name. Never answer a peer " +
-    "by typing a normal chat reply.";
+    "not by your user. Your user cannot see it, and your normal chat reply is NOT delivered to the peer. " +
+    "Reply only when a reply is actually expected:\n" +
+    "- If the peer asked a question, requested work, or is waiting for your response, call the " +
+    "send_message tool with `to` set to the sender's name.\n" +
+    "- If the message is only an acknowledgement, a thank-you, an agreement, a status update that " +
+    "needs no action, or a confirmation that the task is done, do NOT reply — briefly tell your user and stop.\n" +
+    "Never send acknowledgement-only, thanks, or agreement messages: they cause an endless " +
+    "back-and-forth between agents. Once you and the peer have reached a conclusion, stop.\n" +
+    "When you call send_message (or any tool), always include a brief text message in the same " +
+    "assistant turn; never emit a bare tool call with no text.";
 const NOTICE_FOOTER = "---\n" +
     "This is an automated notification from the opencode-collaboration plugin. " +
     "Show it to the user verbatim, then stop. Do not take further action.";
@@ -29,8 +35,11 @@ export function formatMessages(messages) {
         ? `to="${senders[0].name}" (exact endpoint ID "${senders[0].instanceId}")`
         : `to the sender name shown in each message header (endpoint IDs ${senders.map((sender) => `"${sender.instanceId}"`).join(", ")})`;
     const header = "[incoming message from another opencode session — this is NOT from your user. " +
-        "Reply by calling the send_message tool; a normal chat reply is never delivered to the sender.]";
-    return header + "\n\n" + blocks.join("\n\n") + "\n\n" + FOOTER + ` To reply, call the send_message tool with ${replyTarget}.`;
+        "To reply to the sender, call the send_message tool; a normal chat reply is never delivered. " +
+        "Reply only if the peer expects a response — do not acknowledge just to be polite.]";
+    return header + "\n\n" + blocks.join("\n\n") + "\n\n" + FOOTER +
+        ` To reply, call the send_message tool with ${replyTarget}. ` +
+        "Reply only if a response is expected; do not send acknowledgement-only messages.";
 }
 export function deterministicPeerMessageId(sessionId, message) {
     const digest = createHash("sha256")

package/dist/index.js

@@ -31,6 +31,7 @@ import { Outbox } from "./outbox.js";
 import { PeerPermissions } from "./permissions.js";
 import { buildPeerTools } from "./tools/peers-tools.js";
 import { handlePeersCommand } from "./commands.js";
+import { sanitizeMessages } from "./sanitize.js";
 import { consumeCommand, createLogger, errorMessage } from "./feedback.js";
 // Read the real package version at runtime so registry entries never report a
 // stale hardcoded number. Falls back to "0.0.0" if package.json is unavailable.
@@ -296,6 +297,22 @@ export const PeersPlugin = async (ctx, pluginOptions) => {
             if (!disposing)
                 await registry.heartbeat();
         },
+        "experimental.chat.messages.transform": async (_input, output) => {
+            if (disposing)
+                return;
+            // Clean the model-bound history before any provider sees it. opencode can
+            // leave empty text parts on tool-call turns and fully-empty assistant
+            // messages on failed turns; strict providers reject both, poisoning every
+            // later request in the session. Stripping them here is non-destructive to
+            // the stored history (parentID/tool pairing is untouched).
+            const messages = output.messages;
+            if (!Array.isArray(messages) || messages.length === 0)
+                return;
+            const dropped = sanitizeMessages(messages);
+            if (dropped > 0) {
+                await logger("warn", "stripped empty assistant messages from the outgoing history", { dropped });
+            }
+        },
         "command.execute.before": async (input, output) => {
             if (disposing)
                 return;

package/dist/sanitize.d.ts

@@ -0,0 +1,28 @@
+/**
+ * Sanitization for the model-bound conversation history.
+ *
+ * opencode can record tool-call turns with an empty text part (text="") and,
+ * when a turn fails to stream, a fully empty assistant message (0 parts).
+ * Strict model providers reject either ("missing input.content.text",
+ * "assistant must not be empty"), poisoning every later request in the
+ * session. We clean the outgoing history in the
+ * experimental.chat.messages.transform hook instead of touching storage, so
+ * provider-side parentID/tool pairing is never disturbed.
+ */
+export interface SanitizeMessage {
+    info?: {
+        role?: string;
+        summary?: boolean;
+    };
+    parts?: Array<{
+        type?: string;
+        text?: string;
+    }>;
+}
+/**
+ * Mutates `messages` in place:
+ *  - removes empty/whitespace-only text parts from every message, and
+ *  - drops assistant messages that end up with no parts at all.
+ * Returns how many assistant messages were dropped.
+ */
+export declare function sanitizeMessages<T extends SanitizeMessage>(messages: T[]): number;

package/dist/sanitize.js

@@ -0,0 +1,38 @@
+/**
+ * Sanitization for the model-bound conversation history.
+ *
+ * opencode can record tool-call turns with an empty text part (text="") and,
+ * when a turn fails to stream, a fully empty assistant message (0 parts).
+ * Strict model providers reject either ("missing input.content.text",
+ * "assistant must not be empty"), poisoning every later request in the
+ * session. We clean the outgoing history in the
+ * experimental.chat.messages.transform hook instead of touching storage, so
+ * provider-side parentID/tool pairing is never disturbed.
+ */
+/**
+ * Mutates `messages` in place:
+ *  - removes empty/whitespace-only text parts from every message, and
+ *  - drops assistant messages that end up with no parts at all.
+ * Returns how many assistant messages were dropped.
+ */
+export function sanitizeMessages(messages) {
+    for (const message of messages) {
+        if (Array.isArray(message.parts)) {
+            message.parts = message.parts.filter((part) => part?.type !== "text" || (part.text ?? "").trim().length > 0);
+        }
+    }
+    let dropped = 0;
+    for (let index = messages.length - 1; index >= 0; index--) {
+        const message = messages[index];
+        const role = message.info?.role;
+        // Never drop compaction summary messages (info.summary === true): the model
+        // may depend on them for context that predates the compaction.
+        if (role === "assistant" &&
+            message.info?.summary !== true &&
+            (!message.parts || message.parts.length === 0)) {
+            messages.splice(index, 1);
+            dropped++;
+        }
+    }
+    return dropped;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "opencode-collaboration",
-  "version": "0.5.1",
+  "version": "0.6.0",
   "description": "Cross-session messaging for opencode — let independent sessions discover and text each other, modeled after Claude Code's cross-session messaging",
   "type": "module",
   "main": "./dist/index.js",