opencode-agent-skill 15.0.0 → 15.1.1

package/pi/extensions/ues-child-runtime.ts

@@ -1,11 +1,16 @@
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
 import { Type } from "typebox";
 import { readFile, stat } from "node:fs/promises";
+import path from "node:path";
 import { compactReversibleOutput } from "../../lib/performance-fabric.mjs";
 import { getEvidenceSelected } from "../../lib/evidence-store.mjs";
 import { recordVerification } from "../../lib/verification-broker.mjs";
 import { runtimeWorkspaceFingerprint } from "../../lib/workspace-fingerprint.mjs";
 import { destructiveShellRisk } from "../../lib/safety.mjs";
+import { getUesConfigDir } from "../../lib/runtime-config.mjs";
+import { PermissionPolicyStore, permissionRecoveryHint, toolPermissionRequest } from "../../lib/permission-policy.mjs";
+import { analyzeUntrustedOutput, renderUntrustedOutputWarning } from "../../lib/untrusted-output.mjs";
+import { mcpExecutionPolicy } from "../../lib/mcp-tool-policy.mjs";
 import { crossToolTempPathRisk, isLocalEnvPath, localEnvWriteRisk } from "../../lib/execution-contract.mjs";
 import {
   canonicalVerificationCommand,
@@ -14,9 +19,11 @@ import {
 import {
   applyAnchoredFileEdits,
   diagnoseCode,
+  lspOperation,
   probeCodeIntelligence,
   readAnchoredCode,
   searchCodeIntelligence,
+  shutdownLspPool,
 } from "../../lib/code-intelligence/index.mjs";
 import { ingestDocument } from "../../lib/document-ingestion.mjs";
 import { compactContext, expandContext, searchContext } from "../../lib/reversible-context.mjs";
@@ -31,6 +38,16 @@ import {
   waitForService,
 } from "../../lib/service-manager.mjs";
 
+const PERMISSION_POLICY = new PermissionPolicyStore(
+  path.join(getUesConfigDir(), ".ues", "permissions.json"),
+);
+const EXTERNAL_TOOL_NAMES = new Set(
+  String(process.env.UES_CHILD_EXTERNAL_TOOL_NAMES || "")
+    .split(",")
+    .map((value) => value.trim())
+    .filter(Boolean),
+);
+
 const toolExecutionState = new Map<string, {
   startedAt: number;
   workspaceBefore?: string;
@@ -101,12 +118,45 @@ export default function (pi: ExtensionAPI) {
   pi.on("session_start", clearExecutionState);
   pi.on("session_shutdown", async (_event, ctx) => {
     clearExecutionState();
-    await stopAllServices(ctx.cwd).catch(() => []);
+    await Promise.all([
+      stopAllServices(ctx.cwd).catch(() => []),
+      shutdownLspPool(ctx.cwd).catch(() => ({ stopped: 0, remaining: 0 })),
+    ]);
   });
 
   pi.on("tool_call", async (event, ctx) => {
     const toolName = String(event.toolName || "");
     const input: any = event.input || {};
+    const permissionRequest = toolPermissionRequest(toolName, input);
+    const configuredPermission: any = await PERMISSION_POLICY.evaluate(
+      permissionRequest,
+      { agent: String(process.env.UES_CHILD_AGENT || "ues-child") },
+    ).catch((error) => ({
+      configured: true,
+      decision: null,
+      error: error instanceof Error ? error.message : String(error),
+    }));
+    if (configuredPermission.error) {
+      toolExecutionState.delete(String(event.toolCallId || ""));
+      return {
+        block: true,
+        reason: "UES permission policy is invalid: " + configuredPermission.error,
+      };
+    }
+    if (configuredPermission?.decision?.effect === "deny") {
+      toolExecutionState.delete(String(event.toolCallId || ""));
+      return {
+        block: true,
+        reason: permissionRecoveryHint(permissionRequest, configuredPermission.decision, { effect: "deny" }),
+      };
+    }
+    if (configuredPermission?.decision?.effect === "ask") {
+      toolExecutionState.delete(String(event.toolCallId || ""));
+      return {
+        block: true,
+        reason: permissionRecoveryHint(permissionRequest, configuredPermission.decision, { effect: "ask" }),
+      };
+    }
     const localEnvAllowed = String(process.env.UES_CHILD_ALLOW_LOCAL_ENV_WRITE || "") === "1";
     const writeTool = ["edit", "write", "write_file", "apply_patch", "ues_code_edit"].includes(toolName);
     const fileTool = ["read", "edit", "write", "write_file", "apply_patch", "ues_code", "ues_code_edit"].includes(toolName);
@@ -185,11 +235,37 @@ export default function (pi: ExtensionAPI) {
 
   pi.on("tool_result", async (event, ctx) => {
     const toolName = String(event.toolName || "");
+    const shownText = visibleText(event);
+    const allTools = typeof (pi as any).getAllTools === "function" ? (pi as any).getAllTools() : [];
+    const descriptor = allTools.find((tool: any) => String(tool?.name || "") === toolName);
+    const externalPolicy = mcpExecutionPolicy(descriptor || { name: toolName });
+    const externalBoundary =
+      EXTERNAL_TOOL_NAMES.has(toolName) ||
+      externalPolicy.externalEvidenceBoundary === true;
+    if (externalBoundary && shownText) {
+      const analysis = analyzeUntrustedOutput(shownText, { source: toolName });
+      if (analysis.flagged) {
+        const originalContent = Array.isArray(event.content)
+          ? event.content
+          : [{ type: "text", text: shownText }];
+        return {
+          content: [
+            { type: "text", text: renderUntrustedOutputWarning(analysis, { source: toolName }) },
+            ...originalContent,
+          ],
+          details: {
+            ...(event.details && typeof event.details === "object" ? event.details : {}),
+            uesUntrustedOutputBoundary: analysis,
+          },
+          isError: event.isError,
+          usage: event.usage,
+        };
+      }
+    }
+
     if (!["bash", "powershell", "grep", "find", "ls"].includes(toolName)) {
       return undefined;
     }
-
-    const shownText = visibleText(event);
     const capture = await capturedText(event, shownText);
     const rawText = capture.text;
     const images = (event.content || []).filter((part: any) => part?.type !== "text");
@@ -272,13 +348,20 @@ export default function (pi: ExtensionAPI) {
     name: "ues_code",
     label: "UES Code Intelligence",
     description:
-      "Bounded code/document/context intelligence for weak models: semantic/AST search, hash-anchored reads, optional LSP diagnostics, optional MarkItDown ingestion, and reversible context recovery.",
+      "Bounded code/document/context intelligence for weak models: semantic/AST search, hash-anchored reads, deterministic LSP definition/references/symbols/hover/rename-preview/call hierarchy, diagnostics, optional MarkItDown ingestion, and reversible context recovery.",
     parameters: Type.Object({
       action: Type.Union([
         Type.Literal("status"),
         Type.Literal("search"),
         Type.Literal("read"),
         Type.Literal("diagnostics"),
+        Type.Literal("definition"),
+        Type.Literal("references"),
+        Type.Literal("symbols"),
+        Type.Literal("hover"),
+        Type.Literal("rename-preview"),
+        Type.Literal("incoming-calls"),
+        Type.Literal("outgoing-calls"),
         Type.Literal("document"),
         Type.Literal("context-expand"),
         Type.Literal("context-search"),
@@ -289,6 +372,10 @@ export default function (pi: ExtensionAPI) {
       language: Type.Optional(Type.String()),
       startLine: Type.Optional(Type.Number({ minimum: 1 })),
       endLine: Type.Optional(Type.Number({ minimum: 1 })),
+      line: Type.Optional(Type.Number({ minimum: 1, description: "1-based source line for LSP operations" })),
+      character: Type.Optional(Type.Number({ minimum: 1, description: "1-based source character for LSP operations" })),
+      newName: Type.Optional(Type.String({ minLength: 1, maxLength: 512 })),
+      includeDeclaration: Type.Optional(Type.Boolean()),
       ref: Type.Optional(Type.String()),
       maxBytes: Type.Optional(Type.Number({ minimum: 1, maximum: 128000 })),
     }),
@@ -320,7 +407,18 @@ export default function (pi: ExtensionAPI) {
           };
         } else if (params.action === "diagnostics") {
           if (!params.file) throw new Error("ues_code diagnostics requires file");
-          result = await diagnoseCode(ctx.cwd, params.file, { timeoutMs: 3000, maxDiagnostics: 40 });
+          result = await diagnoseCode(ctx.cwd, params.file, { timeoutMs: 5000, maxResults: 80 });
+        } else if (["definition", "references", "symbols", "hover", "rename-preview", "incoming-calls", "outgoing-calls"].includes(params.action)) {
+          if (!params.file) throw new Error(`ues_code ${params.action} requires file`);
+          if (params.action === "rename-preview" && !params.newName) throw new Error("ues_code rename-preview requires newName");
+          result = await lspOperation(ctx.cwd, params.file, params.action, {
+            line: params.line || 1,
+            character: params.character || 1,
+            newName: params.newName,
+            includeDeclaration: params.includeDeclaration,
+            timeoutMs: 7000,
+            maxResults: 120,
+          });
         } else if (params.action === "document") {
           if (!params.file) throw new Error("ues_code document requires file");
           const document = await ingestDocument(ctx.cwd, params.file, { maxBytes: Math.min(Number(params.maxBytes || 4 * 1024 * 1024), 4 * 1024 * 1024) });