opencode-acp 1.14.18-pr.307.19 → 1.14.19-pr.297.30

package/README.md

@@ -284,7 +284,8 @@ Each level overrides the previous, so project settings take priority over global
     // Automatically update npm-installed ACP when a newer npm latest is available.
     // Version-locked plugin specs are not updated.
     "autoUpdate": true,
-    // Enable debug logging to ~/.config/opencode/logs/acp/
+    // Enable INFO/DEBUG logging + per-request snapshots to ~/.config/opencode/logs/acp/
+    // (WARN/ERROR are always logged to daily/<date>.log)
     "debug": false,
     // Notification display: "off", "minimal", or "detailed"
     "pruneNotification": "off",
@@ -492,6 +493,16 @@ For the complete list with root cause analysis, see the [bug tracker](https://gi
 
 ## Changelog
 
+### v1.14.19 — Fix release pipeline for real (npm 10 `--ignore-scripts` bug)
+
+**Problem**: v1.14.18 (#306) was merged but still never published — `release.yml` failed at the exact same step. Root cause of the failed fix: the CI runner uses Node 22 (npm 10.9.x), and **npm 10 runs the `prepare` lifecycle hook during `npm pack` even when `--ignore-scripts` is passed**. v1.14.18's fix (`npm pack --ignore-scripts`) works on npm 11 but is a no-op on npm 10. When prepare runs, tsup writes `CLI Building entry: index.ts` to **stdout**, breaking `JSON.parse` in `verify-package.mjs` (`SyntaxError: Unexpected token`).
+
+**Fix**: Redirect the `prepare` build's stdout to stderr: `"prepare": "npm run build 1>&2"` in `package.json`. Build output (informational) goes to stderr; stdout stays pure JSON regardless of npm version or whether `--ignore-scripts` works. Verified empirically with npm 10.9.9 locally: `npm pack --dry-run --json` now returns valid JSON (173 tarball entries) both with and without `--ignore-scripts`. The `--ignore-scripts` flag added in v1.14.18 is kept (harmless on npm 10, skips the redundant rebuild on npm 11). The `npm install github:...#branch` path still works — prepare still runs and still builds `dist/`.
+
+Files: `package.json`. Tests: 976 pass; `check:package` green on npm 10.9.9 and npm 11.12.1.
+
+**Install**: `opencode plugin opencode-acp@latest --global`
+
 ### v1.14.18 — Supersedes unpublished v1.14.17; fix release pipeline
 
 **Problem**: v1.14.17 was merged (#305) but never published — `release.yml` failed at `npm run check:package` because the `prepare` hook added in #298 (`npm run build`) runs during `npm pack --json` inside `verify-package.mjs`, and tsup's `CLI Building entry: index.ts` stdout output breaks `JSON.parse` (`SyntaxError: Unexpected token 'C'`).

package/README.zh-CN.md

@@ -239,7 +239,8 @@ ACP 使用自己的配置文件，按以下顺序搜索：
     // Automatically update npm-installed ACP when a newer npm latest is available.
     // Version-locked plugin specs are not updated.
     "autoUpdate": true,
-    // Enable debug logging to ~/.config/opencode/logs/acp/
+    // Enable INFO/DEBUG logging + per-request snapshots to ~/.config/opencode/logs/acp/
+    // (WARN/ERROR are always logged to daily/<date>.log)
     "debug": false,
     // Notification display: "off", "minimal", or "detailed"
     "pruneNotification": "detailed",
@@ -446,6 +447,16 @@ ACP 是 DCP 的直接替代品。迁移步骤：
 
 ## 更新日志
 
+### v1.14.19 — 彻底修复发版流水线（npm 10 `--ignore-scripts` 失效）
+
+**问题**：v1.14.18（#306）已合并但依然没有发布 —— `release.yml` 又在同一步骤失败。v1.14.18 修复失败的根本原因：CI 运行器是 Node 22（npm 10.9.x），而 **npm 10 在 `npm pack` 时即使传了 `--ignore-scripts` 也照样执行 `prepare` 生命周期钩子**。v1.14.18 的修复（`npm pack --ignore-scripts`）在 npm 11 上有效，在 npm 10 上是空操作。prepare 一旦执行，tsup 会把 `CLI Building entry: index.ts` 写到 **stdout**，破坏 `verify-package.mjs` 里的 `JSON.parse`（`SyntaxError: Unexpected token`）。
+
+**修复**：把 `prepare` 构建的 stdout 重定向到 stderr：`package.json` 中改为 `"prepare": "npm run build 1>&2"`。构建输出（信息性）走 stderr，stdout 无论 npm 版本、无论 `--ignore-scripts` 是否生效都保持纯 JSON。已在本地用 npm 10.9.9 实证验证：`npm pack --dry-run --json` 现在返回合法 JSON（173 个 tarball 条目），带与不带 `--ignore-scripts` 均通过。v1.14.18 加的 `--ignore-scripts` 标志保留（npm 10 上无害，npm 11 上跳过多余重建）。`npm install github:...#branch` 路径不受影响 —— prepare 照常执行并构建 `dist/`。
+
+文件：`package.json`。测试：976 通过；`check:package` 在 npm 10.9.9 和 npm 11.12.1 上均绿。
+
+**安装**：`opencode plugin opencode-acp@latest --global`
+
 ### v1.14.18 — 取代未能发布的 v1.14.17；修复发版流水线
 
 **问题**：v1.14.17 已合并（#305）但从未发布 —— \`release.yml\` 在 \`npm run check:package\` 一步失败：#298 新增的 \`prepare\` 钩子（\`npm run build\`）会在 \`verify-package.mjs\` 的 \`npm pack --json\` 期间运行，tsup 的 \`CLI Building entry: index.ts\` 输出污染 stdout，导致 \`JSON.parse\` 报错（\`SyntaxError: Unexpected token 'C'\`）。

package/dist/index.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAA;AA2BjD,QAAA,MAAM,MAAM,EAAE,MAiHK,CAAA;AAEnB,eAAe,MAAM,CAAA"}
+{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,MAAM,EAAE,MAAM,qBAAqB,CAAA;AA2BjD,QAAA,MAAM,MAAM,EAAE,MA6IK,CAAA;AAEnB,eAAe,MAAM,CAAA"}

package/dist/index.js

@@ -2949,6 +2949,51 @@ function applyPendingCompressionDurations(state) {
   return updates;
 }
 
+// lib/state/model-limits.ts
+function createModelLimitCatalog() {
+  const modelLimits = /* @__PURE__ */ new Map();
+  return {
+    record(providerId, modelId, limit) {
+      if (!providerId || !modelId || typeof limit !== "number" || limit <= 0) return;
+      modelLimits.set(`${providerId}/${modelId}`, limit);
+    },
+    resolve(providerId, modelId) {
+      if (!providerId || !modelId) return void 0;
+      return modelLimits.get(`${providerId}/${modelId}`);
+    },
+    /**
+     * Best-effort one-time seed from the host's provider catalog
+     * (`client.config.providers()` → GET /config/providers). Never throws;
+     * returns the number of model-limit entries recorded.
+     */
+    async hydrateFromClient(client) {
+      try {
+        const config = client;
+        const result = await config.config?.providers?.();
+        const payload = result;
+        const providers = payload?.data?.providers;
+        if (!Array.isArray(providers)) return 0;
+        let recorded = 0;
+        for (const provider of providers) {
+          const { id, models } = provider ?? {};
+          if (typeof id !== "string" || !models) continue;
+          for (const [modelId, model] of Object.entries(models)) {
+            const limit = model?.limit;
+            const context = limit?.context;
+            if (typeof context === "number" && context > 0) {
+              modelLimits.set(`${id}/${modelId}`, context);
+              recorded++;
+            }
+          }
+        }
+        return recorded;
+      } catch {
+        return 0;
+      }
+    }
+  };
+}
+
 // lib/compress/search.ts
 import { tool } from "@opencode-ai/plugin";
 async function fetchSessionMessages(client, sessionId) {
@@ -4140,6 +4185,26 @@ var SessionStateRegistry = class {
     startsByCallId: /* @__PURE__ */ new Map(),
     pendingByCallId: /* @__PURE__ */ new Map()
   };
+  // [FIX #312] Model-limit catalog (full rationale in ./model-limits.ts):
+  // lets the messages hook reconcile state.modelContextLimit against the
+  // model named on the request's user message instead of waiting one turn
+  // for the system hook. Shared implementation — the test registry stub
+  // composes the same factory.
+  catalog = createModelLimitCatalog();
+  recordModelLimit(providerId, modelId, limit) {
+    this.catalog.record(providerId, modelId, limit);
+  }
+  resolveModelLimit(providerId, modelId) {
+    return this.catalog.resolve(providerId, modelId);
+  }
+  /**
+   * Best-effort one-time seed from the host's provider catalog
+   * (`client.config.providers()` → GET /config/providers). Never throws;
+   * returns the number of model-limit entries recorded.
+   */
+  hydrateModelLimitsFromClient(client) {
+    return this.catalog.hydrateFromClient(client);
+  }
   get(sessionId) {
     return this.states.get(sessionId);
   }
@@ -4688,8 +4753,8 @@ ${progressBar}`;
   let toastMessage = message;
   toastMessage = config.pruneNotification === "minimal" ? toastMessage : truncateToastBody(toastMessage);
   if (config.debug) {
-    const chatMessage = config.pruneNotification === "minimal" ? message : truncateToastBody(message);
-    await sendIgnoredMessage(client, sessionId, chatMessage, params, logger);
+    logger.debug(`[ACP Debug] Compress notification:
+${message}`);
   }
   await client.tui.showToast({
     body: {
@@ -5672,11 +5737,6 @@ exact values, errors). Then add "acknowledgeRisk": true to the compress tool cal
 Without acknowledgeRisk: true, the compression will be rejected again.`;
   return new Error(message);
 }
-function buildPreemptiveAcknowledgeError() {
-  return new Error(
-    'Parameter "acknowledgeRisk": true was provided, but no quality gate rejection is pending. This parameter is only valid immediately after a compression was rejected by the quality gate. Remove it and try again.'
-  );
-}
 
 // lib/compress/pipeline.ts
 function snapshotCompressionState(state) {
@@ -6150,13 +6210,13 @@ function createCompressRangeTool(factoryCtx) {
       }
       const acknowledgeRisk = args.acknowledgeRisk === true;
       const qualityGateRetryPendingBefore = ctx.state.qualityGateRetryPending;
-      if (acknowledgeRisk && !ctx.state.qualityGateRetryPending) {
-        throw buildPreemptiveAcknowledgeError();
+      const bypassQuality = acknowledgeRisk && ctx.state.qualityGateRetryPending;
+      const ignoredAcknowledgeRisk = acknowledgeRisk && !ctx.state.qualityGateRetryPending;
+      if (ignoredAcknowledgeRisk) {
+        ctx.logger.warn("compress: acknowledgeRisk ignored \u2014 no quality gate rejection pending");
       }
-      if (acknowledgeRisk) {
-        ctx.state.qualityGateRetryPending = false;
-      } else {
-        ctx.state.qualityGateRetryPending = false;
+      ctx.state.qualityGateRetryPending = false;
+      if (!bypassQuality) {
         for (const plan of preparedPlans) {
           const result = evaluatePreCommitQuality(
             rawMessages,
@@ -6232,7 +6292,10 @@ function createCompressRangeTool(factoryCtx) {
       const skippedNote = phantomSkipNotice !== null ? `
 \u26A0\uFE0F ${phantomSkipNotice}
 ` : "";
-      return `Compressed ${totalCompressedMessages} messages into ${COMPRESSED_BLOCK_HEADER}.${skippedNote}
+      const ackNote = ignoredAcknowledgeRisk ? `
+\u26A0\uFE0F acknowledgeRisk was ignored: no quality gate rejection was pending, so quality checks ran normally. Only pass it when retrying immediately after a quality gate rejection.
+` : "";
+      return `Compressed ${totalCompressedMessages} messages into ${COMPRESSED_BLOCK_HEADER}.${skippedNote}${ackNote}
 IMPORTANT: This was an automatic context compression. You MUST continue your previous task exactly where you left off. Do NOT ask the user what to do next.
 \u{1F4A1} Tip: Use search_context('keyword') to find compressed content when you need it later.`;
     }
@@ -7566,16 +7629,6 @@ var injectCompressNudges = (state, config, logger, messages, prompts, compressio
     { logger }
   );
   const hasRecommendations = recommendedRanges.length > 0;
-  if (config.debug && contextRanges.compressible.length > 0) {
-    const compressible = contextRanges.compressible;
-    const fmt = (n) => n >= 1e3 ? `${(n / 1e3).toFixed(1)}K` : String(n);
-    const lines = [
-      `[ACP Debug] Recommendation filter:`,
-      `  Input: ${compressible.length} range(s), ${fmt(compressible.reduce((s, r) => s + r.tokens, 0))} tokens`,
-      `  Output: ${recommendedRanges.length} range(s) (last segment marked dangerous)`
-    ];
-    logger.debug(lines.join("\n"));
-  }
   const allProtected = contextRanges.compressible.length === 0 && contextRanges.protected.length > 0;
   const allInProtectedZone = protectedRefs.size > 0 && unprotectedCompressible.length === 0;
   const nothingToCompress = allProtected || allInProtectedZone;
@@ -7671,6 +7724,16 @@ ${rules}`;
     }
   }
   state.nudges.shouldInjectThisTurn = shouldInject;
+  if (shouldInject && config.debug && contextRanges.compressible.length > 0) {
+    const compressible = contextRanges.compressible;
+    const fmt = (n) => n >= 1e3 ? `${(n / 1e3).toFixed(1)}K` : String(n);
+    const lines = [
+      `[ACP Debug] Recommendation filter:`,
+      `  Input: ${compressible.length} range(s), ${fmt(compressible.reduce((s, r) => s + r.tokens, 0))} tokens`,
+      `  Output: ${recommendedRanges.length} range(s) (last segment marked dangerous)`
+    ];
+    logger.debug(lines.join("\n"));
+  }
   let tipsText = null;
   if (shouldInject) {
     if (suffixMessage && composition.total > 0) {
@@ -8125,10 +8188,6 @@ function resolveSingleBlockTarget(messagesState, blockIdArg) {
         error: `Error: Block ${target.displayId} is nested inside active block ${activeAncestorBlockId}. Decompress block ${activeAncestorBlockId} first.`
       };
     }
-    return {
-      ok: false,
-      error: `Error: Block ${target.displayId} is not active. It may have already been decompressed.`
-    };
   }
   return { ok: true, targets: [target] };
 }
@@ -8281,7 +8340,7 @@ function createDecompressTool(factoryCtx) {
         const blockMessages = rawMessages.filter((m) => msgIdSet.has(extractMessageId(m)));
         const lines2 = blockMessages.map(extractMessageText2);
         const { writeFile: writeFile3 } = await import("fs/promises");
-        const fileContent = lines2.length > 0 ? lines2.join("\n\n---\n\n") : activeBlocks[0]?.summary ?? "(no content available)";
+        const fileContent = lines2.length > 0 ? lines2.join("\n\n---\n\n") : targets[0]?.blocks[0]?.summary ?? "(no content available)";
         await writeFile3(targetPath, fileContent, "utf-8");
         const displayIds2 = targets.map((t) => `b${t.displayId}`).join(", ");
         return `Block(s) ${displayIds2} content (${blockMessages.length} messages, ${fileContent.length} chars) written to ${targetPath}. Block(s) stay compressed \u2014 context unchanged. Use read tool to access specific parts.`;
@@ -8738,16 +8797,23 @@ function renderCompressedDrilldown(blocks, sort, limit, blocksById) {
   lines.push(`Sorted by ${sort === "time" ? "time" : sort === "age" ? "age" : "size"}`);
   lines.push("");
   const shown = sorted.slice(0, limit);
+  const activeCount = sorted.filter((b) => b.active).length;
+  const inactiveCount = sorted.length - activeCount;
+  if (inactiveCount > 0) {
+    lines.push(`${activeCount} active, ${inactiveCount} inactive/consumed`);
+    lines.push("");
+  }
   for (const b of shown) {
     const survived = b.survivedCount ?? 0;
     const gen = b.generation ?? "young";
     const effCount = b.effectiveMessageIds?.length ?? 0;
     const consumed = b.includedBlockIds && b.includedBlockIds.length > 0 ? ` nested=[${b.includedBlockIds.map((n) => `b${n}`).join(",")}]` : "";
+    const status = b.active ? "" : " [inactive]";
     const topic = b.topic || "(no topic)";
     const tier = tierLabel(b);
     const effTokens = getEffectiveCompressedTokens(b, blocksById);
     lines.push(
-      `  b${b.blockId} (${tier})  ${formatTokens(effTokens)}\u2192${formatTokens(b.summaryTokens)}  ${formatAge(b.createdAt)}  ${formatIdRange(b)}  age=${survived} ${gen} eff=${effCount}${consumed}`
+      `  b${b.blockId} (${tier})  ${formatTokens(effTokens)}\u2192${formatTokens(b.summaryTokens)}  ${formatAge(b.createdAt)}  ${formatIdRange(b)}  age=${survived} ${gen} eff=${effCount}${consumed}${status}`
     );
     lines.push(`    "${topic}"`);
   }
@@ -8768,8 +8834,10 @@ function buildStatusReport(renderCtx, rawMessages, options) {
   const sort = options?.sort ?? "size";
   const limit = options?.limit ?? 30;
   const msgState = renderCtx.state.prune.messages;
-  const activeIds = Array.from(msgState.activeBlockIds).sort((a, b) => a - b);
-  const allBlocks = activeIds.map((id) => msgState.blocksById.get(id)).filter((b) => b !== void 0 && b.active);
+  const allBlocks = Array.from(msgState.blocksById.values()).sort(
+    (a, b) => a.blockId - b.blockId
+  );
+  const activeBlocks = allBlocks.filter((b) => b.active);
   const lines = [];
   if (scope === "compressed") {
     lines.push(...renderCompressedDrilldown(allBlocks, sort, limit, msgState.blocksById));
@@ -8791,7 +8859,7 @@ function buildStatusReport(renderCtx, rawMessages, options) {
         visibleMsgs,
         summaryTokens,
         systemTokens,
-        allBlocks,
+        activeBlocks,
         false,
         rawMessages,
         renderCtx
@@ -8949,7 +9017,7 @@ import { writeFile as writeFile2, mkdir as mkdir2 } from "fs/promises";
 import { join as join3 } from "path";
 import { existsSync as existsSync3 } from "fs";
 import { homedir as homedir3 } from "os";
-var LOG_VERSION = true ? "1.14.18-pr.307.19" : "dev";
+var LOG_VERSION = true ? "1.14.19-pr.297.30" : "dev";
 var Logger = class {
   logDir;
   enabled;
@@ -9004,7 +9072,7 @@ var Logger = class {
     }
   }
   async write(level, component, message, data) {
-    if (!this.enabled) return;
+    if (!this.enabled && level !== "ERROR" && level !== "WARN") return;
     try {
       await this.ensureLogDir();
       const timestamp = (/* @__PURE__ */ new Date()).toISOString();
@@ -9031,12 +9099,10 @@ var Logger = class {
     return this.write("DEBUG", component, message, data);
   }
   warn(message, data) {
-    if (!this.enabled) return;
     const component = this.getCallerFile(2);
     return this.write("WARN", component, message, data);
   }
   error(message, data) {
-    if (!this.enabled) return;
     const component = this.getCallerFile(2);
     return this.write("ERROR", component, message, data);
   }
@@ -10047,6 +10113,7 @@ function applyMessageFilters(messages, config, logger, ctx) {
   }
   const result = { partsFiltered: 0, partsDropped: 0, partsModified: 0 };
   const total = messages.length;
+  const warnedFilters = /* @__PURE__ */ new Set();
   const buildCtx = (text, role, i) => ({
     text,
     role,
@@ -10102,11 +10169,14 @@ function applyMessageFilters(messages, config, logger, ctx) {
         try {
           decision = filter.filter(filterCtx);
         } catch (err) {
-          logger.warn("Message filter threw error", {
-            filter: filter.name,
-            error: err instanceof Error ? err.message : String(err),
-            messageIndex: i
-          });
+          if (!warnedFilters.has(filter.name)) {
+            warnedFilters.add(filter.name);
+            logger.warn("Message filter threw error", {
+              filter: filter.name,
+              error: err instanceof Error ? err.message : String(err),
+              messageIndex: i
+            });
+          }
           continue;
         }
         if (decision.action === "keep") continue;
@@ -10514,6 +10584,11 @@ function isInternalAgentRequest(messages) {
 }
 function createSystemPromptHandler(registry4, logger, config, prompts) {
   return async (input, output) => {
+    registry4.recordModelLimit(
+      input.model?.providerID,
+      input.model?.id,
+      input.model?.limit?.context
+    );
     const state = input.sessionID ? registry4.get(input.sessionID) : void 0;
     if (state && input.model?.limit?.context) {
       state.modelContextLimit = input.model.limit.context;
@@ -10569,6 +10644,14 @@ function createChatMessageTransformHandler(client, registry4, logger, config, pr
         messages,
         config
       );
+      const requestModel = lastUserMessage.info.model;
+      const requestModelLimit = registry4.resolveModelLimit(
+        requestModel?.providerID,
+        requestModel?.modelID
+      );
+      if (requestModelLimit !== void 0) {
+        state.modelContextLimit = requestModelLimit;
+      }
       await updatePerTurnState(state, logger, messages);
     }
     syncCompressPermissionState(state, config, hostPermissions, output.messages);
@@ -10614,23 +10697,6 @@ function createChatMessageTransformHandler(client, registry4, logger, config, pr
       config.debug ? (text) => {
         logger.debug(`[ACP Debug] Nudge injected:
 ${text}`);
-        if (state.sessionId && lastUserMessage) {
-          const userInfo = lastUserMessage.info;
-          sendIgnoredMessage(
-            client,
-            state.sessionId,
-            `[ACP Debug Nudge]
-${text}`,
-            {
-              providerId: userInfo.model?.providerID,
-              modelId: userInfo.model?.modelID,
-              agent: userInfo.agent,
-              variant: userInfo.variant
-            },
-            logger
-          ).catch(() => {
-          });
-        }
         client.tui.showToast({
           body: {
             title: "ACP: Nudge Injected",
@@ -10684,10 +10750,9 @@ function createCommandExecuteHandler(client, registry4, logger, config, workingD
       const sub = input.arguments?.trim().toLowerCase();
       if (sub === "stats" || sub === "status") {
         await handleStatsCommand(commandCtx);
-        throw new Error("__DCP_CONTEXT_HANDLED__");
+        return;
       }
       await handleContextCommand(commandCtx);
-      throw new Error("__DCP_CONTEXT_HANDLED__");
     }
   };
 }
@@ -10954,6 +11019,25 @@ var server = (async (ctx) => {
   if (isSecureMode()) {
     configureClientAuth(ctx.client);
   }
+  registry4.hydrateModelLimitsFromClient(ctx.client).then(
+    (recorded) => {
+      if (recorded > 0) {
+        logger.info("Model limit catalog seeded from provider config", {
+          models: recorded
+        });
+      } else {
+        logger.warn(
+          "Model limit catalog seeding recorded no entries \u2014 falling back to per-request refresh (system.transform)"
+        );
+      }
+    },
+    (error) => {
+      logger.warn(
+        "Model limit catalog seeding failed \u2014 falling back to per-request refresh (system.transform)",
+        { error: error instanceof Error ? error.message : String(error) }
+      );
+    }
+  );
   logger.info("DCP initialized");
   startAutoUpdate(ctx, config.autoUpdate);
   const compressToolContext = {