opencode-acp 1.14.0 → 1.14.2

package/README.md

@@ -528,6 +528,22 @@ For the complete list with root cause analysis, see the [bug tracker](https://gi
 
 ## Changelog
 
+### v1.14.2 — Split Protected Ranges + Soften Last-User-Message (PR #210)
+
+**Problem**: In autonomous agentic sessions (1 user message + many assistant/tool messages), `buildCompressibleRanges` created one giant compressible group because grouping only breaks on user messages — and tool results are `assistant` role in OpenCode. The giant group's endRef fell in the protected zone → `excludeProtectedRanges` removed the entire range → zero recommendations → nudge suppressed → model could never compress. Additionally, `preserveLastUserMessage` hard-rejected any compress call covering the last user message, blocking deliberate compressions of surrounding tool output.
+
+**Fix**: (1) `buildCompressibleRanges` now accepts `protectedZoneRefs` and splits groups at the protected-zone boundary — the unprotected head survives as a recommended range while the protected tail is excluded. (2) `preserveLastUserMessage` moved from hard-reject (`checkProtectedRange` throw) to soft-filter (`filterLastUserMessage` excludes from compress plan, following Bug 39's `filterProtectedToolMessages` pattern). The last user message survives in visible context; surrounding tool output compresses normally. (3) Added `allInProtectedZone` condition to `nothingToCompress` to cover the case where all messages are in the protected zone. (4) Fixed stale error messages and added empty-plan guard in both range and message modes. Dual-agent reviewed (both APPROVE with minor fixes; all WARNINGs addressed in follow-up commit). 922 tests pass.
+
+Files: `lib/messages/inject/{utils,inject}.ts`, `lib/compress/{pipeline,protected-content,range,message,status}.ts`. Tests: `tests/{preserve-recent,soft-block,protected-tool-exclusion}.test.ts`. No persisted-state schema changes. `preserveLastUserMessage` config semantics changed from hard-reject to soft-filter (intentional fix; `lastSegmentSoftBlock: false` disables all protection including the new soft filter).
+
+### v1.14.1 — Log Version Info + Growth Baseline Fix (PRs #205, #207)
+
+**Problem**: Two issues since v1.14.0. (1) **Unidentifiable logs** (PR #205): ACP daily logs and per-request context logs carried no version marker, so when users shared debug logs it was impossible to tell which ACP version produced them — making regression triage across versions guesswork. (2) **Growth-baseline feedback loop in short sessions** (PR #207): When the growth threshold was met (`nudgeAllowed`) but every compressible range was filtered out (`nothingToCompress`, e.g. all ranges inside the protected zone in a short session or subagent), the code reset `state.nudges.lastPerMessageNudgeTokens = currentTokens`. This ate the accumulated growth every cycle, so the baseline chased the current context and the model never saw a nudge even though context had grown well past the threshold.
+
+**Fix**: (1) PR #205 — `lib/logger.ts` now appends `| v={version}` to every daily-log line and writes a one-shot `_version` file under each per-request context-log directory. The version is injected at build time via a new `tsup.config.ts` `define: { ACP_VERSION: JSON.stringify(pkg.version) }` (read from `package.json`), with a `declare const ACP_VERSION` ambient declaration in `logger.ts`. Falls back to `"dev"` when the define is absent (e.g. tsx-run tests). (2) PR #207 — Removed the `lastPerMessageNudgeTokens = currentTokens` reset in the `nothingToCompress` branch of `lib/messages/inject/inject.ts`; only `lastNudgeShownTokens` is cleared now. Growth now accumulates across `nothingToCompress` turns until there genuinely is something to compress, at which point the nudge fires. Coverage: 3 tautological baseline-reset tests (which never called `injectCompressNudges`, violating AGENTS.md §5.6) were removed; a real E2E growth scenario in `tests/inject.test.ts` verifies baseline preservation through `nothingToCompress` turns and nudge firing once content exits the protected zone. Dual-authored with Sisyphus (co-authored-by trailer).
+
+Files: `lib/logger.ts`, `tsup.config.ts`, `lib/messages/inject/inject.ts`. Tests: `tests/inject.test.ts` (E2E growth scenario added, 3 tautological tests removed from `tests/baseline-reset.test.ts`). No persisted-state schema changes. No config changes.
+
 ### v1.14.0 — Three-Tier Compression + Preserve-Recent + Summary Visibility Fix (PRs #200, #201, #202)
 
 **Problem**: Three critical issues for long-session stability. (1) **Summary accumulation** (PR #200): Summary blocks accumulated indefinitely (v1.13.5+ force-protection). At ~7.3K tokens/day growth rate, sessions hit the 100K summary ceiling in ~3 days. 92.5% of ancient blocks were shipped/historical work with zero actionable value. (2) **Active task loss** (PR #201): `lastSegmentSoftBlock` only protected the very last 1 message from compression. When the model compressed a range that included the current task context, the active work was lost — the recommendation list itself could point at messages that should have been protected. (3) **summaryBuffer over-counting** (PR #202): `getActiveSummaryTokenUsage()` counted ALL active blocks (e.g., 448 = 151K tokens), but only ~26 blocks had their compress calls in the visible context window. The inflated count caused false T2/T3 triggers and misleading `acp stats` output ("摘要 146%").

package/README.zh-CN.md

@@ -482,6 +482,22 @@ ACP 在首次启动时自动将配置从 `dcp.jsonc` 迁移到 `acp.jsonc`，将
 
 ## 更新日志
 
+### v1.14.2 — 拆分保护区范围 + 软化最后用户消息保护（PR #210）
+
+**问题**：在自主代理会话中（1 条用户消息 + 多条 assistant/tool 消息），`buildCompressibleRanges` 创建了一个巨型可压缩组，因为分组只在用户消息处断开 —— 而 OpenCode 中 tool 结果是 `assistant` 角色。巨型组的 endRef 落在保护区内 → `excludeProtectedRanges` 移除整个范围 → 零推荐 → nudge 被抑制 → 模型永远无法压缩。此外，`preserveLastUserMessage` 硬拒绝任何覆盖最后用户消息的压缩调用，阻塞了对周围 tool 输出的有意压缩。
+
+**修复**：(1) `buildCompressibleRanges` 现在接受 `protectedZoneRefs` 参数，在保护区边界处拆分组 —— 非保护区头部保留为推荐范围，保护区尾部被排除。(2) `preserveLastUserMessage` 从硬拒绝（`checkProtectedRange` 抛错）改为软过滤（`filterLastUserMessage` 从压缩计划中排除，遵循 Bug 39 的 `filterProtectedToolMessages` 模式）。最后用户消息保留在可见上下文中；周围的 tool 输出正常压缩。(3) 在 `nothingToCompress` 中添加了 `allInProtectedZone` 条件，覆盖所有消息都在保护区内的情况。(4) 修复了过时的错误消息，在 range 和 message 模式中都添加了空计划守卫。双 agent 审查通过（均 APPROVE WITH MINOR FIXES；所有 WARNING 在后续 commit 中解决）。922 项测试通过。
+
+文件：`lib/messages/inject/{utils,inject}.ts`、`lib/compress/{pipeline,protected-content,range,message,status}.ts`。测试：`tests/{preserve-recent,soft-block,protected-tool-exclusion}.test.ts`。无持久化状态 schema 变更。`preserveLastUserMessage` 配置语义从硬拒绝变为软过滤（有意的修复；`lastSegmentSoftBlock: false` 禁用所有保护包括新的软过滤）。
+
+### v1.14.1 — 日志版本信息 + 增长基线修复（PR #205, #207）
+
+**问题**：v1.14.0 之后的两个问题。(1) **日志无法识别版本**（PR #205）：ACP daily 日志和每请求 context 日志没有任何版本标记，用户分享调试日志时无法判断是哪个 ACP 版本产生的 —— 跨版本回归排查只能靠猜。(2) **短会话中的增长基线反馈循环**（PR #207）：当增长阈值已满足（`nudgeAllowed`）但所有可压缩范围都被过滤掉时（`nothingToCompress`，例如短会话或子代理中所有范围都在保护区内），旧代码会重置 `state.nudges.lastPerMessageNudgeTokens = currentTokens`。这会每轮吃掉累积增长，基线一路追逐当前上下文，即使上下文早已远超阈值，模型也永远等不到 nudge。
+
+**修复**：(1) PR #205 —— `lib/logger.ts` 现在在每行 daily 日志末尾追加 `| v={version}`，并在每个每请求 context 日志目录下写一个一次性 `_version` 文件。版本通过新的 `tsup.config.ts` `define: { ACP_VERSION: JSON.stringify(pkg.version) }`（从 `package.json` 读取）在构建时注入，`logger.ts` 中有 `declare const ACP_VERSION` 环境声明。当 define 缺失时（例如 tsx 跑测试）回退为 `"dev"`。(2) PR #207 —— 移除了 `lib/messages/inject/inject.ts` 中 `nothingToCompress` 分支的 `lastPerMessageNudgeTokens = currentTokens` 重置；现在只清空 `lastNudgeShownTokens`。增长会在多个 `nothingToCompress` 轮次之间累积，直到确实有内容可压缩时 nudge 才触发。测试覆盖：删除了 3 个 taautological 的 baseline-reset 测试（这些测试从不调用 `injectCompressNudges`，违反 AGENTS.md §5.6）；`tests/inject.test.ts` 中新增真实 E2E 增长场景，验证基线在 `nothingToCompress` 轮次间被保留、内容离开保护区后 nudge 触发。与 Sisyphus 合作完成（co-authored-by 署名）。
+
+文件：`lib/logger.ts`、`tsup.config.ts`、`lib/messages/inject/inject.ts`。测试：`tests/inject.test.ts`（新增 E2E 增长场景，`tests/baseline-reset.test.ts` 删除 3 个 tautological 测试）。无持久化 state schema 变更，无配置变更。
+
 ### v1.14.0 — 三级压缩 + 保留近期消息 + 摘要可见性修复（PR #200, #201, #202）
 
 **问题**：长会话稳定性三个关键问题。(1) **摘要累积**（PR #200）：摘要块无限累积（v1.13.5+ 强制保护后），以每天约 7.3K token 增长，会话在约 3 天内触及 100K 摘要上限。92.5% 的旧块是已发布/历史工作，零可操作价值。(2) **活跃任务丢失**（PR #201）：`lastSegmentSoftBlock` 仅保护最后 1 条消息不被压缩。当模型压缩包含当前任务上下文的范围时，活跃工作丢失——推荐列表本身可能指向应该被保护的消息。(3) **summaryBuffer 过度计数**（PR #202）：`getActiveSummaryTokenUsage()` 计算了所有活跃块（如 448 块 = 151K token），但只有约 26 块的 compress 调用在可见上下文窗口中。虚高的计数导致错误的 T2/T3 触发和误导性的 `acp stats` 输出（"摘要 146%"）。

package/dist/index.js

@@ -3062,6 +3062,39 @@ function filterProtectedToolMessages(selection, searchContext, protectedTools, p
     toolIds: filteredToolIds
   };
 }
+function filterLastUserMessage(selection, searchContext, state, compress) {
+  if (compress.lastSegmentSoftBlock === false) return selection;
+  if (!(compress.preserveLastUserMessage ?? true)) return selection;
+  let lastUserMessageId = null;
+  for (let i = searchContext.rawMessages.length - 1; i >= 0; i--) {
+    const msg = searchContext.rawMessages[i];
+    const id = msg?.info?.id;
+    if (!id || typeof id !== "string") continue;
+    if (isSyntheticMessage(msg)) continue;
+    if (isIgnoredUserMessage(msg)) continue;
+    if (state.prune.messages.byMessageId.has(id)) continue;
+    if (msg.info.role === "user") {
+      lastUserMessageId = id;
+      break;
+    }
+  }
+  if (!lastUserMessageId || !selection.messageIds.includes(lastUserMessageId)) {
+    return selection;
+  }
+  const filteredMessageIds = selection.messageIds.filter((id) => id !== lastUserMessageId);
+  const filteredMessageTokenById = /* @__PURE__ */ new Map();
+  for (const id of filteredMessageIds) {
+    const tokens = selection.messageTokenById.get(id);
+    if (tokens !== void 0) {
+      filteredMessageTokenById.set(id, tokens);
+    }
+  }
+  return {
+    ...selection,
+    messageIds: filteredMessageIds,
+    messageTokenById: filteredMessageTokenById
+  };
+}
 
 // lib/compress/state.ts
 var DEFAULT_PROMOTION_THRESHOLD = 5;
@@ -6399,7 +6432,6 @@ function checkPhantomBlock(state, plans) {
 function computeProtectedRawIds(rawMessages, state, compress) {
   const preserveN = compress.preserveRecentMessages ?? 20;
   const preserveTokens = compress.preserveRecentTokens ?? 2e4;
-  const preserveLastUser = compress.preserveLastUserMessage ?? true;
   const result = /* @__PURE__ */ new Set();
   const visible = [];
   for (const msg of rawMessages) {
@@ -6430,14 +6462,6 @@ function computeProtectedRawIds(rawMessages, state, compress) {
       tokenAccum += visible[i].tokens;
     }
   }
-  if (preserveLastUser) {
-    for (let i = visible.length - 1; i >= 0; i--) {
-      if (visible[i].isUser) {
-        result.add(visible[i].id);
-        break;
-      }
-    }
-  }
   return result;
 }
 function checkProtectedRange(ctx, allPlanMessageIds, rawMessages, dangerous) {
@@ -6460,7 +6484,7 @@ function checkProtectedRange(ctx, allPlanMessageIds, rawMessages, dangerous) {
   return new Error(
     `This range includes ${coveredProtected.length} protected recent message(s) (${sample}), which are likely still needed for the current task step.
 
-Protected zone: last ${nMsgs} messages + last ${nToks >= 1e3 ? `${nToks / 1e3}K` : nToks} tokens + most recent user message.
+Protected zone: last ${nMsgs} messages + last ${nToks >= 1e3 ? `${nToks / 1e3}K` : nToks} tokens.
 If you are certain this content is genuinely consumed and must be compressed, re-issue the call with \`dangerous: true\`.
 Otherwise, compress older ranges that do not include the tail of the conversation.`
   );
@@ -6635,14 +6659,25 @@ function createCompressMessageTool(factoryCtx) {
         ctx.state,
         ctx.config
       );
-      if (plans.length === 0 && skippedCount > 0) {
-        throw new Error(formatIssues(skippedIssues, skippedCount));
+      const filteredPlans = plans.map((plan) => ({
+        ...plan,
+        selection: filterLastUserMessage(
+          plan.selection,
+          searchContext,
+          ctx.state,
+          ctx.config.compress
+        )
+      })).filter((plan) => plan.selection.messageIds.length > 0);
+      if (filteredPlans.length === 0) {
+        throw new Error(
+          skippedCount > 0 ? formatIssues(skippedIssues, skippedCount) : "All selected messages were filtered out (protected tool outputs and/or the last user message). They must remain in visible context."
+        );
       }
       const minCompressRange = ctx.config.compress.minCompressRange;
       if (minCompressRange > 0) {
         let totalChars = 0;
         const counted = /* @__PURE__ */ new Set();
-        for (const plan of plans) {
+        for (const plan of filteredPlans) {
           for (const messageId of plan.selection.messageIds) {
             if (counted.has(messageId)) continue;
             counted.add(messageId);
@@ -6661,14 +6696,14 @@ function createCompressMessageTool(factoryCtx) {
       const dangerous = args.dangerous === true;
       const lastSegmentError = checkProtectedRange(
         ctx,
-        plans.map((p) => p.selection.messageIds),
+        filteredPlans.map((p) => p.selection.messageIds),
         rawMessages,
         dangerous
       );
       if (lastSegmentError) throw lastSegmentError;
       const notifications = [];
       const preparedPlans = [];
-      for (const plan of plans) {
+      for (const plan of filteredPlans) {
         const summaryWithPromptInfo = appendProtectedPromptInfo(
           plan.entry.summary,
           plan.selection,
@@ -6778,7 +6813,7 @@ function createCompressMessageTool(factoryCtx) {
         ctx.state.qualityGateRetryPending = qualityGateRetryPendingBefore;
         throw error;
       }
-      return formatResult(plans.length, skippedIssues, skippedCount);
+      return formatResult(filteredPlans.length, skippedIssues, skippedCount);
     }
   });
 }
@@ -6852,10 +6887,18 @@ function createCompressRangeTool(factoryCtx) {
           ctx.config.compress.protectedTools,
           ctx.config.protectedFilePatterns
         )
+      })).map((plan) => ({
+        ...plan,
+        selection: filterLastUserMessage(
+          plan.selection,
+          searchContext,
+          ctx.state,
+          ctx.config.compress
+        )
       })).filter((plan) => plan.selection.messageIds.length > 0);
       if (filteredPlans.length === 0) {
         throw new Error(
-          "All selected messages contain protected tool outputs and cannot be compressed. Protected tools (task, skill, todowrite, etc.) must remain in visible context."
+          "All selected messages were filtered out (protected tool outputs and/or the last user message). They must remain in visible context."
         );
       }
       const minCompressRange = ctx.config.compress.minCompressRange;
@@ -8122,7 +8165,7 @@ function refNum(ref) {
   const n = parseInt(ref.slice(1), 10);
   return Number.isNaN(n) ? -1 : n;
 }
-function buildCompressibleRanges(messages, state, protectedTools = [], protectedFilePatterns = []) {
+function buildCompressibleRanges(messages, state, protectedTools = [], protectedFilePatterns = [], protectedZoneRefs) {
   const msgInfo = [];
   const protectedMsgInfo = [];
   for (const msg of messages) {
@@ -8174,6 +8217,14 @@ function buildCompressibleRanges(messages, state, protectedTools = [], protected
   let cur = null;
   let prevRefNum = -2;
   for (const info of msgInfo) {
+    if (protectedZoneRefs?.has(info.ref)) {
+      if (cur) {
+        groups.push(cur);
+        cur = null;
+      }
+      prevRefNum = info.refNum;
+      continue;
+    }
     const hasGap = info.refNum > prevRefNum + 1;
     if (cur && (info.isUser && cur.count >= 3 || hasGap)) {
       groups.push(cur);
@@ -8380,7 +8431,6 @@ function computeProtectedRefs(messages, state, compress) {
   if (compress.lastSegmentSoftBlock === false) return /* @__PURE__ */ new Set();
   const preserveN = compress.preserveRecentMessages ?? 20;
   const preserveTokens = compress.preserveRecentTokens ?? 2e4;
-  const preserveLastUser = compress.preserveLastUserMessage ?? true;
   const result = /* @__PURE__ */ new Set();
   const visible = [];
   for (const msg of messages) {
@@ -8411,14 +8461,6 @@ function computeProtectedRefs(messages, state, compress) {
       tokenAccum += visible[i].tokens;
     }
   }
-  if (preserveLastUser) {
-    for (let i = visible.length - 1; i >= 0; i--) {
-      if (visible[i].isUser) {
-        result.add(visible[i].ref);
-        break;
-      }
-    }
-  }
   return result;
 }
 function excludeProtectedRanges(ranges, protectedRefs) {
@@ -8600,13 +8642,14 @@ var injectCompressNudges = (state, config, logger, messages, prompts, compressio
     config.compress.protectedTools,
     config.protectedFilePatterns
   );
+  const protectedRefs = computeProtectedRefs(messages, state, config.compress);
   const contextRanges = buildCompressibleRanges(
     messages,
     state,
     config.compress.protectedTools,
-    config.protectedFilePatterns
+    config.protectedFilePatterns,
+    protectedRefs
   );
-  const protectedRefs = computeProtectedRefs(messages, state, config.compress);
   const unprotectedCompressible = excludeProtectedRanges(contextRanges.compressible, protectedRefs);
   const recommendedRanges = filterRecommendedRanges(
     unprotectedCompressible,
@@ -8635,10 +8678,10 @@ var injectCompressNudges = (state, config, logger, messages, prompts, compressio
   }
   const filterSuppressed = contextRanges.compressible.length > 0 && !hasRecommendations;
   const allProtected = contextRanges.compressible.length === 0 && contextRanges.protected.length > 0;
-  const nothingToCompress = filterSuppressed || allProtected;
+  const allInProtectedZone = protectedRefs.size > 0 && unprotectedCompressible.length === 0;
+  const nothingToCompress = filterSuppressed || allProtected || allInProtectedZone;
   let shouldInject = nudgeAllowed && (!nothingToCompress || emergencyOverride);
-  if (nudgeAllowed && nothingToCompress && !emergencyOverride && currentTokens !== void 0) {
-    state.nudges.lastPerMessageNudgeTokens = currentTokens;
+  if (nudgeAllowed && nothingToCompress && !emergencyOverride) {
     state.nudges.lastNudgeShownTokens = void 0;
   }
   if (suffixMessage && !shouldInject) {
@@ -9635,11 +9678,13 @@ function renderOverview(visibleMessages, summaryTokens, blocks, fetchFailed, raw
       const entry = pruneMap.get(msgId);
       return !entry || entry.activeBlockIds.length === 0;
     });
+    const protectedRefs = ctx.config?.compress ? computeProtectedRefs(visibleRaw, ctx.state, ctx.config.compress) : /* @__PURE__ */ new Set();
     const contextRanges = buildCompressibleRanges(
       visibleRaw,
       ctx.state,
       ctx.config?.compress?.protectedTools ?? [],
-      ctx.config?.protectedFilePatterns ?? []
+      ctx.config?.protectedFilePatterns ?? [],
+      protectedRefs
     );
     if (contextRanges.compressible.length > 0 || contextRanges.protected.length > 0) {
       lines.push("");
@@ -9662,11 +9707,13 @@ function renderUncompressedRanges(rawMessages, ctx) {
     const entry = pruneMap.get(msgId);
     return !entry || entry.activeBlockIds.length === 0;
   });
+  const protectedRefs = ctx.config?.compress ? computeProtectedRefs(visibleMessages, ctx.state, ctx.config.compress) : /* @__PURE__ */ new Set();
   const contextRanges = buildCompressibleRanges(
     visibleMessages,
     ctx.state,
     ctx.config?.compress?.protectedTools ?? [],
-    ctx.config?.protectedFilePatterns ?? []
+    ctx.config?.protectedFilePatterns ?? [],
+    protectedRefs
   );
   const compressible = contextRanges.compressible;
   const totalTokens = compressible.reduce((s, r) => s + r.tokens, 0);
@@ -10023,6 +10070,7 @@ import { writeFile as writeFile2, mkdir as mkdir2 } from "fs/promises";
 import { join as join3 } from "path";
 import { existsSync as existsSync3 } from "fs";
 import { homedir as homedir3 } from "os";
+var LOG_VERSION = true ? "1.14.2" : "dev";
 var Logger = class {
   logDir;
   enabled;
@@ -10082,7 +10130,7 @@ var Logger = class {
       await this.ensureLogDir();
       const timestamp = (/* @__PURE__ */ new Date()).toISOString();
       const dataStr = this.formatData(data);
-      const logLine = `${timestamp} ${level.padEnd(5)} ${component}: ${message}${dataStr ? " | " + dataStr : ""}
+      const logLine = `${timestamp} ${level.padEnd(5)} ${component}: ${message}${dataStr ? " | " + dataStr : ""} | v=${LOG_VERSION}
 `;
       const dailyLogDir = join3(this.logDir, "daily");
       if (!existsSync3(dailyLogDir)) {
@@ -10211,6 +10259,10 @@ var Logger = class {
       const timestamp = (/* @__PURE__ */ new Date()).toISOString().replace(/[:.]/g, "-");
       const contextFile = join3(contextDir, `${timestamp}.json`);
       await writeFile2(contextFile, JSON.stringify(minimized, null, 2));
+      const versionFile = join3(contextDir, "_version");
+      if (!existsSync3(versionFile)) {
+        await writeFile2(versionFile, LOG_VERSION);
+      }
     } catch (error) {
     }
   }