opencode-acp 1.13.1 → 1.13.2

package/README.md

@@ -235,7 +235,7 @@ Each level overrides the previous, so project settings take priority over global
     // Enable debug logging to ~/.config/opencode/logs/acp/
     "debug": false,
     // Notification display: "off", "minimal", or "detailed"
-    "pruneNotification": "detailed",
+    "pruneNotification": "off",
     // Notification type: "chat" (deprecated, falls back to toast) or "toast" (system toast)
     "pruneNotificationType": "toast",
     // Slash commands configuration
@@ -471,6 +471,12 @@ For the complete list with root cause analysis, see the [bug tracker](https://gi
 
 ## Changelog
 
+### v1.13.2 — Preserve Last User Msg + Config Defaults Tuning (PR #169)
+
+**Problem**: Two issues remained after v1.13.1's notification freeze fix. (1) When the model compressed a range that covered all visible user messages, the next API call had zero user-role messages — zhipuai-lb rejected this with the same HTTP 400 code 1214 (`isRetryable: false`), freezing the session. This was the second path to the same freeze that v1.13.1's empty-notification fix addressed. (2) The default `pruneNotification: "detailed"` fired a toast on every compress call (10–30 per session is typical), which was over-intrusive for a routine background operation. Additionally, `compress.maxSummaryLengthHard: 10000` rejected ~25% of information-dense useful summaries in real sessions.
+
+**Fix**: (1) `lib/messages/prune.ts` — `filterCompressedRanges` rewritten as a two-pass filter: pass 1 computes survivors, pass 2 builds the result; if no user-role message would survive, the most recent pruned user message is restored to keep the API request shape valid. The restore is transform-time only — `byMessageId` still records the message as compressed. (2) `lib/config.ts` — default `pruneNotification` changed `"detailed"` → `"off"`; compression events still log to `~/.config/opencode/logs/acp/` via a new always-log path in `lib/ui/notification.ts` (lossless observability without UI noise). (3) `lib/config.ts` — default `compress.maxSummaryLengthHard` raised `10000` → `20000` (aligns with observed good-summary lengths). (4) `dcp.schema.json` — 4 stale defaults synced. Files: `lib/messages/prune.ts`, `lib/config.ts`, `lib/ui/notification.ts`, `dcp.schema.json`, `README.md`. Tests: 803 pass (5 new regression tests for the preserve-last-user fix).
+
 ### v1.13.1 — cc-alg Extraction + Compress Notification Freeze Fix (PRs #167, #168)
 
 **Problem (compress notification freeze, #167)**: After every successful `compress` tool call, ACP injected a user-role notification message with a single `ignored: true` text part. opencode strips `ignored` parts before sending to the LLM, leaving an empty user message. The provider (zhipuai-lb / glm-5.2) rejects this with HTTP 400 code 1214 (`"messages 参数非法"`), `isRetryable: false` — opencode does not retry, and the session freezes until external recovery. 113 total occurrences across active sessions (8 in a single 3,156-message session).

package/README.zh-CN.md

@@ -439,6 +439,12 @@ ACP 在首次启动时自动将配置从 `dcp.jsonc` 迁移到 `acp.jsonc`，将
 
 ## 更新日志
 
+### v1.13.2 — 保留最近用户消息 + 配置默认值调优（PR #169）
+
+**问题**：v1.13.1 的通知冻结修复之后还剩两个问题。（1）当模型压缩的范围覆盖了所有可见的 user 消息时，下一次 API 调用中 user 角色消息数量为零——zhipuai-lb 以同样的 HTTP 400 code 1214（`isRetryable: false`）拒绝，会话冻结。这是 v1.13.1 修复的空通知路径之外，通往同一冻结 bug 的第二条路径。（2）默认 `pruneNotification: "detailed"` 每次压缩都弹 toast（典型会话 10–30 次），对例行后台操作来说过于打扰。另外 `compress.maxSummaryLengthHard: 10000` 在真实会话中拒绝了约 25% 信息密度高的有用摘要。
+
+**修复**：（1）`lib/messages/prune.ts`——`filterCompressedRanges` 重写为两段过滤：第一段计算存活消息，第二段构建结果；如果没有 user 角色消息存活，恢复最近一条被压缩的 user 消息以保证 API 请求格式合法。恢复仅发生在 transform 阶段——`byMessageId` 仍记录该消息为已压缩。（2）`lib/config.ts`——默认 `pruneNotification` 改为 `"off"`；压缩事件仍通过 `lib/ui/notification.ts` 新增的 always-log 路径记录到 `~/.config/opencode/logs/acp/`（无损失可观测性，无 UI 噪音）。（3）`lib/config.ts`——默认 `compress.maxSummaryLengthHard` 从 `10000` 提升到 `20000`（与真实会话中观察到的优质摘要长度对齐）。（4）`dcp.schema.json`——同步 4 个过时默认值。文件：`lib/messages/prune.ts`、`lib/config.ts`、`lib/ui/notification.ts`、`dcp.schema.json`、`README.md`。测试：803 pass（5 个新的 preserve-last-user 回归测试）。
+
 ### v1.13.1 — cc-alg 抽取 + 压缩通知冻结修复（PR #167, #168）
 
 **问题（压缩通知冻结，#167）**：每次 `compress` 工具调用成功后，ACP 会注入一条 user 角色通知消息，其中只包含一个带 `ignored: true` 标记的 text part。opencode 在发送给 LLM 前会剥离 ignored parts，于是这条消息变成空 user 消息。Provider（zhipuai-lb / glm-5.2）会以 HTTP 400 code 1214（`"messages 参数非法"`）拒绝，且 `isRetryable: false`——opencode 不会重试，会话冻结，直到外部恢复。所有活跃会话累计发生 113 次（单个 3,156 条消息的会话出现 8 次）。

package/dist/index.js

@@ -1557,7 +1557,7 @@ var defaultConfig = {
   enabled: true,
   autoUpdate: true,
   debug: false,
-  pruneNotification: "detailed",
+  pruneNotification: "off",
   // [FIX #20] Default to toast — chat-mode notifications inject an empty
   // user message that freezes the session on providers that reject empty
   // messages (zhipuai-lb code 1214). See lib/ui/notification.ts.
@@ -1593,7 +1593,7 @@ var defaultConfig = {
     protectedTools: [...COMPRESS_DEFAULT_PROTECTED_TOOLS],
     protectTags: false,
     protectUserMessages: false,
-    maxSummaryLengthHard: 1e4,
+    maxSummaryLengthHard: 2e4,
     minCompressRange: 5e3,
     minNudgeGrowthRatio: 0.45,
     minNudgeGrowthFloor: 5e3,
@@ -5078,10 +5078,25 @@ function formatContextTransition(tokensBefore, tokensAfter) {
   return `Context ${beforeStr} \u2192 ${afterStr}`;
 }
 async function sendCompressNotification(client, logger, config, state, sessionId, entries, batchTopic, sessionMessageIds, params, contextTokensBefore) {
-  if (config.pruneNotification === "off") {
+  if (entries.length === 0) {
     return false;
   }
-  if (entries.length === 0) {
+  const logBlockIds = entries.map((e) => e.blockId);
+  const logTopics = entries.map((e) => state.prune.messages.blocksById.get(e.blockId)?.topic ?? "?");
+  const logCompressedTokens = entries.reduce((sum, e) => {
+    const block = state.prune.messages.blocksById.get(e.blockId);
+    return sum + (block?.compressedTokens ?? 0);
+  }, 0);
+  const logSummaryTokens = entries.reduce((sum, e) => sum + e.summaryTokens, 0);
+  logger.info("Compression completed", {
+    sessionId,
+    blockIds: logBlockIds,
+    topics: logTopics,
+    compressedTokens: logCompressedTokens,
+    summaryTokens: logSummaryTokens,
+    contextTokensBefore
+  });
+  if (config.pruneNotification === "off") {
     return false;
   }
   let message;
@@ -6669,15 +6684,29 @@ var filterCompressedRanges = (state, messages) => {
   if (state.prune.messages.byMessageId.size === 0) {
     return;
   }
+  const survive = messages.map((msg) => {
+    const pruneEntry = state.prune.messages.byMessageId.get(msg.info.id);
+    if (!pruneEntry || pruneEntry.activeBlockIds.length === 0) {
+      return true;
+    }
+    return false;
+  });
+  const anyUserSurvives = messages.some(
+    (msg, i) => survive[i] && msg.info.role === "user"
+  );
+  if (!anyUserSurvives) {
+    for (let i = messages.length - 1; i >= 0; i--) {
+      if (messages[i].info.role === "user" && !survive[i]) {
+        survive[i] = true;
+        break;
+      }
+    }
+  }
   const result = [];
   for (let i = 0; i < messages.length; i++) {
-    const msg = messages[i];
-    const msgId = msg.info.id;
-    const pruneEntry = state.prune.messages.byMessageId.get(msgId);
-    if (pruneEntry && pruneEntry.activeBlockIds.length > 0) {
-      continue;
+    if (survive[i]) {
+      result.push(messages[i]);
     }
-    result.push(msg);
   }
   messages.length = 0;
   messages.push(...result);