openclaw-lark-multi-agent 1.8.2 → 1.8.3

package/dist/feishu-bot.d.ts

@@ -50,6 +50,11 @@ export declare class FeishuBot {
      * DONE when that batch completes successfully; cleared (unflipped) when the
      * batch scope ends any other way. */
     private admittedSteerAcks;
+    /** Identity token of the CURRENT queue owner per chat. Steer acks carry
+     *  the token of the batch that admitted them; a completion path only flips
+     *  acks of its OWN batch, so a superseded inner can never DONE a newer
+     *  batch's steered inputs (2026-10-16 audit B9). */
+    private queueRunTokens;
     /** Go / Go-Checker supervision controller (per-bot instance). */
     private readonly goDeliveryReceipts;
     private readonly goReceiptApis;

package/dist/feishu-bot.js

@@ -149,6 +149,11 @@ export class FeishuBot {
      * DONE when that batch completes successfully; cleared (unflipped) when the
      * batch scope ends any other way. */
     admittedSteerAcks = new Map();
+    /** Identity token of the CURRENT queue owner per chat. Steer acks carry
+     *  the token of the batch that admitted them; a completion path only flips
+     *  acks of its OWN batch, so a superseded inner can never DONE a newer
+     *  batch's steered inputs (2026-10-16 audit B9). */
+    queueRunTokens = new Map();
     /** Go / Go-Checker supervision controller (per-bot instance). */
     goDeliveryReceipts = new AsyncLocalStorage();
     goReceiptApis = new WeakSet();
@@ -1227,7 +1232,7 @@ export class FeishuBot {
                         // never (2026.9.9 removed mirrors); either way the message belongs
                         // to this batch for the Get -> DONE flip.
                         const steerAckList = this.admittedSteerAcks.get(chatId) || [];
-                        steerAckList.push({ messageId, insertedId });
+                        steerAckList.push({ messageId, insertedId, batch: this.queueRunTokens.get(chatId) });
                         this.admittedSteerAcks.set(chatId, steerAckList);
                     }
                     if (insertedId > 0 && !consumedBeforeAck) {
@@ -1303,8 +1308,14 @@ export class FeishuBot {
                 // path and it will never settle). Force-expire it and process this input
                 // NOW instead of queueing behind a dead promise forever.
                 if (steer.status === "no_active_run" && this.queueRuns.has(chatId)) {
+                    const ownerAtCheck = this.queueRuns.get(chatId);
                     const live = await this.openclawClient.getSessionRuntimeStatus(sessionKeyForSteer).catch(() => null);
-                    if (live && !live.running) {
+                    // B1 (2026-10-16 audit): require POSITIVE idle evidence. An RPC
+                    // failure normalizes to {status:"unknown", running:false} and must
+                    // never authorize expiring a legitimately running owner. The owner
+                    // identity is also CAS-checked across the status RPC: a newer batch
+                    // that took over meanwhile must not be expired by stale evidence.
+                    if (live && !live.running && live.status !== "unknown" && this.queueRuns.get(chatId) === ownerAtCheck) {
                         console.warn(`[${this.config.name}] gateway reports session idle while queue owner exists for ${chatId.slice(-8)} — expiring zombie owner (status=${live.status})`);
                         this.forceExpireQueueOwner(chatId, `gateway idle (steer=${steer.status}, session=${live.status})`);
                         // Fall through to the normal send path below; the durable trigger
@@ -1478,7 +1489,9 @@ export class FeishuBot {
             console.log(`[${this.config.name}] processQueue already running for ${chatId.slice(-8)}, joining existing run`);
             return existing;
         }
-        const run = this.processQueueInner(chatId).finally(() => {
+        const batchToken = {};
+        this.queueRunTokens.set(chatId, batchToken);
+        const run = this.processQueueInner(chatId, batchToken).finally(() => {
             // Ownership token guard: only the CURRENT owner may release the slot. A
             // zombie owner that settles after forceExpireQueueOwner must not delete
             // the replacement owner's entry (that would open a concurrent-run window).
@@ -1486,6 +1499,7 @@ export class FeishuBot {
                 this.queueRuns.delete(chatId);
                 this.runFailureObservers.delete(chatId);
                 this.admittedSteerAcks.delete(chatId);
+                this.queueRunTokens.delete(chatId);
             }
         });
         this.queueRuns.set(chatId, run);
@@ -1514,9 +1528,10 @@ export class FeishuBot {
         this.fireRunFailureObservers(chatId);
         this.runFailureObservers.delete(chatId);
         this.admittedSteerAcks.delete(chatId);
+        this.queueRunTokens.delete(chatId);
         return true;
     }
-    async processQueueInner(chatId) {
+    async processQueueInner(chatId, batchToken) {
         while (true) {
             // A fresh batch starts: steered inputs admitted into the PREVIOUS batch
             // completed with it (consumed or not); their failure observers are stale.
@@ -1998,9 +2013,15 @@ export class FeishuBot {
                 this.pendingAckMessages.set(chatId, remainingAcks);
                 // Steered messages admitted into THIS batch were consumed with it:
                 // flip their Get → DONE alongside the batch's own triggers.
-                const admittedSteers = this.admittedSteerAcks.get(chatId) || [];
+                // B9 (2026-10-16 audit): flip only THIS batch's admitted steer acks. A
+                // superseded inner completing late must never DONE a newer batch's
+                // steered inputs — foreign acks stay for their owning batch.
+                const allSteers = this.admittedSteerAcks.get(chatId) || [];
+                const admittedSteers = allSteers.filter((s) => s.batch === batchToken);
+                if (allSteers.length > 0) {
+                    this.admittedSteerAcks.set(chatId, allSteers.filter((s) => s.batch !== batchToken));
+                }
                 if (admittedSteers.length > 0) {
-                    this.admittedSteerAcks.delete(chatId);
                     for (const s of admittedSteers) {
                         await this.removeReaction(s.messageId, "Get").catch(() => { });
                         await this.addReaction(s.messageId, "DONE").catch(() => { });

package/dist/openclaw-client.js

@@ -870,9 +870,14 @@ export class OpenClawClient {
                         return;
                     if (snapshot.status === "ok" && snapshot.yielded !== true) {
                         const terminal = snapshot.terminalReply;
+                        // B6 (2026-10-16 audit): disposition "empty" is an authoritative
+                        // no-visible-text terminal — never recycle an interim draft as the
+                        // final answer. Only genuinely unspecified metadata may fall back.
                         const visible = terminal?.disposition === "visible" && typeof terminal.text === "string"
-                            ? terminal.text : terminal?.disposition === "silent" ? "NO_REPLY"
-                            : this.pickBestCollectedText(chatFinalText, text, chatDeltaText, transcriptAssistantText);
+                            ? terminal.text
+                            : terminal?.disposition === "silent" || terminal?.disposition === "empty"
+                                ? "NO_REPLY"
+                                : this.pickBestCollectedText(chatFinalText, text, chatDeltaText, transcriptAssistantText);
                         resolve(visible || "NO_REPLY");
                     }
                     else if (snapshot.status === "error" || snapshot.status === "timeout") {
@@ -1374,7 +1379,9 @@ export class OpenClawClient {
                                 return;
                             }
                             if (isWaitTimeout(errText)) {
-                                bucket.splice(i, 1);
+                                // B5 (2026-10-16 audit): already dequeued by the unified splice
+                                // above; a second splice here deleted the NEXT buffered frame
+                                // (a real chatFinal following a timeout error was swallowed).
                                 if (!decidingTimeout) {
                                     decidingTimeout = true;
                                     void this.classifyWaitTimeout(errText, targetSessionKey || sessionKey).then(handleTimeoutResult);
@@ -1428,11 +1435,13 @@ export class OpenClawClient {
                             if (this.isRecoverableAgentError(errText)) {
                                 pendingRuntimeFailureText = `⚠️ Agent 未正常完成\n原因: ${safeErrorSummary(errText)}`;
                                 console.warn(`[OpenClaw] recoverable chat error for runId=${evRunId || runId}; deferring: ${safeErrorSummary(errText)}`);
-                                bucket.splice(i, 1);
+                                // B5: already dequeued above — no second splice.
                                 continue;
                             }
                             if (isWaitTimeout(errText)) {
-                                bucket.splice(i, 1);
+                                // B5 (2026-10-16 audit): already dequeued by the unified splice
+                                // above; a second splice here deleted the NEXT buffered frame
+                                // (a real chatFinal following a timeout error was swallowed).
                                 if (!decidingTimeout) {
                                     decidingTimeout = true;
                                     void this.classifyWaitTimeout(errText, targetSessionKey || sessionKey).then(handleTimeoutResult);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openclaw-lark-multi-agent",
-  "version": "1.8.2",
+  "version": "1.8.3",
   "description": "Multi-bot Lark/Feishu bridge for OpenClaw, with per-bot model routing and isolated sessions",
   "type": "module",
   "scripts": {