openclaw-lark-multi-agent 1.0.7 → 1.0.9

package/dist/feishu-bot.d.ts

@@ -98,6 +98,7 @@ export declare class FeishuBot {
     private runDiscussionTurn;
     private replyMessage;
     private extractBridgeAttachments;
+    private pushBridgeAttachment;
     private validateBridgeAttachmentPath;
     private inferFeishuFileType;
     private isImagePath;

package/dist/feishu-bot.js

@@ -2,14 +2,13 @@ import * as lark from "@larksuiteoapi/node-sdk";
 import { createRequire } from "module";
 import { existsSync, readFileSync, statSync } from "fs";
 import { basename, extname, resolve } from "path";
-import { getBridgeAttachmentAllowedRoots, getBridgeAttachmentsDir } from "./paths.js";
+import { getBridgeAttachmentsDir } from "./paths.js";
 import { buildFeishuCardElements } from "./markdown.js";
 import { discussionManager } from "./discussion-manager.js";
 const require = createRequire(import.meta.url);
 const LMA_VERSION = require("../package.json").version;
 const MAX_BOT_STREAK = 10;
 const BRIDGE_ATTACHMENTS_DIR = getBridgeAttachmentsDir();
-const BRIDGE_ATTACHMENT_ALLOWED_ROOTS = getBridgeAttachmentAllowedRoots();
 /**
  * Manages a single Feishu bot instance.
  *
@@ -762,9 +761,17 @@ export class FeishuBot {
                         console.warn(`[${this.config.name}] Reply already delivered, skip duplicate for ${chatId.slice(-8)} msgId=${triggerId}`);
                     }
                     else {
-                        await this.enqueueAndDispatchDelivery(chatId, "assistant_visible", this.deliverySourceId("visible", `${(shouldReply ? visibleReply : "").trim()}|${JSON.stringify(parsedReply.attachments)}`), shouldReply ? visibleReply : "", parsedReply.attachments, lastHuman.messageId, `trigger:${triggerId}`);
-                        if (triggerId)
-                            this.store.markDeliveredReply(this.config.name, chatId, triggerId, lastHuman.messageId);
+                        try {
+                            await this.enqueueAndDispatchDelivery(chatId, "assistant_visible", this.deliverySourceId("visible", `${(shouldReply ? visibleReply : "").trim()}|${JSON.stringify(parsedReply.attachments)}`), shouldReply ? visibleReply : "", parsedReply.attachments, lastHuman.messageId, `trigger:${triggerId}`);
+                            if (triggerId)
+                                this.store.markDeliveredReply(this.config.name, chatId, triggerId, lastHuman.messageId);
+                        }
+                        catch (err) {
+                            // enqueueAndDispatchDelivery already sent a user-visible delivery
+                            // failure. Do not fall through to the generic provider-error path;
+                            // that creates a second misleading "bot did not complete" message.
+                            console.warn(`[${this.config.name}] assistant delivery failed after notification:`, this.errorSummary(err));
+                        }
                     }
                 }
                 if (isRuntimeFailure && lastHuman.messageId) {
@@ -1178,29 +1185,39 @@ export class FeishuBot {
             try {
                 const parsed = JSON.parse(String(jsonText).trim());
                 const rawAttachments = Array.isArray(parsed) ? parsed : Array.isArray(parsed?.attachments) ? parsed.attachments : [parsed];
-                for (const item of rawAttachments) {
-                    if (!item || typeof item.path !== "string")
-                        continue;
-                    attachments.push({
-                        type: item.type === "image" || item.type === "document" || item.type === "file" ? item.type : undefined,
-                        path: item.path,
-                        caption: typeof item.caption === "string" ? item.caption : undefined,
-                    });
-                }
+                for (const item of rawAttachments)
+                    this.pushBridgeAttachment(attachments, item);
             }
             catch (err) {
                 console.warn(`[${this.config.name}] Failed to parse bridge attachment marker:`, err.message);
             }
             return "";
+        });
+        // Compatibility fallback for agents that use OpenClaw's channel directive
+        // syntax instead of the LMA marker. In Feishu/LMA, leaving MEDIA:<path> in
+        // plain text only shows the path, so parse it into bridge attachments.
+        const mediaDirectivePattern = /^\s*MEDIA:(.+)$/gm;
+        text = text.replace(mediaDirectivePattern, (_match, rawPath) => {
+            const mediaPath = String(rawPath).trim();
+            if (!mediaPath)
+                return "";
+            const cleanPath = mediaPath.replace(/^['\"]|['\"]$/g, "");
+            attachments.push({ type: this.isImagePath(cleanPath) ? "image" : "file", path: cleanPath });
+            return "";
         }).trim();
         return { text, attachments };
     }
+    pushBridgeAttachment(attachments, item) {
+        if (!item || typeof item.path !== "string")
+            return;
+        attachments.push({
+            type: item.type === "image" || item.type === "document" || item.type === "file" ? item.type : undefined,
+            path: item.path,
+            caption: typeof item.caption === "string" ? item.caption : undefined,
+        });
+    }
     validateBridgeAttachmentPath(filePath) {
         const resolvedPath = resolve(filePath);
-        const isAllowed = BRIDGE_ATTACHMENT_ALLOWED_ROOTS.some((root) => resolvedPath === root || resolvedPath.startsWith(root + "/"));
-        if (!isAllowed) {
-            throw new Error(`Attachment path outside allowed directories (${BRIDGE_ATTACHMENT_ALLOWED_ROOTS.join(", ")}): ${resolvedPath}`);
-        }
         if (!existsSync(resolvedPath))
             throw new Error(`Attachment file not found: ${resolvedPath}`);
         const stats = statSync(resolvedPath);
@@ -1634,7 +1651,8 @@ export class FeishuBot {
     async downloadResource(messageId, fileKey, type) {
         const { mkdirSync, writeFileSync } = await import("fs");
         const { resolve } = await import("path");
-        const dir = resolve(process.cwd(), "data", "media");
+        const { getLmaMediaDir } = await import("./paths.js");
+        const dir = getLmaMediaDir();
         mkdirSync(dir, { recursive: true });
         const resp = await this.client.im.messageResource.get({
             path: { message_id: messageId, file_key: fileKey },

package/dist/openclaw-client.js

@@ -2,11 +2,11 @@ import WebSocket from "ws";
 import { randomUUID } from "crypto";
 import { mkdirSync, readFileSync, writeFileSync } from "fs";
 import { basename, extname, join } from "path";
-import { getBridgeAttachmentsDir, getStateDir } from "./paths.js";
+import { getBridgeAttachmentsDir, getDataDir } from "./paths.js";
 export const GATEWAY_PROTOCOL_MIN = 3;
 export const GATEWAY_PROTOCOL_MAX = 4;
 const BRIDGE_ATTACHMENTS_DIR = getBridgeAttachmentsDir();
-const CONTEXT_SYNC_DIR = join(getStateDir(), "context-sync");
+const CONTEXT_SYNC_DIR = join(getDataDir(), "context-sync");
 const MAX_INLINE_CONTEXT_MESSAGES = Number(process.env.OPENCLAW_LARK_MULTI_AGENT_MAX_INLINE_CONTEXT_MESSAGES || 1000);
 const MAX_INLINE_CONTEXT_BYTES = Number(process.env.OPENCLAW_LARK_MULTI_AGENT_MAX_INLINE_CONTEXT_BYTES || 8 * 1024 * 1024);
 /**
@@ -867,7 +867,7 @@ export class OpenClawClient {
             return "";
         return `
 
-[Bridge attachment capability hint: This is an OpenClaw Lark Multi-Agent bridge session. You cannot send Feishu files/images directly from inside OpenClaw. Do NOT call message, sessions_send, Feishu tools, or proactive send tools for this request. If the user asks you to send an image/file/document to Feishu, prefer creating new files under ${BRIDGE_ATTACHMENTS_DIR}/; existing files under the OpenClaw workspace are also allowed. Include this exact marker at the very end of your final reply (do not explain or expose the marker as normal text): <LMA_BRIDGE_ATTACHMENTS>{"attachments":[{"type":"image|file|document","path":"/absolute/path","caption":"optional"}]}</LMA_BRIDGE_ATTACHMENTS>. The bridge layer will parse this marker and send the attachment. Use type=image for images; use type=document for Markdown documents (.md) so the bridge creates a Feishu cloud document and sends its link; use type=file for other ordinary files.]`;
+[Bridge attachment capability hint: This is an OpenClaw Lark Multi-Agent bridge session. You cannot send Feishu files/images directly from inside OpenClaw. Do NOT call message, sessions_send, Feishu tools, or proactive send tools for this request. If the user asks you to send an image/file/document to Feishu, save or copy the real file under ${BRIDGE_ATTACHMENTS_DIR}/, or use an existing real file under the OpenClaw workspace. NEVER use placeholder paths such as /absolute/path, /real/path, /path/to/file, or example paths; the path must be the actual file you created and it must exist. Include this exact marker at the very end of your final reply (do not explain or expose the marker as normal text): <LMA_BRIDGE_ATTACHMENTS>{"attachments":[{"type":"image","path":"${BRIDGE_ATTACHMENTS_DIR}/replace-with-actual-created-file.png","caption":"optional"}]}</LMA_BRIDGE_ATTACHMENTS>. Replace the example path with the actual existing file path before replying. The bridge layer will parse this marker and send the attachment. Use type=image for images; use type=document for Markdown documents (.md) so the bridge creates a Feishu cloud document and sends its link; use type=file for other ordinary files.]`;
     }
     /**
      * Build and send a context catch-up message followed by the actual message.

package/dist/paths.d.ts

@@ -3,6 +3,8 @@
  * for packaged deployments, tests, containers, or systemd installations.
  */
 export declare function getStateDir(): string;
+export declare function getDataDir(): string;
 export declare function getBridgeAttachmentsDir(): string;
 export declare function getOpenClawWorkspaceDir(): string;
+export declare function getLmaMediaDir(): string;
 export declare function getBridgeAttachmentAllowedRoots(): string[];

package/dist/paths.js

@@ -1,20 +1,39 @@
 import { homedir } from "os";
-import { resolve } from "path";
+import { dirname, resolve } from "path";
 /**
  * Runtime state defaults to the user's home directory but can be overridden
  * for packaged deployments, tests, containers, or systemd installations.
  */
 export function getStateDir() {
-    return resolve(process.env.OPENCLAW_LARK_MULTI_AGENT_STATE_DIR || resolve(homedir(), ".openclaw/openclaw-lark-multi-agent"));
+    // Windows services often run as LocalSystem, where homedir() resolves to
+    // C:\\Windows\\System32\\config\\systemprofile. When the installer supplies
+    // LMA_DATA_DIR, derive the state dir from it instead of falling back to that
+    // service profile home.
+    if (process.env.OPENCLAW_LARK_MULTI_AGENT_STATE_DIR)
+        return resolve(process.env.OPENCLAW_LARK_MULTI_AGENT_STATE_DIR);
+    if (process.env.LMA_DATA_DIR)
+        return dirname(resolve(process.env.LMA_DATA_DIR));
+    return resolve(homedir(), ".openclaw/openclaw-lark-multi-agent");
+}
+export function getDataDir() {
+    return resolve(process.env.LMA_DATA_DIR || resolve(getStateDir(), "data"));
 }
 export function getBridgeAttachmentsDir() {
     return resolve(process.env.OPENCLAW_LARK_MULTI_AGENT_ATTACHMENTS_DIR || resolve(getStateDir(), "attachments"));
 }
 export function getOpenClawWorkspaceDir() {
-    return resolve(process.env.OPENCLAW_WORKSPACE_DIR || resolve(homedir(), ".openclaw/workspace"));
+    // Prefer the explicit OpenClaw workspace when provided. Otherwise derive it
+    // from the LMA state dir instead of homedir(); Windows services may run as
+    // LocalSystem, whose homedir is C:\\Windows\\System32\\config\\systemprofile.
+    return resolve(process.env.OPENCLAW_WORKSPACE_DIR || resolve(dirname(getStateDir()), "workspace"));
+}
+export function getLmaMediaDir() {
+    // Feishu-downloaded media should live inside the OpenClaw workspace so agent
+    // tools such as read/image can access it on both Linux and Windows services.
+    return resolve(process.env.OPENCLAW_LARK_MULTI_AGENT_MEDIA_DIR || resolve(getOpenClawWorkspaceDir(), ".lma-media"));
 }
 export function getBridgeAttachmentAllowedRoots() {
-    const roots = [getBridgeAttachmentsDir(), getOpenClawWorkspaceDir()];
+    const roots = [getBridgeAttachmentsDir(), getOpenClawWorkspaceDir(), getLmaMediaDir()];
     const extra = process.env.OPENCLAW_LARK_MULTI_AGENT_ATTACHMENT_ALLOW_ROOTS || "";
     for (const part of extra.split(",")) {
         const trimmed = part.trim();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openclaw-lark-multi-agent",
-  "version": "1.0.7",
+  "version": "1.0.9",
   "description": "Multi-bot Lark/Feishu bridge for OpenClaw, with per-bot model routing and isolated sessions",
   "type": "module",
   "scripts": {