openbot 0.3.6 → 0.4.0

package/src/plugins/approval/index.ts

@@ -1,228 +1,130 @@
-import { MelonyPlugin } from 'melony';
-import type { Plugin } from '../../bus/plugin.js';
-import { OpenBotEvent, OpenBotState } from '../../app/types.js';
-import { storageService } from '../../services/storage.js';
+import { randomUUID } from 'node:crypto';
+import type { Plugin } from '../../services/plugins/types.js';
+import { OpenBotEvent } from '../../app/types.js';
 
 /**
  * `approval` — gates protected tool calls behind a UI confirmation widget.
- *
- * Configuration is read from the per-agent plugin config in AGENT.md:
- * ```yaml
- * plugins:
- *   - id: approval
- *     config:
- *       rules:
- *         - action: action:shell_exec
- *           message: The agent wants to run a terminal command.
- *           detailKeys: [command, cwd, shell, timeoutMs]
- * ```
+ * 
+ * This is a simplified version that intercepts specified actions (default: shell_exec)
+ * and requires user approval before they are allowed to proceed.
  */
 
-export type ApprovalRule = {
-  action: string;
-  message?: string;
-  detailKeys?: string[];
-  hiddenKeys?: string[];
-  executeEvent?: string;
-  denyEvent?: string;
-  denyData?: Record<string, unknown>;
-};
-
-export const DEFAULT_APPROVAL_RULES: ApprovalRule[] = [
-  {
-    action: 'action:shell_exec',
-    denyEvent: 'action:shell_exec:result',
-    message: 'The agent wants to run a terminal command.',
-    detailKeys: ['command', 'cwd', 'shell', 'timeoutMs'],
-    hiddenKeys: ['env'],
-    denyData: {
-      exitCode: null,
-      stdout: '',
-      stderr: 'Command execution was denied by the user.',
-      timedOut: false,
-    },
-  },
-];
-
-type PendingApproval = {
-  id: string;
-  action: string;
-  executeEvent: string;
-  denyEvent: string;
-  denyData: Record<string, unknown>;
-  payload: Record<string, unknown>;
-  meta?: Record<string, unknown>;
-  message: string;
-  createdAt: string;
-  status: 'pending' | 'approved' | 'denied';
-};
+// In-memory tracking for pending approval IDs with TTL (shared across plugin instances)
+const pendingApprovals = new Map<string, number>();
+const TTL_MS = 4 * 60 * 60 * 1000; // 4 hours
 
-const asRecord = (value: unknown): Record<string, unknown> =>
-  value && typeof value === 'object' && !Array.isArray(value)
-    ? (value as Record<string, unknown>)
-    : {};
+export const approvalPlugin: Plugin = {
+  id: 'approval',
+  name: 'Approval',
+  description: 'Gate protected tool calls behind a UI confirmation widget.',
+  factory: ({ config }) => (builder) => {
+    // Actions that require approval. Defaults to shell_exec.
+    const actionsToApprove = (config.actions as string[]) || ['action:shell_exec'];
 
-const getApprovalsFromState = (state: OpenBotState): Record<string, PendingApproval> => {
-  const source = state.threadDetails?.state ?? state.channelDetails?.state;
-  const stateRecord = asRecord(source);
-  return asRecord(stateRecord.approvals) as Record<string, PendingApproval>;
-};
+    for (const action of actionsToApprove) {
+      builder.intercept(action as OpenBotEvent['type'], (event, context) => {
+        // If already approved in this flow, let it pass to the actual handler
+        if (event.meta?.approvalStatus === 'approved') return event;
 
-const persistApprovals = async (
-  state: OpenBotState,
-  approvals: Record<string, PendingApproval>,
-): Promise<void> => {
-  if (state.threadId) {
-    await storageService.patchThreadState({
-      channelId: state.channelId,
-      threadId: state.threadId,
-      state: { approvals },
-    });
-    return;
-  }
-  await storageService.patchChannelState({
-    channelId: state.channelId,
-    state: { approvals },
-  });
-};
+        // Otherwise, intercept and ask for approval via a UI widget
+        const displayData = action === 'action:shell_exec'
+          ? `\`\`\`bash\n${(event as any).data.command}\n\`\`\``
+          : `\`\`\`json\n${JSON.stringify((event as any).data, null, 2)}\n\`\`\``;
 
-const buildApprovalPlugin =
-  (rules: ApprovalRule[]): MelonyPlugin<OpenBotState, OpenBotEvent> =>
-  (builder) => {
-    for (const rule of rules) {
-      builder.on(rule.action as OpenBotEvent['type'], async function* (event, context) {
-        const meta = asRecord(event.meta);
-        if (meta.approvalStatus === 'approved') return;
-
-        const eventData = asRecord((event as { data?: unknown }).data);
-        const eventMeta = meta;
-
-        const approvalId = `approval_${Date.now()}_${Math.random().toString(36).slice(2, 8)}`;
-        const widgetId = `widget_${approvalId}`;
-        const executeEvent = rule.executeEvent || rule.action;
-        const denyEvent = rule.denyEvent || `${rule.action}:result`;
-        const denyData = rule.denyData || {};
-        const hiddenKeys = new Set(rule.hiddenKeys || []);
-        const detailKeys = rule.detailKeys || Object.keys(eventData);
-        const details = detailKeys
-          .filter((key) => !hiddenKeys.has(key))
-          .map((key) => `- ${key}: ${String(eventData[key] ?? '')}`)
-          .join('\n');
-
-        const pendingApprovals = getApprovalsFromState(context.state);
-        pendingApprovals[approvalId] = {
-          id: approvalId,
-          action: rule.action,
-          executeEvent,
-          denyEvent,
-          denyData,
-          payload: eventData,
-          meta: eventMeta,
-          message: rule.message || `Approval required for ${rule.action}.`,
-          createdAt: new Date().toISOString(),
-          status: 'pending',
-        };
-        await persistApprovals(context.state, pendingApprovals);
+        const widgetId = randomUUID();
+        pendingApprovals.set(widgetId, Date.now());
 
-        yield {
+        context.suspend({
           type: 'client:ui:widget',
           data: {
-            kind: 'choice',
             widgetId,
-            title: 'Approval Required',
-            body: `${rule.message || 'A protected action requires approval.'}${
-              details ? `\n\n${details}` : ''
-            }`,
-            metadata: { type: 'approval:request', approvalId, action: rule.action },
+            kind: 'message',
+            title: `The agent wants to perform \`${action}\``,
+            body: displayData,
+            metadata: {
+              type: 'approval:request',
+              originalEvent: event,
+            },
             actions: [
               { id: 'approve', label: 'Approve', variant: 'primary' },
               { id: 'deny', label: 'Deny', variant: 'danger' },
             ],
           },
-          meta: { ...(event.meta || {}), agentId: context.state.agentId },
-        } as OpenBotEvent;
-
-        yield {
-          type: 'agent:output',
-          data: { content: `Waiting for approval before running \`${rule.action}\`.` },
-          meta: { ...(event.meta || {}), agentId: context.state.agentId },
-        } as OpenBotEvent;
-
-        context.suspend();
+          meta: { agentId: context.state.agentId, threadId: context.state.threadId },
+        } as OpenBotEvent);
       });
     }
 
+    // Handle the user's response from the UI widget
     builder.on('client:ui:widget:response', async function* (event, context) {
-      const metadata = asRecord(event.data?.metadata);
-      if (metadata.type !== 'approval:request') return;
+      const { widgetId, actionId } = event.data;
+      const metadata = event.data?.metadata;
+      if (metadata?.type !== 'approval:request') return;
 
-      const approvalId = String(metadata.approvalId || '');
-      if (!approvalId) return;
+      // Verify the widget is still pending and hasn't expired
+      if (!widgetId || !pendingApprovals.has(widgetId)) {
+        console.warn(`[approval] Received response for unknown or already handled widget: ${widgetId}`);
+        return;
+      }
 
-      const approvals = getApprovalsFromState(context.state);
-      const approval = approvals[approvalId];
-      if (!approval || approval.status !== 'pending') {
-        yield {
-          type: 'agent:output',
-          data: { content: 'Approval request not found or already resolved.' },
-          meta: { ...(event.meta || {}), agentId: context.state.agentId },
-        } as OpenBotEvent;
+      const timestamp = pendingApprovals.get(widgetId)!;
+      if (Date.now() - timestamp > TTL_MS) {
+        pendingApprovals.delete(widgetId);
+        console.warn(`[approval] Received response for expired widget: ${widgetId}`);
         return;
       }
 
-      const approved = event.data.actionId === 'approve';
-      approvals[approvalId] = {
-        ...approval,
-        status: approved ? 'approved' : 'denied',
-      };
-      await persistApprovals(context.state, approvals);
+      // Mark as handled
+      pendingApprovals.delete(widgetId);
+
+      const originalEvent = metadata.originalEvent as OpenBotEvent;
+      const approved = actionId === 'approve';
+
+      // Yield a "responded" widget update to the UI
+      yield {
+        type: 'client:ui:widget',
+        data: {
+          widgetId,
+          kind: 'message',
+          title: `Action ${approved ? 'Approved' : 'Denied'}`,
+          body: `The request for \`${originalEvent.type}\` was ${approved ? 'approved' : 'denied'}.`,
+          state: approved ? 'submitted' : 'cancelled',
+          display: 'collapsed',
+          disabled: true,
+          actions: [], // Clear actions to disable buttons in UI
+        },
+        meta: { agentId: context.state.agentId, threadId: context.state.threadId },
+      } as OpenBotEvent;
 
       if (approved) {
+        // Re-emit the original event with approved status so the actual handler can run
         yield {
-          type: approval.executeEvent as OpenBotEvent['type'],
-          data: approval.payload,
+          ...originalEvent,
           meta: {
-            ...(approval.meta || {}),
-            approvalId,
+            ...(originalEvent.meta || {}),
             approvalStatus: 'approved',
           },
+        };
+      } else {
+        // Emit a failure result event for the denied action
+        // yield {
+        //   type: `${originalEvent.type}:result` as OpenBotEvent['type'],
+        //   data: {
+        //     success: false,
+        //     error: 'Action denied by user.',
+        //     stderr: 'Action denied by user.',
+        //   },
+        //   meta: originalEvent.meta,
+        // } as OpenBotEvent;
+
+        yield {
+          type: 'agent:output',
+          data: { content: `Action \`${originalEvent.type}\` was denied.` },
+          meta: { agentId: context.state.agentId },
         } as OpenBotEvent;
-        return;
       }
-
-      yield {
-        type: approval.denyEvent as OpenBotEvent['type'],
-        data: {
-          success: false,
-          approved: false,
-          error: 'Action denied by user approval.',
-          ...approval.denyData,
-        },
-        meta: { ...(approval.meta || {}), approvalId },
-      } as OpenBotEvent;
-
-      yield {
-        type: 'agent:output',
-        data: { content: 'Action denied by user approval.' },
-        meta: { ...(event.meta || {}), agentId: context.state.agentId },
-      } as OpenBotEvent;
     });
-  };
-
-const readRules = (config: Record<string, unknown>): ApprovalRule[] => {
-  const raw = config.rules;
-  if (!Array.isArray(raw)) return DEFAULT_APPROVAL_RULES;
-  return raw.filter(
-    (entry): entry is ApprovalRule =>
-      !!entry && typeof entry === 'object' && typeof (entry as { action?: unknown }).action === 'string',
-  );
-};
-
-export const approvalPlugin: Plugin = {
-  id: 'approval',
-  name: 'Approval',
-  description: 'Gate protected tool calls (e.g. shell_exec) behind a UI confirmation prompt.',
-  factory: ({ config }) => buildApprovalPlugin(readRules(config)),
+  },
 };
 
 export default approvalPlugin;

package/src/plugins/delegation/index.ts

@@ -1,51 +1,148 @@
-import { MelonyPlugin } from 'melony';
-import z from 'zod';
-import type { Plugin } from '../../bus/plugin.js';
-import { OpenBotEvent, OpenBotState } from '../../app/types.js';
-
-const handoffToolDefinitions = {
-  handoff: {
-    description:
-      'Transfer control to another agent. The target agent continues the task in this thread.',
+import { z } from 'zod';
+import { generateId } from 'melony';
+import type { Plugin } from '../../services/plugins/types.js';
+import { runAgent } from '../../harness/index.js';
+import {
+  OpenBotEvent,
+  DelegateTaskEvent,
+} from '../../app/types.js';
+
+/**
+ * `delegation` — allows agents to delegate tasks to other agents.
+ * 
+ * Only the 'system' agent is allowed to delegate by default.
+ * It uses runAgent to execute the delegated agent in its own isolated runtime,
+ * bridging events back to the caller's stream.
+ */
+
+const delegationToolDefinitions = {
+  delegate_task: {
+    description: 'Delegate a specific task or question to another specialized agent.',
     inputSchema: z.object({
-      agentId: z.string().describe('The ID of the target agent.'),
-      content: z.string().describe('The message or task to hand off.'),
+      agentId: z.string().describe('The ID of the agent to delegate to (e.g., "researcher", "coder").'),
+      prompt: z.string().describe('The instructions or question for the delegated agent.'),
     }),
   },
 };
 
-const handoffPluginRuntime = (): MelonyPlugin<OpenBotState, OpenBotEvent> => (builder) => {
-  builder.on('action:handoff', async function* (event, context) {
-    const { agentId, content } = event.data;
+export const delegationPlugin: Plugin = {
+  id: 'delegation',
+  name: 'Delegation',
+  description: 'Allows agents to call upon other agents to solve sub-tasks.',
+  toolDefinitions: delegationToolDefinitions,
+  factory: () => (builder) => {
 
-    yield {
-      type: 'agent:output',
-      data: { content: `Handing off to **${agentId}**: ${content}` },
-      meta: { ...(event.meta || {}), agentId: context.state.agentId },
-    };
+    // Handle the tool execution
+    builder.on('action:delegate_task', async function* (event, context) {
+      const delegateEvent = event as DelegateTaskEvent;
 
-    yield {
-      type: 'handoff:request',
-      data: { agentId, content },
-      meta: { ...(event.meta || {}), agentId: context.state.agentId },
-    };
+      // POLICY: Only the 'system' agent can delegate
+      if (context.state.agentId !== 'system') {
+        yield {
+          type: 'action:delegate_task:result',
+          data: {
+            success: false,
+            error: 'Only the system agent can delegate.'
+          },
+          meta: delegateEvent.meta,
+        } as OpenBotEvent;
+        return;
+      }
 
-    if (event.meta?.toolCallId) {
-      yield {
-        type: 'action:handoff:result',
-        data: { success: true, agentId, accepted: true },
-        meta: { ...(event.meta || {}), agentId: context.state.agentId },
-      };
-    }
-  });
-};
+      const { agentId, prompt } = delegateEvent.data;
+      const toolCallId = delegateEvent.meta?.toolCallId;
 
-export const delegationPlugin: Plugin = {
-  id: 'delegation',
-  name: 'Handoff',
-  description: 'Hand off tasks to other agents on the bus.',
-  toolDefinitions: handoffToolDefinitions,
-  factory: () => handoffPluginRuntime(),
+      if (!toolCallId) return;
+
+      const runId = `dg_${generateId()}`;
+      let lastAgentOutput = '';
+
+      // Queue to bridge the async onEvent callback to this generator
+      const eventQueue: OpenBotEvent[] = [];
+      let resolveNext: (() => void) | null = null;
+      let isFinished = false;
+
+      // Start the delegated agent in its own runtime.
+      // We don't await this immediately so we can yield events as they arrive.
+      const runPromise = runAgent({
+        runId,
+        agentId,
+        event: {
+          type: 'agent:invoke',
+          data: {
+            role: 'user',
+            content: prompt,
+            agentId: agentId,
+          },
+          meta: {
+            threadId: context.state.threadId,
+            parentAgentId: context.state.agentId,
+            parentToolCallId: toolCallId,
+          },
+        } as OpenBotEvent,
+        channelId: context.state.channelId,
+        threadId: context.state.threadId,
+        onEvent: async (outEvent) => {
+          // Enrich events with parent metadata so the UI can track the hierarchy
+          const enrichedEvent = {
+            ...outEvent,
+            meta: {
+              ...outEvent.meta,
+              parentAgentId: context.state.agentId,
+              parentToolCallId: toolCallId,
+            }
+          };
+
+          eventQueue.push(enrichedEvent);
+
+          if (outEvent.type === 'agent:output') {
+            lastAgentOutput = outEvent.data.content;
+          }
+
+          // Wake up the generator loop if it's waiting
+          if (resolveNext) {
+            resolveNext();
+            resolveNext = null;
+          }
+        }
+      }).catch(error => {
+        console.error(`[delegation] Error in delegated run ${runId}:`, error);
+      }).finally(() => {
+        isFinished = true;
+        if (resolveNext) {
+          resolveNext();
+          resolveNext = null;
+        }
+      });
+
+      // Yield events from the delegated agent as they arrive
+      while (!isFinished || eventQueue.length > 0) {
+        if (eventQueue.length === 0) {
+          await new Promise<void>(r => { resolveNext = r; });
+        }
+        while (eventQueue.length > 0) {
+          yield eventQueue.shift()!;
+        }
+      }
+
+      // Ensure the run is fully complete (though isFinished already implies this)
+      await runPromise;
+
+      // Yield the result back to our own LLM runtime.
+      yield {
+        type: 'action:delegate_task:result',
+        data: {
+          success: true,
+          output: lastAgentOutput,
+        },
+        meta: {
+          ...delegateEvent.meta,
+          agentId: context.state.agentId,
+          toolCallId: toolCallId,
+        },
+      } as OpenBotEvent;
+    });
+  },
 };
 
 export default delegationPlugin;

package/src/plugins/memory/index.ts

@@ -1,19 +1,42 @@
 import z from 'zod';
-import type { Plugin } from '../../bus/plugin.js';
+import type { Plugin } from '../../services/plugins/types.js';
+import { OpenBotEvent, MemoryScopeAlias } from '../../app/types.js';
 
 /**
- * `memory` — exposes the global memory store as agent tools.
- *
- * The actual handlers live in `bus/services.ts` because memory is platform
- * infrastructure (shared across every agent on the bus); this plugin only
- * contributes the tool definitions so a runtime plugin (e.g. `ai-sdk`) can
- * surface them to the LLM.
- *
- * Scopes
- * ------
- * - `global`  (default) — visible to every agent and channel.
- * - `agent`   — visible only to the agent that wrote it.
- * - `channel` — visible only inside the active channel.
+ * Resolve a scope alias to a concrete scope string. Aliases let tools accept
+ * `agent`/`channel`/`global` without knowing the active ids; the bus rewrites
+ * them using `context.state`.
+ */
+function resolveMemoryScope(
+  alias: MemoryScopeAlias | undefined,
+  state: any,
+): string {
+  switch (alias) {
+    case 'agent':
+      return `agent:${state.agentId}`;
+    case 'channel':
+      return `channel:${state.channelId}`;
+    case 'global':
+    case undefined:
+      return 'global';
+    default:
+      return 'global';
+  }
+}
+
+function resolveMemoryScopeFilter(
+  alias: MemoryScopeAlias | 'all' | undefined,
+  state: any,
+): string[] | undefined {
+  if (alias === 'all' || alias === undefined) {
+    return ['global', `agent:${state.agentId}`, `channel:${state.channelId}`];
+  }
+  return [resolveMemoryScope(alias, state)];
+}
+
+/**
+ * `memory` — exposes the global memory store as agent tools and provides
+ * platform-level memory handlers.
  */
 const memoryToolDefinitions = {
   remember: {
@@ -77,8 +100,82 @@ export const memoryPlugin: Plugin = {
   description:
     'Global long-term memory: remember/recall/forget facts across runs and agents.',
   toolDefinitions: memoryToolDefinitions,
-  factory: () => () => {
-    // Handlers live in bus/services.ts; this plugin only contributes tool definitions.
+  factory: ({ storage }) => (builder) => {
+    builder.on('action:remember', async function* (event, context) {
+      const resultMeta = { ...(event.meta || {}), agentId: context.state.agentId };
+      try {
+        const { content, scope, tags } = event.data;
+        const record = await storage.appendMemory({
+          scope: resolveMemoryScope(scope, context.state),
+          content,
+          tags,
+        });
+        yield {
+          type: 'action:remember:result',
+          data: { success: true, record },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      } catch (error) {
+        yield {
+          type: 'action:remember:result',
+          data: {
+            success: false,
+            error: error instanceof Error ? error.message : 'Unknown error',
+          },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      }
+    });
+
+    builder.on('action:recall', async function* (event, context) {
+      const resultMeta = { ...(event.meta || {}), agentId: context.state.agentId };
+      try {
+        const { query, tag, scope, limit } = event.data;
+        const records = await storage.listMemories({
+          scopes: resolveMemoryScopeFilter(scope, context.state),
+          query,
+          tag,
+          limit,
+        });
+        yield {
+          type: 'action:recall:result',
+          data: { success: true, records },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      } catch (error) {
+        yield {
+          type: 'action:recall:result',
+          data: {
+            success: false,
+            records: [],
+            error: error instanceof Error ? error.message : 'Unknown error',
+          },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      }
+    });
+
+    builder.on('action:forget', async function* (event, context) {
+      const resultMeta = { ...(event.meta || {}), agentId: context.state.agentId };
+      try {
+        const deleted = await storage.deleteMemory({ id: event.data.id });
+        yield {
+          type: 'action:forget:result',
+          data: { success: true, deleted },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      } catch (error) {
+        yield {
+          type: 'action:forget:result',
+          data: {
+            success: false,
+            deleted: false,
+            error: error instanceof Error ? error.message : 'Unknown error',
+          },
+          meta: resultMeta,
+        } as OpenBotEvent;
+      }
+    });
   },
 };
 

package/src/{services/memory.ts → plugins/memory/service.ts}

@@ -1,7 +1,7 @@
 import fs from 'node:fs/promises';
 import path from 'node:path';
 import crypto from 'node:crypto';
-import { DEFAULT_BASE_DIR, loadConfig, resolvePath } from '../app/config.js';
+import { DEFAULT_BASE_DIR, loadConfig, resolvePath } from '../../app/config.js';
 
 /**
  * Global memory service.