openalgo-script 0.7.2 → 0.8.0

package/src/adapters/charts/undrawable.ts

@@ -3,17 +3,24 @@
  *
  * `compiled-program.md` section 11: a host draws what its surface has room for,
  * and refuses what it does not with OS6024 rather than drawing part of a study
- * and saying nothing. Two things a version 1 program can declare have no place
- * on this chart's surface, and both used to be dropped in silence.
+ * and saying nothing. Two things a version 1 program can declare have a place
+ * on a newer chart and none on an older one (`capabilities.ts` says which is
+ * which), and on an older one both used to be dropped in silence.
  *
- * - **A second grid.** The descriptor has one `table` hook, so one grid reaches
- *   a pane. Merging two into it would put cells somewhere the script never
- *   asked for, and drawing the first alone is a study whose second panel never
- *   appears and whose cells look broken.
- * - **A band colour computed per bar.** The chart's band takes one colour for
- *   the whole run and has no channel to point at, so a band whose colour the
- *   script computes was drawn in the first plot's colour faded, which is a
- *   colour the script did not choose.
+ * - **A second grid.** An older descriptor has one `table` hook, so one grid
+ *   reaches a pane. Merging two into it would put cells somewhere the script
+ *   never asked for, and drawing the first alone is a study whose second panel
+ *   never appears and whose cells look broken. A newer chart's list of grids
+ *   carries every one (`tables.ts`).
+ * - **A band colour computed per bar.** An older chart's band takes one colour
+ *   for each side for the whole run, and a band whose colour the script
+ *   computes would be drawn in a colour the script did not choose. A newer
+ *   chart's band has a per-bar colour callback (`fills.ts`).
+ *
+ * Which chart the descriptor is registered with is what the host states, and
+ * `capabilities.ts` reads it. A host that states nothing is refused both, as
+ * before, because a chart that ignores a hook it does not know draws the
+ * silent version of each.
  *
  * The compiled program carries no source position for a declaration, so the
  * refusal names the declaration by its title, which is what a reader sees in
@@ -22,23 +29,26 @@
 import { diagnosticFor, makeSpan } from '../../core/index.js';
 import type { Diagnostic } from '../../core/index.js';
 import type { CompiledProgram, Field } from '../../core/emit/index.js';
+import { lacking } from './capabilities.js';
+import type { ChartCapabilities } from './capabilities.js';
 
 /** A load refusal has no line of its own: the program is what was refused. */
 const AT_LOAD = makeSpan(0, 0, 0, 0);
 
-export function undrawable(program: CompiledProgram): Diagnostic | undefined {
+export function undrawable(program: CompiledProgram, chart: ChartCapabilities): Diagnostic | undefined {
   const second = program.outputs.tables[1];
-  if (second !== undefined) {
+  if (second !== undefined && !chart.grids) {
     return diagnosticFor('OS6024', AT_LOAD, {
       what: `the table ${titled(second.title, 'after the first')}, the second grid this study declares`,
-      limit: 'a chart pane draws one grid',
+      limit: lacking(chart, 'grids', 'a chart pane draws one grid'),
     });
   }
+  if (chart.bandColours) return undefined;
   for (const band of program.outputs.fills) {
     if (band.colorUpChannel !== null || band.colorDownChannel !== null) {
       return diagnosticFor('OS6024', AT_LOAD, {
         what: "a band's colour that is computed per bar",
-        limit: "a chart's band takes one colour for the whole run",
+        limit: lacking(chart, 'bandColours', "a chart's band takes one colour for the whole run"),
       });
     }
   }

package/src/core/version/version.generated.ts

@@ -4,7 +4,7 @@
 // spec/compiled-program.md, so neither can drift from the thing it names.
 
 /** This build's package version. The release refuses to publish unless the tag, the manifest and this agree. */
-export const VERSION = "0.7.2";
+export const VERSION = "0.8.0";
 
 /**
  * The compiled program format this compiler emits.