openairev 0.3.10 → 0.3.12

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "openairev",
-  "version": "0.3.10",
+  "version": "0.3.12",
   "description": "Cross-model AI code reviewer — independent review for AI-assisted coding workflows",
   "type": "module",
   "bin": {

package/src/agents/claude-code.js

@@ -25,7 +25,7 @@ export class ClaudeCodeAdapter {
     stream = false,
     signal,
   } = {}) {
-    const args = ['-p', prompt];
+    const args = ['-p', prompt, '--max-budget-usd', '5'];
 
     if (stream) {
       args.push('--output-format', 'stream-json', '--verbose', '--include-partial-messages');

package/src/agents/codex.js

@@ -24,7 +24,7 @@ export class CodexAdapter {
     }
 
     args.push(prompt);
-    args.push('--json');
+    args.push('--json', '--sandbox', 'read-only');
 
     if (useSchema) {
       const schemaPath = join(__dirname, '../config', schemaFile);

package/src/cli/review.js

@@ -1,7 +1,6 @@
 import chalk from 'chalk';
-import { readFileSync } from 'fs';
 import { loadConfig, getReviewer, getMaxIterations } from '../config/config-loader.js';
-import { getDiff } from '../tools/git-tools.js';
+import { hasDiff, buildDiffCmd } from '../tools/git-tools.js';
 import { runReview } from '../review/review-runner.js';
 import { runWorkflow } from '../orchestrator/orchestrator.js';
 import { createSession, saveSession } from '../session/session-manager.js';
@@ -37,13 +36,17 @@ export async function reviewCommand(options) {
     console.log(`  Mode:        ${chalk.cyan('implement → review loop')}`);
   }
 
-  let diff = '';
+  let diffCmd = '';
+  let hasChanges = false;
   if (options.file) {
     console.log(`  Source:      ${chalk.cyan(options.file)}`);
-    diff = readFileSync(options.file, 'utf-8');
+    diffCmd = `cat ${JSON.stringify(options.file)}`;
+    hasChanges = true;
   } else {
-    try { diff = getDiff(options.diff); } catch { /* no diff yet is ok for workflow mode */ }
-    if (diff?.trim()) console.log(`  Diff lines:  ${chalk.cyan(diff.split('\n').length)}`);
+    const ref = options.diff || '';
+    try { hasChanges = hasDiff(ref); } catch { /* no diff yet is ok for workflow mode */ }
+    diffCmd = buildDiffCmd(ref);
+    if (hasChanges) console.log(`  Diff cmd:    ${chalk.cyan(diffCmd)}`);
   }
 
   if (options.specRef) console.log(`  Spec:        ${chalk.cyan(options.specRef)}`);
@@ -56,13 +59,13 @@ export async function reviewCommand(options) {
   console.log('');
 
   if (options.once) {
-    if (!diff?.trim()) {
+    if (!hasChanges) {
       console.log(chalk.yellow('No changes found. Stage some changes or specify --diff <ref>.'));
       process.exit(0);
     }
     try {
       console.log(chalk.dim('Starting review...\n'));
-      const review = await runReview(diff, { config, reviewerName, cwd, stream: true });
+      const review = await runReview(diffCmd, { config, reviewerName, cwd, stream: true });
 
       const session = createSession({ executor, reviewer: reviewerName, diff_ref: options.diff || 'auto' });
       session.iterations.push({ round: 1, review, timestamp: new Date().toISOString() });
@@ -83,7 +86,7 @@ export async function reviewCommand(options) {
   } else {
     try {
       const result = await runWorkflow({
-        config, executor, reviewerName, maxRounds, diff, diffRef: options.diff,
+        config, executor, reviewerName, maxRounds, diffRef: options.diff,
         taskDescription: options.task, specRef: options.specRef, tools: config.tools,
         cwd, skipAnalyze, skipPlan,
         onStageChange: (stage) => console.log(chalk.bold(`\n[${stageLabel(stage)}]\n`)),

package/src/cli/wait.js

@@ -61,6 +61,9 @@ function printResult(data) {
   }
 
   console.log('');
+  if (data.partial_notice) {
+    console.log(`\n⚠ ${data.partial_notice}\n`);
+  }
   if (data.executor_feedback) {
     console.log(data.executor_feedback);
   } else if (data.verdict) {

package/src/mcp/mcp-server.js

@@ -6,7 +6,7 @@ import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { StdioServerTransport } from '@modelcontextprotocol/sdk/server/stdio.js';
 import { z } from 'zod';
 import { loadConfig, getReviewer } from '../config/config-loader.js';
-import { getDiff } from '../tools/git-tools.js';
+import { getDiff, hasDiff, buildDiffCmd } from '../tools/git-tools.js';
 import { runToolGates } from '../tools/tool-runner.js';
 import { runReview } from '../review/review-runner.js';
 import { createSession, saveSession } from '../session/session-manager.js';
@@ -29,28 +29,19 @@ server.tool(
   'TRIGGER: Use this tool when the user says "review", "review my code", "get a review", "check my changes", "openairev", or asks for independent/cross-model code review. Sends current code changes to a DIFFERENT AI model for independent review. The review starts in the background and returns immediately. After calling this, run `openairev wait` via Bash to stream progress and get the verdict — one blocking call, no polling needed.',
   {
     executor: z.string().optional().describe('Which agent wrote the code (claude_code or codex). If you are Claude Code, set this to "claude_code". If you are Codex, set this to "codex".'),
-    diff: z.string().optional().describe('The diff to review. IMPORTANT: Pass only the diff for files YOU changed, not the entire repo. Use `git diff HEAD -- file1 file2` to scope it. If omitted, auto-detects from git which may be too large.'),
-    diff_cmd: z.string().optional().describe('The git command used to get the diff, e.g. "git diff HEAD -- src/auth.ts src/routes.ts". If provided instead of diff, the server will run this command to get the diff.'),
+    diff_cmd: z.string().optional().describe('The git diff command for the reviewer to run, e.g. "git diff HEAD -- src/auth.ts src/routes.ts". The reviewer runs in the same repo and executes this itself. If omitted, auto-detects staged or unstaged changes.'),
     task_description: z.string().optional().describe('What the code is supposed to do. Used for requirement checking.'),
   },
-  async ({ executor, diff, diff_cmd, task_description }) => {
+  async ({ executor, diff_cmd, task_description }) => {
     const execAgent = executor || Object.keys(config.agents || {}).find(a => config.agents[a].available);
     const reviewerName = getReviewer(config, execAgent);
     if (!reviewerName) {
       return { content: [{ type: 'text', text: `No reviewer configured for executor "${execAgent}"` }] };
     }
 
-    let diffContent = diff;
-    if (!diffContent && diff_cmd) {
-      try {
-        const { execSync } = await import('child_process');
-        diffContent = execSync(diff_cmd, { encoding: 'utf-8', maxBuffer: 10 * 1024 * 1024, cwd });
-      } catch (e) {
-        return { content: [{ type: 'text', text: `diff_cmd failed: ${e.message}` }] };
-      }
-    }
-    if (!diffContent) diffContent = getDiff();
-    if (!diffContent?.trim()) {
+    const reviewDiffCmd = diff_cmd || buildDiffCmd();
+
+    if (!hasDiff()) {
       return { content: [{ type: 'text', text: 'No changes found to review.' }] };
     }
 
@@ -62,7 +53,7 @@ server.tool(
     };
 
     activeAbort = new AbortController();
-    activeReview = runReview(diffContent, {
+    activeReview = runReview(reviewDiffCmd, {
       config,
       reviewerName,
       taskDescription: task_description,
@@ -76,13 +67,16 @@ server.tool(
       session.status = 'completed';
       saveSession(session, cwd);
 
-      writeProgress({
-        status: 'completed',
+      const progressData = {
+        status: review.error ? 'error' : 'completed',
         reviewer: reviewerName,
         progress: review.progress || [],
         verdict: review.verdict,
         executor_feedback: review.executor_feedback,
-      });
+      };
+      if (review.error) progressData.error = review.error;
+      if (review.partial_notice) progressData.partial_notice = review.partial_notice;
+      writeProgress(progressData);
       activeReview = null;
       activeAbort = null;
       return review;

package/src/orchestrator/orchestrator.js

@@ -1,7 +1,7 @@
 import { createAdapter } from '../agents/registry.js';
 import { runReview } from '../review/review-runner.js';
 import { loadPromptFile } from '../review/prompt-loader.js';
-import { getDiff } from '../tools/git-tools.js';
+import { hasDiff, buildDiffCmd } from '../tools/git-tools.js';
 import { runToolGates } from '../tools/tool-runner.js';
 import {
   createChain, transitionTo, addRound, setArtifact,
@@ -44,7 +44,7 @@ export async function runWorkflow({
     }
   }
 
-  let currentDiff = initialDiff;
+  let hasChanges = !!initialDiff;
   let codeReviewCount = 0;
   let planReviewCount = 0;
 
@@ -140,13 +140,7 @@ export async function runWorkflow({
         const prompt = buildImplementationPrompt(chain, specRef);
         await runExecutor(executor, config, prompt, chain, cwd);
 
-        try {
-          currentDiff = getDiff(diffRef);
-        } catch {
-          currentDiff = '';
-        }
-
-        if (currentDiff?.trim()) {
+        if (hasDiff(diffRef)) {
           setArtifact(chain, 'current_diff_ref', diffRef || 'auto', cwd);
           transitionTo(chain, 'code_review', cwd);
         } else {
@@ -168,7 +162,8 @@ export async function runWorkflow({
           toolResults = runToolGates(Object.keys(tools), cwd, tools);
         }
 
-        const review = await runReviewRound(reviewerName, config, currentDiff, {
+        const reviewDiffCmd = diffRef ? `git diff ${diffRef}` : 'git diff --staged || git diff';
+        const review = await runReviewRound(reviewerName, config, reviewDiffCmd, {
           kind: 'code_review', chain, specRef, cwd,
         });
 
@@ -205,14 +200,7 @@ export async function runWorkflow({
         const feedback = buildFeedback(lastVerdict, cwd);
         await runExecutor(executor, config, feedback, chain, cwd);
 
-        try {
-          currentDiff = getDiff(diffRef);
-        } catch (e) {
-          closeChain(chain, 'error', cwd);
-          return { chain, status: 'error', message: `Failed to get diff: ${e.message}` };
-        }
-
-        if (!currentDiff?.trim()) {
+        if (!hasDiff(diffRef)) {
           closeChain(chain, 'error', cwd);
           return { chain, status: 'error', message: 'No changes after fix attempt' };
         }
@@ -255,15 +243,16 @@ async function runExecutor(executor, config, prompt, chain, cwd) {
   return { output: result?.result || result?.raw || null, session_id: sessionId };
 }
 
-async function runReviewRound(reviewerName, config, content, { kind, chain, specRef, cwd }) {
+async function runReviewRound(reviewerName, config, input, { kind, chain, specRef, cwd }) {
   const promptFile = kind === 'plan_review' ? 'plan-reviewer.md' : 'reviewer.md';
   const sessionId = getReviewerSession(chain, kind);
 
-  return runReview(content, {
+  return runReview(input, {
     config, reviewerName, promptFile,
     taskDescription: chain.task?.user_request,
     specRef: specRef || chain.task?.spec_ref,
     cwd, sessionId, stream: true,
+    inputMode: kind === 'plan_review' ? 'inline' : 'diff_cmd',
   });
 }
 

package/src/review/review-runner.js

@@ -1,10 +1,9 @@
 import { mkdirSync, writeFileSync } from 'fs';
 import { join } from 'path';
 import { createAdapter } from '../agents/registry.js';
-import { stageInput, buildInputReference } from './input-stager.js';
 import { loadPromptFile } from './prompt-loader.js';
 
-export async function runReview(content, {
+export async function runReview(input, {
   config,
   reviewerName,
   promptFile = 'reviewer.md',
@@ -14,6 +13,7 @@ export async function runReview(content, {
   sessionId = null,
   stream = false,
   signal,
+  inputMode = 'diff_cmd',
 }) {
   const adapter = createAdapter(reviewerName, config, { cwd });
 
@@ -22,8 +22,6 @@ export async function runReview(content, {
   }
 
   const reviewerPrompt = loadPromptFile(promptFile, cwd);
-  const staged = stageInput(content, { cwd });
-  const inputRef = buildInputReference(staged);
 
   let prompt = reviewerPrompt;
   if (taskDescription) {
@@ -32,7 +30,12 @@ export async function runReview(content, {
   if (specRef) {
     prompt += `\n\nSpec reference: ${specRef}\nRead the spec file for requirements and acceptance criteria.`;
   }
-  prompt = `${prompt}${inputRef}`;
+
+  if (inputMode === 'diff_cmd') {
+    prompt += `\n\n--- CHANGES TO REVIEW ---\nRun this command to get the diff:\n\`${input}\`\n\nReview the changed files. You are in the same repo as the executor — run the diff command yourself, read the files, and produce your verdict.`;
+  } else {
+    prompt += `\n\n--- CONTENT TO REVIEW ---\n${input}`;
+  }
 
   const schemaFile = promptFile === 'plan-reviewer.md' ? 'plan-verdict-schema.json' : 'verdict-schema.json';
 
@@ -51,7 +54,7 @@ export async function runReview(content, {
 
   logReviewerOutput(rawOutput, reviewerName, cwd);
 
-  return {
+  const reviewResult = {
     reviewer: reviewerName,
     verdict,
     executor_feedback: executorFeedback,
@@ -59,6 +62,17 @@ export async function runReview(content, {
     progress: result?.progress || [],
     session_id: adapter.sessionName || adapter.sessionId,
   };
+
+  if (!verdict) {
+    const explicitError = result?.error;
+    if (explicitError) {
+      reviewResult.error = `Reviewer (${reviewerName}) failed: ${explicitError}`;
+    } else {
+      reviewResult.error = `Reviewer (${reviewerName}) produced no verdict. Possible causes: context budget exceeded, auth failure, or schema mismatch. Check .openairev/logs/ for details.`;
+    }
+  }
+
+  return reviewResult;
 }
 
 function logReviewerOutput(rawOutput, reviewerName, cwd) {

package/src/tools/git-tools.js

@@ -34,6 +34,38 @@ export function getDiff(ref, { context = 1, excludes = EXCLUDE_PATTERNS } = {})
   return '';
 }
 
+/**
+ * Check if there are changes without reading the diff content.
+ * Uses git diff --quiet (exit code only, no output).
+ */
+export function hasDiff(ref) {
+  try {
+    if (ref) {
+      execFileSync('git', ['diff', '--quiet', ref]);
+      return false;
+    }
+    // Try staged first
+    try {
+      execFileSync('git', ['diff', '--quiet', '--cached']);
+      // exit 0 = no staged changes, try unstaged
+      execFileSync('git', ['diff', '--quiet']);
+      return false; // no changes at all
+    } catch {
+      return true; // either staged or unstaged has changes
+    }
+  } catch {
+    return true; // exit 1 = has changes
+  }
+}
+
+/**
+ * Build a diff command string for the reviewer to run.
+ */
+export function buildDiffCmd(ref) {
+  if (ref) return `git diff ${ref}`;
+  return 'git diff --staged || git diff';
+}
+
 function gitExec(args) {
   try {
     return execFileSync('git', args, { encoding: 'utf-8', maxBuffer: 10 * 1024 * 1024 });

package/src/review/input-stager.js

@@ -1,35 +0,0 @@
-import { writeFileSync, mkdirSync } from 'fs';
-import { join } from 'path';
-
-const INLINE_THRESHOLD = 8_000; // characters — inline if under this
-
-/**
- * Stage review input. For small content, returns it inline.
- * For large content, writes to .openairev/tmp/ and returns a file reference.
- */
-export function stageInput(content, { cwd = process.cwd(), label = 'review-input' } = {}) {
-  if (content.length <= INLINE_THRESHOLD) {
-    return { mode: 'inline', content };
-  }
-
-  const tmpDir = join(cwd, '.openairev', 'tmp');
-  mkdirSync(tmpDir, { recursive: true });
-
-  const filename = `${label}-${Date.now()}.diff`;
-  const filePath = join(tmpDir, filename);
-  const relativePath = `.openairev/tmp/${filename}`;
-
-  writeFileSync(filePath, content);
-
-  return { mode: 'file', filePath, relativePath };
-}
-
-/**
- * Build the prompt prefix for the first pass based on staging result.
- */
-export function buildInputReference(staged) {
-  if (staged.mode === 'inline') {
-    return `\n\n--- DIFF ---\n${staged.content}`;
-  }
-  return `\n\nThe diff to review is stored at: ${staged.relativePath}\nRead that file to see the full changes. It is too large to include inline.`;
-}

package/src/review/input-stager.test.js

@@ -1,53 +0,0 @@
-import { describe, it, beforeEach, afterEach } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdirSync, rmSync, existsSync, readFileSync } from 'fs';
-import { join } from 'path';
-import { stageInput, buildInputReference } from './input-stager.js';
-
-const TMP = join(process.cwd(), '.test-tmp-stager');
-
-describe('input-stager', () => {
-  beforeEach(() => {
-    mkdirSync(TMP, { recursive: true });
-  });
-
-  afterEach(() => {
-    rmSync(TMP, { recursive: true, force: true });
-  });
-
-  it('inlines small content', () => {
-    const result = stageInput('small diff', { cwd: TMP });
-    assert.equal(result.mode, 'inline');
-    assert.equal(result.content, 'small diff');
-  });
-
-  it('writes large content to file', () => {
-    const large = 'x'.repeat(10_000);
-    const result = stageInput(large, { cwd: TMP });
-    assert.equal(result.mode, 'file');
-    assert.ok(result.filePath);
-    assert.ok(result.relativePath.startsWith('.openairev/tmp/'));
-    assert.ok(existsSync(result.filePath));
-    assert.equal(readFileSync(result.filePath, 'utf-8'), large);
-  });
-
-  it('buildInputReference returns inline content for small input', () => {
-    const staged = { mode: 'inline', content: 'diff here' };
-    const ref = buildInputReference(staged);
-    assert.ok(ref.includes('diff here'));
-    assert.ok(ref.includes('--- DIFF ---'));
-  });
-
-  it('buildInputReference returns file path for large input', () => {
-    const staged = { mode: 'file', relativePath: '.openairev/tmp/test.diff' };
-    const ref = buildInputReference(staged);
-    assert.ok(ref.includes('.openairev/tmp/test.diff'));
-    assert.ok(ref.includes('Read that file'));
-  });
-
-  it('uses custom label for filename', () => {
-    const large = 'y'.repeat(10_000);
-    const result = stageInput(large, { cwd: TMP, label: 'my-review' });
-    assert.ok(result.relativePath.includes('my-review'));
-  });
-});