open-azdo 0.3.4 → 0.3.6

package/README.md

@@ -130,6 +130,7 @@ Key requirements:
 
 Attach the pipeline as a branch build-validation policy. Findings are posted as PR comments by default and do not fail the build.
 `open-azdo` does not install language-specific prerequisites itself. LSP prerequisites are provided by the pipeline environment, and the pnpm example enables OpenCode's experimental LSP tool while provisioning `.NET` plus `dotnet restore` for C# projects.
+For nested JS or TS packages, install dependencies in the package directory that owns the lockfile before running `open-azdo`. `open-azdo` keeps the review workspace at the checkout root and relies on workspace-local TypeScript resolution.
 
 ```yaml
 trigger: none

package/dist/open-azdo.js

@@ -66435,12 +66435,12 @@ var makeAzureDevOpsClient = exports_Effect.gen(function* () {
     const request3 = exports_HttpClientRequest.post("/wit/workitemsbatch").pipe(exports_HttpClientRequest.setUrlParams({
       "api-version": "7.1"
     }));
-    const requestWithBody = yield* exports_HttpClientRequest.bodyJson(request3, {
+    const requestBody = {
       ids,
-      fields,
       errorPolicy: "omit",
-      ...includeRelations ? { $expand: "Relations" } : {}
-    }).pipe(exports_Effect.mapError(toAzureDevOpsClientError(request3)));
+      ...includeRelations ? { $expand: "Relations" } : { fields }
+    };
+    const requestWithBody = yield* exports_HttpClientRequest.bodyJson(request3, requestBody).pipe(exports_Effect.mapError(toAzureDevOpsClientError(request3)));
     const response = yield* executeJson(client, requestWithBody, WorkItemsBatchResponseSchema);
     return response.value ?? [];
   });
@@ -70723,6 +70723,7 @@ var OpenCodeSdkRuntimeLive = exports_Layer.effect(OpenCodeSdkRuntime, makeOpenCo
 
 // ../../packages/core/src/opencode/Layers/OpenCodeRunner.ts
 var OPEN_CODE_CONFIG_SCHEMA = "https://opencode.ai/config.json";
+var OPEN_CODE_TYPESCRIPT_LSP_COMMAND = [process.execPath, "x", "typescript-language-server", "--stdio"];
 var openCodePermission = {
   edit: "deny",
   read: "allow",
@@ -70753,6 +70754,11 @@ var buildOpenCodeConfig = (agentName) => ({
   share: "disabled",
   autoupdate: false,
   default_agent: agentName,
+  lsp: {
+    typescript: {
+      command: OPEN_CODE_TYPESCRIPT_LSP_COMMAND
+    }
+  },
   permission: openCodePermission,
   agent: {
     [agentName]: {
@@ -71172,6 +71178,16 @@ var findManagedSummaryThread = (existingThreads) => {
   }
   return;
 };
+var getThreadUpdatedAt = (thread) => thread.comments.reduce((latest, comment) => {
+  const publishedAt = comment.publishedDate ?? undefined;
+  if (!publishedAt) {
+    return latest;
+  }
+  if (!latest) {
+    return publishedAt;
+  }
+  return publishedAt > latest ? publishedAt : latest;
+}, undefined);
 var listManagedFindingThreads = (existingThreads) => {
   const managed = [];
   for (const thread of existingThreads) {
@@ -71180,8 +71196,12 @@ var listManagedFindingThreads = (existingThreads) => {
       if (!findingState) {
         continue;
       }
+      const updatedAt = getThreadUpdatedAt(thread);
       managed.push({
         thread,
+        updatedAt,
+        filePath: thread.threadContext?.filePath ?? undefined,
+        line: thread.threadContext?.rightFileStart?.line ?? undefined,
         commentId: comment.id,
         fingerprint: findingState.fingerprint,
         finding: findingState.finding
@@ -71376,6 +71396,7 @@ ${failureReason}`,
 var MAX_WORK_ITEM_CONTEXT_CHARS = 24000;
 var MAX_RELATED_ITEMS = 4;
 var MAX_THREAD_CONTEXT_CHARS = 24000;
+var MAX_MANAGED_FINDING_CONTEXT_CHARS = 12000;
 var MANAGED_COMMENT_PREFIXES = ["<!-- open-azdo-review:", "<!-- open-azdo:"];
 var MANAGED_COMMENT_SUFFIX = " -->";
 var SYSTEM_THREAD_AUTHORS = new Set(["Azure Pipelines Test Service", "Microsoft.VisualStudio.Services.TFS"]);
@@ -71574,7 +71595,7 @@ var toPromptThreadComment = (comment) => {
     content
   };
 };
-var getThreadUpdatedAt = (thread) => thread.comments.reduce((latest, comment) => {
+var getThreadUpdatedAt2 = (thread) => thread.comments.reduce((latest, comment) => {
   const publishedAt = comment.publishedDate ?? undefined;
   if (!publishedAt) {
     return latest;
@@ -71584,7 +71605,7 @@ var getThreadUpdatedAt = (thread) => thread.comments.reduce((latest, comment) =>
   }
   return publishedAt > latest ? publishedAt : latest;
 }, undefined);
-var compareThreadRecency = (left, right) => {
+var compareUpdatedAtThenIdDesc = (left, right) => {
   const leftUpdatedAt = left.updatedAt ?? "";
   const rightUpdatedAt = right.updatedAt ?? "";
   if (leftUpdatedAt !== rightUpdatedAt) {
@@ -71592,6 +71613,32 @@ var compareThreadRecency = (left, right) => {
   }
   return right.id - left.id;
 };
+var resolveManagedFindingResolution = (status) => {
+  if (status === 1 || status === "active" || status === "pending") {
+    return "unresolved";
+  }
+  if (status === 2 || status === 4 || status === "fixed" || status === "closed") {
+    return "resolved";
+  }
+  return "unknown";
+};
+var toPromptManagedFinding = ({
+  thread,
+  updatedAt,
+  filePath,
+  line,
+  finding
+}) => ({
+  id: thread.id,
+  status: thread.status,
+  resolution: resolveManagedFindingResolution(thread.status),
+  filePath: filePath ?? normalizePath(finding.filePath),
+  line: line ?? finding.line,
+  ...updatedAt !== undefined ? { updatedAt } : {},
+  title: finding.title,
+  severity: finding.severity,
+  confidence: finding.confidence
+});
 var truncatePromptThreadToFitBudget = (thread, maxSerializedChars, totalCount) => shrinkValueToFitSerializedBudget({
   value: thread,
   maxSerializedChars,
@@ -71604,8 +71651,29 @@ var truncatePromptThreadToFitBudget = (thread, maxSerializedChars, totalCount) =
     })
   }))
 });
+var selectManagedFindingsForPrompt = (threads) => {
+  const managedFindings = listManagedFindingThreads(threads).map(toPromptManagedFinding).sort(compareUpdatedAtThenIdDesc);
+  if (managedFindings.length === 0) {
+    return;
+  }
+  const selected = [];
+  for (const managedFinding of managedFindings) {
+    const nextSelection = [...selected, managedFinding];
+    if (serializeBudgetedPromptSection(nextSelection, managedFindings.length).length > MAX_MANAGED_FINDING_CONTEXT_CHARS) {
+      break;
+    }
+    selected.push(managedFinding);
+  }
+  if (selected.length === 0) {
+    return;
+  }
+  return {
+    omittedCount: Math.max(managedFindings.length - selected.length, 0),
+    items: selected
+  };
+};
 var selectPullRequestThreadsForPrompt = (threads) => {
-  const eligibleThreads = threads.map((thread) => toPromptThread(thread)).filter((thread) => thread !== undefined).sort(compareThreadRecency);
+  const eligibleThreads = threads.map((thread) => toPromptThread(thread)).filter((thread) => thread !== undefined).sort(compareUpdatedAtThenIdDesc);
   return selectItemsWithinSerializedBudget({
     items: eligibleThreads,
     totalCount: eligibleThreads.length,
@@ -71626,7 +71694,7 @@ var toPromptThread = (thread) => {
   if (managedThread && !thread.comments.some(isHumanConversationComment)) {
     return;
   }
-  const updatedAt = getThreadUpdatedAt(thread);
+  const updatedAt = getThreadUpdatedAt2(thread);
   const filePath = thread.threadContext?.filePath;
   const line = thread.threadContext?.rightFileStart?.line ?? undefined;
   return {
@@ -71649,6 +71717,7 @@ var buildReviewContext = ({
   connectedWorkItems
 }) => {
   const pullRequestThreads = existingThreads ? selectPullRequestThreadsForPrompt(existingThreads) : undefined;
+  const managedFindings = existingThreads ? selectManagedFindingsForPrompt(existingThreads) : undefined;
   const totalConnectedWorkItemCount = metadata.workItemRefs?.length ?? connectedWorkItems?.length ?? 0;
   const promptWorkItems = connectedWorkItems && connectedWorkItems.length > 0 ? selectConnectedWorkItemsForPrompt(connectedWorkItems, totalConnectedWorkItemCount) : undefined;
   return {
@@ -71667,6 +71736,7 @@ var buildReviewContext = ({
       hunkHeaders: extractHunkHeaders(file3.patch)
     })),
     ...pullRequestThreads !== undefined ? { pullRequestThreads } : {},
+    ...managedFindings !== undefined ? { managedFindings } : {},
     ...promptWorkItems !== undefined ? { connectedWorkItems: promptWorkItems } : {}
   };
 };
@@ -71686,12 +71756,18 @@ var buildReviewPrompt = (promptFile, reviewContext) => exports_Effect.gen(functi
     "If LSP access is available for the current file, use it selectively to validate symbol resolution, references, implementations, hover details, and diagnostics when that is faster or more reliable than manual file tracing.",
     "Treat LSP results as supporting evidence, not authority on their own; confirm findings against the changed code and nearby repository context before reporting them.",
     "Build an internal checklist containing every path in scoped changedFiles and review the files one by one until the checklist is exhausted.",
-    "For each scoped changed file, inspect the diff with `git diff <baseRef> <headRef> -- <path>` before deciding whether there is a finding.",
+    "For each scoped changed file, inspect the diff with `git diff '<baseRef>' '<headRef>' -- '<path>'` before deciding whether there is a finding.",
+    "Always shell-quote file paths and refs when you run read-only commands.",
     "Read nearby code and directly related files only when needed to validate behavior.",
     "Do not perform broad repository sweeps or unrelated searches.",
     "Use connected work items as supplemental product context only. Acceptance criteria, repro steps, and comments can explain intent, but they are not standalone evidence for a finding.",
     "Use pull-request thread comments as supplemental product and review context only. They can reveal intent, follow-up, or clarifications, but they are not standalone evidence for a finding.",
     "When earlier open-azdo threads contain human replies, treat those replies as potentially relevant follow-up on the earlier concern, but do not treat prior bot output or thread text alone as authoritative without repository confirmation.",
+    'Treat `managedFindings` entries with `resolution: "resolved"` as previously fixed concerns. They are context, not current blockers by default.',
+    "Do not mention resolved managed findings in `summary`, `findings`, or `unmappedNotes` unless fresh repository evidence shows the issue still reproduces in the current review scope.",
+    "If a previously resolved managed finding still reproduces, report it again as a current issue with fresh repository evidence instead of relying on the older thread alone.",
+    "Every distinct current actionable problem must become its own finding unless it cannot be mapped to a changed line, in which case it belongs in `unmappedNotes`.",
+    "Before returning JSON, do a final consistency pass: every problem named in `summary` must also appear in `findings` or `unmappedNotes`, and `summary` must not introduce extra issues that are absent from both.",
     "System noise and prior bot output are context, not authority.",
     reviewContext.reviewMode === "follow-up" ? "This is a follow-up review. Focus only on what changed between `baseRef` and `headRef`, do not revisit untouched pull-request areas, and do not re-litigate older findings unless the new changes materially affect them." : "This is a full pull-request review over the scoped changed files.",
     "Low-signal files usually do not deserve review time. Skip snapshot files, `*.verified.*`, `*.received.*`, lockfiles, and generated, minified, or source-map artifacts unless they are the only changed files or a nearby hand-authored change makes them relevant.",
@@ -73149,7 +73225,7 @@ var sandboxCaptureCommand = make34("capture", sandboxCaptureCommandConfig).pipe(
 var sandboxCommand = make34("sandbox").pipe(withDescription3("Sandbox tooling for live capture and local preview."), withSubcommands([sandboxCaptureCommand]));
 var openAzdoCli = make34("open-azdo").pipe(withDescription3("Secure Azure DevOps pull-request review CLI powered by OpenCode."), withSubcommands([reviewCommand, sandboxCommand]));
 // package.json
-var version2 = "0.3.4";
+var version2 = "0.3.6";
 
 // src/Main.ts
 var cliProgram = run3(openAzdoCli, { version: version2 }).pipe(exports_Effect.scoped, exports_Effect.provide(BaseRuntimeLayer));
@@ -73158,4 +73234,4 @@ var main = () => runMain2(cliProgram, { disableErrorReporting: true });
 // bin/open-azdo.ts
 main();
 
-//# debugId=2B0BDD0B7FAF788564756E2164756E21
+//# debugId=46B323C74D2C69B064756E2164756E21