onsystem 0.8.0 → 0.9.1

package/README.md

@@ -20,6 +20,7 @@ Using the GitHub Action? `uses: dgesteves/onsystem@v0` checks the lines a pull r
 **Also works with**
 [![Codex CLI](https://img.shields.io/badge/Codex_CLI-0d0f12?style=flat-square)](https://onsystem.vercel.app/docs/clients#codex-cli)
 [![Gemini CLI](https://img.shields.io/badge/Gemini_CLI-0d0f12?style=flat-square&logo=googlegemini&logoColor=white)](https://onsystem.vercel.app/docs/clients#gemini-cli)
+[![Antigravity](https://img.shields.io/badge/Antigravity-0d0f12?style=flat-square)](https://onsystem.vercel.app/docs/clients#antigravity-cli-and-ide)
 [![Grok Build](https://img.shields.io/badge/Grok_Build-0d0f12?style=flat-square)](https://onsystem.vercel.app/docs/clients#grok-build)
 [![GitHub Copilot CLI](https://img.shields.io/badge/GitHub_Copilot_CLI-0d0f12?style=flat-square&logo=githubcopilot&logoColor=white)](https://onsystem.vercel.app/docs/clients#github-copilot-cli)
 [![Claude Desktop](https://img.shields.io/badge/Claude_Desktop-0d0f12?style=flat-square&logo=claude&logoColor=white)](https://onsystem.vercel.app/docs/clients#claude-desktop)
@@ -29,6 +30,8 @@ Using the GitHub Action? `uses: dgesteves/onsystem@v0` checks the lines a pull r
 
 **Website and docs:** [onsystem.vercel.app](https://onsystem.vercel.app), with a [playground](https://onsystem.vercel.app/playground) that checks your own code.
 
+**Feedback wanted:** say where it breaks in the [launch feedback thread](https://github.com/dgesteves/onsystem/discussions/227), see what's next in the [roadmap](https://github.com/dgesteves/onsystem/blob/main/ROADMAP.md), or pick up a [good first issue](https://github.com/dgesteves/onsystem/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22). If onsystem is useful to you, a star helps other people find it.
+
 <p align="center">
   <a href="https://onsystem.vercel.app"><img src=".github/assets/demo.webp" width="100%" alt="On the website, an agent drafts a settings card, check_ui finds 11 problems with a fix each and the agent applies them. Then a real Claude Code session with the plugin, where Claude looks the components up before writing and check_ui passes. Last, the benchmark."></a>
 </p>
@@ -83,7 +86,7 @@ After each Write or Edit of a `.tsx` or `.jsx` file, the hook runs `onsystem che
 
 **Other agents.** `npx skills add dgesteves/onsystem` adds the skill to any agent with Agent Skills, and there are [plugins for Codex, GitHub Copilot CLI, VS Code and Cursor](https://onsystem.vercel.app/docs/clients#plugins-for-other-agents).
 
-**Any MCP client.** Run `npx -y onsystem` as a stdio server. There are [configs for Claude Desktop, Codex CLI, GitHub Copilot CLI, Windsurf, JetBrains IDEs, Zed, Gemini CLI and Grok Build](https://onsystem.vercel.app/docs/clients#other-clients).
+**Any MCP client.** Run `npx -y onsystem` as a stdio server. There are [configs for Claude Desktop, Codex CLI, GitHub Copilot CLI, Windsurf, JetBrains IDEs, Zed, Gemini CLI, Antigravity and Grok Build](https://onsystem.vercel.app/docs/clients#other-clients).
 
 **CI.** Install it as a dev dependency, accept the findings the codebase already has once, and fail pull requests only on new ones:
 
@@ -96,7 +99,22 @@ npx onsystem check . --update-baseline   # writes onsystem.baseline.json: commit
 - run: npx onsystem check . --format github --require-design-system
 ```
 
-Findings show up as annotations on the pull request, and `--require-design-system` fails the job when the design system is no longer found. [CI and baselines](https://onsystem.vercel.app/docs/ci) has the whole workflow. The GitHub Action, `uses: dgesteves/onsystem@v0`, annotates only the lines a pull request changed: [make it a required check on agent pull requests](https://onsystem.vercel.app/docs/required-check).
+Findings show up as annotations on the pull request, and `--require-design-system` fails the job when the design system is no longer found. [CI and baselines](https://onsystem.vercel.app/docs/ci) has the whole workflow.
+
+**GitHub Action.** The [action](https://github.com/marketplace/actions/onsystem-design-system-check) runs the same check, honours the baseline and annotates only the lines a pull request changed. It goes after the checkout and the install, so it can read your design system:
+
+```yaml
+steps:
+  - uses: actions/checkout@v7
+  - uses: actions/setup-node@v7
+    with:
+      node-version: 24
+      cache: npm
+  - run: npm ci
+  - uses: dgesteves/onsystem@v0
+```
+
+[Make it a required check on agent pull requests](https://onsystem.vercel.app/docs/required-check) has the whole workflow and its inputs.
 
 **ESLint.** The same rules for ESLint 8.57, 9 and 10: add `onsystem.configs.recommended` from `onsystem/eslint` to `eslint.config.mjs` ([ESLint plugin](https://onsystem.vercel.app/docs/eslint), with @shadcn/lint).
 

package/dist/cli.js

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
-import { C as pruneBaseline, Ct as isInside, D as updateBaseline, E as unrecordedRules, Et as toPosix, H as CONFIG_FILES, J as LEGACY_CONFIG_FILES, N as toDesignMd, O as writeBaseline, Ot as readProjectConfig, P as toDtcg, Q as excludedBy, S as countBaseline, St as SCRIPT_FILE, T as rulesRun, Tt as relativePath, U as ConfigError, W as DEFAULT_DOCS, Y as RULE_IDS, _ as NAME, b as LEGACY_BASELINE_FILE, c as silentLogger, ct as notReadYet, dt as declaredConfig, ft as detectProject, g as formatDiagnostics, h as escapeData, i as componentFiles, l as stderrLogger, lt as PACKAGE_FIELD, m as uncheckedNotice, mt as isDesignSystemName, nt as rulesFor, o as loadDesignSystem, s as tokenFiles, st as libraryTitle, v as VERSION, w as readBaseline, wt as matchesGlob, x as applyBaseline, xt as unique, y as BASELINE_FILE, yt as plural } from "./design-system-Dmcv7eHR.js";
-import { a as notReadNotices, i as missingDependencies, o as explainProject, s as librariesLeftOut, t as serveStdio } from "./stdio-MTS6QAgo.js";
-import { r as loadTarget } from "./workspace-CM1RyqZA.js";
+import { $ as LEGACY_CONFIG_FILES, A as unrecordedRules, At as relativePath, B as statusKinds, C as countBaseline, D as pruneBaseline, Dt as SCRIPT_FILE, E as onLines, Et as unique, J as ConfigError, L as toDesignMd, M as writeBaseline, Nt as readProjectConfig, O as readBaseline, Ot as isInside, R as toDtcg, S as applyBaseline, T as goneFiles, Y as DEFAULT_DOCS, _ as formatDiagnostics, _t as detectProject, b as BASELINE_FILE, c as silentLogger, et as RULE_IDS, ft as libraryTitle, g as escapeData, gt as declaredConfig, h as uncheckedNotice, i as componentFiles, j as updateBaseline, jt as toPosix, k as rulesRun, kt as matchesGlob, l as stderrLogger, mt as PACKAGE_FIELD, o as loadDesignSystem, pt as notReadYet, q as CONFIG_FILES, rt as excludedBy, s as tokenFiles, st as rulesFor, v as NAME, w as findMoves, wt as plural, x as LEGACY_BASELINE_FILE, y as VERSION, yt as isDesignSystemName } from "./design-system-DZm2aP1z.js";
+import { a as notReadNotices, i as missingDependencies, o as explainProject, s as librariesLeftOut, t as serveStdio } from "./stdio-BJvjEnKW.js";
+import { r as loadTarget } from "./workspace-Dqu3nkYM.js";
 import fs from "node:fs";
 import path from "node:path";
 import { escapePath, glob } from "tinyglobby";
@@ -169,6 +169,14 @@ async function init(configOptions, options, io, runCheck) {
 	const total = errors + warnings;
 	io.stdout(total ? `Dry run of \`${NAME} check .\`: ${count$1(errors, "error")} and ${count$1(warnings, "warning")} in ${flagged} of ${count$1(results.length, "file")}. By rule: ${[...byRule].sort((a, b) => b[1] - a[1]).map(([rule, n]) => `${rule} ${n.toLocaleString("en-US")}`).join(", ")}.` : `Dry run of \`${NAME} check .\`: no problems in ${count$1(results.length, "file")}.`);
 	for (const line of dry.stderr.split("\n").filter(Boolean)) io.stdout(line);
+	if (!workspace) {
+		const own = (await loadTarget({
+			...configOptions,
+			config: void 0
+		})).config;
+		const note = statusNote(await loadDesignSystem(own, { cache: options.cache }));
+		if (note) io.stdout(note);
+	}
 	const hasBaseline = [BASELINE_FILE, LEGACY_BASELINE_FILE].some((name) => fs.existsSync(path.join(root, name)));
 	let baselineWritten = false;
 	if (total && !hasBaseline) {
@@ -196,6 +204,28 @@ async function init(configOptions, options, io, runCheck) {
 	return 0;
 }
 const CONFIG_FILE = "onsystem.config.json";
+/** The status colors docs/tokens.md#status-colors adds, and the hue each one is. */
+const RECIPE = [
+	["success", "green"],
+	["warning", "yellow"],
+	["info", "blue"]
+];
+/**
+* Says which of success, warning and info the theme has no color for, and where the CSS that adds
+* them is: without one, an agent asked for a green "Active" label tends to reach for a chart or a
+* gray token, which loses what the color says. Nothing when the theme has no colors, or all three.
+*/
+function statusNote(ds) {
+	if (!ds.tokens.some((token) => token.category === "color")) return void 0;
+	const has = statusKinds(ds.tokens);
+	const missing = RECIPE.filter(([kind]) => !has.has(kind));
+	if (!missing.length) return void 0;
+	return `The theme has no ${orList(missing.map(([kind]) => kind))} token, so a ${orList(missing.map(([, hue]) => hue))} status color has no token to use, and agents tend to reach for a chart or gray token instead. To add ${missing.length === 1 ? "it" : "them"}: https://onsystem.vercel.app/docs/tokens#status-colors.`;
+}
+/** `success, warning or info`. */
+function orList(items) {
+	return items.length > 1 ? `${items.slice(0, -1).join(", ")} or ${items.at(-1) ?? ""}` : items[0] ?? "";
+}
 /** The instruction files agents read, which `init` offers to add onsystem's section to. */
 const AGENT_FILES = ["AGENTS.md", "CLAUDE.md"];
 const RULES_BEGIN = "<!-- BEGIN:onsystem-agent-rules -->";
@@ -906,17 +936,20 @@ async function check(patterns, configOptions, values, io) {
 	};
 	const disabledByKey = /* @__PURE__ */ new Map();
 	const realRoot = fs.realpathSync.native(selection.root);
-	const baselineKey = (file) => relativePath(realRoot, fs.realpathSync.native(file)).normalize("NFC");
+	const folders = patterns.map((pattern) => path.resolve(io.cwd, pattern)).filter((dir) => fs.statSync(dir, { throwIfNoEntry: false })?.isDirectory()).map(realPath);
+	const changedLines = baseline && !update ? readChangedLines(io.env ?? process.env, io.cwd) : void 0;
 	const results = [];
 	const checked = /* @__PURE__ */ new Map();
 	const ran = /* @__PURE__ */ new Set();
 	let baselined = 0;
 	let fixed = 0;
+	const unrecorded = [];
 	for (const file of files) {
 		const code = await fsp.readFile(file, "utf8");
 		const ds = selection.designSystemOf(file);
 		let result = ds.check(code, relativePath(ds.root, file));
-		const key = baselineKey(file);
+		const real = fs.realpathSync.native(file);
+		const key = relativePath(realRoot, real).normalize("NFC");
 		const disabled = disabledFor(file);
 		disabledByKey.set(key, disabled);
 		if (update || prune) checked.set(key, result.diagnostics);
@@ -924,28 +957,59 @@ async function check(patterns, configOptions, values, io) {
 			for (const rule of RULE_IDS) if (!disabled.has(rule) && canRun(ds, rule)) ran.add(rule);
 		}
 		if (baseline && !update) {
-			const match = applyBaseline(baseline.entries, key, result, disabled);
-			result = {
-				...match.result,
-				baselined: match.baselined
-			};
-			baselined += match.baselined;
-			fixed += match.fixed;
+			const changed = changedLines?.get(real);
+			if (baseline.entries.has(key)) {
+				const match = applyBaseline(baseline.entries, key, result, disabled, changed);
+				result = {
+					...match.result,
+					baselined: match.baselined
+				};
+				baselined += match.baselined;
+				fixed += match.fixed;
+			} else unrecorded.push({
+				index: results.length,
+				key,
+				result,
+				disabled,
+				changed
+			});
 		}
 		results.push({
 			...result,
 			file: relativePath(io.cwd, file)
 		});
 	}
+	let moves = /* @__PURE__ */ new Map();
+	if (baseline && !update) {
+		const covered = (key) => folders.some((dir) => isInside(dir, path.join(realRoot, key)));
+		const matching = unrecorded.some((u) => u.result.diagnostics.length);
+		const gone = goneFiles(baseline.entries, realRoot, new Set(disabledByKey.keys()), (key) => matching || covered(key));
+		const changedIn = new Map(unrecorded.map((u) => [u.key, u.changed]));
+		moves = findMoves(baseline.entries, new Map(unrecorded.map((u) => [u.key, u.result.diagnostics])), gone, (key) => disabledByKey.get(key) ?? /* @__PURE__ */ new Set(), (key, diagnostic) => onLines(changedIn.get(key), diagnostic));
+		for (const { index, key, result, disabled, changed } of unrecorded) {
+			const from = moves.get(key) ?? key;
+			const match = applyBaseline(baseline.entries, from, result, disabled, changed);
+			const file = results[index]?.file ?? result.file;
+			results[index] = {
+				...match.result,
+				baselined: match.baselined,
+				file
+			};
+			baselined += match.baselined;
+			fixed += match.fixed;
+		}
+		const moved = new Set(moves.values());
+		for (const key of gone) {
+			const rules = baseline.entries.get(key);
+			if (rules && !moved.has(key) && covered(key)) fixed += countBaseline(/* @__PURE__ */ new Map([[key, rules]])).findings;
+		}
+	}
 	const elsewhere = results.filter((r) => r.skipped).length;
 	if (elsewhere) notes.push(`${plural(elsewhere, "image or email file")} not checked`);
 	const unchecked = uncheckedNotice(results);
 	if (update) {
 		const next = updateBaseline(baseline?.entries, checked, realRoot, (key) => disabledByKey.get(key) ?? /* @__PURE__ */ new Set());
-		const wholeRoot = patterns.some((pattern) => {
-			const dir = path.resolve(io.cwd, pattern);
-			return Boolean(fs.statSync(dir, { throwIfNoEntry: false })?.isDirectory() && isInside(realPath(dir), realRoot));
-		});
+		const wholeRoot = folders.some((dir) => isInside(dir, realRoot));
 		writeBaseline(baselineFile, next, {
 			onsystem: VERSION,
 			rules: rulesRun(baseline, next, checked, ran, wholeRoot)
@@ -966,15 +1030,16 @@ async function check(patterns, configOptions, values, io) {
 		if (unrecorded.size) baselineNotes.push(unrecordedNote(unrecorded, fresh.length, baseline.onsystem, command("--update-baseline")));
 	}
 	if (prune && baseline) {
-		const next = pruneBaseline(baseline.entries, checked, realRoot, (key) => disabledByKey.get(key) ?? /* @__PURE__ */ new Set());
+		const next = pruneBaseline(baseline.entries, checked, realRoot, (key) => disabledByKey.get(key) ?? /* @__PURE__ */ new Set(), moves);
 		const left = countBaseline(next);
 		const dropped = countBaseline(baseline.entries).findings - left.findings;
-		if (dropped) writeBaseline(baselineFile, next, {
+		if (dropped || moves.size) writeBaseline(baselineFile, next, {
 			onsystem: baseline.onsystem,
 			rules: baseline.rules
 		});
-		baselineNotes.push(`Baseline: ${dropped ? `dropped ${count(dropped, "finding")} that no longer ${dropped === 1 ? "occurs" : "occur"}` : "nothing to drop"}; ${count(left.findings, "finding")} in ${count(left.files, "file")} → ${displayPath(io.cwd, baselineFile)}`);
-	}
+		const done = [moves.size ? `moved the findings of ${count(moves.size, "file")} to ${moves.size === 1 ? "its new path" : "their new paths"}` : "", dropped ? `dropped ${count(dropped, "finding")} that no longer ${dropped === 1 ? "occurs" : "occur"}` : ""].filter(Boolean);
+		baselineNotes.push(`Baseline: ${done.join("; ") || "nothing to drop"}; ${count(left.findings, "finding")} in ${count(left.files, "file")} → ${displayPath(io.cwd, baselineFile)}`);
+	} else if (moves.size) baselineNotes.push(movedNote(moves, command("--prune-baseline")));
 	const output = formatDiagnostics(format === "json" ? results : results.filter((r) => !r.skipped), format, {
 		color: io.color,
 		uri: format === "sarif" || format === "github" ? repositoryPath(io.cwd, io.env ?? process.env) : void 0,
@@ -995,7 +1060,9 @@ async function check(patterns, configOptions, values, io) {
 	const warnings = results.reduce((n, r) => n + r.warningCount, 0);
 	if (errors > 0) return 1;
 	if (maxWarnings !== void 0 && warnings > maxWarnings) {
-		if (format === "pretty") io.stderr(`Too many warnings (${warnings}, max ${maxWarnings}).`);
+		const message = `Too many warnings (${warnings}, max ${maxWarnings}).`;
+		if (format === "github") io.stdout(`::error title=${NAME}::${message}`);
+		else io.stderr(message);
 		return 1;
 	}
 	return 0;
@@ -1647,6 +1714,40 @@ function canRun(ds, rule) {
 		default: return ds.model.components.length > 0;
 	}
 }
+/** Says which files the baseline takes for moved, and how to record their new paths. */
+function movedNote(moves, prune) {
+	const pairs = [...moves].sort(([a], [b]) => a < b ? -1 : a > b ? 1 : 0);
+	const [first] = pairs;
+	if (pairs.length === 1 && first) return `Baseline: ${first[0]} has the findings recorded for ${first[1]}, which no longer exists, so they are accepted as moved. Run \`${prune}\` to record the new path.`;
+	const list = listOf(pairs.map(([to, from]) => `${from} → ${to}`));
+	return `Baseline: ${pairs.length} files have the findings recorded for files that no longer exist, so they are accepted as moved (${list}). Run \`${prune}\` to record the new paths.`;
+}
+/** The variable the GitHub Action names the pull request's changed lines in. */
+const CHANGED_LINES = "ONSYSTEM_CHANGED_LINES";
+/**
+* The lines a pull request changed, by the real path of each file: the JSON file that
+* ONSYSTEM_CHANGED_LINES names maps paths to 1-based ranges, `{ "/repo/app/page.tsx": [[4, 4]] }`.
+* The GitHub Action writes it. Undefined when the variable is not set.
+*/
+function readChangedLines(env, cwd) {
+	const file = env[CHANGED_LINES]?.trim();
+	if (!file) return void 0;
+	const fail = (why) => new ConfigError(`${CHANGED_LINES}: ${why}. The GitHub Action sets this variable to a file of the lines a pull request changed; unset it when you run check yourself.`);
+	let parsed;
+	try {
+		parsed = JSON.parse(fs.readFileSync(path.resolve(cwd, file), "utf8"));
+	} catch (error) {
+		throw fail(`could not read ${file}: ${error.message}`);
+	}
+	const range = (value) => Array.isArray(value) && value.length === 2 && value.every((n) => Number.isInteger(n));
+	if (typeof parsed !== "object" || parsed === null || Array.isArray(parsed)) throw fail(`${file} must map files to line ranges`);
+	const lines = /* @__PURE__ */ new Map();
+	for (const [name, ranges] of Object.entries(parsed)) {
+		if (!Array.isArray(ranges) || !ranges.every(range)) throw fail(`${file} › "${name}" must be a list of [start, end] lines`);
+		lines.set(realPath(path.resolve(cwd, name)), ranges);
+	}
+	return lines;
+}
 /** Why findings of rules that did not run when the baseline was recorded are new to it. */
 function unrecordedNote(byRule, total, version, update) {
 	const rules = [...byRule.keys()].sort();

package/dist/{config-kYGiD5oW.d.ts → config-B98w8bcg.d.ts}

@@ -281,6 +281,11 @@ interface LibrarySource {
   dir?: string | undefined;
   /** The installed version. */
   version?: string | undefined;
+  /**
+   * A design-system package installed without its component sources, read from its type
+   * declarations ({@link declarationsPackages}) rather than as a library onsystem knows.
+   */
+  designSystem?: true | undefined;
 }
 //#endregion
 //#region src/config.d.ts