onroute-policy-engine 2.32.2 → 2.32.4

package/dist/helper/policy-check.helper.js

@@ -133,7 +133,7 @@ function CheckLegalWeight(policy, vehicleConfiguration, axleConfiguration) {
         const axleUnitNumber = axleIndex + 1;
         return {
             id: policyId,
-            message: `Weight for axle unit ${axleUnitNumber} ${result ? 'is legal' : `must not exceed ${legalWeight} kgs`}`,
+            message: `Axle Unit Weight for Axle Unit ${axleUnitNumber} ${result ? 'is legal' : `must not exceed ${legalWeight} kg.`}`,
             // We intentionally only return Pass/Warning, as we should never
             // show an error for being above legal amount, only permitable
             // amount. But it's still useful info for things like OCD table.
@@ -277,36 +277,37 @@ function CheckNumberOfAxles(_policy, _vehicleConfiguration, axleConfiguration) {
     });
     return policyCheckResults;
 }
-function getBridgeFormulaInputFailure(axleConfiguration) {
+/**
+ * This function basically lets us skip Bridge Formula if we know it'll crash.
+ *
+ * This function is a 'necessary evil.'  The Bridge Formula calculation is
+ * important legacy code, but with certain inputs it would throw an
+ * exception and crash the entire calculation, especially in the ASW table.
+ *
+ * These "crashing inputs" are always STOW eval errors, so even if we don't
+ * run bridge formula the user should be seeing seperate errors, so once they
+ * fix those errors then re-run it should include Bridge Formula.
+ *
+ */
+function hasInvalidBridgeFormulaInput(axleConfiguration) {
     for (let axleIndex = 0; axleIndex < axleConfiguration.length; axleIndex++) {
         const axleUnit = axleConfiguration[axleIndex];
-        const axleUnitNumber = axleIndex + 1;
-        let message;
         if (!Number.isFinite(axleUnit.axleUnitWeight) ||
             axleUnit.axleUnitWeight <= 0) {
-            message = `Axle unit weight for axle unit ${axleUnitNumber} must be a finite number greater than 0.`;
+            return true;
         }
         else if (axleUnit.numberOfAxles > 1 &&
             (!Number.isFinite(axleUnit.axleSpread) ||
                 axleUnit.axleSpread <= 0)) {
-            message = `Axle spread for axle unit ${axleUnitNumber} must be a finite number greater than 0 when the unit has multiple axles.`;
+            return true;
         }
         else if (axleIndex > 0 &&
             (!Number.isFinite(axleUnit.interaxleSpacing) ||
                 axleUnit.interaxleSpacing <= 0)) {
-            message = `Axle spacing before axle unit ${axleUnitNumber} must be a finite number greater than 0.`;
-        }
-        if (message) {
-            return {
-                id: enum_1.PolicyCheckId.BridgeFormula,
-                message,
-                result: enum_1.PolicyCheckResultType.Fail,
-                startAxleUnit: axleUnitNumber,
-                endAxleUnit: axleUnitNumber,
-            };
+            return true;
         }
     }
-    return undefined;
+    return false;
 }
 /**
  * Performs bridge formula calculations on axle groups and returns policy check results.
@@ -337,9 +338,12 @@ function getBridgeFormulaInputFailure(axleConfiguration) {
 function CheckBridgeFormula(policy, vehicleConfiguration, axleConfiguration) {
     const policyCheckResults = new Array();
     const policyId = enum_1.PolicyCheckId.BridgeFormula;
-    const inputFailure = getBridgeFormulaInputFailure(axleConfiguration);
-    if (inputFailure) {
-        return [inputFailure];
+    // This basically skips Bridge Formula if the input is invalid.
+    // This is important for STOW, which in the ASW runs this as well as STOW evals
+    // Some of those STOW evals can accept inputs that would make Bridge Formula throw
+    // errors and crash.
+    if (hasInvalidBridgeFormulaInput(axleConfiguration)) {
+        return [];
     }
     const bridgeCalcResults = policy.calculateBridge(axleConfiguration, vehicleConfiguration);
     bridgeCalcResults.forEach((br) => {
@@ -1252,7 +1256,7 @@ function CheckLegalAxleSpread(policy, vehicleConfiguration, axleConfiguration) {
     const axleUnitVehicleIndexes = (0, dimensions_helper_1.getAxleUnitVehicleIndexLookup)(policy, vehicleConfiguration, axleConfiguration);
     return axleConfiguration.flatMap((axleUnit, axleIndex) => {
         const threshold = (0, axle_spread_helper_1.getAxleSpreadThreshold)(vehicleConfiguration, axleUnitVehicleIndexes, axleConfiguration, axleIndex);
-        if (!axleUnit.axleSpread ||
+        if (axleUnit.axleSpread === undefined ||
             !threshold ||
             !Number.isFinite(axleUnit.axleSpread)) {
             return [];

package/dist/version.d.ts

@@ -1 +1 @@
-export declare const version = "v2.32.2";
+export declare const version = "v2.32.4";

package/dist/version.js

@@ -2,4 +2,4 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.version = void 0;
 // Generated by genversion.
-exports.version = 'v2.32.2';
+exports.version = 'v2.32.4';

package/package.json

@@ -91,5 +91,5 @@
     ],
     "testEnvironment": "node"
   },
-  "version": "v2.32.2"
+  "version": "v2.32.4"
 }