onesignal-expo-plugin 1.2.0 → 1.3.0

package/CHANGELOG.md

@@ -1,6 +1,11 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## November 2022
+### `1.3.0` - 11/30/22
+#### Changes
+- Add `iosNSEFilePath` configuration options to the plugin, which allows an app to specify a custom iOS Notification Service Extension.
+
 ## October 2022
 ### `1.2.0` - 10/25/22
 #### Changes

package/README.md

@@ -86,6 +86,7 @@ You can pass props to the plugin config object to configure:
 | `iPhoneDeploymentTarget` | optional | Target `IPHONEOS_DEPLOYMENT_TARGET` value to be used when adding the iOS [NSE](https://documentation.onesignal.com/docs/service-extensions). A deployment target is nothing more than the minimum version of the operating system the application can run on. This value should match the value in your Podfile e.g: `"12.0"`. |
 | `smallIcons`             | optional | An array of local paths to small notification icons for Android.  Image should be white, transparent, and 96x96 in size.  Input images will be automatically scaled down and placed in the appropriate resource folders.  e.g: `["./assets/ic_stat_onesignal_default.png"]`. See https://documentation.onesignal.com/docs/customize-notification-icons#small-notification-icons.  |
 | `largeIcons`             | optional | An array of local paths to large notification icons for Android.  Image should be white, transparent, and 256x256 in size.  e.g: `["./assets/ic_onesignal_large_icon_default.png"]`. See https://documentation.onesignal.com/docs/customize-notification-icons#large-notification-icons.                                                                                                |
+| `iosNSEFilePath`         | optional | The local path to a custom Notification Service Extension (NSE), written in Objective-C. The NSE will typically start as a copy of the [default NSE](https://github.com/OneSignal/onesignal-expo-plugin/blob/main/support/serviceExtensionFiles/NotificationService.m), then altered to support any custom logic required.  e.g: `"./assets/NotificationService.m"`. |
 
 ### OneSignal App ID
 Add your OneSignal App ID to your [Expo constants via the `extra` param](https://docs.expo.dev/versions/latest/config/app/):
@@ -117,9 +118,10 @@ OneSignal.setAppId("YOUR-ONESIGNAL-APP-ID");
 In your configuration file, make sure you set:
 
 | Property             | Details                                                                                                                                                                      |
-|-------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+|-------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | `version`         | Your app version. Corresponds to `CFBundleShortVersionString` on iOS. This value will be used in your NSE* target's plist file.                                               |
 | `ios.buildNumber` | Build number for your iOS standalone app. Corresponds to `CFBundleVersion` and must match Apple's specified format. This value will be used in your NSE* target's plist file. |
+| `ios.bundleIdentifier` | Bundle identifier for your iOS standalone app. Corresponds to `CFBundleIdentifier`. This value will be used in your NSE* target's plist and entitlements file.           |
 
 \* NSE = Notification Service Extension. Learn more about the NSE [here](https://documentation.onesignal.com/docs/service-extensions).
 

package/build/onesignal/withOneSignalIos.js

@@ -105,7 +105,8 @@ const withOneSignalNSE = (config, onesignalProps) => {
             bundleVersion: (_b = props.ios) === null || _b === void 0 ? void 0 : _b.buildNumber,
             bundleShortVersion: props === null || props === void 0 ? void 0 : props.version,
             mode: onesignalProps === null || onesignalProps === void 0 ? void 0 : onesignalProps.mode,
-            iPhoneDeploymentTarget: onesignalProps === null || onesignalProps === void 0 ? void 0 : onesignalProps.iPhoneDeploymentTarget
+            iPhoneDeploymentTarget: onesignalProps === null || onesignalProps === void 0 ? void 0 : onesignalProps.iPhoneDeploymentTarget,
+            iosNSEFilePath: onesignalProps.iosNSEFilePath
         };
         // support for monorepos where node_modules can be up to 5 parents
         // above the project directory.
@@ -133,13 +134,13 @@ const withOneSignalIos = (config, props) => {
 };
 exports.withOneSignalIos = withOneSignalIos;
 function xcodeProjectAddNse(appName, options, sourceDir) {
-    const { iosPath, devTeam, bundleIdentifier, bundleVersion, bundleShortVersion, iPhoneDeploymentTarget } = options;
+    const { iosPath, devTeam, bundleIdentifier, bundleVersion, bundleShortVersion, iPhoneDeploymentTarget, iosNSEFilePath } = options;
     // not awaiting in order to not block main thread
     (0, updatePodfile_1.updatePodfile)(iosPath).catch(err => { OneSignalLog_1.OneSignalLog.error(err); });
     const projPath = `${iosPath}/${appName}.xcodeproj/project.pbxproj`;
+    const sourceFile = "NotificationService.m";
     const extFiles = [
         "NotificationService.h",
-        "NotificationService.m",
         `${iosConstants_1.NSE_TARGET_NAME}.entitlements`,
         `${iosConstants_1.NSE_TARGET_NAME}-Info.plist`
     ];
@@ -156,13 +157,17 @@ function xcodeProjectAddNse(appName, options, sourceDir) {
             const targetFile = `${iosPath}/${iosConstants_1.NSE_TARGET_NAME}/${extFile}`;
             await FileManager_1.FileManager.copyFile(`${sourceDir}${extFile}`, targetFile);
         }
+        // Copy NSE source file either from configuration-provided location, falling back to the default one.
+        const sourcePath = iosNSEFilePath !== null && iosNSEFilePath !== void 0 ? iosNSEFilePath : `${sourceDir}${sourceFile}`;
+        const targetFile = `${iosPath}/${iosConstants_1.NSE_TARGET_NAME}/${sourceFile}`;
+        await FileManager_1.FileManager.copyFile(`${sourcePath}`, targetFile);
         /* MODIFY COPIED EXTENSION FILES */
         const nseUpdater = new NseUpdaterManager_1.default(iosPath);
         await nseUpdater.updateNSEEntitlements(`group.${bundleIdentifier}.onesignal`);
         await nseUpdater.updateNSEBundleVersion(bundleVersion !== null && bundleVersion !== void 0 ? bundleVersion : iosConstants_1.DEFAULT_BUNDLE_VERSION);
         await nseUpdater.updateNSEBundleShortVersion(bundleShortVersion !== null && bundleShortVersion !== void 0 ? bundleShortVersion : iosConstants_1.DEFAULT_BUNDLE_SHORT_VERSION);
         // Create new PBXGroup for the extension
-        const extGroup = xcodeProject.addPbxGroup(extFiles, iosConstants_1.NSE_TARGET_NAME, iosConstants_1.NSE_TARGET_NAME);
+        const extGroup = xcodeProject.addPbxGroup([...extFiles, sourceFile], iosConstants_1.NSE_TARGET_NAME, iosConstants_1.NSE_TARGET_NAME);
         // Add the new PBXGroup to the top level group. This makes the
         // files / folder appear in the file explorer in Xcode.
         const groups = xcodeProject.hash.project.objects["PBXGroup"];

package/onesignal/withOneSignalIos.ts

@@ -102,7 +102,8 @@ const withOneSignalNSE: ConfigPlugin<OneSignalPluginProps> = (config, onesignalP
       bundleVersion: props.ios?.buildNumber,
       bundleShortVersion: props?.version,
       mode: onesignalProps?.mode,
-      iPhoneDeploymentTarget: onesignalProps?.iPhoneDeploymentTarget
+      iPhoneDeploymentTarget: onesignalProps?.iPhoneDeploymentTarget,
+      iosNSEFilePath: onesignalProps.iosNSEFilePath
     };
 
     // support for monorepos where node_modules can be up to 5 parents
@@ -145,16 +146,16 @@ export function xcodeProjectAddNse(
   options: PluginOptions,
   sourceDir: string
 ): void {
-  const { iosPath, devTeam, bundleIdentifier, bundleVersion, bundleShortVersion, iPhoneDeploymentTarget } = options;
+  const { iosPath, devTeam, bundleIdentifier, bundleVersion, bundleShortVersion, iPhoneDeploymentTarget, iosNSEFilePath } = options;
 
   // not awaiting in order to not block main thread
   updatePodfile(iosPath).catch(err => { OneSignalLog.error(err) });
 
   const projPath = `${iosPath}/${appName}.xcodeproj/project.pbxproj`;
 
+  const sourceFile = "NotificationService.m"
   const extFiles = [
     "NotificationService.h",
-    "NotificationService.m",
     `${NSE_TARGET_NAME}.entitlements`,
     `${NSE_TARGET_NAME}-Info.plist`
   ];
@@ -176,6 +177,11 @@ export function xcodeProjectAddNse(
       await FileManager.copyFile(`${sourceDir}${extFile}`, targetFile);
     }
 
+    // Copy NSE source file either from configuration-provided location, falling back to the default one.
+    const sourcePath = iosNSEFilePath ?? `${sourceDir}${sourceFile}`
+    const targetFile = `${iosPath}/${NSE_TARGET_NAME}/${sourceFile}`;
+    await FileManager.copyFile(`${sourcePath}`, targetFile);
+
     /* MODIFY COPIED EXTENSION FILES */
     const nseUpdater = new NseUpdaterManager(iosPath);
     await nseUpdater.updateNSEEntitlements(`group.${bundleIdentifier}.onesignal`)
@@ -183,7 +189,7 @@ export function xcodeProjectAddNse(
     await nseUpdater.updateNSEBundleShortVersion(bundleShortVersion ?? DEFAULT_BUNDLE_SHORT_VERSION);
 
     // Create new PBXGroup for the extension
-    const extGroup = xcodeProject.addPbxGroup(extFiles, NSE_TARGET_NAME, NSE_TARGET_NAME);
+    const extGroup = xcodeProject.addPbxGroup([...extFiles, sourceFile], NSE_TARGET_NAME, NSE_TARGET_NAME);
 
     // Add the new PBXGroup to the top level group. This makes the
     // files / folder appear in the file explorer in Xcode.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "onesignal-expo-plugin",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "description": "The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.",
   "main": "./app.plugin.js",
   "scripts": {

package/types/types.ts

@@ -28,6 +28,13 @@
    * (optional) The large notification icons for Android. Images will be automatically scaled up/down to 256x256.
    */
   largeIcons?:            string[];
+
+  /**
+   * (optional) The local path to a custom Notification Service Extension (NSE), written in Objective-C. The NSE will typically start as a copy
+   * of the default NSE found at (support/serviceExtensionFiles/NotificationService.m, then altered to support any custom
+   * logic required.
+   */
+   iosNSEFilePath?:       string;
 };
 
 /**
@@ -41,7 +48,8 @@ export type PluginOptions = {
   bundleVersion?:           string,
   bundleShortVersion?:      string,
   bundleIdentifier?:        string,
-  iPhoneDeploymentTarget?:  string
+  iPhoneDeploymentTarget?:  string,
+  iosNSEFilePath?:          string
 }
 
 export enum Mode {