onesignal-expo-plugin 1.1.0 → 1.1.2

package/.github/pull_request_template.md

@@ -0,0 +1,46 @@
+<!-- START -->
+# READ AND DELETE THIS SECTION BEFORE SUBMITTING PR
+* **Fill out each _REQUIRED_ section**
+* **Fill out _OPTIONAL_ sections, remove section if it doesn't apply to your PR**
+* **Read and fill out each of the checklists below**
+* **Remove this section after reading**
+<!-- END -->
+
+# Description
+## One Line Summary
+**REQUIRED** - Very short description that summaries the changes in this PR.
+
+## Details
+
+### Motivation
+**REQUIRED -** Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
+
+### Scope
+**RECOMMEND - OPTIONAL -** What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
+
+### OPTIONAL - Other
+**OPTIONAL -** Feel free to add any other sections or sub-sections that can explain your PR better.
+
+# Testing
+
+## Manual testing
+**REQUIRED -** Explain what scenarios were tested and the environment.
+
+
+# Checklist
+## Overview
+   - [ ] I have filled out all **REQUIRED** sections above
+   - [ ] PR does one thing
+     - If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
+   - [ ] Any Public API changes are explained in the PR details and conform to existing APIs
+
+## Testing
+   - [ ] I have personally tested this on my device, or explained why that is not possible
+   - [ ] I have tested this on the latest version of the plugin
+   - [ ] I have tested this on both Android and iOS, or explained why that is not possible
+
+## Final pass
+   - [ ] Code is as readable as possible.
+      - Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
+   - [ ] I have reviewed this PR myself, ensuring it meets each checklist item
+      - WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

package/CHANGELOG.md

@@ -1,6 +1,22 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## October 2022
+### `1.1.2` - 10/04/22
+#### Fixes
+- Specify `use_frameworks` on `OneSignalNotificationServiceExtension` target in iOS Podfile when applicable (i.e. the app target also specifies `use_frameworks`).
+
+## September 2022
+### `1.1.1` - 09/06/22
+#### Fixes
+- Fix issue where EAS release builds were no longer successfully building due to log statement
+
+### `1.1.0` - 09/01/22
+#### Changes
+- No longer inject the OneSignal Gradle plugin on Android builds
+#### Fixes
+- Fix issue where plugin does not support monorepos
+
 ## April 2022
 ### `1.0.1` - 04/11/22
 

package/build/onesignal/withOneSignalAndroid.js

@@ -5,9 +5,9 @@
  */
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.withOneSignalAndroid = void 0;
-const OneSignalLog_1 = require("../support/OneSignalLog");
 const withOneSignalAndroid = (config, props) => {
-    OneSignalLog_1.OneSignalLog.log("No specific actions required for OneSignal on Android...");
+    //commented out until https://github.com/expo/eas-cli/issues/1226 is confirmed fixed
+    //OneSignalLog.log("No specific actions required for OneSignal on Android...");
     return config;
 };
 exports.withOneSignalAndroid = withOneSignalAndroid;

package/build/onesignal/withOneSignalIos.js

@@ -5,7 +5,11 @@
  */
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
     o[k2] = m[k];

package/build/support/FileManager.js

@@ -1,7 +1,11 @@
 "use strict";
 var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
-    Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
 }) : (function(o, m, k, k2) {
     if (k2 === undefined) k2 = k;
     o[k2] = m[k];

package/build/support/iosConstants.js

@@ -6,6 +6,7 @@ exports.TARGETED_DEVICE_FAMILY = `"1,2"`;
 exports.NSE_PODFILE_SNIPPET = `
 target 'OneSignalNotificationServiceExtension' do
   pod 'OneSignalXCFramework', '>= 3.0', '< 4.0'
+  use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks']
 end`;
 exports.NSE_PODFILE_REGEX = /target 'OneSignalNotificationServiceExtension'/;
 exports.GROUP_IDENTIFIER_TEMPLATE_REGEX = /{{GROUP_IDENTIFIER}}/gm;

package/onesignal/withOneSignalAndroid.ts

@@ -11,7 +11,7 @@ export const withOneSignalAndroid: ConfigPlugin<OneSignalPluginProps> = (
   config,
   props,
 ) => {
-  OneSignalLog.log("No specific actions required for OneSignal on Android...");
-
+  //commented out until https://github.com/expo/eas-cli/issues/1226 is confirmed fixed
+  //OneSignalLog.log("No specific actions required for OneSignal on Android...");
   return config;
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "onesignal-expo-plugin",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "description": "The OneSignal Expo plugin allows you to use OneSignal without leaving the managed workflow. Developed in collaboration with SweetGreen.",
   "main": "./app.plugin.js",
   "scripts": {

package/support/iosConstants.ts

@@ -4,6 +4,7 @@ export const TARGETED_DEVICE_FAMILY = `"1,2"`;
 export const NSE_PODFILE_SNIPPET = `
 target 'OneSignalNotificationServiceExtension' do
   pod 'OneSignalXCFramework', '>= 3.0', '< 4.0'
+  use_frameworks! :linkage => podfile_properties['ios.useFrameworks'].to_sym if podfile_properties['ios.useFrameworks']
 end`;
 
 export const NSE_PODFILE_REGEX = /target 'OneSignalNotificationServiceExtension'/;