one-code-extension 0.4.0 → 0.5.0

package/extensions/effort/index.ts

@@ -1,6 +1,10 @@
 /**
  * effort extension — Claude Code's `/effort`, including the `ultracode` stop.
  *
+ * Interactive low/medium/high/xhigh choices persist per model in pi's own
+ * settings (`modelThinkingLevels`); max and ultracode stay session-only. pi
+ * restores the saved level natively, so launch overrides and resume still win.
+ *
  * Reasoning effort is pi's thinking level under another name, and shift+tab
  * already cycles it. pi reserves that key (`app.thinking.cycle` is on its
  * RESERVED_KEYBINDINGS_FOR_EXTENSION_CONFLICTS list, so `registerShortcut` on
@@ -17,9 +21,11 @@
  * same shape the permissions extension uses for plan mode.
  */
 
+import { join } from "node:path";
 import type { ThinkingLevel } from "@earendil-works/pi-agent-core";
 import { getSupportedThinkingLevels } from "@earendil-works/pi-ai/compat";
-import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { getAgentDir, SettingsManager, type ExtensionAPI, type ExtensionContext } from "@earendil-works/pi-coding-agent";
+import { effortSetMessage, isPersistedEffort, type PersistedEffort } from "./settings.ts";
 import { REMINDER_CHANNEL } from "../lib/reminders.ts";
 import { dimRightAlignedWidget, safeThemePaint, truncateLine } from "../lib/tui-render.ts";
 import {
@@ -43,6 +49,8 @@ import {
 	ULTRACODE_STATUS_KEY,
 } from "./slider.ts";
 import { registerLocalCommand } from "../lib/local-command.ts";
+import { panelUi } from "../lib/panel-focus.ts";
+import { extendingCompletions } from "../lib/argument-hints.ts";
 
 /** The levels pi says the active model can reach; the full ladder when unknown. */
 function supportedLevels(ctx: ExtensionContext): ThinkingLevel[] {
@@ -126,8 +134,28 @@ export default function effortExtension(pi: ExtensionAPI) {
 		}
 	};
 
+	const canPersist = (ctx: ExtensionContext) => ctx.hasUI && (ctx.mode === "tui" || ctx.mode === "rpc") && !!ctx.model;
+	/** Through pi's own settings writer: its key format, file lock and merge of changed fields. */
+	const persist = async (ctx: ExtensionContext, level: PersistedEffort | undefined): Promise<string | undefined> => {
+		const settings = SettingsManager.create(ctx.cwd, getAgentDir());
+		const loadError = settings.drainErrors().find((entry) => entry.scope === "global");
+		// An unreadable file would be rewritten from empty settings; leave it for the user.
+		if (loadError) return `Failed to set effort level: ${loadError.error.message}`;
+		if (level === undefined) settings.removeModelThinkingLevel(ctx.model!.provider, ctx.model!.id);
+		else settings.setModelThinkingLevel(ctx.model!.provider, ctx.model!.id, level);
+		await settings.flush();
+		const writeError = settings.drainErrors()[0];
+		if (writeError) return `Failed to set effort level: ${writeError.error.message}`;
+	};
+	const report = (ctx: ExtensionContext, message: string, error = false) => {
+		ctx.ui.notify(message, error ? "error" : "info");
+		return message;
+	};
+
 	/** Apply a chosen stop and report what actually took effect. */
-	const applyChoice = (choice: EffortChoice, ctx: ExtensionContext) => {
+	const applyChoice = async (choice: EffortChoice, ctx: ExtensionContext, asDefault = true): Promise<string> => {
+		const wasUltracode = ultracodeActive;
+		const previous = pi.getThinkingLevel();
 		const wanted = thinkingLevelFor(choice);
 		pi.setThinkingLevel(wanted);
 		const actual = pi.getThinkingLevel();
@@ -144,13 +172,25 @@ export default function effortExtension(pi: ExtensionAPI) {
 		const cappedDown = ar >= 0 && wr >= 0 && ar < wr;
 		const note = cappedDown ? ` (${modelLabel(ctx)} tops out at ${actual})` : "";
 		if (choice === ULTRACODE) {
-			ctx.ui.notify(`Effort: ultracode — ${actual} reasoning, workflows armed every turn${note}`, "info");
-		} else {
-			ctx.ui.notify(`Effort: ${actual}${note}`, "info");
+			return report(ctx, `Effort: ultracode — ${actual} reasoning, workflows armed every turn${note}`);
 		}
+		const saved = asDefault && canPersist(ctx) && isPersistedEffort(choice) && actual === wanted;
+		if (saved) {
+			const error = await persist(ctx, choice);
+			if (error) {
+				// Claude Code changes nothing when the save fails.
+				pi.setThinkingLevel(previous);
+				setUltracode(wasUltracode, previous);
+				applyStatus(ctx);
+				showEffortNote(ctx, previous);
+				return report(ctx, error, true);
+			}
+		}
+		if (isPersistedEffort(actual) || actual === "max") return report(ctx, `${effortSetMessage(actual, saved)}${wasUltracode ? " · Ultracode off" : ""}`);
+		return report(ctx, `Effort: ${actual}${note}`);
 	};
 
-	const showSlider = async (ctx: ExtensionContext): Promise<void> => {
+	const showSlider = async (ctx: ExtensionContext): Promise<string | void> => {
 		const supported = supportedLevels(ctx);
 		if (!supported.some((level) => level !== "off")) {
 			ctx.ui.notify(`${modelLabel(ctx)} doesn't support reasoning effort.`, "info");
@@ -165,7 +205,7 @@ export default function effortExtension(pi: ExtensionAPI) {
 		index = nearestEnabled(index, enabled);
 
 		const label = modelLabel(ctx);
-		const chosen = await ctx.ui.custom<EffortChoice | null>((tui, theme, _keybindings, done) => {
+		const chosen = await panelUi(pi.events, ctx.ui).custom<{ choice: EffortChoice; asDefault: boolean } | null>((tui, theme, _keybindings, done) => {
 			const paint = safeThemePaint(theme);
 			return {
 				// The slider's own layout is column-safe for its ASCII labels, but this
@@ -180,8 +220,8 @@ export default function effortExtension(pi: ExtensionAPI) {
 						done(null);
 						return;
 					}
-					if (key === "confirm") {
-						done(EFFORT_CHOICES[index]);
+					if (key === "confirm" || key === "session") {
+						done({ choice: EFFORT_CHOICES[index], asDefault: key === "confirm" });
 						return;
 					}
 					index = moveIndex(index, key, enabled);
@@ -191,18 +231,32 @@ export default function effortExtension(pi: ExtensionAPI) {
 			};
 		});
 
-		if (chosen) applyChoice(chosen, ctx);
+		if (!chosen) return "Cancelled";
+		return applyChoice(chosen.choice, ctx, chosen.asDefault);
 	};
 
 	registerLocalCommand(pi, "effort", {
-		description: `Set reasoning effort (shift+tab cycles the plain levels): /effort [${EFFORT_CHOICES.join("|")}] — ultracode is ${ULTRACODE_LEVEL} + workflows`,
-		getArgumentCompletions: (prefix) => {
-			const matches = acceptedEffortArgs().filter((value) => value.startsWith(prefix.trim().toLowerCase()));
-			return matches.length ? matches.map((value) => ({ value, label: value })) : null;
-		},
+		description: `Set reasoning effort (shift+tab cycles the plain levels): /effort [${EFFORT_CHOICES.join("|")}|auto] — ultracode is ${ULTRACODE_LEVEL} + workflows`,
+		argumentHint: `[${EFFORT_CHOICES.join("|")}|auto]`,
+		reportsResult: true,
+		getArgumentCompletions: (prefix) => extendingCompletions(prefix, [...acceptedEffortArgs(), "auto", "unset"].map((value) => ({ value, label: value }))),
 		handler: async (args, ctx) => {
 			const typed = args.trim();
 			if (typed) {
+				if (typed.toLowerCase() === "auto" || typed.toLowerCase() === "unset") {
+					// Clear the saved level first: a failed save changes nothing.
+					const saved = canPersist(ctx);
+					if (saved) {
+						const error = await persist(ctx, undefined);
+						if (error) return report(ctx, error, true);
+					}
+					// getSettings arrived in pi 1.0.1; the package still admits older pi.
+					pi.setThinkingLevel(pi.getSettings?.().defaultThinkingLevel ?? "medium");
+					setUltracode(false);
+					applyStatus(ctx);
+					showEffortNote(ctx, pi.getThinkingLevel());
+					return report(ctx, `Effort level set to auto${saved ? "" : " (this session only)"}`);
+				}
 				const parsed = parseEffortArg(typed);
 				if (!parsed) {
 					ctx.ui.notify(`Unknown effort "${typed}". Use one of: ${acceptedEffortArgs().join(", ")}`, "error");
@@ -220,20 +274,19 @@ export default function effortExtension(pi: ExtensionAPI) {
 						return;
 					}
 				}
-				applyChoice(parsed, ctx);
-				return;
+				return applyChoice(parsed, ctx);
 			}
 
 			// The picker needs focus and a terminal; elsewhere say what to type.
 			if (!ctx.hasUI || ctx.mode !== "tui") {
 				ctx.ui.notify(
 					`Current effort: ${ultracodeActive ? `ultracode (${pi.getThinkingLevel()} + workflows)` : pi.getThinkingLevel()}. ` +
-						`Set one with /effort <${acceptedEffortArgs().join("|")}>.`,
+						`Set one with /effort <${acceptedEffortArgs().join("|")}|auto>.`,
 					"info",
 				);
 				return;
 			}
-			await showSlider(ctx);
+			return await showSlider(ctx);
 		},
 	});
 

package/extensions/effort/settings.ts

@@ -0,0 +1,21 @@
+/** Which effort levels are saved, and the result text (pure, no pi imports). */
+
+const PERSISTED_LEVELS = ["low", "medium", "high", "xhigh"] as const;
+export type PersistedEffort = (typeof PERSISTED_LEVELS)[number];
+
+export function isPersistedEffort(level: string): level is PersistedEffort {
+	return (PERSISTED_LEVELS as readonly string[]).includes(level);
+}
+
+const DESCRIPTIONS: Record<string, string> = {
+	low: "Quick, straightforward implementation with minimal overhead",
+	medium: "Balanced approach with standard implementation and testing",
+	high: "Comprehensive implementation with extensive testing and documentation",
+	xhigh: "Deeper reasoning than high, just below maximum (on supported models)",
+	max: "Maximum capability with deepest reasoning. May use excessive tokens resulting in long response times or overthinking. Use sparingly for the hardest tasks.",
+};
+
+/** The ordinary local response, without organization or environment overrides. */
+export function effortSetMessage(level: PersistedEffort | "max", saved: boolean): string {
+	return `Set effort level to ${level} (${saved ? "saved as your default for new sessions" : "this session only"}): ${DESCRIPTIONS[level]}`;
+}

package/extensions/effort/slider.ts

@@ -18,6 +18,7 @@
  */
 
 import type { ThinkingLevel } from "@earendil-works/pi-agent-core";
+import { keyId, keyText } from "../lib/key-input.ts";
 
 /** The final stop on the track: top reasoning + workflows armed every turn. */
 export const ULTRACODE = "ultracode";
@@ -73,35 +74,38 @@ export function choiceForState(level: ThinkingLevel | undefined, ultracodeActive
 	return "medium";
 }
 
-export type SliderKey = "left" | "right" | "first" | "last" | "confirm" | "cancel";
+export type SliderKey = "left" | "right" | "first" | "last" | "confirm" | "session" | "cancel";
 
 /**
  * Decode a raw terminal chunk. `Component.handleInput` hands over bytes, not key
- * names, so the sequences are matched directly: CSI C/D for arrows (plus the
- * older SS3 form some terminals still send), CR/LF to confirm, ESC to cancel.
+ * names; `lib/key-input.ts` names them, so every terminal encoding of a key
+ * (legacy, kitty, modifyOtherKeys) decodes alike.
  */
 export function decodeKey(data: string): SliderKey | undefined {
-	switch (data) {
-		case "\x1b[C":
-		case "\x1bOC":
-		case "l":
+	switch (keyId(data)) {
+		case "right":
 			return "right";
-		case "\x1b[D":
-		case "\x1bOD":
-		case "h":
+		case "left":
 			return "left";
-		case "\x1b[H":
-		case "\x1b[1~":
+		case "home":
 			return "first";
-		case "\x1b[F":
-		case "\x1b[4~":
+		case "end":
 			return "last";
-		case "\r":
-		case "\n":
+		case "enter":
 			return "confirm";
-		case "\x1b":
-		case "\x03": // ctrl+c — same intent as escape while a picker is focused
+		case "escape":
+		case "ctrl+c": // same intent as escape while a picker is focused
 			return "cancel";
+		default:
+			break;
+	}
+	switch (keyText(data)) {
+		case "s":
+			return "session";
+		case "l":
+			return "right";
+		case "h":
+			return "left";
 		default:
 			return undefined;
 	}
@@ -178,10 +182,10 @@ export interface SliderView {
 }
 
 const TITLE = "Effort";
-const HINTS = "←/→ or h/l adjust · Enter confirm · Esc cancel · shift+tab cycles the plain levels";
+const HINTS = "←/→ or h/l adjust · Enter confirm · s for this session only · Esc cancel · shift+tab cycles the plain levels";
 /** Anthropic's cache hierarchy: a thinking/effort change invalidates the message cache once (CACHE-REVIEW-2026-09-04 M4). */
 const CACHE_NOTE = "changing effort re-caches the conversation (one uncached request)";
-const SHORT_HINTS = "←/→ h/l · Enter · Esc";
+const SHORT_HINTS = "←/→ h/l · Enter · s · Esc";
 const ULTRACODE_SUBTITLE = `${ULTRACODE_LEVEL} + workflows`;
 
 /**

package/extensions/exit/index.ts

@@ -1,5 +1,5 @@
 /**
- * exit extension — Claude Code's `/exit`.
+ * exit extension — Claude Code's `/exit` and one-shot failure status.
  *
  * pi's built-in quit command is `/quit`; Claude Code's is `/exit` (with `quit`
  * shown as an alias). A user coming from Claude Code types `/exit` out of habit
@@ -17,8 +17,39 @@
  */
 
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { ONE_SHOT_COMMAND_FAILED_CHANNEL, type RunOutcome, RunOutcomeLatch, TURN_FAILED_CHANNEL } from "../lib/interrupt.ts";
 
 export default function exitExtension(pi: ExtensionAPI) {
+	const outcome = new RunOutcomeLatch();
+	let settled: RunOutcome | undefined;
+	// The harness stopped the turn in progress: its run ends "aborted", which
+	// must not read as a user cancel when the turn settles.
+	let turnFailed = false;
+	pi.on("agent_end", (event, ctx) => {
+		outcome.record(event.messages, ctx.signal?.aborted);
+	});
+	pi.on("agent_settled", () => {
+		const run = outcome.take();
+		settled = turnFailed ? "error" : run ?? settled;
+		turnFailed = false;
+	});
+	pi.events.on(ONE_SHOT_COMMAND_FAILED_CHANNEL, () => {
+		settled = "error";
+	});
+	pi.events.on(TURN_FAILED_CHANNEL, () => {
+		turnFailed = true;
+	});
+	pi.on("session_shutdown", (event, ctx) => {
+		if (ctx.mode !== "print" && ctx.mode !== "json") return;
+		if (event.reason !== "quit" || (settled !== "error" && !turnFailed)) return;
+		// pi 1.0.1 checks provider errors for text output, but not JSON. A print
+		// run may submit several prompts or replace the session (/clear), so a
+		// settled turn is not yet the process's final outcome. Commit only at
+		// final disposal, after retries/compaction and every prompt. main preserves
+		// this code when runPrintMode returns zero; never clear another failure.
+		if (process.exitCode === undefined || Number(process.exitCode) === 0) process.exitCode = 1;
+	});
+
 	pi.registerCommand("exit", {
 		description: "Quit One Code (same as /quit)",
 		handler: async (_args, ctx) => {