oncoprintjs 6.1.2 → 6.1.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "oncoprintjs",
-  "version": "6.1.2",
+  "version": "6.1.4",
   "description": "A data visualization for cancer genomic data.",
   "types": "./dist/js/oncoprint.d.ts",
   "main": "dist/index.js",
@@ -57,5 +57,5 @@
     "tayden-clusterfck": "^0.7.0",
     "typescript": "4.0.3"
   },
-  "gitHead": "727d3a488de0851176ae5660769364e276b94bc7"
+  "gitHead": "e7abcbd899e0d4b0252fa3f9b1d955c296dd111a"
 }

package/src/js/oncoprintmodel.ts

@@ -1708,9 +1708,14 @@ export default class OncoprintModel {
             return null;
         }
 
-        // Next, see if it's in a track
+        // Next, see if it's in a track.
+        // Try binary search first for performance, but fall back to linear
+        // scan if the result is invalid. cell_tops may not be monotonically
+        // ordered relative to the tracks array during async clustering
+        // transitions, which causes binary search to return wrong results.
         const tracks = this.getTracks();
         const cell_tops = this.getCellTops() as TrackProp<number>;
+        let nearest_track: TrackId | undefined;
         const nearest_track_index = binarysearch(
             tracks,
             y,
@@ -1719,12 +1724,29 @@ export default class OncoprintModel {
             },
             true
         );
-        if (nearest_track_index === -1) {
-            return null;
+        if (nearest_track_index !== -1) {
+            const candidate = tracks[nearest_track_index];
+            if (
+                y >= cell_tops[candidate] &&
+                y < cell_tops[candidate] + this.getCellHeight(candidate)
+            ) {
+                nearest_track = candidate;
+            }
+        }
+        if (nearest_track === undefined) {
+            // Binary search failed (tracks out of order) - linear fallback
+            for (let t = 0; t < tracks.length; t++) {
+                const top = cell_tops[tracks[t]];
+                if (
+                    y >= top &&
+                    y < top + this.getCellHeight(tracks[t])
+                ) {
+                    nearest_track = tracks[t];
+                    break;
+                }
+            }
         }
-        const nearest_track = tracks[nearest_track_index];
-        if (y >= cell_tops[nearest_track] + this.getCellHeight(nearest_track)) {
-            // we know y is past the top of the track (>= cell_tops[nearest_track]), so this checks if y is past the bottom of the track
+        if (nearest_track === undefined) {
             return null;
         }