onbuzz 6.3.1 → 6.3.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "onbuzz",
-  "version": "6.3.1",
+  "version": "6.3.3",
   "description": "Loxia OnBuzz - Your AI Fleet",
   "type": "module",
   "main": "src/index.js",

package/src/services/__tests__/aiService.samplingOptions.test.js

@@ -252,11 +252,37 @@ describe('param-quirk ladder (backend path)', () => {
       expect.stringContaining('MODEL QUIRK'), expect.anything());
   });
 
-  test('retry also failing on ANOTHER param error → exactly two attempts, then throw', async () => {
+  test('the SAME rejection after the strip → exactly two attempts, then throw (never an infinite ladder)', async () => {
     const svc = makeService();
-    const calls = mockBackendRejecting(GPT56, () => true); // always rejects
+    const calls = mockBackendRejecting(GPT56, () => true); // always rejects on temperature
     await expect(svc.sendMessage('gpt-5.6-sol', [{ role: 'user', content: 'hi' }], { ...KEYED }))
       .rejects.toThrow();
-    expect(calls).toHaveLength(2); // one learn-retry, never an infinite ladder
+    expect(calls).toHaveLength(2); // temperature stripped once; a second identical rejection learns nothing → throw
+  });
+
+  test('gpt-6-astra fixture: two DIFFERENT rejections in one request (forced reasoning_effort, then temperature) → third attempt succeeds', async () => {
+    const svc = makeService();
+    const ASTRA = "400 Function tools with reasoning_effort are not supported for gpt-6-astra in /v1/chat/completions. To use function tools, use /v1/responses or set reasoning_effort to 'none'.";
+    const calls = [];
+    global.fetch = jest.fn(async (url, init) => {
+      const body = JSON.parse(init.body);
+      calls.push(body);
+      const reject = (message, param) => ({
+        ok: false, status: 400,
+        json: async () => ({ error: { message, param, code: 'unsupported_value' } }),
+        text: async () => JSON.stringify({ error: { message, param, code: 'unsupported_value' } }),
+        headers: { get: () => 'application/json' },
+      });
+      if (body.options?.reasoning_effort !== 'none') return reject(ASTRA, null);
+      if (body.options?.temperature !== undefined) return reject(GPT56, 'temperature');
+      return { ok: true, status: 200, json: async () => ({ content: 'ok' }), text: async () => 'ok', headers: { get: () => 'application/json' } };
+    });
+    const r = await svc.sendMessage('gpt-6-astra', [{ role: 'user', content: 'hi' }], { ...KEYED, temperature: 0.7 });
+    expect(r.content).toBe('ok');
+    expect(calls).toHaveLength(3);
+    expect(calls[2].options.reasoning_effort).toBe('none');
+    expect(calls[2].options.temperature).toBeUndefined();
+    const { getModelQuirkStore } = await import('../modelQuirks.js');
+    expect([...getModelQuirkStore().get('gpt-6-astra')].sort()).toEqual(['reasoning_effort=none', 'temperature']);
   });
 });

package/src/services/aiService.js

@@ -17,6 +17,9 @@ import {
   COMPACTION_CONFIG
 } from '../utilities/constants.js';
 import { getModelQuirkStore, classifyParamError, classifyForcedValue, STRIPPABLE_PARAMS } from './modelQuirks.js';
+
+/** Distinct parameter rejections a single request may learn from before giving up. */
+const MAX_QUIRK_LEARNS_PER_REQUEST = 4;
 import { getOllamaService, OLLAMA_MODEL_PREFIX } from './ollamaService.js';
 import { getDaniService, DANI_MODEL_PREFIX } from './daniService.js';
 import { SHARED_MEMORY_SCOPE } from './memoryService.js';
@@ -613,7 +616,11 @@ class AIService {
           });
           break;
         } catch (err) {
-          if (quirkAttempt === 0 && this._learnParamQuirk(model, err, payload.options)) continue;
+          // Each learned quirk changes the payload, so several distinct rejections
+          // may be resolved within ONE request (gpt-6-astra on the Responses API
+          // rejected `temperature`, then `reasoning_effort`: one learn per request
+          // cost two failed turns before the third succeeded).
+          if (quirkAttempt < MAX_QUIRK_LEARNS_PER_REQUEST && this._learnParamQuirk(model, err, payload.options)) continue;
           throw err;
         }
       }
@@ -776,7 +783,11 @@ class AIService {
           });
           break;
         } catch (err) {
-          if (quirkAttempt === 0 && this._learnParamQuirk(model, err, payload.options)) continue;
+          // Each learned quirk changes the payload, so several distinct rejections
+          // may be resolved within ONE request (gpt-6-astra on the Responses API
+          // rejected `temperature`, then `reasoning_effort`: one learn per request
+          // cost two failed turns before the third succeeded).
+          if (quirkAttempt < MAX_QUIRK_LEARNS_PER_REQUEST && this._learnParamQuirk(model, err, payload.options)) continue;
           throw err;
         }
       }