onbuzz 4.9.0 → 4.9.5

package/src/interfaces/__tests__/bulkAgentRoute.test.js

@@ -59,7 +59,7 @@ function bulkHandler(orchestrator, logger) {
           if (!agent && action !== 'delete') return { agentId, success: false, error: 'Agent not found' };
           if (actionMap[action]) {
             const payload = action === 'set-model' ? { agentId, model: params.model } : { agentId };
-            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'WEB', action: actionMap[action], payload, projectDir });
+            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'web', action: actionMap[action], payload, projectDir });
             return { agentId, success: r?.success !== false, error: r?.error || null };
           }
           if (action === 'enable-tool' || action === 'disable-tool') {
@@ -69,7 +69,7 @@ function bulkHandler(orchestrator, logger) {
             const i = caps.indexOf(tool);
             if (action === 'enable-tool' && i === -1) caps.push(tool);
             if (action === 'disable-tool' && i !== -1) caps.splice(i, 1);
-            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'WEB', action: 'update_agent', payload: { agentId, updates: { capabilities: caps } }, projectDir });
+            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'web', action: 'update_agent', payload: { agentId, updates: { capabilities: caps } }, projectDir });
             return { agentId, success: r?.success !== false, error: r?.error || null };
           }
           if (action === 'archive') {
@@ -77,7 +77,7 @@ function bulkHandler(orchestrator, logger) {
               await orchestrator.stateManager.archiveAgent(agentId, projectDir);
               return { agentId, success: true };
             }
-            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'WEB', action: 'unload_agent', payload: { agentId }, projectDir });
+            const r = await orchestrator.processRequest({ sessionId: effectiveSessionId, interface: 'web', action: 'unload_agent', payload: { agentId }, projectDir });
             return { agentId, success: r?.success !== false, error: r?.error || null };
           }
           return { agentId, success: false, error: `Unhandled action: ${action}` };
@@ -287,4 +287,75 @@ describe('POST /api/agents/bulk — partial success', () => {
     expect(r.body.summary).toEqual({ total: 2, ok: 1, failed: 1 });
     expect(r.body.results.find(x => x.agentId === 'missing-1').error).toMatch(/not found/i);
   });
+
+  // Regression guard for the silent "Invalid interface: WEB" bug.
+  //
+  // The bulk handler used to hardcode `interface: 'WEB'` (uppercase),
+  // but orchestrator.processRequest validates against INTERFACE_TYPES
+  // — which uses LOWERCASE strings ('web', 'cli', etc.). Every bulk
+  // action — delete, pause, resume, unload, set-model, enable-tool,
+  // disable-tool, archive — failed with `Invalid interface: WEB`
+  // before even dispatching. The error was caught in `runOne`'s
+  // try/catch and surfaced as per-agent failure ("Failed to delete
+  // N agents") with no hint at the actual cause.
+  //
+  // Lock the lowercase contract for every action that flows through
+  // processRequest, so any case-drift trips this test immediately.
+  it('forwards lowercase "web" as the interface (not "WEB") for every dispatch', async () => {
+    orch = makeOrchestrator();
+    await startServer(orch);
+    // Hit one representative of each routed action.
+    await post({ action: 'delete', agentIds: ['a'] });
+    await post({ action: 'pause',  agentIds: ['a'] });
+    await post({ action: 'unload', agentIds: ['a'] });
+    await post({ action: 'set-model', agentIds: ['a'], params: { model: 'k' } });
+
+    // Every call to processRequest must have used lowercase 'web'.
+    for (const call of orch.processRequest.mock.calls) {
+      expect(call[0].interface).toBe('web');
+    }
+  });
+
+  it('falls flat if the orchestrator rejects "WEB" — regression of the original bug', async () => {
+    // Simulate the real orchestrator's validation: throw on anything
+    // not matching INTERFACE_TYPES.WEB ('web'). With the fix, every
+    // call should succeed because the handler now passes lowercase.
+    orch = makeOrchestrator({
+      processRequest: jest.fn(async ({ interface: iface }) => {
+        if (iface !== 'web') throw new Error(`Invalid interface: ${iface}`);
+        return { success: true };
+      }),
+    });
+    await startServer(orch);
+    const r = await post({ action: 'delete', agentIds: ['a', 'b'] });
+    expect(r.body.success).toBe(true);
+    expect(r.body.summary).toEqual({ total: 2, ok: 2, failed: 0 });
+  });
+
+  // Regression guard for the My Squadron > group operation (delete) bug.
+  // Before the fix, deleting selected agents in the UI failed with
+  // "Failed to delete N agents" whenever any of them was unloaded —
+  // the bulk handler let `delete` flow through to the orchestrator, but
+  // the orchestrator's _handleDeleteAgent threw "Agent not found" for
+  // anything not in the live pool. Now agentPool.deleteAgent is
+  // idempotent (clears persistent state regardless of pool membership)
+  // and the orchestrator surfaces that success up through processRequest.
+  // From the bulk route's perspective: every missing-prefixed agent
+  // should report success.
+  it('delete against missing/unloaded agents succeeds (idempotent cleanup)', async () => {
+    orch = makeOrchestrator();
+    await startServer(orch);
+    const r = await post({ action: 'delete', agentIds: ['missing-1', 'missing-2', 'a'] });
+    expect(r.status).toBe(200);
+    expect(r.body.success).toBe(true);
+    expect(r.body.summary).toEqual({ total: 3, ok: 3, failed: 0 });
+    // All three reached processRequest (no short-circuit on missing).
+    expect(orch.processRequest).toHaveBeenCalledTimes(3);
+    for (const id of ['missing-1', 'missing-2', 'a']) {
+      expect(orch.processRequest).toHaveBeenCalledWith(expect.objectContaining({
+        action: 'delete_agent',
+        payload: expect.objectContaining({ agentId: id }),
+      }));
+    }
+  });
 });

package/src/interfaces/webServer.js

@@ -1903,6 +1903,96 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
     // API Key Management Endpoints
     
     // Set API keys for current session
+    // ─── Embeddings configuration + telemetry ─────────────────────────
+    //
+    // Settings UI surface for the semantic-retrieval layer (Phases 0-5
+    // in the embeddings rollout). All routes 200 even when the
+    // embedding service hasn't been attached yet — they return a
+    // clearly-marked unconfigured payload rather than a 503, so the
+    // Settings UI can render a "not configured yet" state.
+
+    /** GET /api/embeddings/config — current config + provider catalog. */
+    this.app.get('/api/embeddings/config', async (_req, res) => {
+      try {
+        const svc = this.embeddingService;
+        if (!svc) {
+          return res.json({ configured: false, config: null, providers: [], models: {} });
+        }
+        // Lazy-import the model catalog so we don't pull it into the
+        // hot-path bundle of the webServer.
+        const [{ getProviderModelOptions, PROVIDERS, DEFAULT_CONFIG }] = await Promise.all([
+          import('../services/embeddings/embeddingsConfig.js'),
+        ]);
+        const models = {};
+        for (const p of PROVIDERS) models[p] = getProviderModelOptions(p);
+        res.json({
+          configured: true,
+          config: svc.config,
+          providers: PROVIDERS,
+          models,
+          defaults: DEFAULT_CONFIG,
+          enabled: svc.isEnabled,
+        });
+      } catch (error) {
+        this.logger.error('Failed to read embeddings config', { error: error.message });
+        res.status(500).json({ error: error.message });
+      }
+    });
+
+    /** POST /api/embeddings/config — update + persist. */
+    this.app.post('/api/embeddings/config', async (req, res) => {
+      try {
+        const svc = this.embeddingService;
+        if (!svc) return res.status(503).json({ error: 'Embedding service not initialised' });
+        const result = await svc.updateConfig(req.body || {}, { persist: true });
+        if (!result.ok) {
+          return res.status(400).json({ error: 'Invalid config', details: result.errors });
+        }
+        res.json({ success: true, config: svc.config, enabled: svc.isEnabled });
+      } catch (error) {
+        this.logger.error('Failed to update embeddings config', { error: error.message });
+        res.status(500).json({ error: error.message });
+      }
+    });
+
+    /** GET /api/embeddings/telemetry — cost dashboard data. */
+    this.app.get('/api/embeddings/telemetry', async (_req, res) => {
+      try {
+        const svc = this.embeddingService;
+        if (!svc) return res.json({ configured: false, telemetry: null });
+        res.json({ configured: true, telemetry: svc.getTelemetry(), enabled: svc.isEnabled });
+      } catch (error) {
+        this.logger.error('Failed to read embeddings telemetry', { error: error.message });
+        res.status(500).json({ error: error.message });
+      }
+    });
+
+    /** GET /api/embeddings/health — provider readiness pill. */
+    this.app.get('/api/embeddings/health', async (_req, res) => {
+      try {
+        const svc = this.embeddingService;
+        if (!svc) return res.json({ configured: false, health: { ok: false, reason: 'service not initialised' } });
+        const health = await svc.health();
+        res.json({ configured: true, health, enabled: svc.isEnabled, provider: svc.config?.provider });
+      } catch (error) {
+        this.logger.error('Failed to check embeddings health', { error: error.message });
+        res.status(500).json({ error: error.message });
+      }
+    });
+
+    /** POST /api/embeddings/warmup — load the local model now. */
+    this.app.post('/api/embeddings/warmup', async (_req, res) => {
+      try {
+        const svc = this.embeddingService;
+        if (!svc) return res.status(503).json({ error: 'Embedding service not initialised' });
+        await svc.warmup();
+        res.json({ success: true, health: await svc.health() });
+      } catch (error) {
+        this.logger.error('Embeddings warmup failed', { error: error.message });
+        res.status(500).json({ error: error.message });
+      }
+    });
+
     this.app.post('/api/keys', async (req, res) => {
       try {
         const { sessionId, loxiaApiKey, vendorKeys } = req.body;
@@ -4727,15 +4817,17 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
           try {
             const agent = await this.orchestrator.agentPool.getAgent(agentId).catch(() => null);
             if (!agent && action !== 'delete') {
-              // Allow `delete` to proceed against missing agents
-              // (idempotent cleanup); other actions need the agent loaded.
+              // `delete` flows through to agentPool.deleteAgent which
+              // handles both loaded and unloaded agents (clears
+              // persistent state in either case). Other actions need
+              // a live agent instance to mutate, so we short-circuit.
               return { agentId, success: false, error: 'Agent not found' };
             }
 
             switch (action) {
               case 'delete': {
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'delete_agent',
                   payload: { agentId },
                   projectDir,
@@ -4744,7 +4836,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
               }
               case 'unload': {
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'unload_agent',
                   payload: { agentId },
                   projectDir,
@@ -4753,7 +4845,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
               }
               case 'pause': {
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'pause_agent',
                   payload: { agentId },
                   projectDir,
@@ -4762,7 +4854,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
               }
               case 'resume': {
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'resume_agent',
                   payload: { agentId },
                   projectDir,
@@ -4771,7 +4863,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
               }
               case 'set-model': {
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'switch_model',
                   payload: { agentId, model: params.model },
                   projectDir,
@@ -4788,7 +4880,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
                 if (action === 'enable-tool' && i === -1) caps.push(tool);
                 if (action === 'disable-tool' && i !== -1) caps.splice(i, 1);
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'update_agent',
                   payload: { agentId, updates: { capabilities: caps } },
                   projectDir,
@@ -4804,7 +4896,7 @@ h2{color:#16a34a;margin-bottom:.5rem;} p{color:#666;}</style></head>
                   return { agentId, success: true };
                 }
                 const r = await this.orchestrator.processRequest({
-                  sessionId: effectiveSessionId, interface: 'WEB',
+                  sessionId: effectiveSessionId, interface: INTERFACE_TYPES.WEB,
                   action: 'unload_agent',
                   payload: { agentId },
                   projectDir,