on-zero 0.7.10 → 0.8.0

package/dist/esm/generate.test.native.js

@@ -1,20 +1,24 @@
-import { existsSync, mkdirSync, readFileSync, rmSync, symlinkSync, writeFileSync } from "fs";
+import { existsSync, mkdirSync, readFileSync, rmSync, symlinkSync, writeFileSync as writeFile } from "fs";
 import { tmpdir } from "os";
-import { join } from "path";
+import { dirname, join } from "path";
 import { runInNewContext } from "vm";
 import * as zero from "@rocicorp/zero";
-import { afterEach, beforeEach, describe, expect, test } from "vitest";
-import { generate, generateDrizzleSchemaFile } from "./generate.native.js";
+import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
+import { deriveDataMembership, generate, generateDrizzleSchemaFile, generateDrizzleSchemaInputFile } from "./generate.native.js";
 var testDir = join(tmpdir(), "on-zero-test-" + Date.now());
-beforeEach(function () {
-  mkdirSync(join(testDir, "models"), {
+function writeFileSync(path, content) {
+  mkdirSync(dirname(path), {
     recursive: true
   });
-  mkdirSync(join(testDir, "queries"), {
+  writeFile(path, content);
+}
+beforeEach(function () {
+  mkdirSync(testDir, {
     recursive: true
   });
 });
 afterEach(function () {
+  vi.restoreAllMocks();
   rmSync(testDir, {
     recursive: true,
     force: true
@@ -22,7 +26,7 @@ afterEach(function () {
 });
 describe("generate", function () {
   test("generates models.ts, types.ts, tables.ts from model files", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `
 import { table, string, boolean } from 'on-zero'
 
 export const schema = table('post', {
@@ -31,7 +35,7 @@ export const schema = table('post', {
   published: boolean(),
 })
 `);
-    writeFileSync(join(testDir, "models/comment.ts"), `
+    writeFileSync(join(testDir, "comment/mutations.ts"), `
 import { table, string } from 'on-zero'
 
 export const schema = table('comment', {
@@ -40,8 +44,8 @@ export const schema = table('comment', {
   body: string(),
 })
 `);
-    writeFileSync(join(testDir, "models/post.test.ts"), `throw new Error('test files must not be generated as models')`);
-    writeFileSync(join(testDir, "queries/comment.spec.ts"), `throw new Error('spec files must not be generated as queries')`);
+    writeFileSync(join(testDir, "post/post.test.ts"), `throw new Error('test files must not be generated as models')`);
+    writeFileSync(join(testDir, "comment/comment.spec.ts"), `throw new Error('spec files must not be generated as queries')`);
     var result = await generate({
       dir: testDir,
       silent: true
@@ -53,20 +57,20 @@ export const schema = table('comment', {
     expect(existsSync(join(testDir, "generated/types.ts"))).toBe(true);
     expect(existsSync(join(testDir, "generated/tables.ts"))).toBe(true);
     var modelsContent = readFileSync(join(testDir, "generated/models.ts"), "utf-8");
-    expect(modelsContent).toContain("import * as comment from '../models/comment'");
-    expect(modelsContent).toContain("import * as post from '../models/post'");
+    expect(modelsContent).toContain("import * as comment from '../comment/mutations'");
+    expect(modelsContent).toContain("import * as post from '../post/mutations'");
     expect(modelsContent).not.toContain("post.test");
     expect(modelsContent).toContain("export const models = {");
     var typesContent = readFileSync(join(testDir, "generated/types.ts"), "utf-8");
     expect(typesContent).toContain("export type Post = TableInsertRow<typeof schema.post>");
     expect(typesContent).toContain("export type Comment = TableInsertRow<typeof schema.comment>");
     var tablesContent = readFileSync(join(testDir, "generated/tables.ts"), "utf-8");
-    expect(tablesContent).toContain("export { schema as post } from '../models/post'");
-    expect(tablesContent).toContain("export { schema as comment } from '../models/comment'");
+    expect(tablesContent).toContain("export { schema as post } from '../post/mutations'");
+    expect(tablesContent).toContain("export { schema as comment } from '../comment/mutations'");
   });
   test("generates query validators from query files", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
-    writeFileSync(join(testDir, "queries/post.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/queries.ts"), `
 import { zero } from '../zero'
 
 export const allPosts = () => zero.query.post
@@ -84,7 +88,8 @@ export const postsByAuthor = ({ authorId, limit }: { authorId: string; limit?: n
     expect(existsSync(join(testDir, "generated/groupedQueries.ts"))).toBe(true);
     expect(existsSync(join(testDir, "generated/syncedQueries.ts"))).toBe(true);
     var groupedContent = readFileSync(join(testDir, "generated/groupedQueries.ts"), "utf-8");
-    expect(groupedContent).toContain("export * as post from '../queries/post'");
+    expect(groupedContent).toContain("import * as postSource from '../post/queries'");
+    expect(groupedContent).toContain("postById: postSource.postById");
     var syncedContent = readFileSync(join(testDir, "generated/syncedQueries.ts"), "utf-8");
     expect(syncedContent).toContain("allPosts: defineQuery");
     expect(syncedContent).toContain("postById: defineQuery");
@@ -92,8 +97,8 @@ export const postsByAuthor = ({ authorId, limit }: { authorId: string; limit?: n
     expect(syncedContent).toContain("v.object");
   });
   test("skips permission exports in queries", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
-    writeFileSync(join(testDir, "queries/post.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/queries.ts"), `
 export const permission = () => ({ canRead: true })
 export const allPosts = () => zero.query.post
 `);
@@ -107,20 +112,20 @@ export const allPosts = () => zero.query.post
     expect(syncedContent).not.toContain("permission:");
   });
   test("aliases user import without changing the model key", async function () {
-    writeFileSync(join(testDir, "models/user.ts"), `export const schema = table('user', { id: string(), name: string() })`);
+    writeFileSync(join(testDir, "user/mutations.ts"), `export const schema = table('user', { id: string(), name: string() })`);
     await generate({
       dir: testDir,
       silent: true
     });
     var modelsContent = readFileSync(join(testDir, "generated/models.ts"), "utf-8");
-    expect(modelsContent).toContain("import * as userPublic from '../models/user'");
+    expect(modelsContent).toContain("import * as userPublic from '../user/mutations'");
     expect(modelsContent).toContain("user: userPublic,");
     expect(modelsContent).not.toContain("\n  userPublic,");
     var typesContent = readFileSync(join(testDir, "generated/types.ts"), "utf-8");
     expect(typesContent).toContain("typeof schema.userPublic");
   });
   test("runs after command when files change", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
     var markerFile = join(testDir, "after-ran");
     var result = await generate({
       dir: testDir,
@@ -131,7 +136,7 @@ export const allPosts = () => zero.query.post
     expect(existsSync(markerFile)).toBe(true);
   });
   test("does not regenerate when nothing changed", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
     var first = await generate({
       dir: testDir,
       silent: true
@@ -144,8 +149,8 @@ export const allPosts = () => zero.query.post
     expect(second.filesChanged).toBe(0);
   });
   test("force regenerates without source changes", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
-    writeFileSync(join(testDir, "queries/post.ts"), `export const allPosts = () => zero.query.post`);
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/queries.ts"), `export const allPosts = () => zero.query.post`);
     await generate({
       dir: testDir,
       silent: true
@@ -160,9 +165,333 @@ export const allPosts = () => zero.query.post
     expect(existsSync(syncedQueriesPath)).toBe(true);
   });
 });
+describe("instance layout", function () {
+  var dataDir = function dataDir2() {
+    return join(testDir, "src/data");
+  };
+  test("discovers file and folder namespaces and emits related sync closure", async function () {
+    writeFileSync(join(dataDir(), "control/reaction.ts"), `export const allReactions = () => zql.reaction`);
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: {}, project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "project/message/queries.ts"), `
+const unused = () => zql.message.related('notARealRelation')
+const withComments = () => zql.message.related('comments', (q) => q.related('author'))
+export const messages = () => withComments()
+`);
+    writeFileSync(join(dataDir(), "project/message/mutations.ts"), `export const schema = table('message').columns({ id: string(), projectId: string() })`);
+    writeFileSync(join(dataDir(), "project/message/helpers.ts"), `export const privateHelper = () => 'ignored'`);
+    writeFileSync(join(testDir, "src/database/relations.ts"), `
+export const relations = defineRelations(schema, (r) => ({
+  message: { comments: r.many.comment({}) },
+  comment: { author: r.one.userPublic({}) },
+}))
+`);
+    writeFileSync(join(testDir, "src/database/schema.ts"), `
+export const comment = sqliteTable('comment', { id: text(), projectId: text() })
+export const userPublic = sqliteTable('user_public', { id: text(), projectId: text() })
+`);
+    var membership = await deriveDataMembership({
+      dir: dataDir()
+    });
+    expect(membership.allTables).toEqual(["comment", "message", "reaction", "userPublic"]);
+    expect(membership.instances.project).toEqual({
+      tables: ["message"],
+      syncTables: ["comment", "message", "userPublic"],
+      supportTables: [],
+      scope: "projectId"
+    });
+    await generate({
+      dir: dataDir(),
+      silent: true
+    });
+    var grouped = readFileSync(join(dataDir(), "generated/groupedQueries.ts"), "utf8");
+    expect(grouped).toContain("from '../control/reaction'");
+    expect(grouped).toContain("from '../project/message/queries'");
+    expect(grouped).not.toContain("privateHelper");
+    var manifest = readFileSync(join(dataDir(), "generated/instances.ts"), "utf8");
+    expect(manifest).toContain("control: {");
+    expect(manifest).toContain("project: {");
+    expect(manifest).toContain('tables: ["message"]');
+    expect(manifest).toContain('syncTables: ["comment","message","userPublic"]');
+    expect(manifest).toContain(`defaultVisibility: (value: string) => ({ column: "projectId", value })`);
+  });
+  test("derives single-file namespaces from data exports", async function () {
+    writeFileSync(join(dataDir(), "server.ts"), `export const serverRows = () => zql.server`);
+    writeFileSync(join(dataDir(), "types.ts"), `export const formatRow = (value: string) => value`);
+    writeFileSync(join(dataDir(), "auth.ts"), `export function authId(auth: { id: string }) { return auth.id }`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).resolves.toEqual({
+      instances: {
+        default: {
+          tables: ["server"],
+          syncTables: ["server"],
+          supportTables: [],
+          scope: null
+        }
+      },
+      allTables: ["server"]
+    });
+  });
+  test("warns once and ignores an unparseable non-data file", async function () {
+    writeFileSync(join(dataDir(), "post.ts"), `export const posts = () => zql.post`);
+    writeFileSync(join(dataDir(), "types.ts"), `export type Broken = {`);
+    var warn = vi.spyOn(console, "warn").mockImplementation(function () {});
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).resolves.toMatchObject({
+      allTables: ["post"]
+    });
+    expect(warn).toHaveBeenCalledOnce();
+    expect(warn).toHaveBeenCalledWith("[on-zero] ignoring data/types.ts: no recognized data exports");
+    warn.mockRestore();
+  });
+  test("derives fileless support tables through mutation helpers", async function () {
+    writeFileSync(join(dataDir(), "post.ts"), `
+import { writeAudit } from './helpers/writeAudit'
+export const posts = () => zql.post
+export const mutate = mutations('post', { save: async (ctx) => writeAudit(ctx.tx) })
+`);
+    writeFileSync(join(dataDir(), "helpers/writeAudit.ts"), `
+import { readSettings } from './readSettings'
+export async function writeAudit(tx: Transaction) {
+  await tx.mutate.audit.insert({ id: 'audit' })
+  await tx.mutate.post.update({ id: 'post' })
+  await tx.mutate[tableName].insert({ id: 'dynamic' })
+  return readSettings(tx)
+}
+`);
+    writeFileSync(join(dataDir(), "helpers/readSettings.ts"), `export const readSettings = (tx: Transaction) => tx.query.settings`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).resolves.toEqual({
+      instances: {
+        default: {
+          tables: ["post"],
+          syncTables: ["post"],
+          supportTables: ["audit", "settings"],
+          scope: null
+        }
+      },
+      allTables: ["audit", "post", "settings"]
+    });
+  });
+  test("includes a fileless support table in every instance that uses it", async function () {
+    writeFileSync(join(dataDir(), "control/account.ts"), `export const mutate = mutations('account', { save: async (ctx) => ctx.tx.mutate.audit.insert({}) })`);
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: {}, project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `
+export const schema = table('message').columns({ id: string(), projectId: string() })
+export const mutate = mutations(schema, permission, {
+  save: async (ctx) => ctx.tx.mutate.audit.insert({}),
+})
+`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).resolves.toMatchObject({
+      instances: {
+        control: {
+          supportTables: ["audit"]
+        },
+        project: {
+          supportTables: ["audit"]
+        }
+      },
+      allTables: ["account", "audit", "message"]
+    });
+  });
+  test("keeps a configured default instance at the data root", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { default: { dir: '.', supportTables: ['accountGithubOrgLink', 'accountRepo', 'usageLedger'] }, project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "account.ts"), `export const accounts = () => zql.account`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `export const schema = table('message').columns({ id: string(), projectId: string() })`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).resolves.toEqual({
+      instances: {
+        default: {
+          tables: ["account"],
+          syncTables: ["account"],
+          supportTables: ["accountGithubOrgLink", "accountRepo", "usageLedger"],
+          scope: null
+        },
+        project: {
+          tables: ["message"],
+          syncTables: ["message"],
+          supportTables: [],
+          scope: "projectId"
+        }
+      },
+      allTables: ["account", "accountGithubOrgLink", "accountRepo", "message", "usageLedger"]
+    });
+  });
+  test("emits only relations whose source and target are derived members", async function () {
+    writeFileSync(join(dataDir(), "post.ts"), `export const posts = () => zql.post`);
+    writeFileSync(join(dataDir(), "comment.ts"), `export const comments = () => zql.comment`);
+    writeFileSync(join(testDir, "src/database/relations.ts"), `
+export const relations = defineRelations(schema, (r) => ({
+  post: {
+    comments: r.many.comment({}),
+    privateNotes: r.many.privateNote({}),
+  },
+  comment: { post: r.one.post({}), author: r.one.privateUser({}) },
+  privateNote: { post: r.one.post({}) },
+}))
+`);
+    var generated = await generateDrizzleSchemaInputFile({
+      dir: dataDir(),
+      schemaImportPath: "../../database/schema"
+    });
+    var runnable = generated.replace(`import { defineRelations } from 'drizzle-orm'`, "").replace(`import * as schema from "../../database/schema"`, "").replace(/export \{[^\n]+\} from [^\n]+/, "").replace("export const relations =", "globalThis.relations =");
+    var context = {
+      schema: {
+        comment: {},
+        post: {}
+      },
+      defineRelations: function defineRelations(_schema, factory) {
+        return factory({
+          one: new Proxy({}, {
+            get: function get(_target, table) {
+              return function () {
+                return {
+                  table
+                };
+              };
+            }
+          }),
+          many: new Proxy({}, {
+            get: function get(_target, table) {
+              return function () {
+                return {
+                  table
+                };
+              };
+            }
+          })
+        });
+      }
+    };
+    runInNewContext(runnable, context);
+    expect(context.relations).toEqual({
+      comment: {
+        post: {
+          table: "post"
+        }
+      },
+      post: {
+        comments: {
+          table: "comment"
+        }
+      }
+    });
+  });
+  test("rejects a relation that crosses instance ownership", async function () {
+    writeFileSync(join(dataDir(), "control/userPublic.ts"), `export const users = () => zql.userPublic`);
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: {}, project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `
+export const schema = table('message').columns({ id: string(), projectId: string() })
+export const messages = () => zql.message.related('author')
+`);
+    writeFileSync(join(testDir, "src/database/relations.ts"), `export const relations = defineRelations(schema, (r) => ({ message: { author: r.one.userPublic({}) } }))`);
+    await expect(generate({
+      dir: dataDir(),
+      silent: true
+    })).rejects.toThrow(/message\.messages.*instance 'project'.*userPublic.*instance 'control'/);
+  });
+  test("rejects a scoped sync table without the scope column", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `export const schema = table('message').columns({ id: string() })`);
+    await expect(generate({
+      dir: dataDir(),
+      silent: true
+    })).rejects.toThrow(/table 'message'.*instance 'project'.*scope column 'projectId'/);
+  });
+  test("rejects duplicate namespaces across instances", async function () {
+    writeFileSync(join(dataDir(), "control/message.ts"), `export const messages = () => zql.message`);
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: {}, project: { scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `export const schema = table('message').columns({ projectId: string() })`);
+    await expect(generate({
+      dir: dataDir(),
+      silent: true
+    })).rejects.toThrow(/namespace 'message'.*instances 'control' and 'project'/);
+  });
+  test("resolves configured instance directories relative to the config file", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: { dir: './planes/control-data', supportTables: ['audit'] }, project: { dir: '../project-data', scope: 'projectId' } } })`);
+    writeFileSync(join(dataDir(), "planes/control-data/account.ts"), `export const accounts = () => zql.account`);
+    writeFileSync(join(testDir, "src/project-data/message.ts"), `export const schema = table('message').columns({ id: string(), projectId: string() })`);
+    await expect(deriveDataMembership({
+      dir: dataDir(),
+      config: join(dataDir(), "on-zero.config.ts")
+    })).resolves.toEqual({
+      instances: {
+        control: {
+          tables: ["account"],
+          syncTables: ["account"],
+          supportTables: ["audit"],
+          scope: null
+        },
+        project: {
+          tables: ["message"],
+          syncTables: ["message"],
+          supportTables: [],
+          scope: "projectId"
+        }
+      },
+      allTables: ["account", "audit", "message"]
+    });
+    await expect(generate({
+      dir: dataDir(),
+      config: join(dataDir(), "on-zero.config.ts"),
+      silent: true
+    })).resolves.toMatchObject({
+      modelCount: 2,
+      schemaCount: 1
+    });
+    expect(readFileSync(join(dataDir(), "generated/models.ts"), "utf8")).toContain("from '../../project-data/message'");
+  });
+  test("rejects missing configured instance directories", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { project: { dir: './missing' } } })`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).rejects.toThrow(/instance 'project' directory does not exist.*missing/);
+  });
+  test("rejects two instances that resolve to the same directory", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { control: { dir: './shared' }, project: { dir: './shared' } } })`);
+    writeFileSync(join(dataDir(), "shared/account.ts"), `export const accounts = () => zql.account`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).rejects.toThrow(/instances 'control' and 'project' resolve to the same directory/);
+  });
+  test("rejects root namespaces when instances are configured", async function () {
+    writeFileSync(join(dataDir(), "on-zero.config.ts"), `export default defineConfig({ instances: { project: {} } })`);
+    writeFileSync(join(dataDir(), "project/message.ts"), `export const rows = () => zql.message`);
+    writeFileSync(join(dataDir(), "account.ts"), `export const rows = () => zql.account`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).rejects.toThrow(/data namespace .*account\.ts.*outside every instance directory/);
+  });
+  test("rejects removed instance.ts configuration", async function () {
+    writeFileSync(join(dataDir(), "post.ts"), `export const posts = () => zql.post`);
+    writeFileSync(join(dataDir(), "project/instance.ts"), `export default defineInstance({ scope: 'projectId' })`);
+    await expect(deriveDataMembership({
+      dir: dataDir()
+    })).rejects.toThrow(/uses removed instance\.ts configuration/);
+  });
+  test("rejects the removed top-level layout", async function () {
+    writeFileSync(join(dataDir(), "queries/message.ts"), `export const messages = () => zql.message`);
+    await expect(generate({
+      dir: dataDir(),
+      silent: true
+    })).rejects.toThrow(/removed top-level queries\/ layout/);
+  });
+  test("rejects dynamically named relations", async function () {
+    writeFileSync(join(dataDir(), "message.ts"), `export const messages = (relation: string) => zql.message.related(relation)`);
+    await expect(generate({
+      dir: dataDir(),
+      silent: true
+    })).rejects.toThrow(/related\(\) without a string literal.*statically derivable/);
+  });
+});
 describe("mutations", function () {
   test("generates validators for inline mutation param types", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `
 import { table, string } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 
@@ -191,7 +520,7 @@ export const mutate = mutations(schema, perm, {
     expect(content).toContain("v.string()");
   });
   test("generates CRUD validators from schema columns", async function () {
-    writeFileSync(join(testDir, "models/task.ts"), `
+    writeFileSync(join(testDir, "task/mutations.ts"), `
 import { table, string, number, boolean } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 
@@ -218,7 +547,7 @@ export const mutate = mutations(schema, perm)
     expect(content).toContain("delete:");
   });
   test("treats models without export const mutate as empty mutations", async function () {
-    writeFileSync(join(testDir, "models/readonly.ts"), `
+    writeFileSync(join(testDir, "readonly/mutations.ts"), `
 import { table, string } from 'on-zero'
 
 export const schema = table('readonly').columns({
@@ -235,7 +564,7 @@ export const schema = table('readonly').columns({
     expect(content).toContain("readonly: {");
   });
   test("extracts custom mutations from bare mutations({})", async function () {
-    writeFileSync(join(testDir, "models/admin.ts"), `
+    writeFileSync(join(testDir, "admin/mutations.ts"), `
 import { mutations } from 'on-zero'
 
 export const mutate = mutations({
@@ -253,7 +582,7 @@ export const mutate = mutations({
     expect(content).toContain("v.string()");
   });
   test("generates validators for string-model multiline mutation params", async function () {
-    writeFileSync(join(testDir, "models/agentEvent.ts"), `
+    writeFileSync(join(testDir, "agentEvent/mutations.ts"), `
 import { mutations, serverWhere } from 'on-zero'
 
 const perm = serverWhere('agentEvent', () => true)
@@ -287,7 +616,7 @@ export const mutate = mutations('agentEvent', perm, {
     expect(content).not.toContain("claimReviewLease: v.object({})");
   });
   test("generates validators for object intersections", async function () {
-    writeFileSync(join(testDir, "models/agent.ts"), `
+    writeFileSync(join(testDir, "agent/mutations.ts"), `
 import { mutations, serverWhere } from 'on-zero'
 
 const perm = serverWhere('agent', () => true)
@@ -320,7 +649,7 @@ export const mutate = mutations('agent', perm, {
     expect(content).not.toContain("[key");
   });
   test("uses v.unknown for untyped mutation payloads", async function () {
-    writeFileSync(join(testDir, "models/project.ts"), `
+    writeFileSync(join(testDir, "project/mutations.ts"), `
 import { mutations, serverWhere } from 'on-zero'
 
 const perm = serverWhere('project', () => true)
@@ -340,7 +669,7 @@ export const mutate = mutations('project', perm, {
     expect(content).not.toContain("insert: v.void_()");
   });
   test("handles mutations with only context param (void)", async function () {
-    writeFileSync(join(testDir, "models/user.ts"), `
+    writeFileSync(join(testDir, "user/mutations.ts"), `
 import { table, string } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 
@@ -365,7 +694,7 @@ export const mutate = mutations(schema, perm, {
     expect(content).toContain("finishOnboarding");
   });
   test("handles primitive param type", async function () {
-    writeFileSync(join(testDir, "models/user.ts"), `
+    writeFileSync(join(testDir, "user/mutations.ts"), `
 import { table, string } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 
@@ -391,7 +720,7 @@ export const mutate = mutations(schema, perm, {
     expect(content).toContain("v.string()");
   });
   test("handles array param type", async function () {
-    writeFileSync(join(testDir, "models/batch.ts"), `
+    writeFileSync(join(testDir, "batch/mutations.ts"), `
 import { mutations } from 'on-zero'
 
 export const mutate = mutations({
@@ -409,7 +738,7 @@ export const mutate = mutations({
     expect(content).toContain("v.array");
   });
   test("populates mutationCount and caching works", async function () {
-    writeFileSync(join(testDir, "models/item.ts"), `
+    writeFileSync(join(testDir, "item/mutations.ts"), `
 import { table, string } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 
@@ -441,14 +770,14 @@ export const mutate = mutations(schema, perm, {
 });
 describe("type resolution", function () {
   test("resolves imported type references for mutations", async function () {
-    writeFileSync(join(testDir, "models/types.ts"), `
+    writeFileSync(join(testDir, "post/types.ts"), `
 export type ArchiveParams = {
   id: string
   reason: string
   archived: boolean
 }
 `);
-    writeFileSync(join(testDir, "models/post.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `
 import { table, string, boolean } from 'on-zero'
 import { mutations } from 'on-zero'
 import type { ArchiveParams } from './types'
@@ -470,7 +799,7 @@ export const mutate = mutations({
     expect(content).toContain("archived");
   });
   test("resolves utility types like Pick", async function () {
-    writeFileSync(join(testDir, "models/types.ts"), `
+    writeFileSync(join(testDir, "item/types.ts"), `
 export type Item = {
   id: string
   name: string
@@ -478,7 +807,7 @@ export type Item = {
   count: number
 }
 `);
-    writeFileSync(join(testDir, "models/item.ts"), `
+    writeFileSync(join(testDir, "item/mutations.ts"), `
 import { table, string, number } from 'on-zero'
 import { mutations, serverWhere } from 'on-zero'
 import type { Item } from './types'
@@ -509,8 +838,8 @@ export const mutate = mutations(schema, perm, {
     expect(content).not.toMatch(/rename:[\s\S]*count/);
   });
   test("resolves instantiated Zero row fields through Partial and Omit", async function () {
-    symlinkSync(join(import.meta.dirname, "../../../node_modules"), join(testDir, "node_modules"), "dir");
-    writeFileSync(join(testDir, "models/types.ts"), `
+    symlinkSync(join(import.meta.dirname, "../node_modules"), join(testDir, "node_modules"), "dir");
+    writeFileSync(join(testDir, "item/types.ts"), `
 import type { Row } from '@rocicorp/zero'
 import { drizzleZeroConfig } from 'drizzle-zero-sqlite'
 import { sqliteTable, text } from 'drizzle-orm/sqlite-core'
@@ -524,7 +853,7 @@ const schema = drizzleZeroConfig({ item })
 
 export type Item = Row<(typeof schema)['tables']['item']>
 `);
-    writeFileSync(join(testDir, "models/item.ts"), `
+    writeFileSync(join(testDir, "item/mutations.ts"), `
 import { mutations } from 'on-zero'
 import type { Item } from './types'
 
@@ -547,13 +876,13 @@ export const mutate = mutations('item', {
     expect(content).not.toContain("description: v.optional(v.unknown())");
   });
   test("skips symbol-keyed properties when resolving imported mutation param types", async function () {
-    writeFileSync(join(testDir, "models/types.ts"), `
+    writeFileSync(join(testDir, "item/types.ts"), `
 export type WeirdParams = {
   id: string
   [Symbol.iterator]?: () => Iterator<string>
 }
 `);
-    writeFileSync(join(testDir, "models/item.ts"), `
+    writeFileSync(join(testDir, "item/mutations.ts"), `
 import { mutations } from 'on-zero'
 import type { WeirdParams } from './types'
 
@@ -573,14 +902,14 @@ export const mutate = mutations({
     expect(content).not.toContain("__@iterator");
   });
   test("resolves imported types in query params", async function () {
-    writeFileSync(join(testDir, "models/post.ts"), `export const schema = table('post', { id: string() })`);
-    writeFileSync(join(testDir, "queries/types.ts"), `
+    writeFileSync(join(testDir, "post/mutations.ts"), `export const schema = table('post', { id: string() })`);
+    writeFileSync(join(testDir, "post/types.ts"), `
 export type PostFilter = {
   authorId: string
   published: boolean
 }
 `);
-    writeFileSync(join(testDir, "queries/post.ts"), `
+    writeFileSync(join(testDir, "post/queries.ts"), `
 import type { PostFilter } from './types'
 
 export const filteredPosts = (filter: PostFilter) => zero.query.post