ompchamber 3.3.3 → 3.4.0

package/src/shared/types/btw.ts

@@ -13,18 +13,21 @@
  * `btw_message` frames in the chat's own `ChatMessageData` shape, and the
  * running turn is also carried in `BtwState.live` so a client attaching
  * mid-turn renders the answer already produced.
+ *
+ * A side question runs WITHOUT tools and on the CHAT's model and thinking
+ * selector, so there is no per-topic model/access picker and no approval dialog
+ * to answer — the panel's composer is an input and a send button, exactly like
+ * the TUI's.
  */
 
-import type { ApprovalMode } from '@/shared/lib/omp/config/access-mode';
 import type { ChatMessageData } from '@/shared/types/chat';
-import type { ExtensionUiDialogRequest } from '@/shared/types/omp/agent';
 
 /** Lifecycle of one question/answer pair inside a topic. */
-export type BtwTurnStatus = 'running' | 'complete' | 'cancelled' | 'failed' | 'interrupted';
+export type BtwTurnStatus = 'running' | 'complete' | 'cancelled' | 'error' | 'interrupted';
 
 /** Model a topic's side conversation runs on — the parent session's model,
- *  captured when the topic was created (omp's `/btw` uses the active model),
- *  then re-targeted by the panel's own model dropdown. */
+ *  re-read from the chat's transcript at every ask (omp's `/btw` runs the side
+ *  turn on `request.session.model`), so the panel offers no model picker. */
 export interface BtwModel {
   provider: string;
   id: string;
@@ -63,17 +66,11 @@ export interface BtwTopic {
   updatedAt: number;
   model?: BtwModel;
   /**
-   * Thinking level the side child runs at, or undefined for omp's own default.
-   * The panel's thinking dropdown writes it, and a change is applied with
-   * `set_thinking_level` on the live child.
+   * Thinking SELECTOR the side child runs at (`auto` included), re-read from the
+   * chat's transcript at every ask so a level changed in the chat is mirrored.
+   * Undefined when the chat's transcript records none.
    */
   thinkingLevel?: string;
-  /**
-   * Tool-approval mode the side child was SPAWNED with. omp exposes no RPC for
-   * this, so a change destroys and respawns an idle child — the same reconcile
-   * the chat session does (`reconcileSpawnApprovalMode`).
-   */
-  approvalMode?: ApprovalMode;
   /** Set once the topic was promoted into the chat as a session of its own. */
   promotedSessionId?: string;
   turns: BtwTurn[];
@@ -85,13 +82,12 @@ export interface BtwTopic {
  * Part of the state rather than only a stream of frames: a client that attaches
  * mid-turn (a reload, a second tab) would otherwise receive a `btw_state` whose
  * running turn still has no persisted messages and would show an empty answer
- * while the child streams on. Same reasoning as `dialogs` — the request never
- * comes again, so the state has to carry it.
+ * while the child streams on.
  */
 export interface BtwLiveTurn {
   topicId: string;
   turnIndex: number;
-  /** Chat-shaped conversation so far (thinking, tool calls, prose). */
+  /** Chat-shaped conversation so far (thinking and prose). */
   messages: ChatMessageData[];
   /** Activity phrase for the panel's indicator; '' before the child reports one. */
   activity: string;
@@ -105,23 +101,6 @@ export interface BtwState {
   runningTopicId: string | null;
   /** The running turn's live conversation, or null when nothing is in flight. */
   live: BtwLiveTurn | null;
-  /**
-   * Dialogs a side child is blocked on right now, oldest first. Part of the
-   * state rather than its own frame so a reload (or a fresh panel) replays the
-   * modal a child is waiting on — omp never re-delivers the request, so a lost
-   * one leaves the turn blocked with nothing to answer.
-   */
-  dialogs: BtwDialog[];
-}
-
-/**
- * A dialog the side child is blocked on. The panel renders it with the chat's
- * own `ExtensionDialog`; unlike the chat there is no tool card to host an `ask`
- * inline, so every answerable request is a modal.
- */
-export interface BtwDialog {
-  topicId: string;
-  request: ExtensionUiDialogRequest;
 }
 
 /** Server → client frames on `/api/btw/:sessionId/*` (WS and SSE alike). */