ompchamber 1.0.0 → 1.2.0

package/src/shared/types/chat.ts

@@ -3,13 +3,34 @@ import type { ApprovalMode } from '@/shared/lib/omp/config/access-mode';
 
 export interface Attachment {
   id: string;
+  /**
+   * Display name. Written at creation so a replayed attachment — one that has
+   * been through the queue's JSON round trip or back out of committed history —
+   * still renders and still inlines.
+   */
   name?: string;
-  file: File;
+  /**
+   * Live file handle. ABSENT on every replayed attachment: `File` is not
+   * serializable (`JSON.stringify(new File(...))` is `{}`), so the queue row and
+   * the committed message keep only the display fields below. Read the fields
+   * through `@/shared/lib/chat/attachments` accessors — `a.file.name` throws
+   * here, which is what used to break queue delivery and retry.
+   */
+  file?: File;
   preview: string;
   type?: string;
   size?: number;
   /** Base64 payload for image attachments (sent to the omp model). */
   dataBase64?: string;
+  /** Inlined text-file contents, persisted with the committed user turn so a
+   *  retry can re-send them without the original `File`. */
+  content?: string;
+  /**
+   * Set when `content` came from sniffing the file's bytes rather than from its
+   * name or MIME. A promised-file drag from another app has neither, so without
+   * this marker the send path would classify it as binary and drop it again.
+   */
+  sniffedText?: boolean;
 }
 
 export type ChatAttachment = Attachment;
@@ -166,6 +187,23 @@ export interface ChatMessageData {
   };
 }
 
+/** One user turn of a session's FULL history, as listed by
+ *  `GET /api/chat/:sessionId/turns`. The timeline jump rail draws one tick per
+ *  entry and pages the timeline to it, so an entry carries the row id the
+ *  timeline renders (the jump target) and the row's position in the full
+ *  message list (`index`, the cursor the older-window loader pages from). */
+export interface UserTurnRef {
+  id: string;
+  /** 0-based position in the session's full message list. `-1` for a row that
+   *  exists only in the live timeline (an optimistic send the committed
+   *  history does not carry yet) — such a row is always mounted. */
+  index: number;
+  /** Truncated prompt text for the rail tooltip. */
+  preview: string;
+  date?: string;
+  timestamp?: string;
+}
+
 /** Model settings snapshotted with a queued message so auto-delivery replays
  *  them (set_model / set_thinking_level RPC + spawn access mode) instead of
  *  using whatever the session happens to run with at delivery time. */
@@ -187,71 +225,6 @@ export interface QueuedMessage {
   model: QueuedMessageModel | null;
 }
 
-export interface AIModelOption {
-  id: string;
-  name: string;
-  provider: string;
-  providerIcon?: string;
-  contextWindow?: string | number;
-  isCmdAgent?: boolean;
-  isFavorite?: boolean;
-  isRecent?: boolean;
-  thinkingLevel?: string;
-  /** Baked thinking ladder for this model: `["off", ...efforts]`. */
-  thinkingLevels?: string[];
-  capabilities?: string[];
-  input?: string;
-  output?: string;
-  cost?: {
-    input: string | number;
-    output: string | number;
-    cacheRead?: string | number;
-    cacheWrite?: string | number;
-  };
-  description?: string;
-}
-
-// ── Real omp model registry (forked from omp-web) ──────────────────────────
-
-/** One pickable model from the omp catalog (`/api/models` modelList). */
-export interface ModelEntry {
-  id: string;
-  name: string;
-  provider: string;
-  supportsFastMode?: boolean;
-  contextWindow?: number;
-  maxTokens?: number;
-  /** Baked thinking ladder for this model: `["off", ...efforts]`. */
-  thinkingLevels?: string[];
-  /** Cost in $/1M tokens (omp catalog). */
-  cost?: { input?: number; output?: number; cacheRead?: number; cacheWrite?: number };
-}
-
-/** A model selected by provider + modelId (omp's set_model shape). */
-export interface SelectedModel {
-  provider: string;
-  modelId: string;
-}
-
-/** Model-level thinking metadata read off the live session state. */
-export interface ThinkingModelMeta {
-  provider: string;
-  modelId: string;
-  name?: string;
-  reasoning?: boolean;
-  thinking?: { efforts?: string[] };
-}
-
-/** Response shape of GET /api/models (mirrors omp-web ModelsData). */
-export interface ModelsData {
-  models: Record<string, string>;
-  modelList: ModelEntry[];
-  defaultModel: SelectedModel | null;
-  thinkingLevels: Record<string, string[]>;
-  connectedProviders?: { id: string; name: string; disabled: boolean }[];
-  modelError?: string;
-}
-
 // ── Composer autocomplete (@file/agent / /command+skill) ───────────────────
 
 /** Trigger group that opened the composer autocomplete: `@` → mention, `/` → command. */
@@ -259,6 +232,13 @@ export type ComposerPickKind = 'mention' | 'command';
 /** Origin of a pickable item: an `@` mention is an agent or a workspace file. */
 export type ComposerPickSource = 'agent' | 'file' | 'command' | 'skill';
 
+/**
+ * Which part of a slash invocation the popup is completing. oh-my-pi splits
+ * these the same way: `name` completes the command token itself, `args`
+ * completes a declarative subcommand after `<command> `.
+ */
+export type ComposerTriggerPhase = 'name' | 'args';
+
 /** A detected trigger: the `@`/`/` char plus the query typed after it. */
 export interface ComposerTrigger {
   kind: ComposerPickKind;
@@ -267,6 +247,18 @@ export interface ComposerTrigger {
   start: number;
   /** Caret index when detected. */
   end: number;
+  /** Command completion phase; `mention` triggers are always `name`. */
+  phase: ComposerTriggerPhase;
+  /** Index the accepted text replaces from — equals `start` in the `name` phase. */
+  replaceFrom: number;
+  /** Command the `args` phase belongs to (name or alias as typed). */
+  command?: string;
+  /**
+   * The `/token` sits mid-prompt (prose precedes it on the line or an earlier
+   * line exists), so only skill entries may surface — oh-my-pi's
+   * `buildMidPromptSkillCompletions` gate.
+   */
+  midPrompt?: boolean;
 }
 
 /** One autocomplete item surfaced in the composer popover. */
@@ -281,6 +273,25 @@ export interface ComposerPickItem {
   token: string;
   /** Workspace-relative path (file items only). */
   path?: string;
+  /**
+   * Suppress the trailing space on insertion. Set on the collapsed `/skill:`
+   * namespace row so the popup reopens with the individual skills, matching
+   * oh-my-pi's accept path.
+   */
+  insertWithoutSpace?: boolean;
+  /** Command aliases from oh-my-pi (`/models` for `/model`). */
+  aliases?: string[];
+  /** Declarative subcommands; drives the `args` phase. */
+  subcommands?: ComposerSubcommand[];
+  /** Argument hint (`[on|off|status]`), prefixed to the description like omp. */
+  inputHint?: string;
+}
+
+/** One declarative subcommand of an oh-my-pi slash command. */
+export interface ComposerSubcommand {
+  name: string;
+  description?: string;
+  usage?: string;
 }
 
 /** A pick item after filtering, with the matched range within `name` (or null). */

package/src/shared/types/index.ts

@@ -2,6 +2,8 @@ export * from '@/shared/types/workspace';
 export * from '@/shared/types/fs';
 export * from '@/shared/types/git';
 export * from '@/shared/types/chat';
+export * from '@/shared/types/btw';
+export * from '@/shared/types/models';
 export * from '@/shared/types/terminal';
 export * from '@/shared/types/settings/state';
 export * from '@/shared/types/tokenUsage';

package/src/shared/types/models.ts

@@ -0,0 +1,101 @@
+/**
+ * @license
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * Model catalog types shared by the composer picker, the settings pages and
+ * the `/api/models` route: the picker row (`AIModelOption`), the registry entry
+ * (`ModelEntry`), the selection reference omp's `set_model` takes, and the
+ * stored favorite/recent preference pair.
+ *
+ * Split out of `chat.ts` so that file stays under the per-file ceiling — the
+ * picker's row shape is not part of the chat message model it was nested in.
+ */
+
+export interface AIModelOption {
+  id: string;
+  name: string;
+  provider: string;
+  providerIcon?: string;
+  contextWindow?: string | number;
+  isCmdAgent?: boolean;
+  /**
+   * Favorite / last-used flag. On a picker row these are DERIVED from the
+   * stored preference keys (`ModelPreferences`), never read off the registry —
+   * a favorite is a chamber-local preference, not a property of omp's config.
+   * On the MOCK catalog they are the seed for a fresh install's rails.
+   */
+  isFavorite?: boolean;
+  /** MOCK seed only — the RECENT rail is ordered by `ModelPreferences.recentKeys`. */
+  isRecent?: boolean;
+  thinkingLevel?: string;
+  /** Baked thinking ladder for this model: `["off", ...efforts]`. */
+  thinkingLevels?: string[];
+  capabilities?: string[];
+  input?: string;
+  output?: string;
+  cost?: {
+    input: string | number;
+    output: string | number;
+    cacheRead?: string | number;
+    cacheWrite?: string | number;
+  };
+  description?: string;
+}
+
+// ── Real omp model registry (forked from omp-web) ──────────────────────────
+
+/** One pickable model from the omp catalog (`/api/models` modelList). */
+export interface ModelEntry {
+  id: string;
+  name: string;
+  provider: string;
+  supportsFastMode?: boolean;
+  contextWindow?: number;
+  maxTokens?: number;
+  /** Baked thinking ladder for this model: `["off", ...efforts]`. */
+  thinkingLevels?: string[];
+  /** Cost in $/1M tokens (omp catalog). */
+  cost?: { input?: number; output?: number; cacheRead?: number; cacheWrite?: number };
+}
+
+/** A model selected by provider + modelId (omp's set_model shape). */
+export interface SelectedModel {
+  provider: string;
+  modelId: string;
+}
+
+/** Model-level thinking metadata read off the live session state. */
+export interface ThinkingModelMeta {
+  provider: string;
+  modelId: string;
+  name?: string;
+  reasoning?: boolean;
+  thinking?: { efforts?: string[] };
+}
+
+/**
+ * The user's favorite + last-used models, keyed by the composite `provider:id`
+ * identity (`modelKey`). Stored separately from the model registry because the
+ * registry is a read-only view of omp's config — a favorite is a chamber-local
+ * preference, and an id-only key would light up every provider serving it.
+ */
+export interface ModelPreferences {
+  /** Composite keys in the order the FAVORITES rail renders them. */
+  favorites: string[];
+  /** Composite keys, most recently used first, capped at `RECENT_MODELS_LIMIT`. */
+  recentKeys: string[];
+}
+
+/** Response shape of GET /api/models (mirrors omp-web ModelsData). */
+export interface ModelsData {
+  models: Record<string, string>;
+  modelList: ModelEntry[];
+  defaultModel: SelectedModel | null;
+  thinkingLevels: Record<string, string[]>;
+  connectedProviders?: { id: string; name: string; disabled: boolean }[];
+  modelError?: string;
+  /** Absent when the settings row has never been written. */
+  modelPreferences?: ModelPreferences;
+}

package/src/shared/types/omp/agent.ts

@@ -38,6 +38,12 @@ export interface OmpAgentCallbacks {
    *  on the live stream: it never enters get_state.messages or the session
    *  JSONL, so the timeline must render it from this frame or it is lost. */
   onCommandOutput?: (text: string) => void;
+  /** omp changed the session's display title (auto-generation, /rename, or an
+   *  RPC set_session_name). The frame is the only push signal for it — the
+   *  sidebar reads titles from the session file, which the 256-byte slot write
+   *  updates without changing the scan cache's mtime key — so consumers must
+   *  revalidate the session list from here. */
+  onSessionTitleChanged?: (title: string) => void;
   onNotice?: (level: string, message: string) => void;
   onConnected?: () => void;
   /** Mount-time probe found the session mid-run → the stream was reattached
@@ -61,8 +67,15 @@ export interface OmpAgentState {
   error: string | null;
 }
 
-/** An attached image payload accepted by every prompt-bearing RPC command. */
+/**
+ * An attached image payload accepted by every prompt-bearing RPC command.
+ * `type` is part of omp's `ImageContent` contract and is REQUIRED: omp's
+ * history encoder (`pi-ai/src/dialect/history.ts`) and its text fallback
+ * (`pi-ai/src/dialect/rendering.ts`) both select blocks by `type === "image"`,
+ * so a payload without it is dropped from the model's context.
+ */
 export interface AgentImage {
+  type: 'image';
   data: string;
   mimeType: string;
 }

package/src/shared/types/omp/session.ts

@@ -132,7 +132,10 @@ export interface OmpSession extends OmpSessionBase {
   name?: string;
   /** ISO timestamp of session creation (header timestamp). */
   created: string;
-  /** ISO timestamp of last modification (file mtime). */
+  /** ISO timestamp of the session's last entry — the newest JSONL record's own
+   *  `timestamp`. Drives "latest session" ordering and the row's relative age;
+   *  the file mtime is deliberately not used (a title-slot rewrite bumps it
+   *  without a turn having happened). */
   modified: string;
   /** Parent session id when this session was forked/branched. */
   parentSessionId?: string;

package/src/shared/types/omp/subagent.ts

@@ -150,6 +150,10 @@ export interface SubagentInfo {
   detached?: boolean;
   progress?: SubagentProgress;
   lastUpdate?: number;
+  /** Model role the run resolved to. On-disk history entries carry it here
+   *  (folded from the parent's task toolResult); live snapshots carry it on
+   *  `progress` instead, because it arrives with the progress frame. */
+  modelRole?: string;
   /** Settled result for history entries (SingleResult-derived). */
   result?: SubagentHistoryResult;
   /** Roster origin: live frames/snapshots (default) vs on-disk history. */

package/src/shared/types/settings/command.ts

@@ -1,5 +1,12 @@
 export type CommandScope = 'system' | 'user' | 'project';
 
+/** Declarative subcommand of an oh-my-pi builtin (drives `/cmd <sub>` completion). */
+export interface CommandSubcommand {
+  name: string;
+  description?: string;
+  usage?: string;
+}
+
 export interface CommandItem {
   id: string;
   name: string;
@@ -9,4 +16,10 @@ export interface CommandItem {
   overrideModel?: string;
   template: string;
   isBuiltIn?: boolean;
+  /** oh-my-pi aliases (`/models` for `/model`); live agent commands only. */
+  aliases?: string[];
+  /** Declarative subcommands; live agent commands only. */
+  subcommands?: CommandSubcommand[];
+  /** Argument hint (`[on|off|status]`); live agent commands only. */
+  inputHint?: string;
 }

package/src/shared/types/settings/state.ts

@@ -40,6 +40,11 @@ export interface SettingsState {
   editorFont: string;
   streamResponses: boolean;
   streamTransport: StreamTransport;
+  /** Generate a session title from the first settled run. omp suppresses its
+   *  own auto-titling under `--mode rpc-ui` (PI_NO_TITLE), so without this a
+   *  chamber session keeps its `New Session - <timestamp>` placeholder. A
+   *  user-set name is never overwritten. */
+  autoSessionTitle: boolean;
   expandedThinking: boolean;
   detailedToolCalls: boolean;
   notificationsEnabled: boolean;