omp-fabric 1.3.1 → 1.3.2

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## 1.3.2
+
+### Fixed
+
+- **`omp.write` never resolved an internal URL, so `local://` writes landed in a literal `local:` directory.** Fabric replaces the host's write tool with its own implementation to attach diff previews, and that replacement carried no internal-URL handling: `resolve(cwd, "local://notes.md")` collapses the scheme into a path segment and produced `<cwd>/local:/notes.md`. Subagents are instructed to exchange findings through `local://` files, so a real project accumulated one of these directories with five files in it. Meanwhile `omp.read` resolves `local://` correctly, because Fabric binds the host's read tool unchanged, so a write and a read of the same URL disagreed about where the file was.
+
+  URI-like write targets are now delegated to the host's write tool, which resolves them: `local://round-trip.md` writes to the session's local root under `omp-local`, `xd://` reports that no device is mounted, `artifact://` reports that it is read-only for writes, and an unknown scheme keeps the host's own guidance. Ordinary filesystem writes keep the diff preview.
+
+  1.3.0 turned the silent mis-write into a refusal, which stopped the stray directories but left agents unable to write `local://` at all under full code mode, since the top-level write tool only accepts `local://` during plan mode. This completes that fix.
+
+### Notes
+
+- A directory literally named `local:` inside a project is the signature of this defect from any Fabric before 1.3.0. Its contents are real files and can be moved or deleted; nothing reads them at that path.
+
 ## 1.3.1
 
 ### Fixed

package/dist/fabric-runtime-state.js

@@ -9761,6 +9761,7 @@ import { homedir } from "node:os";
 import { dirname, isAbsolute, resolve, win32 } from "node:path";
 import { mkdir, readFile as readFile2, stat, writeFile } from "node:fs/promises";
 import { Type as Type4 } from "@oh-my-pi/pi-coding-agent/extensibility/legacy-typebox";
+import { WriteTool } from "@oh-my-pi/pi-coding-agent/tools/write";
 var mutationQueues = /* @__PURE__ */ new Map();
 var withFileMutationQueue = async (path20, operation) => {
   const previous = mutationQueues.get(path20) ?? Promise.resolve();
@@ -9778,29 +9779,18 @@ var withFileMutationQueue = async (path20, operation) => {
   }
 };
 var URI_LIKE_WRITE_TARGET_RE = /^([a-z][a-z0-9+.-]*):\/{1,2}/i;
-var OmpWriteUriTargetError = class extends Error {
-  path;
-  constructor(message2, path20) {
-    super(message2);
-    this.name = "OmpWriteUriTargetError";
-    this.path = path20;
-  }
-};
-var assertFilesystemWriteTarget = (candidate, reported) => {
+var uriLikeScheme = (candidate) => {
   const trimmed = candidate.trim();
-  if (win32.isAbsolute(trimmed)) return;
-  const scheme = URI_LIKE_WRITE_TARGET_RE.exec(trimmed)?.[1]?.toLowerCase();
-  if (scheme === void 0) return;
-  const guidance = scheme === "xd" ? "Tool devices are dispatched by the top-level `write` tool, which carries the xd:// transport; omp.write writes files." : "omp.write resolves filesystem paths only.";
-  throw new OmpWriteUriTargetError(
-    `Refusing to write '${reported}': '${scheme}://' is a URI scheme, not a directory. ${guidance} Prefix the path with './' to create a literal file by that name.`,
-    reported
-  );
+  if (win32.isAbsolute(trimmed)) return void 0;
+  return URI_LIKE_WRITE_TARGET_RE.exec(trimmed)?.[1]?.toLowerCase();
+};
+var isUriLikeWriteTarget = (filePath) => {
+  const expanded = filePath.startsWith("@") ? filePath.slice(1) : filePath;
+  return uriLikeScheme(expanded.replace(/[\u00a0\u2000-\u200a\u202f\u205f\u3000]/g, " ")) !== void 0;
 };
 var resolvePreviewPath = (filePath, cwd) => {
   let expanded = filePath.startsWith("@") ? filePath.slice(1) : filePath;
   expanded = expanded.replace(/[\u00a0\u2000-\u200a\u202f\u205f\u3000]/g, " ");
-  assertFilesystemWriteTarget(expanded, filePath);
   if (expanded === "~") expanded = homedir();
   else if (expanded.startsWith("~/")) expanded = homedir() + expanded.slice(1);
   return isAbsolute(expanded) ? expanded : resolve(cwd, expanded);
@@ -9837,7 +9827,7 @@ var readExistingFileForPreview = async (filePath, cwd, nextContent) => {
     return skipped("previous content unavailable", fileStat.size);
   }
 };
-var createPreviewWriteToolDefinition = (cwd) => {
+var createPreviewWriteToolDefinition = (cwd, session) => {
   const original = {
     name: "write",
     label: "Write",
@@ -9849,6 +9839,21 @@ var createPreviewWriteToolDefinition = (cwd) => {
     ...original,
     async execute(_toolCallId, params, signal) {
       const { path: path20, content } = params;
+      if (isUriLikeWriteTarget(path20)) {
+        if (session === void 0) {
+          throw new Error(
+            `Refusing to write '${path20}': URI-like targets need a host session to resolve. Prefix the path with './' to create a literal file by that name.`
+          );
+        }
+        return await new WriteTool(session).execute(
+          _toolCallId,
+          params,
+          signal,
+          (() => {
+          }),
+          { signal }
+        );
+      }
       const absolutePath = resolvePreviewPath(path20, cwd);
       return withFileMutationQueue(absolutePath, async () => {
         const throwIfAborted2 = () => {
@@ -10444,7 +10449,7 @@ var OmpToolsProvider = class _OmpToolsProvider {
       read: createNativeReadToolDefinition(cwd),
       bash: createNativeBashToolDefinition(cwd, this.#artifactPaths),
       edit: createNativeReplaceEditToolDefinition(cwd),
-      write: createPreviewWriteToolDefinition(cwd),
+      write: createPreviewWriteToolDefinition(cwd, createNativeSession(cwd)),
       grep: createGrepDefinitionWithSkip(cwd),
       find: createFindDefinitionWithFilters(cwd),
       ls: createLsToolDefinition(cwd)