omp-conductor 0.19.7 → 0.20.1

package/src/tracker/github.ts

@@ -486,6 +486,40 @@ export function prVerificationFrom(
   return { status: "green", reason: `${checks.length} checks succeeded or were skipped`, headSha };
 }
 
+/**
+ * Whether one raw `gh pr view --json ...statusCheckRollup` payload collected
+ * zero rollup contexts (#999).
+ *
+ * {@link prVerificationFrom} maps zero collected checks to `pending` — "GitHub
+ * has not reported any checks yet" — which is the right refusal when it is
+ * true, and a silent stall when it is not. It is not always true: a head whose
+ * PR was opened by `github-actions[bot]` carries a second, empty
+ * `action_required` check suite beside the completed one, and the rollup read
+ * can resolve that empty suite and collect nothing while 18 check-runs
+ * (one of them failed) sit on the same SHA. So the caller uses this to treat
+ * an empty rollup as *unresolvable* and re-prove from the REST plane, which
+ * flattens every page of both `check_runs` and `statuses` for the exact head
+ * and sees all of them.
+ *
+ * A missing rollup counts as zero collected, exactly as
+ * {@link prVerificationFrom}'s `?? []` does. A body this predicate cannot read
+ * — unparseable, not a JSON object (a bare list is not a `pr view` payload),
+ * or a rollup that is not a list — is not its problem: it answers false so the
+ * existing verdict stands unchanged.
+ */
+export function rollupCollectedNoChecks(raw: string): boolean {
+  let parsed: unknown;
+  try {
+    parsed = JSON.parse(raw) as unknown;
+  } catch {
+    return false;
+  }
+  if (parsed === null || typeof parsed !== "object" || Array.isArray(parsed)) return false;
+  const rollup = (parsed as GhPrVerification).statusCheckRollup;
+  if (rollup === undefined || rollup === null) return true;
+  return Array.isArray(rollup) && rollup.length === 0;
+}
+
 function failedCheck(raw: string): GhCheck | undefined {
   const checks = (JSON.parse(raw) as GhPrVerification).statusCheckRollup ?? [];
   return checks.find((check) => checkVerdict(check) === "failed");
@@ -2024,6 +2058,22 @@ export function makeTracker(
           "state,isDraft,headRefOid,statusCheckRollup",
         ]);
         const verification = prVerificationFrom(raw, expectedHead, opts);
+        if (verification.status === "pending" && rollupCollectedNoChecks(raw)) {
+          // An empty rollup is not proof that the head has no checks (#999):
+          // a PR opened by `github-actions[bot]` carries a second, empty
+          // `action_required` suite beside the completed one, the rollup read
+          // resolves that suite, collects nothing, and this verdict reads
+          // "GitHub has not reported any checks yet" over a head with 18
+          // check-runs and a failure among them. A commit that carries an
+          // empty suite beside a completed one is not a commit with no
+          // checks, so zero collected contexts is unresolvable rather than
+          // decisive: re-prove from REST, which flattens every page of both
+          // `check_runs` and `statuses` for the exact head. REST that cannot
+          // answer leaves this pending exactly as it stands — fail-closed,
+          // never green by omission.
+          const rest = await verifyPrRest(runGh, cache, url, expectedHead, opts, hooks.onNotModified);
+          return rest ?? verification;
+        }
         if (verification.status !== "failed") return verification;
 
         const detailsUrl = failedCheck(raw)?.detailsUrl;