omp-conductor 0.18.1 → 0.19.0

package/src/decisions.ts

@@ -79,14 +79,21 @@ export const PR_LOOKUP_WINDOW_MS = 30 * 24 * 60 * 60_000;
  * read by both `conductor_pr_review` and the `pr-review-ready` watch so they
  * cannot drift.
  *
- * Ownership is the same newest-first resolution the review verb uses: the
- * newest attempt of this project that recorded the PR within the
- * recent-history window (`runsForProjectPr`), never the issue's newest row —
- * a requeued continuation must not hide the PR its predecessor opened
- * (#434), and a newer live owner hides an older settled one. That older
- * settled row is exactly the shape dogfood #844 started from: PR #838 was
- * green while its newest owner was still `running`, and a watch keyed only to
- * checks woke the orchestrator before `conductor_pr_review` was actionable.
+ * Ownership is the newest attempt of this project that recorded the PR within
+ * the recent-history window (`runsForProjectPr`), never the issue's newest
+ * row — a requeued continuation must not hide the PR its predecessor opened
+ * (#434). A `stopped` row is transparent to that selection (#870): stopping
+ * is terminal and the attempt will never touch the PR again, so a stopped
+ * duplicate must not shadow the older revisable owner of the same PR — the
+ * row ordering that stranded PR #870's blocking findings. Every other
+ * non-revisable state still decides as the newest owner: a live row
+ * (`running` / `claimed`) hides an older settled one because a worker is in
+ * flight (#844 — PR #838 was green while its newest owner was still
+ * `running`, and a watch keyed only to checks woke the orchestrator before
+ * `conductor_pr_review` was actionable), `pushed-pending` checks are still
+ * settling, `blocked` may resume, `orphaned` is reconciled back to live at
+ * startup, and `merged` means the PR lifecycle is over. When every row is
+ * `stopped`, the newest one answers and the predicate fails closed.
  *
  * `no-owner` and `not-revisable` both fail closed: a review can never act, so
  * a watch must not wake, even when the checks are green.
@@ -97,9 +104,10 @@ export type PrReviewReadiness =
   | { kind: "not-revisable"; run: RunRecord };
 
 export function prReviewReadiness(store: Store, project: string, prUrl: string, now: number): PrReviewReadiness {
-  const run = store.runsForProjectPr(project, prUrl, now - PR_LOOKUP_WINDOW_MS)[0];
-  if (run === undefined) return { kind: "no-owner" };
-  return REVISABLE_RUN_STATES[run.state] === true ? { kind: "ready", run } : { kind: "not-revisable", run };
+  const runs = store.runsForProjectPr(project, prUrl, now - PR_LOOKUP_WINDOW_MS);
+  const owner = runs.find((attempt) => attempt.state !== "stopped") ?? runs.at(0);
+  if (owner === undefined) return { kind: "no-owner" };
+  return REVISABLE_RUN_STATES[owner.state] === true ? { kind: "ready", run: owner } : { kind: "not-revisable", run: owner };
 }
 
 /**