omp-conductor 0.15.10 → 0.15.12

package/src/briefs/worker.md

@@ -24,17 +24,20 @@ cannot account for, and the checks that would have refused a bad push never ran.
 Reading with `gh` is fine; `git push`, `gh pr create` and `gh pr merge` are not
 yours to run.
 
-Read the issue first. **This brief is your copy of it**: the acceptance criteria
-below were rendered from the issue at dispatch, so you already have what you
-need. One `gh` read is still worth the call, for the discussion the brief did
-not copy down:
+Read the issue first. **This brief is your copy of it**: the acceptance
+criteria below were rendered from the issue at dispatch, and every comment on
+it is rendered in the Discussion section. One `gh` read is still worth the
+call, to compare the live issue against the copy in this brief:
 
 ```bash
-gh issue view {{ISSUE_NUMBER}} --repo {{TRACKER_REPO}} --comments
+gh issue view {{ISSUE_NUMBER}} --repo {{TRACKER_REPO}} --json comments --jq '.comments[]|"@\(.author.login): \(.body)"'
 ```
 
-If that command fails, work from this brief and say so in your report rather
-than treating it as a blocker.
+**If that command prints nothing, the read failed — say so in your report.**
+`gh issue view --comments` prints nothing on a non-TTY while still exiting 0,
+so empty output is never proof of an empty discussion. The Discussion section
+below is what was read at dispatch; a live read that prints nothing while it
+is there is a broken read, not a silent queue.
 
 Then read the repo's own guidance before writing anything: `AGENTS.md`,
 `CLAUDE.md`, `CONTEXT.md`, and any `docs/adr/` entry the issue touches. Those
@@ -44,7 +47,7 @@ files are canonical; your priors are not.
 
 {{ACCEPTANCE_CRITERIA}}
 
-## How to work
+{{ISSUE_COMMENTS}}## How to work
 
 1. **Understand before editing — and ask the graph before you grep.** Your turns
    are mostly spent finding code, not writing it, and running out of turns
@@ -213,10 +216,16 @@ pr:      <url or "none">
 head:    <40-character head SHA or "none">
 state:   pushed-green | blocked | failed
 gates:   <exact commands run and their results>
-changed: <files touched, one line>
+changed: <the settlement derives this from the PR diff — omit the line>
 next:    <nothing | the specific decision needed>
 ```
 
+The `changed:` line is not yours to write from memory: the settlement replaces
+it with the actual file list from the PR's diff. Omit it, or write it wrongly —
+the settled report carries the diff's list either way. The narrative in your
+report (what you changed and why, above these lines) is the part only you can
+write, and it is the part a reviewer reads.
+
 Never report success you have not observed. "Should pass CI" is not a state, and
 `pushed-green` means you watched the checks go green — not that you expect them
 to.

package/src/chain-check.ts

@@ -154,4 +154,4 @@ export function chainViolations(input: ChainViolationInput): string[] {
   }
 
   return violations;
-}
+}

package/src/check-trailing-newlines.ts

@@ -0,0 +1,82 @@
+/**
+ * Gate: tracked text files must end with a final newline and no trailing
+ * blank lines.
+ *
+ * Run via `bun run check` from the package root (after `tsc --noEmit`).
+ * Neither tsc nor the test suite has an opinion about the last byte of a
+ * file, so worker-authored files kept landing without one — each a spurious
+ * two-line hunk on the next edit. This is the cheap mechanical check that
+ * closes that gap: it walks `git ls-files`, checks every tracked text file
+ * by extension, and names every offender in a single run.
+ */
+
+import { execFileSync } from "node:child_process";
+import { readFileSync } from "node:fs";
+import { join } from "node:path";
+
+/** Tracked text suffixes the gate applies to. */
+export const INCLUDED_SUFFIXES: readonly string[] = [
+  ".ts", ".js", ".css", ".html", ".md", ".json", ".yml", ".yaml", ".toml", ".sh",
+];
+
+/**
+ * Generated files the gate must not police, named explicitly rather than
+ * guessed at by content. Paths are repo-root-relative, as `git ls-files`
+ * reports them.
+ */
+export const EXCLUDED_PATHS: readonly string[] = [
+  "omp/bun.lock", // regenerated by `bun install`
+  "omp/schema/config.schema.json", // regenerated by `bun run schema`
+];
+
+/** Reason this file's ending fails the gate, or null when it is correct. */
+export function checkEnding(bytes: Uint8Array): string | null {
+  let trailingNewlines = 0;
+  for (let i = bytes.length - 1; i >= 0 && bytes[i] === 0x0a; i--) {
+    trailingNewlines++;
+  }
+  if (trailingNewlines === 0) return "missing trailing newline";
+  if (trailingNewlines > 2) return `ends with ${trailingNewlines - 1} blank lines`;
+  return null;
+}
+
+/**
+ * Check every file, returning one violation line per offender so a single
+ * run names every bad path instead of dying on the first.
+ */
+export function findViolations(
+  paths: readonly string[],
+  read: (path: string) => Uint8Array = readFileSync,
+): string[] {
+  const violations: string[] = [];
+  for (const path of paths) {
+    const bytes = read(path);
+    if (bytes.length === 0) continue; // nothing to terminate
+    const reason = checkEnding(bytes);
+    if (reason !== null) violations.push(`${path}: ${reason}`);
+  }
+  return violations;
+}
+
+function repoRoot(): string {
+  return execFileSync("git", ["rev-parse", "--show-toplevel"], { encoding: "utf8" }).trim();
+}
+
+if (import.meta.main) {
+  const root = repoRoot();
+  const tracked = execFileSync("git", ["-C", root, "ls-files"], { encoding: "utf8" })
+    .split("\n")
+    .filter((path) => path.length > 0);
+  const textFiles = tracked.filter(
+    (path) =>
+      INCLUDED_SUFFIXES.some((suffix) => path.endsWith(suffix)) &&
+      !EXCLUDED_PATHS.includes(path),
+  );
+  const violations = findViolations(textFiles, (path) => readFileSync(join(root, path)));
+  if (violations.length > 0) {
+    for (const violation of violations) console.error(violation);
+    console.error(`trailing newline gate: ${violations.length} file(s) need fixing`);
+    process.exit(1);
+  }
+  console.log("trailing newline gate: ok");
+}